Commit Graph

592 Commits

Author SHA1 Message Date
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Butkovits Atila
cea2025687 Backed out 6 changesets (bug 1832348) for causing mochitest failures with leaks. CLOSED TREE
Backed out changeset 50f0546e5e0e (bug 1832348)
Backed out changeset 294d38c19889 (bug 1832348)
Backed out changeset 9cc22e70d293 (bug 1832348)
Backed out changeset fdcd11e66071 (bug 1832348)
Backed out changeset a357b1c75148 (bug 1832348)
Backed out changeset fcc56c5fd7e4 (bug 1832348)
2023-07-26 20:41:26 +03:00
ganna
4830d356f9 Bug 1832348 - Part 3: Replace .panel-footer with moz-button-group in downloadsPanel r=dao,mak
Differential Revision: https://phabricator.services.mozilla.com/D181313
2023-07-26 15:47:40 +00:00
Emilio Cobos Álvarez
45324c46bc Bug 1844717 - Move downloadArea min-width rules so that they apply to places window. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184235
2023-07-24 12:07:21 +00:00
Marco Bonardo
aefe8ae2f5 Bug 1834804 - More reliable downloads panel states. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D180546
2023-06-23 19:27:06 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Mark Banner
40de601f11 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Gregory Pappas
d12bc54641 Bug 1822864 - Remove browser.download.improvements_to_download_panel pref r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179300
2023-05-31 10:29:37 +00:00
Natalia Csoregi
1b67d0b941 Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Noemi Erli
1f146f097e Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 08:13:08 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Marco Bonardo
e1ffc0d710 Bug 1824746 - Don't show a context menu if there's no download "selected". r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173753
2023-03-28 12:34:01 +00:00
Marco Bonardo
56e31f5b0e Bug 1817650 - Sometimes the context menu in Downloads Panel opens for the wrong download. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D171775
2023-03-24 15:37:34 +00:00
Stanca Serban
3de2959f54 Backed out changeset 8a7883ea39d2 (bug 1817650) for causing mochitests failures in browser_downloads_panel_context_menu.js. CLOSED TREE 2023-03-24 12:54:03 +02:00
Marco Bonardo
876c4b2346 Bug 1817650 - Sometimes the context menu in Downloads Panel opens for the wrong download. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D171775
2023-03-24 09:47:48 +00:00
William Durand
640baa7e87 Bug 1816725 - Remove indicator attribute on the downloads button. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D169839
2023-02-15 09:33:11 +00:00
William Durand
cd365e6f7f Bug 1811332 - Make sure this.indicator is truthy before using it. r=Gijs
The `indicator` getter may return `null` so we cannot just call methods on it.

Differential Revision: https://phabricator.services.mozilla.com/D169717
2023-02-14 12:03:02 +00:00
Neil Deakin
21426e24f4 Bug 1776879, replace text/unicode for clipboard and drag and drop and use text/plain directly, r=edgar,mak,stransky,geckoview-reviewers,extension-reviewers,zombie,m_kato
Most usage is a straight replacement but gtk needs extra changes as it transfers plain text in UTF8 natively and needs to be converted into UTF16, and Windows uses single-byte characters for RTF and CF_HTML formats so we preserve this.

Differential Revision: https://phabricator.services.mozilla.com/D158587
2023-02-01 23:30:55 +00:00
Florian Quèze
e5a0fb38ca Bug 1812034 - set the download progress on the #downloads-indicator-progress-inner element directly instead of on the entire downloads button to limit restyled elements, r=Gijs,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D167660
2023-01-25 08:58:58 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Amy Churchwell
69014fc71f Bug 1804411 - Downloads panel animations should honour prefers-reduced-motion settings. r=sfoster,mak
Differential Revision: https://phabricator.services.mozilla.com/D166444
2023-01-17 16:40:09 +00:00
Gijs Kruitbosch
897d721410 Bug 1781090 - avoid updating the download icon for hidden windows, r=florian,mak
Differential Revision: https://phabricator.services.mozilla.com/D152658
2022-12-23 14:44:43 +00:00
Gijs Kruitbosch
07047be166 Bug 1803800, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D163932
2022-12-12 17:44:14 +00:00
Mark Banner
e319b56680 Bug 1801809 - Automatically replace Cu.reportError with console.error (places, download). r=mak
Depends on D162696

Differential Revision: https://phabricator.services.mozilla.com/D162697
2022-11-22 16:23:38 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mark Banner
df52ac2d97 Bug 1798212 - Replace defineModuleGetter in Integration.sys.mjs with a ES version. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D161014
2022-11-07 17:56:10 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Shane Hughes
34b247cb72 Bug 1742999 - Make DownloadSpamProtection per-window. r=Gijs,mak
This patch modifies DownloadSpamProtection and DownloadIntegration so
that each window will track blocked spam downloads separately. (Which
shouldn't affect permissions.) When a download is blocked, the helper
app service dispatches a notification, passing the relevant browsing
context and URL to DownloadIntegration. Then it passes the window and
URL to the singleton DownloadSpamProtection. That maps all the windows
to objects that carry the spam download objects. This allows us to only
show blocked spam downloads in the downloads panel of the window from
which they were triggered.

Differential Revision: https://phabricator.services.mozilla.com/D148092
2022-10-04 22:38:18 +00:00
Andrew McCreight
670df172aa Bug 1792457 - Revert workarounds for weak references to XPCWJS crashes. r=Gijs
I have fixed the underlying XPConnect issue, so these workarounds should
no longer be needed.

There are also two more in browser/base/content/browser-siteProtections.js
that I have not fixed.

Differential Revision: https://phabricator.services.mozilla.com/D158158
2022-09-29 11:40:19 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Eemeli Aro
a96b427af3 Bug 1786055 - Drop find keys from editMenuKeys.inc.xhtml. r=mconley
It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D155448
2022-08-26 16:31:40 +00:00
Calixte
379358db72 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D151431
2022-08-08 18:56:24 +00:00
Butkovits Atila
5b38a79427 Backed out changeset 724282da88eb (bug 1778714) for causing failures at browser_library_select_all.js. 2022-08-08 18:14:00 +03:00
Calixte
7428eacbc4 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D151431
2022-08-08 13:47:55 +00:00
Emilio Cobos Álvarez
2c1499dce8 Bug 1782185 - Fix a typo introduced in bug 1765083. r=Gijs
I confirmed it's the only one, whoops.

Differential Revision: https://phabricator.services.mozilla.com/D153152
2022-07-29 09:52:38 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00