When using the tab context menu or drag-dropping tabs to put them into a group, record a metric for the number of tabs added to the group.
Data Science asked us to launch with this metric disabled so that they could control it using server knobs. They expect a high volume of events, so they expect to only enable this metric for some proportion of users.
I converted the existing `TabMove` event derived from `UIEvent` being fired when tabs change their tab index in the tab strip. `UIEvent` doesn't allow for attaching additional context/detail to the event. `TabMove` is now a `CustomEvent` that provides more context about the moved tab and it fires in more cases -- it's possible for the tab index not to change despite the tab having "moved" into/out of a tab group.
This approach would not capture tab movements that occur across multiple frames/event loop iterations.
Differential Revision: https://phabricator.services.mozilla.com/D244616
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.
This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.
Differential Revision: https://phabricator.services.mozilla.com/D241884
Adding additional functionality for there to be a link in the message part of the optin component. Using a place holder link to support for now. This will be updated to a new SUMO article.
Differential Revision: https://phabricator.services.mozilla.com/D244069
highlight text when label is suggested but also un-focus the input when a user clicks out of the input anywhere on the panel.
Differential Revision: https://phabricator.services.mozilla.com/D244096
when the user is presented with the AI suggested tabs in STG, change the action button that toggles the select and deselect actions to just being a simple select all checkbox that only selects all when checked. Remove the deselect all functionality.
Differential Revision: https://phabricator.services.mozilla.com/D243221
Update strings in STG user flow. Update button styles. Add new footer paragraph and link to model optin component. Expand the panel when showing suggested tabs. Fix messaging coloring when there are no tabs to suggest.
Differential Revision: https://phabricator.services.mozilla.com/D242786
- Telemetry for opt-in
- For each onboarding step
- Telemetry updates for existing
- Clicking away with ML group name without explicitly clicking "done" or "cancel"
- When there are no suggestions for "suggest other tabs"
- Add group id to ml telemetry
- Move stg telemetry under tab group telemetry
- Remove num_ from events
Differential Revision: https://phabricator.services.mozilla.com/D242784
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.
This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.
Differential Revision: https://phabricator.services.mozilla.com/D241884
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Add a feature flag for turning on/off the UI for smart tab grouping. Updating formatting for the HTML. Due to the use of XUL the html has no syntax highlighting and is extremely difficult to read when not formatted vertically. More UI is comming and this helps pave the way for a more readable file.
Differential Revision: https://phabricator.services.mozilla.com/D236383
To prep for the transition of code migrating from Larch to Central, for STG (Smart Tab Grouping), the best technique would be to implement peace by peace not to overwhelm a single patch.
This bug is the beginning of said work by setting the ground work for the state machine that manages the many additional states used by the STG feature.
Differential Revision: https://phabricator.services.mozilla.com/D235712
