Commit Graph

1320 Commits

Author SHA1 Message Date
Ehsan Akhgari
41ae97b060 Bug 1509555 - Part 5: Remove fastblock from tests r=baku
Depends on D12831

Differential Revision: https://phabricator.services.mozilla.com/D12832
2018-11-27 08:57:53 +00:00
Eugen Sawin
e54716978d Bug 1503560 - [1.2] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois 2018-11-12 18:47:17 +01:00
Ehsan Akhgari
5f5eeea40c Bug 1504194 - Part 3: Add tests for granting access to trackers across the same eTLD+1 r=baku
Depends on D10789

Differential Revision: https://phabricator.services.mozilla.com/D10790
2018-11-05 17:10:49 +00:00
matthias
fca9c2fd5e Bug 1462499 - changed priority of harmful. r=francois
Differential Revision: https://phabricator.services.mozilla.com/D6570
2018-09-24 15:51:50 +00:00
Ehsan Akhgari
5a784329db Bug 1501978 - Part 2: Remove the browser.contentblocking.enabled pref from the tests that set it to true needlessly r=baku
Depends on D10074

Differential Revision: https://phabricator.services.mozilla.com/D10075
2018-10-30 07:47:56 +00:00
Ehsan Akhgari
5e975a4a5f Bug 1501978 - Part 1: Stop honouring the browser.contentblocking.enabled pref in Gecko r=baku
Differential Revision: https://phabricator.services.mozilla.com/D10074
2018-10-30 14:30:15 +00:00
Julian Descottes
15aaadb6c7 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739
2018-10-23 07:12:23 +00:00
Dimi Lee
16c28822da Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois
Sometimes the protocol buffer data (RiceEncodingData) sent by Google's Safe Browsing server has the following properties:

1. |has_first_value| is false
2. |num_entries| > 0

In this case, we can still parse the data and apply partial update correctly by assuming that the first value is equal to 0.

Differential Revision: https://phabricator.services.mozilla.com/D6393
2018-10-16 10:36:01 +00:00
Francois Marier
e1e6936b5e Bug 1498736 - Log the number of prefixes loaded from disk. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D8622
2018-10-13 20:21:45 +00:00
Andreas Farre
7463bf2449 Bug 1437064 - Remove tracking timeouts list from TimeoutManager. r=chutten,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D7878
2018-10-12 18:01:19 +00:00
Liang-Heng Chen
05b1f24def Bug 1495110 - make slow-iframe as a separated file r=mayhemer
The slowIframe added in bug 1488974 shares the same target HTML page with fastIframe, and the resource will be canceled by ChannelUnifier and only loaded once.
Sometimes, when slowIframe is loaded faster than fastIframe, the resource in fastIframe will be canceled, that's the root cause of the intermittent.

Differential Revision: https://phabricator.services.mozilla.com/D8423
2018-10-12 13:39:09 +00:00
Cristina Coroiu
7c037a338c Bug 1495110 - Disable test_fastblock_bug1477046.html for multiple failures on windows7 and mac r=jmaher 2018-10-07 15:37:00 +03:00
arthur.iakab
1ed97ce5d8 Merge inbound to mozilla-central a=merge 2018-09-29 07:16:35 +03:00
Francois Marier
3f5ff70fb0 Bug 1488974 - Disable FastBlock after the load event has fired. r=mayhemer,Ehsan
The test used to assume that the load event didn't matter and so
the expected values had to be updated to match the new behavior.

A new "slowIFrame" test was added to capture what was previously
tested by the "badIFrame".

Differential Revision: https://phabricator.services.mozilla.com/D7031
2018-09-28 19:12:10 +00:00
Ehsan Akhgari
7bddc35620 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 14:46:02 -04:00
Noemi Erli
7fb8829472 Backed out 12 changesets (bug 1493563) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset d2e83655082f (bug 1493563)
Backed out changeset 1ce58f004593 (bug 1493563)
Backed out changeset 344298c73ee7 (bug 1493563)
Backed out changeset 02b8b073f7d7 (bug 1493563)
Backed out changeset 3ef707008502 (bug 1493563)
Backed out changeset bb2720a401fe (bug 1493563)
Backed out changeset ce0211be57a1 (bug 1493563)
Backed out changeset 83d6c2bf8dc6 (bug 1493563)
Backed out changeset 1844af4cc25b (bug 1493563)
Backed out changeset c8ab17addb7a (bug 1493563)
Backed out changeset a1ff0cd62563 (bug 1493563)
Backed out changeset 932b41e211e0 (bug 1493563)
2018-09-28 21:31:18 +03:00
Ehsan Akhgari
6c662bd61e Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 13:24:41 -04:00
Jonathan Kingston
03ff4a44fb Bug 1485305 - toolkit/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4563
2018-08-29 15:49:12 +01:00
Brindusan Cristian
6c0094d53f Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
dabc469c77 Bug 1485305 - toolkit/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4563
2018-08-29 15:49:12 +01:00
Liang-Heng Chen
3bcd723aa3 Bug 1492087 - Disable browser.fastblock.limit in tests r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D6135
2018-09-18 11:14:01 +00:00
Dimi Lee
293fcd3f58 Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois
A directory-based file copy without checkpoint to abort may take lots
of time to finish. This cause an issue that if firefox is shutting down
and try to close an ongoing update thread, main-thread may be blocked
for a long time.

This patch adds a wrapper for copying an entire directory, within this
wrapper, we use file-based copy and add checkpoints to let update thread
has a chance to abort.

Differential Revision: https://phabricator.services.mozilla.com/D3414
2018-09-18 14:29:20 +00:00
Liang-Heng Chen
591c74931f Bug 1477046 - Part 3: Add FastBlock redirect tests; r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D5806
2018-09-17 14:57:52 +00:00
Gurzau Raul
ce0d647947 Backed out changeset 6f6886c89554 (bug 1481819) for failing at url-classifier/tests/mochitest/test_classified_annotations.html 2018-09-14 21:49:04 +03:00
Dimi Lee
459daf3a1b Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois
A directory-based file copy without checkpoint to abort may take lots
of time to finish. This cause an issue that if firefox is shutting down
and try to close an ongoing update thread, main-thread may be blocked
for a long time.

This patch adds a wrapper for copying an entire directory, within this
wrapper, we use file-based copy and add checkpoints to let update thread
has a chance to abort.

Differential Revision: https://phabricator.services.mozilla.com/D3414
2018-09-14 15:33:24 +00:00
Liang-Heng Chen
d670c8778c Bug 1477046 - Part 2: Add FastBlock iframe tests; r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D4770
2018-09-13 21:30:39 +00:00
Liang-Heng Chen
7d7bee3e1e Bug 1477046 - Part 1: Add basic FastBlock automation tests; r=mayhemer
Basic parts of FastBlock tests, no iframe/xhr tests in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D4655
2018-09-13 21:27:54 +00:00
Andreea Pavel
11db669fba Backed out changeset d965284aca14 (bug 1477046) for failing toolkit/components/url-classifier/tests/mochitest/test_fastblock_bug1477046.htm 2018-09-13 19:31:32 +03:00
Liang-Heng Chen
de14d53f95 Bug 1477046 - Part 1: Add basic FastBlock automation tests; r=mayhemer
Basic parts of FastBlock tests, no iframe/xhr tests in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D4655
2018-09-13 15:07:07 +00:00
Andreea Pavel
4016718d69 Backed out 2 changesets (bug 1477046) for failing eslint on a CLOSED TREE
Backed out changeset dcbe562ce87a (bug 1477046)
Backed out changeset 757bbd2e3176 (bug 1477046)
2018-09-13 15:22:19 +03:00
Liang-Heng Chen
6491b53ab8 Bug 1477046 - Part 2: Add FastBlock iframe tests; r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D4770
2018-09-13 09:06:17 +00:00
Liang-Heng Chen
dd5c328c0a Bug 1477046 - Part 1: Add basic FastBlock automation tests; r=mayhemer
Basic parts of FastBlock tests, no iframe/xhr tests in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D4655
2018-09-13 12:03:41 +00:00
Francois Marier
225086a87e Bug 1441345 - Force the use of the Linux phishing list on Android. r=dimi
Reviewers: dimi

Reviewed By: dimi

Subscribers: dveditz, francois, dimi

Bug #: 1441345

Differential Revision: https://phabricator.services.mozilla.com/D5479
2018-09-12 18:07:26 +03:00
Tiberius Oros
967e769da9 Backed out 11 changesets (bug 1493563) for failures on dom/workers/test/test_sharedworker_event_listener_leaks.html on a CLOSED TREE
Backed out changeset 0bb55b604bfd (bug 1493563)
Backed out changeset 8e25c301675a (bug 1493563)
Backed out changeset 4f608b8801d4 (bug 1493563)
Backed out changeset f58d0b1ca088 (bug 1493563)
Backed out changeset eae105f2bf6d (bug 1493563)
Backed out changeset 7a8a0d1cfd69 (bug 1493563)
Backed out changeset dbba8451aab1 (bug 1493563)
Backed out changeset a6141dbd0328 (bug 1493563)
Backed out changeset f4ca3d8fa90e (bug 1493563)
Backed out changeset 56bab7fae64d (bug 1493563)
Backed out changeset 66787e603401 (bug 1493563)
2018-09-26 06:16:22 +03:00
Ehsan Akhgari
d60107096d Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-25 21:02:51 -04:00
Tiberius Oros
5e5decf303 Backed out 11 changesets (bug 1493563) for failures on browser_blockingCookies.js on a CLOSED TREE
Backed out changeset d755b96837ac (bug 1493563)
Backed out changeset 651f87dca51f (bug 1493563)
Backed out changeset 68de8f0866d0 (bug 1493563)
Backed out changeset 205d69890f50 (bug 1493563)
Backed out changeset 5f922cd6c21e (bug 1493563)
Backed out changeset 84dc54c1a9c1 (bug 1493563)
Backed out changeset 287666ecdd17 (bug 1493563)
Backed out changeset c64a2ea15b7b (bug 1493563)
Backed out changeset 9085269938cd (bug 1493563)
Backed out changeset de06604fefcb (bug 1493563)
Backed out changeset f9bac5e73bd4 (bug 1493563)
2018-09-25 23:12:03 +03:00
Ehsan Akhgari
f2335f1a99 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-25 13:51:47 -04:00
Henri Sivonen
a776659a48 Bug 1484988 - Avoid writing past the logical length of a string in Toolkit. r=froydnj
Also remove a useless call to SetCapacity().

MozReview-Commit-ID: LarsWKI3qwz

Differential Revision: https://phabricator.services.mozilla.com/D3882
2018-09-03 06:51:33 +00:00
Cosmin Sabou
46e6416d7f Bug 1480443 - Part 3: Disable FastBlock in URL Classifier tests. r=dimi,francois 2018-09-01 11:06:32 +03:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Nicholas Nethercote
cd127441a0 Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
There are surprisingly many of them.

(Plus a couple of unnecessary checks after `new` calls that were nearby.)
2018-08-28 15:56:01 +10:00
Ciure Andrei
f1621433fc Merge inbound to mozilla-central. a=merge 2018-08-29 00:58:21 +03:00
Henri Sivonen
89f220ee63 Bug 1485342 - Avoid isdigit() and isxdigit() in URL classifier. r=francois
MozReview-Commit-ID: IvadP10PFEZ

Differential Revision: https://phabricator.services.mozilla.com/D4312
2018-08-27 15:55:13 +00:00
Cosmin Sabou
1a193c7255 Backed out changeset be4fd8ee7afd (bug 1483985) for causing build bustages on LookupCache. CLOSED TREE 2018-08-27 18:26:41 +03:00
Alex Gaynor
fe8353bb43 Bug 1483985 - use std::move to avoid a copy in a few places that clang recommends; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D3543
2018-08-27 15:06:58 +00:00
Andrea Marchesini
de630c2f3d Bug 1476967 - Allow the adding of tracking-protection entries via prefs, r=francois 2018-08-27 21:01:14 +02:00
Henri Sivonen
cb3dbf9549 Bug 1485325 - Avoid nsTSubstring::GetMutableData() in URL classifier. r=francois
MozReview-Commit-ID: EzyOTuEZ9Ot

Differential Revision: https://phabricator.services.mozilla.com/D3966
2018-08-22 23:07:59 +00:00
Daniel Holbert
bd9ede6b83 Bug 1485142: Make url-classifier 'PartialHashHex()' API return a nsAutoCString instead of nsCString, to address build warning & reduce copying. r=gcp
Before this patch -- with the nsCString return type -- we have to do heap
allocation and copying to produce the return value.  But the callers don't
actually care about having a nsCString -- they just call .get() to access the
character buffer, and log it, and then they're done. They can do this just as
easily with the stack-allocated nsAutoCString that PartialHashHex() works with
locally, so let's change the return type so that Return Value Optimization
can give them that variable directly and avoid needless copying/allocation.

This patch addresses the following clang 8.0 build warning:
 LookupCache.h:63:12 [-Wreturn-std-move]
 local variable 'hex' will be copied despite being returned by name

Differential Revision: https://phabricator.services.mozilla.com/D3920
2018-08-22 16:51:56 +00:00
Francois Marier
7c07227930 Bug 1482306 - Ensure that tables are enabled when shared between features. r=dimi!
The enable/disable logic of the list manager was wrong. If multiple features
shared a given table (e.g. tracking protection and tracking annotations)
and only one of them was enabled, then updates could either be disabled
or enabled depending on which feature was checked first.

By disabling everything at the beginning and selectively re-enabling tables,
we can ensure that no table gets both enabled and disabled by different
feature toggles.

Differential Revision: https://phabricator.services.mozilla.com/D3259
2018-08-15 12:13:16 +00:00
Francois Marier
941b742abf Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!
Depends on D3131

Differential Revision: https://phabricator.services.mozilla.com/D3132
2018-08-13 23:20:40 +00:00