Commit Graph

146 Commits

Author SHA1 Message Date
Florian Quèze
a41844c552 Bug 1931901 - remove leftover test references to legacy scalar APIs, r=chutten,geckoview-reviewers,extension-reviewers,home-newtab-reviewers,robwu,ohall,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D229929
2024-12-10 10:31:58 +00:00
Mike Conley
e06d4179af Bug 1932859 - Prevent auto-closing of the AppMenu / FxA panels when generically clicking the FxA menu message CTA. r=pdahiya,omc-reviewers
The change in CustomizableUI is required because the routine wasn't designed to handle
custom elements with shadow roots. The routine's job is to walk up the ancestry of
the click event and determine if any of the parents have certain characteristics
that would indicate that the event should not close the panel, and without this
change it would bail out as soon as it hit the shadow root if the event's original
target was inside the custom element.

In this case, the element enclosing the fxa-menu-message is the "appMenu-fxa-menu-message"
toolbaritem with `closemenu="none"`, which this modification now lets
CustomizableUI detect.

Differential Revision: https://phabricator.services.mozilla.com/D230560
2024-12-09 21:16:19 +00:00
Tooru Fujisawa
0f29352379 Bug 1934048 - Update obsoleve comments about JSM in browser/components/asrouter/tests/unit/ASRouter.test.js. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D230566
2024-12-05 00:04:59 +00:00
Punam Dahiya
3ce35fab35 Bug 1923726 - Update NimbusRolloutMessageProvider with recent messaging rollouts r=negin,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230813
2024-12-02 23:02:59 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Meg Viar
48ab3860bf Bug 1923868 - Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya
This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Differential Revision: https://phabricator.services.mozilla.com/D225212
2024-11-25 18:14:28 +00:00
Sebastian Hengst
4d78eba78c Bug 1922355 - adjust mochitest expectations for macOS 14.70 x86-64. r=jmaher,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229944
2024-11-25 16:28:39 +00:00
Jason Prickett
86f8c07bf1 Bug 1928467 - Add ability for bookmarks toolbar button to be removed after unenrollment r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D229380
2024-11-22 20:32:07 +00:00
Alexandru Marc
f8117504e2 Backed out changeset a2435b289727 (bug 1923868) for causing bc failures @ browser_aboutwelcome_multistage_languageSwitcher.js. CLOSED TREE 2024-11-22 19:14:57 +02:00
Meg Viar
cf5467d380 Bug 1923868 - Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya
This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Differential Revision: https://phabricator.services.mozilla.com/D225212
2024-11-22 14:29:15 +00:00
Adi
9d9552bf95 Backed out changeset 893b697b0ad7 (bug 1923868) for causing bc failures @nsMacDockSupport.mm. CLOSED TREE 2024-11-22 05:40:59 +02:00
Adi
1553bea548 Backed out changeset 12efd90d2c57 (bug 1928467) for causing bc failures @browser_bookmarks_bar_button.js. 2024-11-22 05:38:11 +02:00
Jason Prickett
89c974a0bc Bug 1928467 - Add ability for bookmarks toolbar button to be removed after unenrollment r=mviar,omc-reviewers
This patch adds the functionality of the fxms_bmb_button surface to be removed when a user has been unenrolled from an experiment that used said feature.

Differential Revision: https://phabricator.services.mozilla.com/D229380
2024-11-22 02:40:22 +00:00
Meg Viar
12908e2cd7 Bug 1923868 - Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya
This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Differential Revision: https://phabricator.services.mozilla.com/D225212
2024-11-21 20:54:40 +00:00
hanna alemu
f2b065e5bb Bug 1825381 - Create experimental set to default prompt-style spotlight and enable showing via Nimbus r=mviar,omc-reviewers,firefox-desktop-core-reviewers ,mossop,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D225699
2024-11-20 18:04:46 +00:00
Jason Prickett
e0cf13dab7 Bug 1928465 - Add asrouter trigger listener for button click r=mviar,omc-reviewers
This patch adds an `elementClick` trigger listener that can be used like so:

```
trigger: {
        id: "elementClicked",
        params: ["element-id"],
}
```

Differential Revision: https://phabricator.services.mozilla.com/D228399
2024-11-20 02:58:51 +00:00
Beth Rennie
83f3481e28 Bug 1929116 - Update NimbusEnrollment.schema.json and store new Firefox Labs fields in saved enrolments r=chumphreys,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D228723
2024-11-19 22:18:43 +00:00
Sandor Molnar
847fd3bab7 Bug 1775852 - Disable browser_asrouter_group_userprefs.js on linux1804-64-qr asan & debug & opt configuration. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D228117
2024-11-06 01:24:02 +00:00
Dave Townsend
4ea798a326 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-05 12:59:04 +00:00
Stanca Serban
7bfaea64ba Backed out changeset 101063793364 (bug 1894239) for causing mochitests failures in browser_sentence_case_strings.js. CLOSED TREE 2024-11-04 20:39:11 +02:00
Dave Townsend
09c0a011d8 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 16:20:41 +00:00
Goloman Adrian
43172c6f10 Backed out changeset 4aeabb1fca7f (bug 1894239) for causing bc failures @browser_parsable_css.js. CLOSED TREE 2024-11-04 17:11:24 +02:00
Dave Townsend
658587a8e9 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 13:19:59 +00:00
Goloman Adrian
a536e48199 Backed out changeset 07b4dffd9109 (bug 1894239) for causing bc failures @browser_all_files_referenced.js. CLOSED TREE 2024-11-04 14:50:12 +02:00
Dave Townsend
d23817862a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 11:15:32 +00:00
Goloman Adrian
8d0a2fbb16 Backed out changeset 6539a7d0d9ca (bug 1894239) for causing xpcshell failures at test_selectable_profile_launch.js. CLOSED TREE 2024-11-01 20:43:36 +02:00
Dave Townsend
0085ce80d2 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 17:08:27 +00:00
Cristian Tuns
8f3ca1449e Backed out changeset 7df0f0dd73a1 (bug 1894239) for causing bc failures in /browser_appmenu.js CLOSED TREE 2024-11-01 12:48:39 -04:00
Dave Townsend
52f716131a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 14:38:45 +00:00
hanna alemu
6d1493ff8d Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D213239
2024-10-30 20:56:29 +00:00
Mike Conley
398b96c057 Bug 1926585 - Append the right menu identifier to the utm_content param for FxAMenuMessage. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226650
2024-10-24 16:06:45 +00:00
Emily McMinn
f3bbb3366b Bug 1918536 - CREATE_NEW_SELECTABLE_PROFILE Special Message Action && test message r=jhirsch,omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D222980
2024-10-17 18:18:59 +00:00
hanna alemu
c1335b0cb7 Bug 1892548 - Remove faulty test r=omc-reviewers,mviar
Removes the react_to_trigger test that causes intermittent failures on different platforms. The method that renders the infobar message (showInfoBarMessage) and the defaultBrowserCheck trigger are covered by other tests separately.

Differential Revision: https://phabricator.services.mozilla.com/D225532
2024-10-15 19:52:11 +00:00
Mike Conley
8f93af2686 Bug 1920799 - Add tests for the new menu messaging surface for the FxA CTA message. r=pdahiya,omc-reviewers,home-newtab-reviewers,nbarrett
To manually test the message, make sure to set
`browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` to `true`,
and then visit about:asrouter. Scroll down to the message with ID
FXA_ACCOUNTS_APPMENU_PROTECT_BROWSING_DATA, and click "Show".

This will default to opening the AppMenu with the message. You can open
it for the PXI menu by changing `testingTriggerContext` in the test
message definition from "app_menu" to "pxi_menu".

Differential Revision: https://phabricator.services.mozilla.com/D224790
2024-10-15 16:15:09 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
hanna alemu
ad40840097 Bug 1910641 - Update the FxMS Bookmarks Bar button for the onboarding setup checklist experiment r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224537
2024-10-07 17:56:24 +00:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Florian Quèze
93b33a0974 Bug 1922217 - Migrate telemetry events to use Glean APIs for messaging_experiments, r=chutten,omc-reviewers,pdahiya.
Differential Revision: https://phabricator.services.mozilla.com/D223291
2024-10-03 11:45:27 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221538
2024-09-26 17:54:01 +00:00
Eric Chen
7ccb2cc84f Bug 1896804 - adding support for architecture based experiment targeting r=nalexander,omc-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D223424
2024-09-25 18:32:21 +00:00
hanna alemu
7598b19c9a Bug 1913431 - modify activeNotifications to account for newtab topic selection modal r=omc-reviewers,mviar,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D222379
2024-09-24 21:15:26 +00:00
negin
02f4e905ae Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D222151
2024-09-20 20:18:28 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D221307
2024-09-19 02:52:04 +00:00
Iulian Moraru
7fadac62f4 Backed out changeset 8faf0e38aae6 (bug 1918745) for causing xpcshell failures on test_NimbusRolloutMessageProvider.js. 2024-09-16 22:08:37 +03:00
negin
0dd29c39bf Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya
Adds `FOX_DOODLE_SET_DEFAULT` and `FAKESPOT_CALLOUT_` and removes `Q4_DEVICE_MIGRATION` and `ADDONS_STAFF_PICK` as part of live rollouts.


```
Processing rollout: 1-click-set-to-default-existing-profiles-rollout
  Processing branch: treatment-b
    Importing message: FOX_DOODLE_SET_DEFAULT
Processing rollout: us-review-checker-rollout-v2
  Processing branch: treatment-a
    Importing message 1 of 4: FAKESPOT_CALLOUT_NO_OP_DUMMY
    Importing message 2 of 4: FAKESPOT_CALLOUT_CLOSED_NOT_OPTED_IN_AUTO_OPEN
    Importing message 3 of 4: FAKESPOT_CALLOUT_PDP_NOT_OPTED_IN_REMINDER
    Importing message 4 of 4: FAKESPOT_CALLOUT_OPTED_OUT_SURVEY
Processing rollout: recommend-add-ons-staff-pick-relaunch-treatment-a-rollout
```

Differential Revision: https://phabricator.services.mozilla.com/D222151
2024-09-16 17:17:01 +00:00
hanna alemu
8bb0544d31 Bug 1915019 - Include hidden and isBuiltin in addonsInfo targeting values r=omc-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D222174
2024-09-16 13:12:02 +00:00
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
2024-09-16 09:13:30 +00:00
Sebastian Hengst
2cc2b0108b Bug 1892548 - disable browser_asrouter_infobar.js on Linux debug for frequent intermittent failures. r=intermittent-reviewers,omc-reviewers,ahal,hanna_a DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D221794
2024-09-12 21:25:30 +00:00