corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
886,577 Commits 1 Branch 0 Tags
f2235bc02a15adef981738bcb4f57d7581486b48
Commit Graph

59 Commits

Author SHA1 Message Date
longsonr
a1e0dc11f4 Bug 1931617 Part 2 - Remove mentions of Algorithm.h where it's no longer used r=emilio,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D229205
 2024-11-19 11:25:39 +00:00
Adi
96cdd300d5 Backed out 2 changesets (bug 1931617) for causing for causing build bustages @sVersionComparator.cpp. CLOSED TREE 
Backed out changeset 7376753fb852 (bug 1931617)
Backed out changeset 4cd29d936b4b (bug 1931617)
 2024-11-19 11:11:50 +02:00
longsonr
2431f88b47 Bug 1931617 Part 2 - Remove mentions of Algorithm.h where it's no longer used r=emilio,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D229205
 2024-11-19 08:26:38 +00:00
serge-sans-paille
c2bbe8fb3a Bug 1920717 - Add static checker for global variables with runtime initialisation r=glandium 
This patch both:

1. Provides a static checker to detect global variables which may not be
   initialized at compile-time

2. Verify that variables flagged as MOZ_RUNINIT are indeed
   initialized at runtime

3. In case of variables whose initialisation status varies based on
   macro definition or template parameters, just flag them as
   MOZ_GLOBINIT.

Differential Revision: https://phabricator.services.mozilla.com/D223342
 2024-10-30 11:05:25 +00:00
serge-sans-paille
5946338a6a Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato 
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
 2024-10-30 11:05:24 +00:00
Tamas Szentpeteri
8285dfaab8 Backed out changeset 4b1409597101 (bug 1920718) for causing bp bustages on rapl.cpp. 2024-10-08 23:27:18 +03:00
serge-sans-paille
1966f9a43c Bug 1920718 - Annotate all global variable with runtime initialization as MOZ_RUNINIT r=application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh 
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
 2024-10-08 16:49:51 +00:00
Mark Banner
57b142b0fe Bug 1907860 - Clean up remaining parts of format-source. r=sheehan 
Differential Revision: https://phabricator.services.mozilla.com/D216546
 2024-07-15 14:00:10 +00:00
Andrew McCreight
7e5cd3bd2b Bug 1902344 - Remove outdated data structure references in "Using C++ in Mozilla code" and elsewhere. r=xpcom-reviewers,nika DONTBUILD 
nsAutoTArray was renamed to AutoTArray.

nsDataHashtable and nsJSThingHashtable don't exist any more.

nsTHashMap and nsTHashSet now exist.

nsDeque is properly typed now.

Pair is now CompactPair.

Differential Revision: https://phabricator.services.mozilla.com/D213624
 2024-06-13 22:41:51 +00:00
Botond Ballo
fb1065c0c3 Bug 1858446 - Document that classes representing HTML elements should live in the mozilla::dom namespace. r=peterv DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D210576
 2024-05-17 23:23:44 +00:00
ogiorgis
d916e7edbe Bug 1840493 - doc/rst: fix some languages declaration r=firefox-source-docs-reviewers,webdriver-reviewers,necko-reviewers,geckoview-reviewers,devtools-reviewers,profiler-reviewers,championshuttler,whimboo,nchevobbe,julienw,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D196268
 2023-12-13 18:32:20 +00:00
Mike Hommey
6aa78a25db Bug 1867459 - Replace CPU_ARCH with TARGET_CPU. r=firefox-build-system-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D195157
 2023-12-08 10:43:59 +00:00
Sylvestre Ledru
2cc79f510e Bug 1519636 - Remove nbsp in the doc r=firefox-source-docs-reviewers,geckoview-reviewers,ahal,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D194782
 2023-12-03 11:01:53 +00:00
Sylvestre Ledru
3608dc8457 Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D191480
 2023-10-19 20:52:10 +00:00
Emilio Cobos Álvarez
04e2ae3af3 Bug 1858711 - Refactor lwtheme attributes to account for missing colors. r=dao,desktop-theme-reviewers 
When a theme doesn't specify popup colors, it makes sense to follow the
system-preferred color scheme. Refactor theming attributes so that we
can distinguish this. Instead of a single [lwt-popup-brighttext], we get
lwt-popup="dark"/"light", and handle it appropriately.

Same for the other relevant attributes.

Refactor sidebar theming (which already did this tri-state thing via
lwt-sidebar and lwt-sidebar-brighttext) to do the same using a single
lwt-sidebar attribute, and update the docs.

Differential Revision: https://phabricator.services.mozilla.com/D190919
 2023-10-13 13:24:14 +00:00
Mike Hommey
c3d18e1e02 Bug 1851754 - Upgrade minimum supported Clang version to 8. r=firefox-build-system-reviewers,ahochheiden 
Differential Revision: https://phabricator.services.mozilla.com/D188898
 2023-09-22 02:34:51 +00:00
CanadaHonk
f65d19a19a Bug 1841117 - Remove unused intl.uidirection pref r=gregp,sylvestre 
It was still in `about:config` and referenced in some docs after mostly
being removed in Bug 1676137.

Differential Revision: https://phabricator.services.mozilla.com/D182748
 2023-07-10 12:00:58 +00:00
Cristian Tuns
d80b8e8911 Backed out changeset 088b1611348a (bug 1841117) as requested by canadahonk CLOSED TREE 2023-07-04 18:39:27 -04:00
CanadaHonk
96a32ae0ca Bug 1841117 - Remove unused intl.uidirection pref r=gregp 
It was still in `about:config` and referenced in some docs after mostly
being removed in Bug 1676137.

Differential Revision: https://phabricator.services.mozilla.com/D182748
 2023-07-04 22:31:28 +00:00
Mike Hommey
027d05ec27 Bug 1834436 - Upgrade minimum supported GCC version to 8. r=firefox-build-system-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D178736
 2023-06-01 20:09:19 +00:00
Mike Hommey
096fff8c41 Bug 1834955 - Upgrade minimum supported Clang-cl version to 9. r=firefox-build-system-reviewers,sergesanspaille 
We have less constraints on the minimum supported clang-cl version, and
it would unlock C++17 inline variables (which had a bug on Windows
targets in clang up-to 8.x).

Differential Revision: https://phabricator.services.mozilla.com/D179037
 2023-05-29 20:31:08 +00:00
Mike Hommey
3a3571681b Bug 1833958 - Update clang version in C++ in Firefox doc. r=firefox-source-docs-reviewers,marco 
Differential Revision: https://phabricator.services.mozilla.com/D178891
 2023-05-25 06:50:43 +00:00
Andi-Bogdan Postelnicu
fc974b33c4 Bug 1277372 - Remove unused "mozilla/TypeTraits.h" r=sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D174129
 2023-04-17 13:50:11 +00:00
Itiel
6da8219633 Bug 1825586 - Update RTL docs r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D174136
 2023-04-13 17:14:05 +00:00
Sylvestre Ledru
2d87d6b58f no bug - doc: fix some typos r=marco 
Differential Revision: https://phabricator.services.mozilla.com/D171688
 2023-03-06 11:53:54 +00:00
ogiorgis
1826f0e73d Bug 1749473 - fix all pygments warnings r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D167915
 2023-01-27 13:41:10 +00:00
Eemeli Aro
3d25e4614a Bug 1804404 - Update l10n documentation due to DTD & .inc removal. r=flod 
Differential Revision: https://phabricator.services.mozilla.com/D164047
 2022-12-07 11:50:39 +00:00
Greg Stoll
757c579cea no bug - fx doc: fix a few links to old pages r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D162421
 2022-11-18 21:20:18 +00:00
Greg Stoll
72069a846d no bug - fx doc: fix link to moved string guide page r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D159705
 2022-10-19 19:51:27 +00:00
Sylvestre Ledru
43ee108f26 Bug 1787590 - Doc: Remove a 404 link r=jandem DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D157112
 2022-09-12 12:37:43 +00:00
Ray Kraesig
fcc0aae9a6 Bug 1772856 - Clean up formatting r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148417
 2022-06-15 07:12:02 +00:00
Ray Kraesig
0cbc21cb91 Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148416
 2022-06-15 07:12:02 +00:00
Bobby Holley
98e3028bb3 Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D148081
 2022-06-02 21:01:42 +00:00
Janvi Bajoria
a6d7d18556 Bug 1759754 - fix use the static preference API link in C++ coding style documentation r=KrisWright 
Differential Revision: https://phabricator.services.mozilla.com/D144191
 2022-05-10 17:26:31 +00:00
Mathew Hodson
e39ff60a8e Bug 1630027 - Migrate RTL Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142183
 2022-05-06 07:16:58 +00:00
Mathew Hodson
481dd8581a Bug 1630027 - Migrate CSS Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142163
 2022-05-06 07:16:48 +00:00
Mathew Hodson
f2b3c1eab6 Bug 1630027 - Migrate SVG Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142184
 2022-05-06 07:16:48 +00:00
Mike Conley
b273648e2f Bug 1758753 - Migrate XPCOM hashtable documentation from MDN to Firefox Source Docs. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D140671
 2022-03-17 14:23:27 +00:00
Sylvestre Ledru
aa55fd2be8 Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D137741
 2022-02-03 18:34:58 +00:00
Bobby Holley
0d8d639e0d Bug 1740616 - Modify the C++ style guide to prefer unsigned types and CheckedInt. r=glandium DONTBUILD 
This commit resolves the question posed in [1], largely on the basis of
the rationale put forth by emilio [2].

The reasons cited for using signed types boil down to (1) taking
advantage of UB optimizations, (2) more tractable dynamic overflow
analysis, and (3) increased chance of the surrounding logic identifying
and rejecting overflowed values.

Emilio points out that (1) is not a durable advantage. I see some value
in (2) and (3), but I see more value in consistency with existing code
and clear communication of semantic intent to the reader.

[1] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/
[2] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/m/NPdl2uIhAgAJ

Differential Revision: https://phabricator.services.mozilla.com/D130928
 2021-11-16 19:38:01 +00:00
Chris Peterson
811beee789 Bug 1729598 - Remove now-unused MustUseChecker and MOZ_MUST_USE_TYPE attribute. r=static-analysis-reviewers,andi 
Depends on D125504

Differential Revision: https://phabricator.services.mozilla.com/D125505
 2021-09-15 05:10:51 +00:00
Simon Giesecke
969138c537 Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2021-09-08 12:56:01 +00:00
surajeet310
6cf624ea47 Bug 1714788 - Fixed more Sphinx warnings in 'mach doc' r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D117419
 2021-06-10 19:33:53 +00:00
Simon Giesecke
a6e3b52371 Bug 1692835 - Remove nsJSThingHashtable. r=xpcom-reviewers,nika 
The only use of nsJSThingHashtable is replaced by a direct use of
nsBaseHashtable.

Differential Revision: https://phabricator.services.mozilla.com/D105971
 2021-03-02 09:02:19 +00:00
Mark Banner
34db9cc17a Bug 1686226 - Add references to the Matrix Lint & Formatting room in the coding style docs. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D101463
 2021-01-12 15:04:35 +00:00
Butkovits Atila
84f1d7afa2 Backed out changeset eb6cdd43ce2e (bug 1677549) as requested by Simon. CLOSED TREE 2020-12-14 17:32:44 +02:00
Simon Giesecke
0db014fa9a Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=andi,sylvestre,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2020-12-11 10:35:54 +00:00
Sylvestre Ledru
af5e653325 Bug 1667831 - doc: fix more pygments r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91868
 2020-09-30 07:03:41 +00:00
Markus Stange
ee173b67a1 Bug 1667463 - Fix two typos in using_cxx_in_firefox_code.rst. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D91472
 2020-09-25 20:25:23 +00:00
Simon Giesecke
29f4eb535b Bug 1648010 - Update coding style with respect to string literals. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D81503
 2020-07-21 11:24:06 +00:00