beng@bengoodger.com
f11b3889f9
323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
2006-03-28 00:53:50 +00:00
beng@bengoodger.com
2c33614c1e
324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS)
2006-03-25 00:46:09 +00:00
annie.sullivan@gmail.com
8847fc4aec
Bug 329743: fixes dropmarker icon not showing up on places toolbar folders on mac.
...
Patch by Pam Greene <pamg.bugs@gmail.com >
r=annie.sullivan@gmail.com sr=ben@mozilla.org
2006-03-23 16:30:27 +00:00
joe@retrovirus.com
7f648bbd0f
* Moved changeBookmarkURI functionality from controller.js into
...
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546
bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com
2006-03-23 06:24:54 +00:00
beng@bengoodger.com
a7a60eefa5
329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com
2006-03-23 00:53:54 +00:00
joe@retrovirus.com
7b2a2d0d09
This submission is a roll-up of three patches developed & approved during
...
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-03-22 03:36:41 +00:00
beng@bengoodger.com
11144b6eeb
329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
2006-03-17 02:01:06 +00:00
annie.sullivan@gmail.com
25d09daf6e
Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130
2006-03-15 19:59:09 +00:00
joe@retrovirus.com
b1ecd5619d
Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
...
toolkit/content/debug.js
debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.
NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true. The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions. To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.
bug=327349
r=darin@meer.net , gavin.sharp@gmail.com
2006-03-14 01:56:09 +00:00
beng@bengoodger.com
ba999eacf0
329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
2006-03-10 23:48:40 +00:00
joe@retrovirus.com
28e71dd1d2
Changes to bookmark properties dialog:
...
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
yielding layout and accessibility improvements
* Switched to using standard dialog buttons
bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-10 17:36:41 +00:00
beng@bengoodger.com
de13bd15cc
329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com
2006-03-09 22:02:21 +00:00
beng@bengoodger.com
268b6e977b
329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com
2006-03-09 02:08:45 +00:00
annie.sullivan@gmail.com
29243bdeb2
Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org
2006-03-07 23:20:08 +00:00
beng@bengoodger.com
75afec6589
329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com
2006-03-07 18:24:28 +00:00
joe@retrovirus.com
8f7b3936ca
* Allows the user to access Bookmark Properties dialog from context menus.
...
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js
NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.
bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-07 00:52:35 +00:00
annie.sullivan@gmail.com
edc2180ac1
Adds menuitem for Open In Tabs.
...
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034
2006-03-04 01:12:05 +00:00
annie.sullivan@gmail.com
edc0a47409
Fixes problems with bookmark menus and toolbarbuttons not working correctly on mac. bug=327036 r=ben@mozilla.org
2006-02-23 18:30:40 +00:00
annie.sullivan@gmail.com
5030e95c4e
Checking in patch by mossop@blueprintit.co.uk to allow middle click to open links in tabs. bug=325781 sr=beng
2006-02-17 22:58:13 +00:00
annie.sullivan@gmail.com
cc3aec4e24
Fixed drag and drop support for toolbars and menus. Added lots more visual feedback when dragging and dropping.
...
bug=318052 r=beng
2006-02-17 18:31:06 +00:00
beng@bengoodger.com
35ac93355f
326598 - tree D&D massively broken. r=annie.sullivan@gmail.com. checked in on the branch earlier, checking in now to the trunk.
2006-02-14 21:36:04 +00:00
beng@bengoodger.com
ebfbe24fa8
324948 - should not be able to do edit operations on immutable containers (delete, paste, cut). Make sure we check if a container has readonly children, or the folder itself (if it is a bookmark folder) is readonly before enabling commands for cut, copy and paste. Also assert that activeView is non-null, for safety. r=annie.sullivan@gmail.com
2006-02-09 21:32:24 +00:00
beng@bengoodger.com
7c823c9c0e
320655 - changing the history view displayed should also update the sorting r=annie.sullivan@gmail.com
2006-02-09 19:29:10 +00:00
beng@bengoodger.com
e5d391b859
326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com
2006-02-08 01:52:41 +00:00
bryner@brianryner.com
dc2b6bdc33
Add support for bookmark separators (bug 320261). r=brettw, ben.
2006-02-08 01:10:57 +00:00
brettw@gmail.com
07495f4424
Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode.
2006-02-07 01:56:36 +00:00
annie.sullivan@gmail.com
27b6cde5bd
bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons
2006-02-01 02:13:34 +00:00
beng@bengoodger.com
f05c577626
317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'.
2006-01-31 18:00:06 +00:00
brettw@gmail.com
27fde2f6eb
[for joe@retrovirus.com] Bug 324743, r=brettw. Result roots are closed by default.
2006-01-31 03:05:02 +00:00
annie.sullivan@gmail.com
572011fc10
Fixes to toolbar and menu to work with new history backend.
...
r=brettw sr=ben bug=209804
2006-01-27 18:30:51 +00:00
brettw@gmail.com
738be3534d
Bug 323492 r=bryner,beng Places history result node refactor, dynamic updates, performance improvements.
2006-01-24 01:24:15 +00:00
annie.sullivan@gmail.com
edf1de8fc6
Fixed JavaScript errors which were breaking copy/paste/delete.
...
bug=324056 r=beng
2006-01-20 17:03:45 +00:00
beng@bengoodger.com
8a704d0243
save selection across delete operations (not done automatically by the view object)... , also restyle parts of the band across the top of the places view to make the content clearer.
2006-01-18 00:11:25 +00:00
beng@bengoodger.com
f9a35c3fec
rejigger places UI a bit, add a title bar across the top of the places view, adjust the default entries in the listbox, etc. also fix icons for generic queries and generic non-favicon pages. r=brettw for changes to the cpp. NPOB
2006-01-13 20:47:18 +00:00
brettw@gmail.com
68f107e02b
Bug 320422 r=annie.sullivan: Rename nav-history/nsINavHistory to nav-history-service/nsINavHistoryService
2005-12-16 00:40:48 +00:00
annie.sullivan@gmail.com
6c2c9fe5ff
Added nsIBookmarksContainer interface which allows custom bookmarks types.
...
Implemented nsILivemarksService as a nsIBookmarksContainer.
bug=317837 r=beng sr=bryner
2005-12-15 20:56:18 +00:00
brettw@gmail.com
9f9b61b6da
Bug 317840, r=ben Delete history itens frontend
2005-12-15 17:53:31 +00:00
beng@bengoodger.com
0e561e2819
fix braindead bug in nodeIsQuery function in controller.js, make sure to return result. r=brettw
2005-12-14 18:36:43 +00:00
beng@bengoodger.com
5b0280dfd7
Including 318809 - group by site/group by page is not sticky in places. r=annie
2005-12-14 18:29:41 +00:00
bryner@brianryner.com
b1e09ce0ea
Make bookmark and history views update dynamically (bug 317826 and 317827), r=brettw.
2005-12-09 23:48:44 +00:00
beng@bengoodger.com
e6c19a6cdc
better D&D handling - make sure insertion point index is adjusted properly when rearranging items within a container. also lots of documentation and reorganization. NPOB
2005-12-02 18:32:27 +00:00
beng@bengoodger.com
5cfb653628
fix D&D to toolbar NPOB
2005-12-02 00:01:56 +00:00
beng@bengoodger.com
5ec0cc99fa
315940 - more D&D fixes. makes sure the right elements are selected post drop, fix js errors and save selection. NPOB
2005-12-01 23:58:02 +00:00
beng@bengoodger.com
c323497b6a
more d&d polish NPOB
2005-12-01 02:22:14 +00:00
beng@bengoodger.com
edfbd8bd51
more improvements to d&d NPOB
2005-12-01 01:54:32 +00:00
beng@bengoodger.com
9b452c7291
more d&d feedback... select dropped items NPOB
2005-12-01 00:39:15 +00:00
beng@bengoodger.com
e0c75d0801
more work on selection saving across view reloading, also as part of 317633 store txmgr on history service for global txn stack. r=brettw for that NPOB
2005-12-01 00:09:29 +00:00
annie.sullivan@gmail.com
8161c25ad1
Fixes "open links in tabs" attempting to open folders.
...
Fixes open commands sometimes being disabled because they're not up to date
with the activeView
Work on fixing pasting of folders.
2005-11-30 19:24:44 +00:00
bryner@brianryner.com
882175fecd
Fix some regressions from bug 317878, r=brettw.
2005-11-29 17:12:02 +00:00
bryner@brianryner.com
29b826e062
Make folder nodes just be a type of query node. Make nsNavHistoryResult inherit from QueryNode instead of ResultNode, to get rid of some redundancy. Bug 317878 / 314553, r=brettw.
2005-11-29 00:35:31 +00:00
