Commit Graph

320 Commits

Author SHA1 Message Date
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 14:45:51 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Gijs Kruitbosch
87fba25ea4 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D194632
2023-11-27 23:27:36 +00:00
Iulian Moraru
df1ac624b2 Backed out changeset 49b89e35b5f5 (bug 1866503) for causing multiple bc failures related to panelUI. CLOSED TREE 2023-11-27 15:39:13 +02:00
Gijs Kruitbosch
ae5f8336a8 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D194632
2023-11-27 12:14:03 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Shane Hughes
6da3c5e401 Bug 1831906 - Add release notes link to update modal prompts. r=bytesized,omc-reviewers,application-update-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D177410
2023-06-08 15:48:01 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Shane Caraveo
c114951f8b Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154179
2022-08-22 18:55:59 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
9e59e52e55 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Neil Deakin
c9ddb2f4b9 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-07-03 09:44:39 +00:00
Norisz Fay
f4827a4636 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_menu_touch.js CLOSED TREE
Backed out changeset 88be5107a4a1 (bug 1682621)
Backed out changeset e32910a4948b (bug 1682621)
2022-06-29 19:36:51 +03:00
Neil Deakin
4674aa45e8 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-29 12:38:30 +00:00
Marian-Vasile Laza
3dee1242d8 Backed out 2 changesets (bug 1682621) for causing bc failures on browser_ext_browserAction_click_types.js.
Backed out changeset 31a6b027b4e7 (bug 1682621)
Backed out changeset 782fd4871c5f (bug 1682621)
2022-06-28 20:27:15 +03:00
Neil Deakin
27e54692b9 Bug 1682621, remove keypress listener for main toolbar buttons, and use the inputSource to distinguish keyboard events, r=Gijs
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm

This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.

Differential Revision: https://phabricator.services.mozilla.com/D149285
2022-06-28 16:02:37 +00:00
Gijs Kruitbosch
a408c9940d Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D135949
2022-02-28 14:33:29 +00:00
Jonathan Watt
8bf216317f Bug 1745332 - Remove print.tab_modal.enabled checks from CustomizableUI code. r=mconley
The old UI is going away.

Differential Revision: https://phabricator.services.mozilla.com/D133451
2022-01-06 18:55:37 +00:00
Rob Wu
b6b78cf0cc Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Butkovits Atila
f90ffaea22 Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE 2021-12-03 23:30:10 +02:00
Rob Wu
68e93f997c Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-03 19:16:51 +00:00
Scott
9c09e77b2e Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130770
2021-11-16 00:35:34 +00:00
Tooru Fujisawa
9281ca231f Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs
Instead of copying from label-* attributes, set data-l10n-id for each
notification

Also, stop using attributes for checking if the notification is supported.

Differential Revision: https://phabricator.services.mozilla.com/D129270
2021-10-26 18:32:36 +00:00
Neil Deakin
0d6adaeabb Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00
Scott
d596fb0a27 Bug 1693582 - Moving Pocket button panels to remote content process r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D122128
2021-09-08 16:11:34 +00:00
Scott
016ff65279 Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-25 00:46:01 +00:00
Marian-Vasile Laza
3cf60904a9 Backed out changeset 6ba2b54d02f6 (bug 1724668) for causing bc failures on browser_panel_locationSpecific.js. CLOSED TREE 2021-08-20 20:52:53 +03:00
Scott
6b8ab0fe63 Bug 1724668 - Ensure Pocket panel closes if location changes with locationSpecific CustomizableUI prop. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D122278
2021-08-20 16:54:00 +00:00
Sam Foster
22012dcb8a Bug 1719463 - Part 7: Remove the Logins, Addons, Preferences and Print buttons from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121807
2021-08-10 05:29:32 +00:00
Mike Conley
45d08882f4 Bug 1720534 - Clean up styles in Bookmarks Menu Button menupopups on Windows 7 and 10. r=desktop-theme-reviewers,dao
This also gets rid of a dead CSS class (panel-subview-footer).

Differential Revision: https://phabricator.services.mozilla.com/D119906
2021-07-18 00:06:41 +00:00
Gijs Kruitbosch
4508e659f8 Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D117058
2021-07-07 22:15:50 +00:00
Mike Conley
ec03c5ad34 Bug 1700198 - Remove subviewbutton-iconic class from Library panel markup. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D118621
2021-06-24 20:27:46 +00:00