corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
555,186 Commits 1 Branch 0 Tags
edfa25a364a213d77be920bb716d65a68dec2b92
Commit Graph

31 Commits

Author SHA1 Message Date
Boris Zbarsky
00c784322e Bug 1455052 part 4. Stop using nsIDOMEvent in xpidl interfaces. r=masayuki 
MozReview-Commit-ID: GIs8DVfduKe
 2018-04-20 12:53:17 -04:00
Marco Bonardo
506fe4efc1 Bug 1435711 - Remove controller support for tree autocomplete. r=Paolo 
MozReview-Commit-ID: 5NJu2ILBP5h
 2018-02-17 18:11:13 +01:00
Masayuki Nakano
b93a0ce668 Bug 1407085 - nsAutoCompleteController shouldn't restore original value after somebody changes the input value even when Escape key is pressed r=mak 
When Escape key is pressed, nsAutoCompleteController needs to restore last
string which was default value of the input or typed by the user.  However,
somebody may change the value, e.g., an event listener which handles
Escape key.  In this case, nsAutoCompleteController shouldn't restore the
last string.

Unfortunately, when JS sets input value, DOM "input" event won't be fired.
Therefore, nsAutoCompleteController doesn't have a chance to modify
mSearchString in this case.  Therefore, nsAutoCompleteController needs to
store expected input string for checking if somebody modified the input value.
For solving this issue, this patch adds a new member, mSetValue which is
modified when the input value is modified by nsAutoCompleteController itself
or mSearchString is modified.

Even with this patch, if user temporarily selects an item of the popup and
JS sets same value as the selected item from JS, nsAutoCompleteController
restores the input value with mSearchString.  However, this must be rare
case and I don't have idea to fix this issue with simple patches.

MozReview-Commit-ID: lig8c7xvD7
 2017-12-19 16:46:20 +09:00
Marco Bonardo
c6b922c0b7 Bug 1415908 - Intermittent failure (nsIAutoCompleteController.getCommentAt) in browser_ext_omnibox.js. r=adw 
Fixes a timing bug where in certain moments matchCount may not be in sync with the current search status,
due to previous results not being cleared immediately. Still delays tree updates to avoid UI flickering.
Fixes a theorical timing issue in unifiedComplete where a stopped search could notify a result.
Removes the no more used OnUpdateSearchResult API.

MozReview-Commit-ID: COoIN4oQT4v
 2017-11-19 21:58:14 +01:00
Bevis Tseng
59627df038 Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
Sylvestre Ledru
9d4a84d778 Bug 1378712 - Remove all trailing whitespaces r=Ehsan 
MozReview-Commit-ID: Kdz2xtTF9EG
 2017-07-06 14:00:35 +02:00
Drew Willcoxon
a11453a5f4 Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian 
MozReview-Commit-ID: A9YXB32L7MN
 2016-08-02 18:00:26 -07:00
Marco Bonardo
6c190ee363 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Marco Bonardo
ed7123ee15 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Ryan VanderMeulen
d132c6c469 Backed out changeset 91b6fe481685 (bug 1172937) for test_autocomplete_with_composition_on_input.html failures. 2015-07-30 12:45:03 -04:00
Marco Bonardo
ef650b87a0 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Andrea Marchesini
ad97ae68b8 Bug 1148527 - Indentation fix after bug 1145631, r=ehsan 2015-03-27 18:52:19 +00:00
Tim Taubert
61f65b8a83 Bug 1042561 - Correct autocomplete search result update handling in OnUpdateSearchResult() r=mak 2015-03-22 13:26:09 +01:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj 
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
 2015-03-21 12:28:04 -04:00
Gijs Kruitbosch
b4e3c116f7 Bug 1043584 - fix mouseover vs. enter issue in the urlbar, r=mak 2014-12-02 15:52:26 -08:00
Julian Viereck
0047711bbf Bug 950797 - Use result from last completion in nsAutoCompleteController to reduce autoFill UI flickering until search results come back. r=mak 2014-09-30 04:14:49 -07:00
Trevor Saunders
d67df400c1 bug 1047696 - mark a number of classes MOZ_FINAL to get compilers to devirtualize more r=froydnj 2014-08-05 13:33:55 -04:00
Benoit Jacob
029e0e533d Bug 1028588 - Fix dangerous public destructors in toolkit/ - r=ehsan 2014-06-23 18:40:02 -04:00
Marco Bonardo
a50da3e1dc Bug 754265 - Add a dedicated API to provide a final complete value different from the matching one, r=Enn sr=gavin 2014-04-18 16:04:19 +02:00
Trevor Saunders
fdf2a869ea bug 407956 - make nsITreeView not take a nsISupportsArray* r=neil, bz sr=neil 2013-01-06 19:54:42 -05:00
Ehsan Akhgari
243c878d26 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg 
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
 2012-08-22 11:56:38 -04:00
Marco Bonardo
1c5eccb65b Bug 720081 - Part 1: backportable solution for autocomplete controller to provide a different final defaultComplete value for typeAheadResults 
r=gavin
 2012-06-04 00:42:48 +02:00
Gavin Sharp
6e2b8bf544 Back out 59409e2655ca (from bug 720081) due to bug 760803 2012-06-02 13:35:39 -07:00
Marco Bonardo
f02b9ba9ae Bug 720081 - Part 1: backportable solution for autocomplete controller to provide a different final defaultComplete value for typeAheadResults 
r=gavin
 2012-06-01 14:38:37 +02:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Masayuki Nakano
1f6df04cb6 Bug 720659 nsAutoCompletController should search with committed composition string at input event handler immediately after compositionend event rather than composition event handler feedback=mak+m_kato, r=gavin 2012-03-13 15:03:03 +09:00
Marco Bonardo
184853699f Bug 720792 - Implement a better solution to start selected searches without a timeout. 
r=gavin
 2012-03-01 14:37:13 +01:00
Michael Ventnor
178570bda1 Bug 660156 - Race condition between sync and async autocomplete searches. 
r=mak
 2012-01-19 12:31:20 +01:00
Felix Fung
a5498d88ff Bug 702410 - mIsOpen is a Redundant Property. r=mak 2011-11-18 14:37:51 -08:00
Michael Wu
0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Mitchell Field
8969bddd5d Bug 595513 - Reduce makefile recursion in toolkit. r=khuey 2011-03-08 14:58:46 +11:00