- Live update the button position when user moves the sidebar to the left or right, unless it is not in its default position.
- Ensure the button is placed correctly when initially toggling revamp.
- RTL is already correctly handled, so didn't make any checks to RTL_UI.
- Resetting CUI will also reset the sidebar position.
Differential Revision: https://phabricator.services.mozilla.com/D241226
To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.
Differential Revision: https://phabricator.services.mozilla.com/D233749
To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.
Differential Revision: https://phabricator.services.mozilla.com/D233749
The change in CustomizableUI is required because the routine wasn't designed to handle
custom elements with shadow roots. The routine's job is to walk up the ancestry of
the click event and determine if any of the parents have certain characteristics
that would indicate that the event should not close the panel, and without this
change it would bail out as soon as it hit the shadow root if the event's original
target was inside the custom element.
In this case, the element enclosing the fxa-menu-message is the "appMenu-fxa-menu-message"
toolbaritem with `closemenu="none"`, which this modification now lets
CustomizableUI detect.
Differential Revision: https://phabricator.services.mozilla.com/D230560
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
In bug 878551, the ability to move the list-all-tabs button was removed
for a few reasons:
> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).
> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.
These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.
Differential Revision: https://phabricator.services.mozilla.com/D224623
In bug 878551, the ability to move the list-all-tabs button was removed
for a few reasons:
> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).
> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.
These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.
Differential Revision: https://phabricator.services.mozilla.com/D224623
In bug 878551, the ability to move the list-all-tabs button was removed
for a few reasons:
> Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).
> Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.
These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.
Differential Revision: https://phabricator.services.mozilla.com/D224623
- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button
Differential Revision: https://phabricator.services.mozilla.com/D223406
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements
Differential Revision: https://phabricator.services.mozilla.com/D222059
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
Differential Revision: https://phabricator.services.mozilla.com/D223406
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements
Differential Revision: https://phabricator.services.mozilla.com/D222059
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements
Differential Revision: https://phabricator.services.mozilla.com/D222059
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
Differential Revision: https://phabricator.services.mozilla.com/D223406
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
