corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
865,247 Commits 1 Branch 0 Tags
ec1f215c3741e5487eb863d38b7ca7f06328e52f
Commit Graph

182 Commits

Author SHA1 Message Date
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211670
 2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212499
 2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar 
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
 2024-06-18 15:06:03 +00:00
Meg Viar
82932a56de Bug 1897804 - Fox Doodle Spotlight and Fox Doodle Set Default enrollment targeting should exclude First Run r=omc-reviewers,pdahiya 
This patch updates the targeting for two in-tree messages that include “source == ‘startup’” in their targeting and are triggered on default browser check. There are currently edge cases where these messages can collide with about:welcome. See [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1897804#c4 | this comment ]] for steps to replicate an example.

By adding additional targeting that ensures this isn’t the user’s first session, we can avoid about:welcome collisions.

Differential Revision: https://phabricator.services.mozilla.com/D213456
 2024-06-18 11:32:42 +00:00
Shane Hughes
b7111cb1ca Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-18 10:42:27 +00:00
Stanca Serban
47ba18b7d7 Backed out changeset f6ca02568bef (bug 1899439) for causing xcpshell failures in xpcshell/test_PanelTestProvider.js. CLOSED TREE 2024-06-18 05:14:28 +03:00
Shane Hughes
91acd11433 Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-17 17:52:59 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount 
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
 2024-06-17 14:53:04 +00:00
Shane Hughes
039ba4cf7a Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 23:05:10 +00:00
Aron Cseh
f28964fa3c Backed out changeset 98c3d77b4330 (bug 1899757) for causing multiple failures CLOSED TREE 2024-06-16 23:21:14 +03:00
Shane Hughes
6ef1ca7a31 Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 19:11:41 +00:00
hanna alemu
d7c67f44bd Bug 1828508 - Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209404
 2024-06-11 18:24:35 +00:00
Maxx Crawford
f79515b485 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D212952
 2024-06-07 20:44:50 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 23:02:05 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D212157
 2024-06-04 00:54:00 +00:00
Nathan Barrett
c7d3cc489b Bug 1893007 - add location query to weather widget r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212069
 2024-06-03 20:59:32 +00:00
scottdowne
0d285f9aec Bug 1900043 - Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes. r=home-newtab-reviewers,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D212301
 2024-05-31 18:36:19 +00:00
scottdowne
8954d01757 Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode r=desktop-theme-reviewers,home-newtab-reviewers,omc-reviewers,sfoster,aminomancer,amy 
Differential Revision: https://phabricator.services.mozilla.com/D211623
 2024-05-30 18:47:21 +00:00
Shane Hughes
64ab25b51e Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211275
 2024-05-28 17:59:47 +00:00
Maxx Crawford
ca1c9f6bb6 Bug 1898275 - Add impression and error telemetry events to Weather feature r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211402
 2024-05-24 01:46:48 +00:00
hanna alemu
5ad29cf4b1 Bug 1869212 - [Docs] Moments page is missing its example screenshot r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D210028
 2024-05-20 18:55:06 +00:00
Maxx Crawford
ef0230d8ef Bug 1895797 - Add telemetry to New Tab weather widget r=home-newtab-reviewers,omc-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209867
 2024-05-20 18:01:50 +00:00
Nathan Barrett
a46122da52 Bug 1896004 - Add wallpaper telemetry r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D210101
 2024-05-17 14:51:43 +00:00
Nipun Shukla
a788d363d7 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 15:34:43 +00:00
Tamas Szentpeteri
833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE 
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
 2024-05-15 11:24:17 +03:00
Nipun Shukla
3e3ebab8c6 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 02:54:55 +00:00
Maxx Crawford
99b8fc05eb Bug 1890136 - Add weather widget component r=home-newtab-reviewers,omc-reviewers,aminomancer,thecount 
This commit adds the component - including markup, logic and styles for the weather widget on the New Tab page

Differential Revision: https://phabricator.services.mozilla.com/D208885
 2024-05-09 22:11:57 +00:00
Nathan Barrett
3ae97b6c59 Bug 1886833 - Home and newtab creating weather feed r=home-newtab-reviewers,maxx,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D207763
 2024-05-06 16:02:21 +00:00
Sarah Chung
9a286a1dc8 Bug 1877512 - change feature-callout dismiss-button background color to transparent r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209302
 2024-05-03 15:48:26 +00:00
Shane Hughes
8dd336f8c5 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D208941
 2024-05-02 20:54:51 +00:00
Tamas Szentpeteri
c0574600bf Backed out changeset 1187f4d67bf7 (bug 1893671) for causing newtab failures in asrouter:CFRMessageProvider. CLOSED TREE 2024-05-02 21:34:33 +03:00
Shane Hughes
2625c54c7c Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D208941
 2024-05-02 17:44:25 +00:00
Punam Dahiya
77134726ce Bug 1775847 - Fix intermittent milestone message and accessibility cfr test failure r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D208761
 2024-04-26 16:38:10 +00:00
Shane Hughes
ca7244fbbc Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin 
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
 2024-04-24 20:54:02 +00:00
Barret Rennie
0633e0cca7 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-24 20:15:19 +00:00
gravyant
e950fb5069 Bug 1869065 - Re-visit some of the element property names used in moz-message-bar. r=hjones,reusable-components-reviewers,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207897
 2024-04-23 21:27:46 +00:00
Nipun Shukla
87498965b0 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207595
 2024-04-23 14:08:52 +00:00
Iulian Moraru
b2f394db04 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
b288396795 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-22 17:57:31 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D190612
 2024-04-22 16:24:30 +00:00
Maxx Crawford
f7bf5949e2 Bug 1824019 - Adjust hover/focus/active states for HNT card context menu buttons r=home-newtab-reviewers,desktop-theme-reviewers,dao,nbarrett,thecount 
This patch adjusts the background-color/border/outline of the three different context menu buttons across the HNT page: top sites, pocket stories and recent activity cards.

It addresses the different link states: :hover, :focus (inlcuding :focus-visible), and :active for this button. This patch also includes attribute values for dark mode.

Differential Revision: https://phabricator.services.mozilla.com/D207067
 2024-04-18 19:54:22 +00:00
Shane Hughes
1b4265e316 Bug 1863384 - Implement offset_x and offset_y for panel feature callout. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D207075
 2024-04-15 16:40:50 +00:00
Nicholas Rishel
f1a859cab6 Bug 1890066 - Show notification when users need to finish setting Firefox as the default in Windows Settings. r=nalexander,omc-reviewers,fluent-reviewers,flod,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D206828
 2024-04-11 17:13:02 +00:00
Nathan Barrett
ae3e1aa169 Bug 1881588 - Add Wallpaper component r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount,maxxcrawford 
Differential Revision: https://phabricator.services.mozilla.com/D205373
 2024-04-11 14:01:18 +00:00
Mark Banner
4eac7c7090 Bug 1557040 - Remove eslint-plugin-fetch-options from the tree. r=Gijs,omc-reviewers,aminomancer,home-newtab-reviewers,frontend-codestyle-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202628
 2024-04-09 08:11:10 +00:00