corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,342 Commits 1 Branch 0 Tags
ec188ec108d0df94c764f1dc0736bc3a72b3b0f3
Commit Graph

198 Commits

Author SHA1 Message Date
Mathew Hodson
52287e7f89 Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150333
 2022-09-26 13:58:49 +00:00
Alexandre Poirot
90ddca703f Bug 1791828 - [devtools] Remove eslint support for DevTools's lazyImporter. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D158004
 2022-09-26 10:48:05 +00:00
Mark Banner
dd194ee451 Bug 1479515 - Add an ESLint rule to check for valid property accesses on Services. r=Gijs 
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156426
 2022-09-12 16:38:44 +00:00
Mark Banner
74f27058b3 Bug 1479515 - Extend the ESLint rule for checking Ci properties to check for unknown interfaces as well. r=Gijs,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156425
 2022-09-12 16:38:44 +00:00
Mark Banner
418607ec92 Bug 1479515 - Add an ESLint rule to check for unknown property accesses on Ci. r=Gijs 
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156424
 2022-09-12 16:38:43 +00:00
Kagami Sascha Rosylight
a37cf7833d Bug 1695435 - Part 2: Add more words to the chrome script heuristic in use-isInstance r=preferences-reviewers,Gijs,webdriver-reviewers,whimboo,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D110932
 2022-08-24 22:47:42 +00:00
Kagami Sascha Rosylight
a88716cc34 Bug 1695435 - Part 1: Use isInstance in XUL files r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D154841
 2022-08-22 18:34:44 +00:00
André Bargull
c9d7d2edbb Bug 1783404: Support --fix option when eslint-plugin-spidermonkey-js is used. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D153843
 2022-08-12 06:10:55 +00:00
Max Smolens
e137b87d56 Bug 1617103 - Add documentation for yamllint. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D154108
 2022-08-09 19:13:45 +00:00
André Bargull
0885e4225d Bug 1782491 - Part 1: Add self-hosted code environment plugin. r=tcampbell 
Adds a simple ESLint plugin for custom environments.

The plugin has a single exported value named `globals`, which is an object with
keys for all globally available self-hosted identifiers. All self-hosted values
are read-only, so we set all properties of `globals` to `"readonly"`.

BytecodeEmitter special identifiers are added to the `.eslintrc.js` file,
because that keeps them closer to the SpiderMonkey source tree when compared
to "tools/lint/eslint/eslint-plugin-spidermonkey-js".

Also see:
- tools/lint/eslint/eslint-plugin-mozilla/lib/environments/
- https://eslint.org/docs/latest/user-guide/configuring/language-options

Differential Revision: https://phabricator.services.mozilla.com/D153337
 2022-08-05 09:58:58 +00:00
Mark Banner
ea37559b35 Bug 1782008 - Add existing test directories to the ESLint test path definition file. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D152735
 2022-08-03 11:16:19 +00:00
Tooru Fujisawa
5892446859 Bug 1779988 - Part 2: Add ESLint rule that rejects multiple ChromeUtils.defineESModuleGetters call on the same object. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D152880
 2022-07-28 00:54:20 +00:00
Francesco Lodolo (:flod)
c955af14aa Bug 1781010: Fluent linter, add checks for hard-coded brand names,r=gregtatum,linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D152718
 2022-07-26 19:48:08 +00:00
Tooru Fujisawa
11e740e6e6 Bug 1780543 - Part 11: Update document for environment. r=Standard8 
Depends on D152648

Differential Revision: https://phabricator.services.mozilla.com/D152649
 2022-07-26 02:46:32 +00:00
Andrew Halberstadt
0899d31e3c Bug 1780087 - Convert some searchfox links under 'docs/code-quality' to the new role, r=linter-reviewers,sylvestre 
This is more to demonstrate the use of the role than anything else.

Differential Revision: https://phabricator.services.mozilla.com/D152125
 2022-07-19 15:41:08 +00:00
Mark Banner
f9d637e4c5 Bug 1779989 - Explicitly disallow ES modules in ESLint import-globals-from statements. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152002
 2022-07-19 05:57:15 +00:00
Tooru Fujisawa
cda8cbecfe Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D150903
 2022-07-11 12:41:54 +00:00
Mark Banner
76af8b0f69 Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151083
 2022-07-06 08:35:59 +00:00
Mark Banner
f05cb62a29 Bug 1764513 - Update ESLint docs for how to set up test configuration and how to use ES modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151039
 2022-07-05 17:09:43 +00:00
Tooru Fujisawa
e1538f8276 Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop 
Depends on D150935

Differential Revision: https://phabricator.services.mozilla.com/D150936
 2022-07-05 01:01:35 +00:00
Mark Banner
f733d566c8 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D150353
 2022-06-29 22:37:57 +00:00
Makoto Kato
37f1452148 Bug 1776804 - Update spotless information in firefox-source-docs. r=geckoview-reviewers,agi 
"Google Java Format plug-in" link is broken now.

Also we should add spotless information to
https://firefox-source-docs.mozilla.org/code-quality/.

Differential Revision: https://phabricator.services.mozilla.com/D150440
 2022-06-28 22:58:11 +00:00
Kagami Sascha Rosylight
e29a0027f8 Bug 1773740 - Part 3: Cover js files including ChromeUtils r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148938
 2022-06-27 20:31:33 +00:00
Tooru Fujisawa
f141eb6bc3 Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149867
 2022-06-24 11:03:53 +00:00
Tooru Fujisawa
d219fa0035 Bug 1772358 - Add ESLint rule to reject defining lazy getters for always available modules. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149872
 2022-06-24 11:03:50 +00:00
Mark Banner
78cb8fd108 Bug 1771173 - Add ESLint rule to check for correct usages of lazy. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D149718
 2022-06-21 20:42:16 +00:00
Tooru Fujisawa
14e84976d3 Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 04:59:13 +00:00
criss
20943ab4b3 Backed out 8 changesets (bug 1771092, bug 1768870, bug 1771097, bug 1769002, bug 1768819) for causing mochitest failures on browser_sendQuery.js. CLOSED TREE 
Backed out changeset 8a4d712f819a (bug 1771092)
Backed out changeset f4e27a35c83c (bug 1771092)
Backed out changeset 072323bc72cc (bug 1771092)
Backed out changeset 2ccf2a00fff7 (bug 1769002)
Backed out changeset ba7086fd9b1f (bug 1768819)
Backed out changeset 6205d3e2c666 (bug 1771097)
Backed out changeset 960f0aee97d5 (bug 1768870)
Backed out changeset 5f53760c5637 (bug 1768870)
 2022-06-17 05:44:37 +03:00
Tooru Fujisawa
1b86cf2dbd Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 01:30:23 +00:00
Mark Banner
b0c82d6cae Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 21:11:24 +00:00
Molnar Sandor
ca093dfdcc Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures. CLOSED TREE 
Backed out changeset 829df1dfad70 (bug 1769002)
Backed out changeset f0537d333adc (bug 1771092)
Backed out changeset 25b43856bc00 (bug 1771092)
Backed out changeset a49f754ca73f (bug 1771092)
Backed out changeset 164f85686a32 (bug 1769002)
Backed out changeset ef5cf9ceb915 (bug 1768819)
Backed out changeset c64e6c1fbfe7 (bug 1771097)
Backed out changeset f85393f988a8 (bug 1768870)
Backed out changeset fe708d13cc1d (bug 1768870)
 2022-06-16 20:15:14 +03:00
Tooru Fujisawa
2420011dfd Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-16 16:20:36 +00:00
Norisz Fay
72669e959c Backed out 5 changesets (bug 1766228) for causing lint failures on test_restrequest.js CLOSED TREE 
Backed out changeset 5ff1634cfe18 (bug 1766228)
Backed out changeset 01642c97e7a5 (bug 1766228)
Backed out changeset cbba28151712 (bug 1766228)
Backed out changeset 76a32127865d (bug 1766228)
Backed out changeset 2c7ef1ad380a (bug 1766228)
 2022-06-16 16:36:44 +03:00
Mark Banner
38b7af6a55 Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 12:09:28 +00:00
Tooru Fujisawa
193b54e231 Bug 1772299 - Reject modification to globalThis inside system module. r=Standard8,webdriver-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D148116
 2022-06-15 22:20:53 +00:00
Tooru Fujisawa
a62358a521 Bug 1771751 - Reject static import for system module from non-system module. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149183
 2022-06-14 21:56:55 +00:00
Tooru Fujisawa
2bef883c3f Bug 1607331 - Part 3: Reject global this usage in JSM. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148551
 2022-06-14 21:56:55 +00:00
Mark Banner
a9fecdd342 Bug 1768031 - Reject top-level await in modules via an ESLint rule. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D145892
 2022-05-11 14:08:15 +00:00
Tooru Fujisawa
ba3f307e2c Bug 1548308 - Remove modules.json. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D145695
 2022-05-06 12:35:33 +00:00
Mark Banner
02c1e5dc6a Bug 1766238 - Disallow more than one argument to ChromeUtils.import via ESLint. r=mossop 
Depends on D144562

Differential Revision: https://phabricator.services.mozilla.com/D144563
 2022-04-27 08:38:35 +00:00
Barret Rennie
e2069f9e9f Bug 1765675 - Reject OS.Path usage in reject-osfile lint r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D144307
 2022-04-26 17:34:35 +00:00
Kagami Sascha Rosylight
f3f80c30f9 Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-04-06 11:57:56 +00:00
Mark Banner
6e6f975d7e Bug 1760286 - Add missing docs for rules in eslint-plugin-mozilla. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D142285
 2022-03-30 17:40:15 +00:00
Gijs Kruitbosch
d04ba14faf Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8 Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
43d6391aa2 Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 08:18:51 +00:00
criss
0038e58f1f Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE 
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
 2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
7e0f00efd6 Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-03-29 13:10:59 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00