corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
857,378 Commits 1 Branch 0 Tags
ec02da26f3053c0e2d52273e56e89f6269bd35e3
Commit Graph

2877 Commits

Author SHA1 Message Date
Gijs Kruitbosch
b60eb110cc Bug 1890718 - remove sync/fxa pane inline command listeners, r=sync-reviewers,lina 
This also tidies up some variable naming (we were passing 'panel's that were not, in fact, panels)
and removes some methods that we no longer call.

Bug 1690131 removed the last call to 'showRemoteTabsFromFxaMenu', bug 1562006 removed the last
call to 'showSidebarFromFxaMenu', AFAICT.

Differential Revision: https://phabricator.services.mozilla.com/D207452
 2024-04-15 23:23:52 +00:00
Gijs Kruitbosch
1be5de8ffe Bug 1890718 - remove history pane inline command listeners, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207121
 2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE 
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
 2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
ff23c68395 Bug 1890718 - remove history pane inline command listeners, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207121
 2024-04-15 14:45:52 +00:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207120
 2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D207119
 2024-04-15 14:45:51 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D207110
 2024-04-15 10:22:46 +00:00
Yi Xiong Wong
86c228872e Bug 1880914 - Move BrowserForceEncodingDetection. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D207108
 2024-04-15 10:22:45 +00:00
Gijs Kruitbosch
e6dd680afd Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D206685
 2024-04-09 18:28:44 +00:00
Emilio Cobos Álvarez
75ee484ddb Bug 1832748 - Hit the urlbar container margin to test the context menu. r=Gijs 
Test passes verify locally without this change on my machine, but this
seems to work on automation and seems no more hacky than the existing
100px offset:

  https://treeherder.mozilla.org/jobs?repo=try&revision=309ff5bb95505c69250f3674131b7b5b2453795c

Differential Revision: https://phabricator.services.mozilla.com/D207032
 2024-04-09 13:41:33 +00:00
Yi Xiong Wong
78b5d3f5fc Bug 1880914 - Move BrowserFullScreen. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D206200
 2024-04-08 17:21:02 +00:00
Emilio Cobos Álvarez
7bbe28bd37 Bug 1832748 - Make click consistently hit space between urlbar and nav bar. r=dao 
It seems that 1px offset isn't consistently for our synthesized click to
hit where it's supposed to. There's a 4px gap between urlbar and navbar
so let's increase this a bit.

Differential Revision: https://phabricator.services.mozilla.com/D206881
 2024-04-08 11:38:28 +00:00
Nika Layzell
690b246be7 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao 
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
 2024-04-05 16:42:51 +00:00
Yi Xiong Wong
3df27d805a Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205529
 2024-04-03 10:32:27 +00:00
Mike Conley
b65b8b6cce Bug 1888419 - Put appmenu-remote-tabs-showmore.label into sentence case. r=kcochrane,fluent-reviewers,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D206016
 2024-04-02 14:03:46 +00:00
Butkovits Atila
8311343a9f Backed out 3 changesets (bug 1887029, bug 1886892) for causing failures at browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 07f554ea4869 (bug 1887029)
Backed out changeset daa5f2355675 (bug 1886892)
Backed out changeset 389163cbd649 (bug 1886892)
 2024-04-01 21:50:42 +03:00
Nika Layzell
c261303179 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao 
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
 2024-04-01 17:11:23 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D204843
 2024-03-19 22:08:29 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Emilio Cobos Álvarez
508427619d Bug 1871515 - Let nsMenuPopupFrame constrain the panelview, and remove _calculateMaxHeight. r=dao,desktop-theme-reviewers 
When I rewrote nsMenuPopupFrame, I made sure percentage sizes worked so
that we could do stuff like this.

This removes some complex code, and improves the behavior on platforms
where screen sizes might not be 100% reliable.

Differential Revision: https://phabricator.services.mozilla.com/D204754
 2024-03-16 16:22:06 +00:00
Gregory Pappas
9d134e22f7 Bug 1878629 - part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/) r=tabbrowser-reviewers,Gijs,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201043
 2024-03-06 19:27:10 +00:00
Kelly Cochrane
d5647a2076 Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D193593
 2024-02-20 18:58:04 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201124
 2024-02-12 18:49:34 +00:00
Noemi Erli
8534246c91 Backed out changeset f19610ecbade (bug 1850591) for causing failures in browser_opentabs_tab_indicators.js CLOSED TREE 2024-02-10 01:07:49 +02:00
Kelly Cochrane
6b7daf459f Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D193593
 2024-02-09 22:01:30 +00:00
Karandeep
fa3e7164c7 Bug 1852051 - Remove the Search Bar from the toolbar for users who haven't used it in 120 days. r=dao,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195001
 2024-02-08 16:28:42 +00:00
Thomas Wisniewski
d99719816a Bug 1869823 - replace Report Broken Site's <menulist> with an <html:select> to simplify some code; r=emilio,Gijs,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D196677
 2024-02-06 00:02:54 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200082
 2024-02-05 22:03:13 +00:00
Anna Yeddi
2065431a19 Bug 1877603 - Add an exception from a11y_checks for a click on a disabled control in a Customizable UI test. r=Gijs 
We intentionally turn off a11y_checks, because the test case [disabled_button_in_panel() click is targeting a disabled control](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js#111) to confirm the click event won't come through.

This disabled control is not meant to be interactive and is not expected to be accessible.

Depends on D200115

Differential Revision: https://phabricator.services.mozilla.com/D200116
 2024-02-01 15:35:54 +00:00
Anna Yeddi
dae585bb5d Bug 1877602 - Update the test case browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js that clicks on an unlabeled toolbarbutton. r=Gijs 
The test "[browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js#35,53)" creates a test widget that has no `label` or `tooltiptext` property that is being clicked. But since its created toolbarbutton has no accessible name, it is being flagged by the a11y-checks. We could add "[tooltiptext](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/CustomizableUI.sys.mjs#4249)" property to make this test toolbarbutton accessible without triggering PanelMultiView to be adding header text, etc.

Since the issue will be resolved, we should also remove the `fail-if` notation from the test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D200115
 2024-02-01 15:35:53 +00:00
Gregory Pappas
b8a57ea6f0 Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D199328
 2024-02-01 00:48:24 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Norisz Fay
22f52ae24a Backed out 2 changesets (bug 1875079) for causing bc failures on browser_menu_touch.js CLOSED TREE 
Backed out changeset 015e7b62138b (bug 1875079)
Backed out changeset 3a62cca5ea26 (bug 1875079)
 2024-01-22 20:01:57 +02:00
Kagami Sascha Rosylight
5b2c025f9e Bug 1875079 - Part 2: Reduce max-height by zoom factor r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198803
 2024-01-22 12:05:34 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
 2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
 2024-01-19 02:15:33 +00:00
Itiel
cd3ef922f3 Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers 
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.

Differential Revision: https://phabricator.services.mozilla.com/D196671
 2024-01-09 17:01:25 +00:00
Cosmin Sabou
6d75e7bd12 Backed out 2 changesets (bug 1869092) for causing osx shippable bc failures on browser_sentence_case_strings.js. CLOSED TREE 
Backed out changeset 73cc7a634df0 (bug 1869092)
Backed out changeset d3a2a2b120e4 (bug 1869092)
 2023-12-13 02:35:02 +02:00
Cosmin Sabou
6198528ccc Bug 1869092 - Fix timeouts in browser_PanelMultiView.js. r=twisniewski,test-only 2023-12-12 21:46:53 +02:00
Thomas Wisniewski
6694fb475b Bug 1869092 - do not go back on left arrow key in PanelMultiViews, if the current panel has no back button; r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D196123
 2023-12-12 13:49:41 +00:00
Anna Yeddi
e04f794cdd Bug 1857056 - Re-enabling 3 test for a11y-checks after the crash was fixed. r=dholbert,extension-reviewers,rpl 
Since the crash in the bug 1868456 was fixed, we could re-enable these 3 test files that were previously crashing on trunk while a11y-checks were running, thus we are removing the `skip-if` notations from their test manifests.

Depends on D195646

Differential Revision: https://phabricator.services.mozilla.com/D195647
 2023-12-06 21:17:28 +00:00
Gijs Kruitbosch
87fba25ea4 Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194632
 2023-11-27 23:27:36 +00:00
Itiel
34e523a635 Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r=Gijs,twisniewski,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194416
 2023-11-27 17:13:56 +00:00