Commit Graph

590 Commits

Author SHA1 Message Date
Simon Giesecke
eba895263e Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55502
2019-12-19 09:25:08 +00:00
Simon Giesecke
65c740ec1f Bug 1600283 - Remove uses of plain pointers and already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55501
2019-12-19 09:24:58 +00:00
Simon Giesecke
9a430d6839 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55500
2019-12-19 09:24:47 +00:00
Simon Giesecke
fe8e1ec7c9 Bug 1600283 - Removed uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55499
2019-12-19 09:24:35 +00:00
Simon Giesecke
01fc281703 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55497
2019-12-19 09:24:15 +00:00
Simon Giesecke
7b764405f4 Bug 1603767 - Ensure that NoteActorDestroyed is not called multiple times. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D57301
2019-12-19 09:55:05 +00:00
Simon Giesecke
4981e5ea1d Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55490
2019-12-16 13:19:24 +00:00
Simon Giesecke
675deb26e3 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55489
2019-12-16 13:19:08 +00:00
Simon Giesecke
0af55bc258 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55488
2019-12-16 13:19:01 +00:00
Simon Giesecke
32ab286c9d Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55487
2019-12-16 13:18:46 +00:00
Simon Giesecke
91fc97a9a2 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55486
2019-12-16 13:18:39 +00:00
Simon Giesecke
99fa370f3b Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55480
2019-12-16 13:17:46 +00:00
Simon Giesecke
2176821c11 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55478
2019-12-13 12:31:10 +00:00
Simon Giesecke
66bd4949a5 Bug 1600283 - Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55477
2019-12-13 12:18:21 +00:00
Simon Giesecke
23c396b19b Bug 1577202 - Defer closing of a database while CreateFileOp's are pending. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D44683
2019-12-13 13:32:02 +00:00
Simon Giesecke
a13ea4dd47 Bug 1600906 - Reduce statefulness of TransactionDatabaseOperationBase using InitializedOnce. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56015
2019-12-13 11:31:56 +00:00
Simon Giesecke
70c2d14fb4 Bug 1600906 - Encapsulate DatabaseOperationBase::mResultCode. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56014
2019-12-13 11:28:24 +00:00
Simon Giesecke
b03b8a322d Bug 1600906 - Use move semantics with IdleDatabaseInfo. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56012
2019-12-13 12:21:18 +00:00
Simon Giesecke
87c344b031 Bug 1600906 - Use move semantics with ThreadInfo. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56011
2019-12-13 12:20:23 +00:00
Simon Giesecke
9b11a9200a Bug 1600906 - Reduce statefulness of DatabaseConnection using InitializedOnce. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56008
2019-12-13 10:55:10 +00:00
Simon Giesecke
3547a1eacd Bug 1600906 - Reduce statefulness of TransactionBase using const and InitializedOnce. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D56006
2019-12-13 10:54:22 +00:00
Doug Thayer
9f70804193 Bug 1602646 - Remove vestigial references to cooperative scheduling r=froydnj
GetCurrentPhysicalThread and GetCurrentVirtualThread are, in practice,
identical, as the TLS override that GetCurrentVirtualThread depends on
is never actually set. This simply removes that and renames some things/
deletes some comments.

Rebased across https://hg.mozilla.org/mozilla-central/rev/3f0b4e206853
by Karl Tomlinson <karlt+@karlt.net>.

Differential Revision: https://phabricator.services.mozilla.com/D41247
2019-12-12 00:56:53 +00:00
Simon Giesecke
c3bd09f8da Bug 1600906 - Added const in IdleConnectionRunnable. r=dom-workers-and-storage-reviewers,ytausky
Depends on D56009

Differential Revision: https://phabricator.services.mozilla.com/D56010
2019-12-11 13:25:21 +00:00
Simon Giesecke
0ca5f7d0e9 Bug 1600906 - Added const in UpdateRefcount. r=dom-workers-and-storage-reviewers,ytausky
Depends on D56008

Differential Revision: https://phabricator.services.mozilla.com/D56009
2019-12-11 14:40:38 +00:00
Simon Giesecke
bea2571518 Bug 1600906 - Reduce statefulness of TransactionInfo using const and FlippedOnce. r=dom-workers-and-storage-reviewers,ytausky
Depends on D56012

Differential Revision: https://phabricator.services.mozilla.com/D56013
2019-12-11 14:45:40 +00:00
Simon Giesecke
4b8e18fee2 Bug 1600906 - Make use of FlippedOnce in TransactionBase. r=dom-workers-and-storage-reviewers,ytausky
Also renamed TransactionBase::SetActive/mHasBeenActive to
TransactionBase::Init/mInitialized to avoid confusion with the 'Active' state
defined in the IndexedDB spec.

Differential Revision: https://phabricator.services.mozilla.com/D55682
2019-12-09 17:12:51 +00:00
Gabriele Svelto
eb403b8785 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442
2019-12-06 09:24:56 +00:00
Simon Giesecke
4361169d36 Bug 1597211 - Use InitializedOnce to reduce statefulness of Cursor class. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53951
2019-12-05 15:16:54 +00:00
Simon Giesecke
0a8134c283 Bug 1597211 - Use EmplaceBack instead of AppendResult, and use return value rather than output parameter. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53938
2019-12-05 15:16:47 +00:00
Simon Giesecke
c89841a80f Bug 1597211 - Calculate size of individual cursor response entries. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53937
2019-12-05 15:16:34 +00:00
Simon Giesecke
2f3223ca82 Bug 1597211 - Stop processing entries when maximum message size has been exceeded. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53936
2019-12-05 15:16:22 +00:00
Simon Giesecke
c9fa7d96e3 Bug 1597211 - Adjust parameters and return types to allow passing response size information. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53935
2019-12-05 15:17:04 +00:00
Simon Giesecke
9b78808e04 Bug 1598164 - Fixed log messages, use serial number of transaction. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D54963
2019-12-05 08:21:55 +00:00
Simon Giesecke
563b153e65 Bug 1600906 - Make use of FlippedOnce in ThreadRunnable. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55680

Differential Revision: https://phabricator.services.mozilla.com/D55681
2019-12-04 14:21:05 +00:00
Simon Giesecke
30d62e495b Bug 1600906 - Make use of FlippedOnce in DatabaseInfo. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55679

Differential Revision: https://phabricator.services.mozilla.com/D55680
2019-12-04 14:21:51 +00:00
Simon Giesecke
77d6827d32 Bug 1600906 - Make use of FlippedOnce in QuotaClient. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55678

Differential Revision: https://phabricator.services.mozilla.com/D55679
2019-12-04 14:22:33 +00:00
Simon Giesecke
16d5d79f3d Bug 1600906 - Make use of FlippedOnce in ConnectionPool. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55677

Differential Revision: https://phabricator.services.mozilla.com/D55678
2019-12-04 14:24:59 +00:00
Simon Giesecke
ee38e21018 Bug 1600906 - Make use of FlippedOnce in FullObjectStoreMetadata. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55676

Differential Revision: https://phabricator.services.mozilla.com/D55677
2019-12-04 14:26:48 +00:00
Simon Giesecke
2a9fbc87a5 Bug 1600906 - Make use of FlippedOnce in FullIndexMetadata. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55675

Differential Revision: https://phabricator.services.mozilla.com/D55676
2019-12-04 14:30:55 +00:00
Simon Giesecke
2df93052b8 Bug 1600906 - Make use of FlippedOnce in Database. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55674

Differential Revision: https://phabricator.services.mozilla.com/D55675
2019-12-04 14:31:13 +00:00
Dorel Luca
67889e1013 Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE 2019-12-04 17:32:27 +02:00
Gabriele Svelto
dc6fa2e86c Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442
2019-12-04 15:01:19 +00:00
Simon Giesecke
a524fb5de4 Bug 1600906 - Make use of FlippedOnce in VersionChangeTransaction. r=dom-workers-and-storage-reviewers,ytausky
Depends on D55081

Differential Revision: https://phabricator.services.mozilla.com/D55674
2019-12-03 18:14:37 +00:00
Simon Giesecke
61eff27cf2 Bug 1596395 - Avoid copying of tokenizer token sub-strings. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D53013
2019-11-29 10:40:55 +00:00
Simon Giesecke
af479f820c Bug 1597191 - Do not fail cursor operation when processing preloaded entries. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53803
2019-11-27 19:06:45 +00:00
Simon Giesecke
aed42342bd Bug 1597191 - Remove duplication between OpenOp::Do*DatabaseWork functions. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53802
2019-11-27 16:31:32 +00:00
Simon Giesecke
c927521972 Bug 1597191 - Remove cursor positions from Cursor state. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53801
2019-11-27 18:51:59 +00:00
Simon Giesecke
4db459a783 Bug 1597191 - Added const where easily possible. r=dom-workers-and-storage-reviewers,perry
Differential Revision: https://phabricator.services.mozilla.com/D53800
2019-11-27 16:31:31 +00:00
Simon Giesecke
2d373400d8 Bug 1597191 - Pull up SendSuccessResult to CursorOpBase to remove code duplication. r=dom-workers-and-storage-reviewers,edenchuang,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53799
2019-11-27 19:08:49 +00:00
Simon Giesecke
c6b65ec8fd Bug 1597191 - Removed code duplication between response type cases. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D53798
2019-11-27 19:06:28 +00:00