Commit Graph

512 Commits

Author SHA1 Message Date
Lebar
eab036787c Bug 1741603 - Fix Show in Folder context menu item in app menu to open in sidebar. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D139230
2022-03-15 17:35:22 +00:00
Evgenia Kotovich
7c2a87cee4 Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D134395
2022-01-28 07:46:06 +00:00
Evgenia Kotovich
c597e5d1d5 Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D133813
2022-01-28 07:46:06 +00:00
Lebar
3d36116e67 Bug 1747200 - Added call to ensureRowIsVisible to make sure that selected node is in view after showInFolder. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D135672
2022-01-27 14:53:43 +00:00
Mark Banner
2649c5fb78 Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop
Differential Revision: https://phabricator.services.mozilla.com/D136368
2022-01-20 14:15:34 +00:00
Cristian Tuns
a6563e6738 Backed out 2 changesets (bug 1725487) for causing mochitest failures on browser_toolbar_drop_bookmarklet.js CLOSED TREE
Backed out changeset 1564124c0309 (bug 1725487)
Backed out changeset ae5ab5c447c3 (bug 1725487)
2022-01-13 07:23:29 -05:00
Evgenia Kotovich
6ef5f7142e Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D134395
2022-01-13 11:05:59 +00:00
Evgenia Kotovich
ce5749f98a Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D133813
2022-01-13 11:05:59 +00:00
Paul Zuehlcke
4134ccfa27 Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128089
2021-10-15 15:07:06 +00:00
Lebar
86d6cd4771 Bug 469441 - Added 'Show in Folder' context menu item for bookmark library searches and bookmarks sidebar. r=Standard8,flod
Differential Revision: https://phabricator.services.mozilla.com/D121040
2021-10-04 21:07:09 +00:00
Mark Banner
f321dfd6b1 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 12:09:49 +00:00
Noemi Erli
20dee875a7 Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
2021-09-10 13:14:12 +03:00
Mark Banner
6a5ffbcc55 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 09:38:42 +00:00
Stefan Zabka
a51b55b8f2 Bug 1711759 - Ask user for confirmation in Forget about this site. r=pbz,Standard8,flod
Differential Revision: https://phabricator.services.mozilla.com/D120363
2021-09-02 11:55:52 +00:00
Gijs Kruitbosch
e93d5b7bcc Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D124045
2021-09-01 16:08:50 +00:00
Nicholas Fason
f0a8082876 Bug 1702708 - Hyphenate places context menu attributes r=mak
Differential Revision: https://phabricator.services.mozilla.com/D121583
2021-08-03 14:03:03 +00:00
Paul Zuehlcke
8c971e0b12 Bug 1705028 - Update places forget-this-site to clear storage by base domain. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D113495
2021-05-26 13:49:36 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D115233
2021-05-18 16:27:44 +00:00
Bernard Igiri
8f33752c03 Bug 1705105 - Update bookmarks folder context menu r=fluent-reviewers,mak,flod
Changed the text on the edit and delete folder buttons and moved position of the Sort By Name menu item.

Differential Revision: https://phabricator.services.mozilla.com/D112110
2021-04-16 17:27:00 +00:00
Marco Bonardo
4e88c4821b Bug 1700929 - Restore Open All in tabs in some Places context menus. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110478
2021-04-02 07:38:51 +00:00
Marco Bonardo
184c593112 Bug 1700929 - Restore Places context menu Delete on mixed selection. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110477
2021-04-02 07:38:51 +00:00
Marco Bonardo
257ee6452c Bug 1700929 - Introduce an 'hideifsingleclickopens' attribute to show/hide Open in the Places context menu. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110476
2021-04-02 07:38:51 +00:00
Marco Bonardo
141a43777d Bug 1700929 - Do some renames and cleanup comments a bit in bookmarks context menu code. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110475
2021-04-02 07:38:50 +00:00
Micah Tigley
1d1363d4d7 Bug 1693139 - Open bookmarks dialogs with in-window modal, plus some styling to input fields. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D108870
2021-03-30 00:56:35 +00:00
Erica Wright
a63671ee72 Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-03-02 15:34:56 +00:00
Butkovits Atila
db896883ba Backed out changeset b3df95f06470 (bug 1692668) for causing failure at browser_bookmark_change_location.js. CLOSED TREE 2021-02-26 23:07:49 +02:00
Erica Wright
b867fe56b5 Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-02-26 18:38:07 +00:00
Tom Schuster
f7d112c734 Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D103555
2021-02-01 12:05:12 +00:00
Jared Wein
84ba59a4bb Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 23:00:47 +00:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Jared Wein
76c6dfa789 Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 19:09:18 +00:00
Sonia Singla
30a78c48fc Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D85021
2020-07-29 11:19:09 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Marco Bonardo
5170074e9a Bug 1627361 - Stop examining the clipboard data when updating Places commands. r=Standard8
We used to read the contents of the clipboard to tell if paste was enabled,
that unfortunately means updating commands was extremely slow for large
clipboard data.
After this change we only check the data flavors. This means paste will be
enabled more often, even for unsupported strings, but commands updating will
be much faster. Places updates commands often, so this is quite useful.

Differential Revision: https://phabricator.services.mozilla.com/D75202
2020-05-15 14:20:58 +00:00
Ian Moody
0a0d8bf126 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Mark Banner
2020ed2c7e Bug 1622243 - Implement the bookmark pages option in the library window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D68776
2020-04-07 12:56:19 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Gijs Kruitbosch
c3d6e37670 Bug 1567414 - ensure we display the 'Open' context menu entry on bookmarks when they load in new tabs by default, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D39025
2019-07-23 15:24:38 +00:00
Hamzah
030732a1dc Bug 1559956 - UX: Bookmark bar context menu item "Open in New Tab" is not consistent with anchor link context menu. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D37197
2019-07-15 18:38:01 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Mihir
4e3e42eba6 Bug 543314 - Allow bookmarks to be moved (as well as copied) from a bookmarks search. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D32629
2019-06-11 20:33:51 +00:00
Boris Zbarsky
bc701e00cb Bug 1557847. Stop using [array] in nsIClipboard. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D34243
2019-06-09 01:06:39 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Toby Ward
207badbc32 Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983
2018-12-10 17:04:18 +00:00
Csoregi Natalia
3043e2663f Backed out changeset 81a6b32f2a8b (bug 1435562) for causing Bug 1512180. a=backout 2018-12-06 14:20:20 +02:00
Toby Ward
608941107e Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983
2018-12-04 19:20:59 +00:00
Tom Schuster
8b2f90e93c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201
2018-11-20 16:59:56 +00:00
Csoregi Natalia
5ada471f97 Backed out 6 changesets (bug 1493292) for bustage on /nsTransferable.cpp. CLOSED TREE
Backed out changeset f198bf91320b (bug 1493292)
Backed out changeset 6487aa307123 (bug 1493292)
Backed out changeset f2cabd69c568 (bug 1493292)
Backed out changeset 71430fceb4a3 (bug 1493292)
Backed out changeset 3a9b6d65d8c7 (bug 1493292)
Backed out changeset 55769869037c (bug 1493292)
2018-11-20 17:13:18 +02:00
Tom Schuster
e294f7e628 Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201
2018-11-20 14:47:02 +00:00