Commit Graph

96 Commits

Author SHA1 Message Date
Sebastian Kaspari
ce323400dd [components] Run ktlintFormat to fix new ktlint errors. 2021-07-28 12:03:23 +00:00
Mozilla L10n Automation Bot
2f28b87315 [components] Import l10n. 2021-06-17 00:20:36 +00:00
Mozilla L10n Automation Bot
e50f0e5f9f [components] Import l10n. 2021-06-13 00:19:56 +00:00
Mozilla L10n Automation Bot
1234e2eecd [components] Import l10n. 2021-06-12 00:19:05 +00:00
Mozilla L10n Automation Bot
cc491ecdc9 [components] Import l10n. 2021-05-12 00:20:05 +00:00
Mozilla L10n Automation Bot
4dafef9f97 [components] Import l10n. 2021-05-04 21:51:53 +00:00
Mozilla L10n Automation Bot
1d43fc6ed4 [components] Import l10n. 2021-04-30 00:20:10 +00:00
Mozilla L10n Automation Bot
374642dc42 [components] Import l10n. 2021-04-18 00:21:12 +00:00
Mozilla L10n Automation Bot
4e8116a2e9 [components] Import l10n. 2021-04-16 00:17:41 +00:00
Mozilla L10n Automation Bot
0026a455a2 [components] Import l10n. 2021-04-15 00:25:01 +00:00
Mozilla L10n Automation Bot
8fc62d6ac9 [components] Import l10n. 2021-04-11 00:20:31 +00:00
Mozilla L10n Automation Bot
6e18ad2b07 [components] Import l10n. 2021-04-05 00:22:33 +00:00
Christian Sadilek
c9d791c53b [components] Adjust detekt TooManyFunctions threshold 2021-03-18 15:25:40 +00:00
Mozilla L10n Automation Bot
fbe06980e1 [components] Import l10n. 2021-03-14 00:22:50 +00:00
Mozilla L10n Automation Bot
98e4f66268 [components] Import l10n. 2021-03-01 00:16:06 +00:00
Mozilla L10n Automation Bot
3e254ac3e9 [components] Import l10n. 2021-02-22 00:18:17 +00:00
Michael Comella
89c283dac1 [components] For https://github.com/mozilla-mobile/android-components/issues/9638: name threads in Executors.new* calls.
I omitted:
- Store, as its a super-class
- Fennec migration code
2021-02-10 00:35:59 +00:00
Mozilla L10n Automation Bot
cb18e55aca [components] Import l10n. 2021-01-29 00:18:39 +00:00
Mozilla L10n Automation Bot
a074547dd9 [components] Import l10n. 2020-12-29 00:20:41 +00:00
Mozilla L10n Automation Bot
e6368dc807 [components] Import l10n. 2020-12-24 00:20:09 +00:00
mcarare
bd2dac1bf7 [components] For https://github.com/mozilla-mobile/android-components/issues/9098: Allow rotation of edit suggestion arrow button. 2020-12-15 09:40:52 +00:00
Mozilla L10n Automation Bot
029a67036a [components] Import l10n. 2020-11-03 00:25:13 +00:00
Mozilla L10n Automation Bot
665146892b [components] Import l10n. 2020-10-31 00:21:41 +00:00
Mozilla L10n Automation Bot
35c8de4ab5 [components] Import l10n. 2020-10-05 00:29:08 +00:00
Mozilla L10n Automation Bot
51662a3fe3 [components] Import l10n. 2020-10-04 00:25:33 +00:00
Mozilla L10n Automation Bot
b427b25d68 [components] Import l10n. 2020-09-25 00:22:10 +00:00
MozLando
f451c7b0a6 [components] Merge https://github.com/mozilla-mobile/android-components/pull/8176
8176: For https://github.com/mozilla-mobile/android-components/issues/8175: Allow SuggestionProviders to specify a edit suggestion r=pocmo a=miDeb

The edit suggestion arrow will only be shown if the suggestion is not null or empty. Tapping it autocompletes the suggestion, which can now be specified by the `SuggestionProvider`.



Co-authored-by: Michael Debertol <michael.debertol@gmail.com>
2020-09-10 17:36:57 +00:00
Mozilla L10n Automation Bot
ad197c4761 [components] Import l10n. 2020-09-10 13:02:00 +02:00
Mozilla L10n Automation Bot
f67c8d27e1 [components] Import l10n. 2020-09-09 00:05:30 +00:00
Mozilla L10n Automation Bot
84a67bde4a [components] Import l10n. 2020-08-28 00:06:37 +00:00
Mozilla L10n Automation Bot
29070805dd [components] Import l10n. 2020-08-27 00:08:31 +00:00
Mozilla L10n Automation Bot
c325d0c9e4 [components] Import l10n. 2020-08-25 00:01:46 +00:00
Michael Debertol
cf7af4cc8e [components] For https://github.com/mozilla-mobile/android-components/issues/8175: Allow SuggestionProviders to specify a edit suggestion 2020-08-20 20:04:09 +02:00
Mozilla L10n Automation Bot
d494cb50c2 [components] Import l10n. 2020-08-20 00:09:22 +00:00
Mozilla L10n Automation Bot
bff26a47e2 [components] Import l10n. 2020-08-13 00:09:23 +00:00
Mozilla L10n Automation Bot
977403cc2b [components] Import l10n. 2020-08-12 00:01:49 +00:00
Mozilla L10n Automation Bot
40f12f14cd [components] Import l10n. 2020-08-11 00:12:54 +00:00
Mozilla L10n Automation Bot
6b1375f5de [components] Import l10n. 2020-08-10 00:04:27 +00:00
Mozilla L10n Automation Bot
6bd29f3d8a [components] Import l10n. 2020-08-09 00:14:57 +00:00
Mozilla L10n Automation Bot
f8ef7b6121 [components] Import l10n. 2020-08-08 00:02:51 +00:00
Mozilla L10n Automation Bot
f798f76e02 [components] Import l10n. 2020-08-07 00:15:41 +00:00
Kirill Rakhman
5e13b69faf [components] Closes https://github.com/mozilla-mobile/android-components/issues/6813 Awesomebar: Add ability to accept suggestion from search completion without submitting 2020-07-31 18:29:40 +02:00
MozLando
1ed2c50eb2 [components] Merge https://github.com/mozilla-mobile/android-components/pull/7738 https://github.com/mozilla-mobile/android-components/pull/7798 (part 1)
7738: For https://github.com/mozilla-mobile/fenix/issues/12632: Align search suggestion and search text r=NotWoods a=hakkikaancaliskan

This is just a small pr for aligning search text and suggestion text, also aligns icons.

![Screenshot_20200716-145421_Firefox_Preview](https://user-images.githubusercontent.com/17825767/87668283-8170ab80-c774-11ea-898e-3edfbad0cd87.png)

<!-- Text above this line will be added to the commit once "bors" merges this PR -->

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


7798: Add tests for Trimming whitespace from email & call context share r=sblatz a=Amejia481

@sblatz as I missed the tests on my initial review, I'm adding them as part of this pr, sorry about that.



Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-07-21 16:00:14 +00:00
Hakkı Kaan Çalışkan
f855c377df [components] For https://github.com/mozilla-mobile/android-components/issues/7803: Visually indicate different types of suggestions in the search screen 2020-07-21 18:43:03 +03:00
Hakkı Kaan Çalışkan
336c9ce917 [components] For https://github.com/mozilla-mobile/fenix/issues/12632: Align search suggestion and search text 2020-07-16 14:55:45 +03:00
Grisha Kruglov
013a08c6cf [components] Closes https://github.com/mozilla-mobile/android-components/issues/7016: Emit awesomebar provider metrics in ms 2020-05-18 17:10:08 -07:00
Christian Sadilek
0095b9eed6 [components] Closes https://github.com/mozilla-mobile/android-components/issues/6985: Make sure suggestions with long title/desc don't freeze UI 2020-05-15 11:47:45 -04:00
Grisha Kruglov
5179fdefa0 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4992: Emit provider duration facts from BrowserAwesomeBar
Some things to consider and trade-offs:

When recording durations of various providers into a glean metric, we have a bit of a hurdle.
One approach would be to encapsulate all of the awesomebar-related perf telemetry entirely within the
awesomebar a-c component. But, set of providers isn't entirely known to us at the a-c level.
We know what providers we have defined, but we don't know what providers applications will provide themselves.
Also, glean doesn't have a metric of type (string->timespan), which would allow us to work-around this.
So, we can't define ping/metrics in the a-c component. This means that they need to be defined elsewhere, while
the measurement happens within the component. An established pattern for that in the codebase is emitting "facts",
which is what this patch does.

We delegate to the consuming application to then actually do something with these facts - e.g. map providers
to concrete glean metric definitions.

Another consideration is if we should try to group timings related to a single query. That's hard to do reliably,
and will introduce additional complexity into what's otherwise a super simple setup. Source of that complexity
is that we actively try to cancel query jobs as user is typing; our providers could take an arbitrary time to resolve,
and so grouping becomes difficult. However, we care about improving how long each individual provider takes,
since that's a good proxy for "how responsive is this UI?". Simply recording each individual timing we see
should be enough for that.
2020-05-12 15:36:21 -07:00
Jonathan Almeida
b86fa6dfb5 [components] Close https://github.com/mozilla-mobile/android-components/issues/6601: Update targetSdkVersion to 29 2020-04-28 03:16:54 -04:00
levimatheri
181eaea947 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4632. Add contains function for suggestion providers 2020-03-24 16:29:22 -04:00