Commit Graph

547 Commits

Author SHA1 Message Date
Helena
651b2cfe37 Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 21:55:20 +00:00
Alexandru Marc
5a4a4de260 Backed out 2 changesets (bug 1448423) for causing bc failures @ browser_startup.js
Backed out changeset 93e49e407bc1 (bug 1448423)
Backed out changeset ac0d0fe55391 (bug 1448423)
2025-01-15 23:14:01 +02:00
Fatih
525b98402b Bug 1448423: Skip earlyBlankFirstPaint if RoundWindowSize RFP target is enabled. r=tjr,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D224240
2025-01-15 18:17:54 +00:00
Butkovits Atila
7d5fe6b5ca Backed out changeset 9e414abada40 (bug 1915672) for causing failures at browser_glean_metrics_exist.js. 2025-01-15 16:03:47 +02:00
Helena
48a5fff8dd Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 12:27:33 +00:00
Sammy Khamis
b095b5ae27 Bug 1901666: Move Account-related code into its own BrowserGlue r=markh,Gijs,sync-reviewers,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D233316
2025-01-14 18:56:55 +00:00
Fred Chasen
0f35a787ae Bug 1921576 - Fix close button for Review Checker sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,kpatenio
* Sends a `CloseShoppingSidebar` message on clicking the shopping header close button to allow the `ReviewCheckerParent` to close the sidebar.

Differential Revision: https://phabricator.services.mozilla.com/D228281
2024-12-18 21:49:02 +00:00
Meg Viar
5567720814 Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable r=firefox-desktop-core-reviewers ,mossop,pdahiya
This patch updates the logic that prevents about:welcome from showing when the Nimbus `aboutWelcome` `showModal` variable is set to true. If separate screens for the modal are provided, it can now be shown on top of the default onboarding flow in about:welcome.

A `requireAction` variable that sets the modal to be a window modal requiring action (other than pressing ESC) to dismiss is also added to the `aboutWelcome` Nimbus feature

Differential Revision: https://phabricator.services.mozilla.com/D230185
2024-12-18 19:04:43 +00:00
Fatih
1c7d8d2aa1 Bug 1913421: Submit ping with at least 24 hour delay since last submission or on pref changes. r=mossop,geckoview-reviewers,tjr,tthibaud
We submit the ping with at least 24 hours delay in between to not spam with pings. When we receive a new captcha event,
we'll check the last submission time and submit the ping if it's been more than 24 hours since the last submission.

Differential Revision: https://phabricator.services.mozilla.com/D226023
2024-12-18 16:17:05 +00:00
Fred Chasen
b173af01b4 Bug 1921570 - Part 2: Render AboutWelcome in the new sidebar. r=shopping-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,kpatenio,pdahiya
- Update `AboutWelcomeShopping` actors to include the sidebar review checker message manager group.
- Update `AWSetProductURL` to handle when a URL is not passed, which will happen on non-product pages.

Differential Revision: https://phabricator.services.mozilla.com/D223431
2024-12-17 20:51:47 +00:00
Stanca Serban
48bbabbc35 Backed out 17 changesets (bug 1913421) for causing mochitests-plain failures in test_arkose_labs.html. CLOSED TREE
Backed out changeset 7eda60115372 (bug 1913421)
Backed out changeset 5f1bb8cea1d5 (bug 1913421)
Backed out changeset 22084dc8fbb0 (bug 1913421)
Backed out changeset d5f36da0c01f (bug 1913421)
Backed out changeset 2fbc4c09d4f0 (bug 1913421)
Backed out changeset 8ca6f7399e31 (bug 1913421)
Backed out changeset cc2acc1bd560 (bug 1913421)
Backed out changeset 335767ea0138 (bug 1913421)
Backed out changeset ba58924faee8 (bug 1913421)
Backed out changeset b36e090e8715 (bug 1913421)
Backed out changeset f6850c74997a (bug 1913421)
Backed out changeset 7f54b1a2c565 (bug 1913421)
Backed out changeset 2459730a7e10 (bug 1913421)
Backed out changeset afd89f58cab0 (bug 1913421)
Backed out changeset cd2258c3f8e3 (bug 1913421)
Backed out changeset 51f94cd7e9e5 (bug 1913421)
Backed out changeset 849674119c65 (bug 1913421)
2024-12-17 17:50:34 +02:00
Fatih
c2c06356a7 Bug 1913421: Submit ping with at least 24 hour delay since last submission or on pref changes. r=mossop,geckoview-reviewers,tjr,tthibaud
We submit the ping with at least 24 hours delay in between to not spam with pings. When we receive a new captcha event,
we'll check the last submission time and submit the ping if it's been more than 24 hours since the last submission.

Differential Revision: https://phabricator.services.mozilla.com/D226023
2024-12-17 13:09:09 +00:00
Fred Chasen
2a40aed615 Bug 1916547 - Part 1: Render Review Checker in the new sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,sclements,mossop,kpatenio
- Adds a remote content browser to contain `about:shoppingsidebar` in `review-checker.xhtml` and update the Review Checker sidebar to use that wrapper document.
- Adds ReviewChecker actors for the sidebar Review Checker panel.
- ReviewCheckerParent is a simplified version of the ShoppingSidebarParent as it does not need to handle the state of the sidebar opening or closing.
- ReviewCheckerChild is just extends ShoppingSidebarChild for now, though it will need to be separate in the future.
- Adds a browser.shopping.experience2023.shoppingSidebar boolean pref to disable ShoppingSidebar actors when they are not needed.
- Fixes `AbortError` error handling when the outer sidebar browser is removed.

Note that any auto-opening or closing behavior will need to be added afterwards, as these actors are not around to check product urls when the sidebar is closed.

Differential Revision: https://phabricator.services.mozilla.com/D222840
2024-12-12 01:24:20 +00:00
Chris H-C
4eb6d15f40 Bug 1936036 - Replace flag histogram MASTER_PASSWORD_ENABLED r=mtigley,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D231559
2024-12-10 20:02:52 +00:00
Dave Townsend
0dfe4b8340 Bug 1935582: Ensure that remote messages that impact profiles come from the correct process type. r=dveditz,firefox-desktop-core-reviewers ,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D231358
2024-12-09 09:28:00 +00:00
hanna.alemu
50ffb1e5e7 Bug 1931926 - Store Timestamp of Default Modal Prompt last seen r=firefox-desktop-core-reviewers ,omc-reviewers,mviar,mossop
Differential Revision: https://phabricator.services.mozilla.com/D229967
2024-12-02 14:59:11 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Emilio Cobos Álvarez
feebe3d11d Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 12:12:50 +00:00
Emilio Cobos Álvarez
dcf6dc5521 Bug 1930292 - Stop setting non-zero chromemargin values. r=win-reviewers,handyman,firefox-desktop-core-reviewers ,dao
These only do something on Windows, and after windows 7 they are not
useful at all.

If this has no fallout I plan to simplify the code further in a
follow-up (we can basically make this a boolean attribute again or so).

Differential Revision: https://phabricator.services.mozilla.com/D228528
2024-11-28 12:12:49 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
67678746e6 Bug 1930292 - Turn chromemargin into a boolean attribute. r=win-reviewers,desktop-theme-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,dao,mconley,rkraesig
There are probably other simplifications that can be done after this on the
windows side of things, but I tried to keep this minimal.

Differential Revision: https://phabricator.services.mozilla.com/D229765
2024-11-28 03:26:50 +00:00
Emilio Cobos Álvarez
e974845dc9 Bug 1930292 - Stop setting non-zero chromemargin values. r=win-reviewers,handyman,firefox-desktop-core-reviewers ,dao
These only do something on Windows, and after windows 7 they are not
useful at all.

If this has no fallout I plan to simplify the code further in a
follow-up (we can basically make this a boolean attribute again or so).

Differential Revision: https://phabricator.services.mozilla.com/D228528
2024-11-28 03:26:49 +00:00
Sandor Molnar
7d50bb6e2e Backed out changeset c4369fa6e979 (bug 1921471) for causing bc failures @ browser_sidebar_remote.js & browser_unavailable_product.js CLOSED TREE 2024-11-26 00:30:14 +02:00
jabram
ad7b1e649c Bug 1451132 - Provide option to close current tab on quit r=fluent-reviewers,reusable-components-reviewers,mconley,settings-reviewers,mossop,accessibility-frontend-reviewers,mstriemer,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D223374
2024-11-25 21:03:45 +00:00
Fred Chasen
5c68a50632 Bug 1921471 - Use content process to display sidebar contents when appropriate. r=places-reviewers,sidebar-reviewers,mossop,firefox-desktop-core-reviewers ,jsudiaman
* Adds a `remoteType` attribute to the config when registering a sidebar to opt-in to using a remote content process when displaying that sidebar panel.
* Moves loading URLs into a `SidebarController._loadUrl` method, which can be passed a remoteType if the sidebar contents should be displayed in a remote content process. If needed it will replace the sidebar browser element with a remote or non-remote browser to match the remoteType passed.
* Adds browser load listeners methods, a `SidebarController._hasLoaded` promise for non-remote loading and a `SidebarController._hasProgressStopped` promise if the browser is remote.
* Adds a setter for `SidebarController.browser`.
* Adds a `shopping-sidebar` message manager group to avoid actor conflict.

Differential Revision: https://phabricator.services.mozilla.com/D223961
2024-11-25 18:22:14 +00:00
Adi
a1f2bdd9ab Backed out changeset 04f7f20bf82e (bug 1921471) for causing bc failures @browser_syncedtabs_sidebar.js. 2024-11-21 21:25:07 +02:00
Fred Chasen
8dcd4eee5d Bug 1921471 - Use content process to display sidebar contents when appropriate. r=places-reviewers,sidebar-reviewers,mossop,firefox-desktop-core-reviewers ,jsudiaman
* Adds a `remoteType` attribute to the config when registering a sidebar to opt-in to using a remote content process when displaying that sidebar panel.
* Moves loading URLs into a `SidebarController._loadUrl` method, which can be passed a remoteType if the sidebar contents should be displayed in a remote content process. If needed it will replace the sidebar browser element with a remote or non-remote browser to match the remoteType passed.
* Adds browser load listeners methods, a `SidebarController._hasLoaded` promise for non-remote loading and a `SidebarController._hasProgressStopped` promise if the browser is remote.
* Adds a setter for `SidebarController.browser`.
* Adds a `shopping-sidebar` message manager group to avoid actor conflict.

Differential Revision: https://phabricator.services.mozilla.com/D223961
2024-11-21 17:36:56 +00:00
hanna alemu
f2b065e5bb Bug 1825381 - Create experimental set to default prompt-style spotlight and enable showing via Nimbus r=mviar,omc-reviewers,firefox-desktop-core-reviewers ,mossop,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D225699
2024-11-20 18:04:46 +00:00
Jan-Erik Rediger
fb37eb33a4 Bug 1926829 - Handle usage profile ID in ClientID.sys.mjs r=chutten,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D226766
2024-11-06 13:30:07 +00:00
Dave Townsend
4ea798a326 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-05 12:59:04 +00:00
Stanca Serban
7bfaea64ba Backed out changeset 101063793364 (bug 1894239) for causing mochitests failures in browser_sentence_case_strings.js. CLOSED TREE 2024-11-04 20:39:11 +02:00
Dave Townsend
09c0a011d8 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 16:20:41 +00:00
Goloman Adrian
43172c6f10 Backed out changeset 4aeabb1fca7f (bug 1894239) for causing bc failures @browser_parsable_css.js. CLOSED TREE 2024-11-04 17:11:24 +02:00
Dave Townsend
658587a8e9 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 13:19:59 +00:00
Goloman Adrian
a536e48199 Backed out changeset 07b4dffd9109 (bug 1894239) for causing bc failures @browser_all_files_referenced.js. CLOSED TREE 2024-11-04 14:50:12 +02:00
Dave Townsend
d23817862a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 11:15:32 +00:00
Goloman Adrian
8d0a2fbb16 Backed out changeset 6539a7d0d9ca (bug 1894239) for causing xpcshell failures at test_selectable_profile_launch.js. CLOSED TREE 2024-11-01 20:43:36 +02:00
Dave Townsend
0085ce80d2 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 17:08:27 +00:00
Cristian Tuns
8f3ca1449e Backed out changeset 7df0f0dd73a1 (bug 1894239) for causing bc failures in /browser_appmenu.js CLOSED TREE 2024-11-01 12:48:39 -04:00
Dave Townsend
52f716131a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 14:38:45 +00:00
Dave Townsend
6928b89ed0 Bug 1893692: Notify concurrent profiles via remoting service. r=jhirsch,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227026
2024-11-01 10:11:24 +00:00
Nicholas Rishel
51fef936bb Bug 1926151 - Pre: Rename Matching to Pinnable to better convey usage of hasPinnableShortcut. r=bhearsum,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227133
2024-10-31 19:53:55 +00:00
Rebecca King
a102a0e075 Bug 1806159 - Create tests for default bookmarks - r=kpatenio,places-reviewers,lina,firefox-desktop-core-reviewers ,mak
Differential Revision: https://phabricator.services.mozilla.com/D225451
2024-10-30 19:34:16 +00:00
Dave Townsend
2b69765d39 Bug 1927441: Errors from async tasks in _scheduleStartupIdleTasks are not logged. r=Gijs,firefox-desktop-core-reviewers ,florian
Differential Revision: https://phabricator.services.mozilla.com/D227032
2024-10-28 14:04:08 +00:00
Florian Quèze
0c249544f1 Bug 1923028 - Migrate scalars to use Glean APIs for security.* in browser/components/BrowserGlue.sys.mjs, r=chutten,firefox-desktop-core-reviewers .
Differential Revision: https://phabricator.services.mozilla.com/D226687
2024-10-24 20:54:14 +00:00
Niklas Baumgardner
86f1b2dbc2 Bug 1886003 - Create about:newprofile page. r=jhirsch,mossop,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D225541
2024-10-24 20:37:14 +00:00
Eric Chen
5960f308ce Bug 1924001 - removing deprecated telemetry recording API r=Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226373
2024-10-21 21:17:32 +00:00
Niklas Baumgardner
2922c6ceb2 Bug 1918524 - Style about:deleteprofile. r=jhirsch,desktop-theme-reviewers,firefox-desktop-core-reviewers ,hjones
Differential Revision: https://phabricator.services.mozilla.com/D226017
2024-10-21 16:25:11 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Florian Quèze
67d22ade73 Bug 1923028 - Migrate scalars to use Glean APIs for os.environment.*, r=chutten,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D225985
2024-10-19 07:54:51 +00:00