Commit Graph

249 Commits

Author SHA1 Message Date
Hanna Jones
e98c8e4379 Bug 1838298 - Custom Stylelint plugin to prevent color tokens from being used directly r=Standard8,frontend-codestyle-reviewers,desktop-theme-reviewers,dao
This patch lays the foundation for a Mozilla-specific Stylelint plugin that we can continue to expand on with new rules as needed. For the first rule I've implemented a simple check to ensure our color tokens are being used as intended.

Differential Revision: https://phabricator.services.mozilla.com/D223204
2024-09-27 14:58:41 +00:00
Mark Banner
1b9a4bcf9e Bug 1920970 - Move ESLint node_modules bundles away from tooltool and into the toolchain. r=jcristau
Differential Revision: https://phabricator.services.mozilla.com/D223647
2024-09-26 10:55:31 +00:00
Julian Descottes
f62a855e09 Bug 1917003 - [eslint] Add linter rule to ban await await r=Standard8,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221187
2024-09-16 09:13:30 +00:00
Bryan Olsson
9af95c3720 Bug 1915749 - Update Localization documentation post GitHub transition, r=flod
Differential Revision: https://phabricator.services.mozilla.com/D220638
2024-09-04 05:28:00 +00:00
Mark Banner
66e8ca14df Bug 1907841 - Change ESLint's .eslintignore to be an imported module. r=frontend-codestyle-reviewers,zeid,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D216540
2024-07-16 12:53:09 +00:00
Mark Banner
57b142b0fe Bug 1907860 - Clean up remaining parts of format-source. r=sheehan
Differential Revision: https://phabricator.services.mozilla.com/D216546
2024-07-15 14:00:10 +00:00
Andrew McCreight
7e5cd3bd2b Bug 1902344 - Remove outdated data structure references in "Using C++ in Mozilla code" and elsewhere. r=xpcom-reviewers,nika DONTBUILD
nsAutoTArray was renamed to AutoTArray.

nsDataHashtable and nsJSThingHashtable don't exist any more.

nsTHashMap and nsTHashSet now exist.

nsDeque is properly typed now.

Pair is now CompactPair.

Differential Revision: https://phabricator.services.mozilla.com/D213624
2024-06-13 22:41:51 +00:00
Mark Banner
94a2472342 Bug 1897898 - Separate out ESLint rule rollouts configurations to a separate module. r=frontend-codestyle-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D210992
2024-05-21 13:38:01 +00:00
Botond Ballo
fb1065c0c3 Bug 1858446 - Document that classes representing HTML elements should live in the mozilla::dom namespace. r=peterv DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D210576
2024-05-17 23:23:44 +00:00
Andrew Halberstadt
a680bcd3e1 Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 20:39:09 +00:00
Stanca Serban
3dbb534055 Backed out 2 changesets (bug 1868440) for gecko decision task broken. CLOSED TREE
Backed out changeset 4b22948d849a (bug 1868440)
Backed out changeset 837bdcb3694a (bug 1868440)
2024-04-18 21:25:43 +03:00
Andrew Halberstadt
ef4f1e168b Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
2024-04-18 17:50:50 +00:00
Greg Mierzwinski
2181bf39d4 Bug 1890318 - Update perfdocs linter documentation. r=perftest-reviewers,kshampur DONTBUILD
This patch updates the perfdocs linter documentation to contain the new config schema, and information about how to add documentation for the metrics.

Differential Revision: https://phabricator.services.mozilla.com/D206953
2024-04-17 12:34:31 +00:00
Gijs Kruitbosch
94e799935c Bug 1880899 - add lint rule that prevents adding more browser.js globals, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D202804
2024-03-16 15:14:07 +00:00
Gijs Kruitbosch
2b6df36c8c Bug 1856535 - allow linters to work by excluding extensions instead of including them, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D202635
2024-03-13 09:40:27 +00:00
Mark Banner
0a0c3c6972 Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204180
2024-03-11 15:26:27 +00:00
Tooru Fujisawa
69f8a594a2 Bug 1879254 - Verify .gitignore and .hgignore consistency. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D201072
2024-02-22 04:48:27 +00:00
Mark Banner
e012a72f1c Bug 1878848 - Remove ESLint support for .jsm.js extensions. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D200771
2024-02-06 13:32:52 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
Gregory Pappas
8e0ae3e9ae Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Gijs Kruitbosch
9547bd9ce0 Bug 1780071 - add eslint rule for misuse of assignments or conditions inside ok(), r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D198593
2024-01-17 15:04:34 +00:00
Luca Greco
af88486ae1 Bug 1868144 - Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D195434
2024-01-17 14:07:53 +00:00
Cristian Tuns
fc22950f3d Backed out 2 changesets (bug 1868144, bug 1874487) for causing mozlint-condprof-addons failures CLOSED TREE
Backed out changeset 7a65679aabcf (bug 1874487)
Backed out changeset cd38cf3f7807 (bug 1868144)
2024-01-16 16:34:11 -05:00
Luca Greco
47d4a95f67 Bug 1868144 - Introduce a new condprof-addons linter and condprof-addons-verify taskcluster task. r=sparky,jmaher,linter-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D195434
2024-01-16 21:11:33 +00:00
Mark Banner
220a28fd3e Bug 1872674 - Add an ESLint rule to reject new uses of Console.sys.mjs/Log.sys.mjs. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D197504
2024-01-16 13:37:07 +00:00
Joel Maher
619c45cf54 Bug 1859911 - migrate raptor .ini to .toml. r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D197392
2024-01-09 20:43:41 +00:00
ogiorgis
d916e7edbe Bug 1840493 - doc/rst: fix some languages declaration r=firefox-source-docs-reviewers,webdriver-reviewers,necko-reviewers,geckoview-reviewers,devtools-reviewers,profiler-reviewers,championshuttler,whimboo,nchevobbe,julienw,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D196268
2023-12-13 18:32:20 +00:00
ogiorgis
6b2b3b2e24 Bug 1749473 - fix internal links r=sylvestre,firefox-source-docs-reviewers DONTBUILD
Depends on D196076

Differential Revision: https://phabricator.services.mozilla.com/D196077
2023-12-11 17:42:35 +00:00
ogiorgis
00d806ae5e Bug 1749473 - fix quotes in js code-block r=sylvestre,firefox-source-docs-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D196076
2023-12-11 17:42:34 +00:00
ogiorgis
ba7cd11193 Bug 1749473 - fix typos r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D196011
2023-12-11 10:09:09 +00:00
Mike Hommey
6aa78a25db Bug 1867459 - Replace CPU_ARCH with TARGET_CPU. r=firefox-build-system-reviewers,sergesanspaille
Differential Revision: https://phabricator.services.mozilla.com/D195157
2023-12-08 10:43:59 +00:00
Sylvestre Ledru
2cc79f510e Bug 1519636 - Remove nbsp in the doc r=firefox-source-docs-reviewers,geckoview-reviewers,ahal,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D194782
2023-12-03 11:01:53 +00:00
Mark Banner
8d310687e0 Bug 1858148 - Change ESLint rule reject-importGlobalProperties to reject all imports in sjs files. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D190760
2023-11-04 09:29:27 +00:00
Gijs Kruitbosch
f6a49dc94e Bug 1790354 - stop using individual inclusions for toctree by moving all eslint rules things to a subdir, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D192213
2023-10-30 15:29:47 +00:00
Gijs Kruitbosch
27a249fb7d Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-30 15:29:47 +00:00
Cristian Tuns
1aaded69b3 Backed out changeset c66fc23f71d5 (bug 1790354) for causing doc-generate failures. CLOSED TREE 2023-10-27 13:06:04 -04:00
Gijs Kruitbosch
253e6660f0 Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-27 15:02:09 +00:00
Mark Banner
86632e686f Bug 1860427 - Add a new environment to ESLint for testharness.js and automatically use it for html files including the harness. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191581
2023-10-23 15:37:18 +00:00
Sylvestre Ledru
3608dc8457 Bug 1860157 - Fix typos found by codespell 2.2.6 r=webdriver-reviewers,zeid,search-reviewers,perftest-reviewers,devtools-reviewers,releng-reviewers,gbrown,sparky,jteow
Differential Revision: https://phabricator.services.mozilla.com/D191480
2023-10-19 20:52:10 +00:00
Emilio Cobos Álvarez
04e2ae3af3 Bug 1858711 - Refactor lwtheme attributes to account for missing colors. r=dao,desktop-theme-reviewers
When a theme doesn't specify popup colors, it makes sense to follow the
system-preferred color scheme. Refactor theming attributes so that we
can distinguish this. Instead of a single [lwt-popup-brighttext], we get
lwt-popup="dark"/"light", and handle it appropriately.

Same for the other relevant attributes.

Refactor sidebar theming (which already did this tri-state thing via
lwt-sidebar and lwt-sidebar-brighttext) to do the same using a single
lwt-sidebar attribute, and update the docs.

Differential Revision: https://phabricator.services.mozilla.com/D190919
2023-10-13 13:24:14 +00:00
Mark Banner
3fc24054c0 Bug 1774888 - Remove XPCOMUtils.defineLazyModuleGetter. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189722
2023-10-02 09:48:01 +00:00
Sylvestre Ledru
c3f5275090 no bug - doc: remove the reference to Semmle/LGTM r=tjr DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D189649
2023-09-29 14:47:04 +00:00
Mark Banner
e66904fdc2 Bug 1855948 - Fix link on enabling ESLint rules page. r=aminomancer DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D189641
2023-09-29 13:09:01 +00:00
Mark Banner
496b96ae06 Bug 1851632 - Add ESLint documentation about adding rules and plugins. r=Gijs,mossop
Differential Revision: https://phabricator.services.mozilla.com/D187475
2023-09-26 21:27:40 +00:00
Mark Banner
171fab0355 Bug 1851632 - Improve documentation on linting for running locally and within editors. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D187474
2023-09-26 21:27:40 +00:00
Mark Banner
781ccaba98 Bug 1854948 - Remove support for Cu.import and XPCOMUtils.defineLazyModuleGetter from most of ESLint. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189132
2023-09-25 14:26:43 +00:00
Mike Hommey
c3d18e1e02 Bug 1851754 - Upgrade minimum supported Clang version to 8. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D188898
2023-09-22 02:34:51 +00:00
Andrew Halberstadt
6434075320 Bug 1848533 - Update 'create linter' example to use ruff, r=linter-reviewers,andi
Differential Revision: https://phabricator.services.mozilla.com/D187133
2023-08-31 04:17:34 +00:00