Commit Graph

110 Commits

Author SHA1 Message Date
Mark Banner
8d8bbb48cb Bug 1915486 - Fix document generation errors about 'Undefined substitution referenced' in migration component's JSDoc. r=migration-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D220492
2024-08-29 15:21:53 +00:00
Mark Banner
f675b28f2a Bug 1870226 - Fix missing jsdoc @returns for other browser code. r=firefox-desktop-core-reviewers ,backup-reviewers,kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D219510
2024-08-23 16:43:56 +00:00
Butkovits Atila
11a5a23896 Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
2024-08-23 12:22:02 +03:00
Mark Banner
f578ce9062 Bug 1870226 - Fix missing jsdoc @returns for other browser code. r=firefox-desktop-core-reviewers ,backup-reviewers,kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D219510
2024-08-23 08:55:48 +00:00
Jason Prickett
91fb205924 Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 03:53:10 +00:00
Stanca Serban
ae9f298177 Backed out changeset 75215e4ff218 (bug 1896597) for causing mochitests failures. 2024-06-08 04:24:47 +03:00
Jason Prickett
09251075f4 Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 00:47:23 +00:00
Daisuke Akatsuka
36c9757475 Bug 1894821: Throw NS_ERROR_FILE_TOO_BIG if the favicon data size is over than MAX_FAVICON_BUFFER_SIZE r=places-reviewers,mak,migration-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D210261
2024-05-15 21:42:59 +00:00
Daisuke Akatsuka
3a8e1f71cd Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 20:40:50 +00:00
Stanca Serban
375a8970d3 Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp. CLOSED TREE
Backed out changeset 4be83e948d32 (bug 1552815)
Backed out changeset 0b2d40719586 (bug 1552815)
Backed out changeset c17e4da85514 (bug 1552815)
Backed out changeset c66812747d09 (bug 1552815)
Backed out changeset 62b3d85f4ca3 (bug 1552815)
2024-05-01 09:58:57 +03:00
Daisuke Akatsuka
4a1f83472b Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 05:47:09 +00:00
Stanca Serban
b0b915869e Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp.
Backed out changeset 08a2ac7a9834 (bug 1552815)
Backed out changeset bb9854e6ffe7 (bug 1552815)
Backed out changeset 4e06ccb2599e (bug 1552815)
Backed out changeset d28dd2aec9f4 (bug 1552815)
Backed out changeset 392389a8d495 (bug 1552815)
2024-04-24 03:03:10 +03:00
Daisuke Akatsuka
8084fddcc3 Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
Depends on D192536

Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-04-23 23:21:39 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Bojidar Marinov
b0118a001e Bug 1839845 - Try switching to about:settings tab when opening about:preferences. r=Gijs,extension-reviewers,migration-reviewers,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D202735
2024-02-29 10:09:59 +00:00
Gregory Pappas
8e0ae3e9ae Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Nikki Sharpley
12407fd178 Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833

Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-04 15:40:22 +00:00
Cosmin Sabou
7cd8c743d7 Backed out changeset 0a133d5fd155 (bug 1864534) for causing screenshot related failures. CLOSED TREE 2024-01-04 18:38:25 +02:00
Nikki Sharpley
c4649017a7 Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833

Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-04 15:40:22 +00:00
Noemi Erli
7d4856299a Backed out changeset 6aab4af4cab8 (bug 1864534) for causing failures in browser_syncedtabs_firefoxview_next.js CLOSED TREE 2024-01-03 19:30:19 +02:00
Nikki Sharpley
c3ee3b9dcd Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833

Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-03 16:17:03 +00:00
Mike Conley
1201221bf2 Bug 1860606 - Get rid of migration.ftl in favour of migrationWizard.ftl. r=kpatenio,fluent-reviewers,bolsson
migration.ftl was used by the old, legacy XUL migration dialog that was removed
in bug 1824851.

There were still a few strings being used by migration.ftl, but I've moved those
over to migrationWizard.ftl, and gone ahead and just removed the old file.

Differential Revision: https://phabricator.services.mozilla.com/D192509
2023-11-02 22:03:26 +00:00
Mike Conley
882584cc9e Bug 1824851 - Remove the legacy XUL-based migration dialog. r=kpatenio
This also gets rid of some Histograms and Scalars that only the legacy wizard was
using, and also gets rid of the "legacy_wizard" object for migration wizard events.

Differential Revision: https://phabricator.services.mozilla.com/D191227
2023-10-23 16:08:06 +00:00
Mike Conley
ee031a3626 Bug 1858783 - Add a telemetry event for when migration permissions are requested for Snap packages. data-review=jhirsch,r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D190934
2023-10-18 19:16:38 +00:00
Mike Conley
3c473874e4 Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.

It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.

It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.

Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
Mike Conley
5085c317ab Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 20:09:21 +00:00
Sandor Molnar
d8a0e28ce0 Backed out 2 changesets (bug 1818237) for causing xpc failures on browser/components/migration/tests/unit/test_Chrome_permissions.js CLOSED TREE
Backed out changeset e5d78a9ddcb4 (bug 1818237)
Backed out changeset 87f67f05c8a8 (bug 1818237)
2023-10-11 19:53:35 +03:00
Mike Conley
1452dbdc7b Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 14:53:55 +00:00
Sandor Molnar
3a1563107d Backed out 2 changesets (bug 1818237) for causing mochitest/xpc failures on browser/components/migration/<...>.js CLOSED TREE
Backed out changeset a8584f57dc7c (bug 1818237)
Backed out changeset 477292e081b3 (bug 1818237)
2023-10-11 09:32:23 +03:00
Mike Conley
bcdf5f918d Bug 1818237 - Make it possible to request permission to access Chrome-browser profiles. r=mstriemer,fluent-reviewers,desktop-theme-reviewers
This is needed for Ubuntu Linux when Firefox is installed as a Snap package.
Under those conditions, Firefox doesn't have the ability to read the contents
of the other browsers' data directories.

We work around by showing the user a native file picker and instructing them
to browse to that data directory in folder picker mode - doing so gives
the Firefox process access to the folder (through a temporary symlink).

Another restriction we must overcome is Sqlite's inability to read from
Sqlite databases through that symlinked folder. We work around this by
copying the databases we're importing from to the system temporary
directory, querying it, and then deleting those copies.

Differential Revision: https://phabricator.services.mozilla.com/D188874
2023-10-11 04:16:49 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Mike Conley
537ddd9c0c Bug 1852973 - Delegate the responsibility of opening about:addons from the migration wizard to MigrationWizardParent. r=tgiles
Originally, we had had the extensions migration success link work by using a normal
anchor element with "about:addons" set as the href. This works on privileged pages like
about:preferences, but not for unprivileged pages like about:welcome - unprivileged
pages are generally unable to directly link to most about: pages.

The solution here is to continue to use an anchor element, but to use an event handler
on it rather than a "href" attribute, and have the MigrationWizardParent hear that
click event and take responsibility for opening about:addons.

As part of this, we're also intentionally choosing to open about:addons in a background
tab so that the user can continue to work through their onboard flow uninterrupted
should they click on the link while on about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D188116
2023-09-13 21:28:21 +00:00
Kelly Cochrane
ab66bdc5e6 Bug 1826604 - Add History empty states and banner in about:firefoxview-next r=mkaply,fxview-reviewers,sclements,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D183197
2023-07-18 13:42:11 +00:00
Mike Conley
2ca930cc08 Bug 1840792 - Be more resilient and timely when dealing with database corruption during Chrome browser import. r=kpatenio
This patch does two things:

1. It makes it so that a corrupt database doesn't result in several retries to
   requery the database, as it's extremely unlikely that a corrupt database is
   going to somehow get repaired in the interim.
2. It makes it so that if any Chrome-based browser resource fails to be acquired
   properly, it still allows other resources from the same (and other!) profiles
   to be imported.

Differential Revision: https://phabricator.services.mozilla.com/D182737
2023-07-04 20:43:09 +00:00
Mike Conley
bf24e238c7 Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-07-04 15:36:56 +00:00
Sandor Molnar
baa557ca94 Backed out changeset d4e89e0e7e9b (bug 1840917) for causing bc failures in browser/components/migration/tests/browser/browser_entrypoint_telemetry.js CLOSED TREE 2023-06-30 04:48:41 +03:00
Mike Conley
cd4dc3db2f Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-06-29 23:57:26 +00:00
Mike Conley
875b2b901a Bug 1840488 - Change from classes to a state attribute for the migration wizard progress icon. r=tgiles,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D182274
2023-06-28 16:46:19 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D180713
2023-06-23 19:23:51 +00:00
William Durand
409e3fa522 Bug 1839830 - Integrate AMBrowserExtensionsImport with the migration wizard UI. r=mconley,mixedpuppy
Depends on D181465

Differential Revision: https://phabricator.services.mozilla.com/D181747
2023-06-23 12:25:55 +00:00
Mike Conley
172ab2a94f Bug 1839462 - Add keyed histogram to record the number of matched extensions during migration. data-review=jhirsch, r=tgiles
Depends on D181566

Differential Revision: https://phabricator.services.mozilla.com/D181567
2023-06-22 13:48:51 +00:00
Norisz Fay
de0f4e32f7 Backed out 2 changesets (bug 1839462) as requested by dev CLOSED TREE
Backed out changeset a61155e9121f (bug 1839462)
Backed out changeset 99d02fe665aa (bug 1839462)
2023-06-21 23:42:10 +03:00
Mike Conley
b20bf5018f Bug 1839462 - Add keyed histogram to record the number of matched extensions during migration. data-review=jhirsch, r=tgiles
Depends on D181566

Differential Revision: https://phabricator.services.mozilla.com/D181567
2023-06-21 20:24:57 +00:00
Tim Giles
6d7971b059 Bug 1836773 - Support the new MigrationResource in the migration wizard. r=mconley,willdurand,fluent-reviewers,desktop-theme-reviewers,flod
Enables support for migrating extensions from Chrome once we have the
API to match and install extensions from the add-ons store.

Adds a new ProgressState object to delineate between various progress
states. This new object has four properties: value, message, linkURL,
and linkText. See migration-wizard-constants for more information.

MigrationWizard.#onShowingProgress uses the new ProgressState object
to handle the new LOADING, SUCCESS, ERROR and INFO values for progress.
This has the added benefit of updating the UI on error cases for the
existing resource groups.

Adds a new details object parameter to MigratorBase.migrate which is
currently used in the Chrome extensions import case.
See ChromeProfileMigrator.GetExtensionsResource for an example of
creating this details object.
See MigrationWizardParent.#doBrowserMigration for example usage of this
details object.

Adds support-text links under each resource type group in the markup.
This is currently used only by extensions in the partial matching and
no matching extensions cases.

Refactor MigrationUtils.installExtensionsWrapper to return an array
with the progress state (LOADING, SUCCESS, ERROR, INFO) and any
imported extensions.

Depends on D180005

Differential Revision: https://phabricator.services.mozilla.com/D180876
2023-06-21 20:24:56 +00:00
Tim Giles
ab89b5c2f8 Bug 1836555 - Add new 'extensions' migration resource type. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D180005
2023-06-21 20:24:56 +00:00
Mike Conley
fededa4b9c Bug 1838507 - Default the about:welcome migration behaviour to the legacy XUL dialog. r=Mardak
This adds a new behaviour that opens the legacy migration wizard from about:welcome,
and sets the pref to default to that behaviour.

This also adds the behaviour to the FeatureManifest.yaml file so that it can be
instrumented remotely via Nimbus.

Differential Revision: https://phabricator.services.mozilla.com/D181105
2023-06-15 16:33:43 +00:00
Mike Conley
bb66c4f000 Bug 1823537 - Port some older telemetry probes from the old migration wizard to the new one. r=Gijs
Those probes are:
* migration.uninstaller_profile_refresh (scalar)
* migration.discovered_migrators (keyed scalar)
* FX_MIGRATION_SOURCE_BROWSER (histogram)
* FX_MIGRATION_USAGE (histogram)
* FX_MIGRATION_ERRORS (histogram)

Not being ported are the following histograms:
* FX_STARTUP_MIGRATION_BROWSER_COUNT
* FX_STARTUP_MIGRATION_EXISTING_DEFAULT_BROWSER
* FX_STARTUP_MIGRATION_DATA_RECENCY
* FX_STARTUP_MIGRATION_USED_RECENT_BROWSER

as these are all expired.

Differential Revision: https://phabricator.services.mozilla.com/D180231
2023-06-09 17:39:51 +00:00
Mike Conley
9dcf68ac4d Bug 1823537 - Use new migration wizard for startup and profile reset migrations. r=kpatenio,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D180230
2023-06-09 17:39:51 +00:00