Commit Graph

278 Commits

Author SHA1 Message Date
Jared Hirsch
cc107e3f5d Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-02 19:12:57 +00:00
Butkovits Atila
b95413c1ad Backed out changeset f878cff45427 (bug 1800670) for causing failures at browser_protectionsUI_cookie_banner.js. CLOSED TREE 2023-02-01 20:40:46 +02:00
Jared Hirsch
42e2eda79e Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-01 14:51:39 +00:00
Noemi Erli
879d74bdb0 Backed out changeset 68de023d3c5c (bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE 2023-01-30 21:16:42 +02:00
Jared Hirsch
992086fbed Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 16:30:28 +00:00
Butkovits Atila
8a37a83f45 Backed out changeset 0072aa5cd31d (bug 1800670) for causing multiple mochitest failures. CLOSED TREE 2023-01-30 15:26:29 +02:00
Jared Hirsch
64cb4ee8e6 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 12:24:28 +00:00
Paul Zuehlcke
c561bb7d44 Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-20 12:22:09 +00:00
Marian-Vasile Laza
70fd2af8ea Backed out 2 changesets (bug 1809700) for causing automation/mochitest/marionette failures. CLOSED TREE
Backed out changeset 7d58f9afe4b7 (bug 1809700)
Backed out changeset 8a37c048a169 (bug 1809700)
2023-01-19 21:33:08 +02:00
Paul Zuehlcke
2071ac660b Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-19 17:12:00 +00:00
Mark Banner
34d6fb8d94 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Francesco Lodolo (:flod)
083fc7f23f Bug 1801915 - Migrate confirmation hints to Fluent, r=eemeli,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D162746
2022-11-22 20:12:55 +00:00
Paul Zuehlcke
981895cd9d Bug 1798960 - Hide cookie banner handling per-site toggle in MODE_DETECT_ONLY. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161731
2022-11-14 22:50:42 +00:00
Iulian Moraru
d4e0c8f6e6 Backed out 7 changesets (bug 1798960) for causing bc failures on browser_startup_content_subframe.js.
Backed out changeset 37160a6f6d6e (bug 1798960)
Backed out changeset 955c6861b6df (bug 1798960)
Backed out changeset d4d687020c42 (bug 1798960)
Backed out changeset 9b95f762751a (bug 1798960)
Backed out changeset 3ab8c890086d (bug 1798960)
Backed out changeset ddd6e63f05dc (bug 1798960)
Backed out changeset 1810be532880 (bug 1798960)
2022-11-14 23:44:21 +02:00
Paul Zuehlcke
9416fa5d5d Bug 1798960 - Hide cookie banner handling per-site toggle in MODE_DETECT_ONLY. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161731
2022-11-14 20:38:18 +00:00
Paul Zuehlcke
7e98c8995e Bug 1798669 - Extend protections popup event telemetry to include cookie banner handling toggle. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D161064
2022-11-09 18:14:06 +00:00
Paul Zuehlcke
0668c2ff68 Bug 1795041 - Add a cookie banner handling per-site toggle to the protection panel. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D160254
2022-11-01 13:34:56 +00:00
Itiel
bb1a599e62 Bug 1797591 - Center the icon in the trackers list when no trackers are detected r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D160399
2022-10-27 11:56:37 +00:00
Itiel
93140a5b5c Bug 1790232 - Use subviewbutton for the Protections popup buttons and cleanup some CSS r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157045
2022-10-25 19:02:45 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Itiel
16ee0f8445 Bug 1710885 - Hide the toolbarseparator in the protections popup when needed r=hpeuckmann
Differential Revision: https://phabricator.services.mozilla.com/D155863
2022-09-02 08:02:58 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
9e59e52e55 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Hannah Peuckmann
1a3d975a52 Bug 1764761 - Remove/replace the network.cookie.lifetimePolicy. r=pbz,necko-reviewers,mkaply,dom-storage-reviewers,agi,asuth,dragana
Differential Revision: https://phabricator.services.mozilla.com/D144548
2022-06-29 17:33:37 +00:00
Shane Hughes
d0205caf06 Bug 1724622 - Fix missing ETP toast popup animation. r=pbz,Gijs
When the tracking protection toast popup closes on a timer, it doesn't
smoothly fade out, because it uses PanelMultiView.hidePopup instead of
panelNode.hidePopup. The static method on PanelMultiView ultimately
calls panelNode.hidePopup, but it doesn't have a parameter for enabling
the animation so it passes nothing to that method. This patch extends
PanelMultiView's hidePopup class methods to add an optional `animate`
parameter, and adds that parameter to the toast popup's hidePopup call.
This should slightly reduce the speed of part of
browser_protectionsUI.js but I don't think it affects any other tests.

Differential Revision: https://phabricator.services.mozilla.com/D146394
2022-05-24 16:04:23 +00:00
Shane Hughes
e79852e462 Bug 1750129 - Remove old/obsolete reference to photon tracking protection icon animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D135961
2022-02-25 17:58:31 +00:00
Benjamin VanderSloot
1793417017 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 18:25:58 +00:00
Marian-Vasile Laza
88f9e0defb Backed out 3 changesets (bug 1731739) for causing build bustages on PermissionManager.cpp.
Backed out changeset 2f723b6e625b (bug 1731739)
Backed out changeset 7b053cfeab3e (bug 1731739)
Backed out changeset c4a31c29c441 (bug 1731739)
2021-11-23 19:06:14 +02:00
Benjamin VanderSloot
5ad5689e47 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 16:18:42 +00:00
Molly Howell
5abe51e990 Bug 1703608 - Hide doorhangers while protections panel is open. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D117693
2021-07-06 15:37:44 +00:00
Paul Zuehlcke
a75810f15b Bug 1710857 - Fixed protections panel cookie state label and button. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D114990
2021-05-18 09:51:06 +00:00
Sam Foster
c3daea8737 Bug 1704152 - Update the tracking protection icon, and remove the state transition animation. r=jaws
* Updates the addressbar "lock" icon for the tracking-protection blocked/disabled state, the default "no trackers" state, and the "trackers blocked" state. Where we used to animate the transition to trackers blocked, its now a static iconwith the same blue/purple gradient fill.

* Remove browser_protectionsUI_animation.js which was specifically testing the animation behavior and use of the animation frames as visible icons, which is no longer the case

* Rename and adjust browser_protectionsUI_animation_2.js which is primarily testing the active/not state of the icon

Differential Revision: https://phabricator.services.mozilla.com/D111507
2021-04-16 17:47:29 +00:00
Dão Gottwald
ba52a5524d Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-14 13:57:34 +00:00
Alexandru Michis
4d8bf7297a Backed out changeset 80f482be9920 (bug 1704152) for causing bc failures in browser_protectionsUI_animation.js
CLOSED TREE
2021-04-13 23:27:38 +03:00
Sam Foster
72ac18ae89 Bug 1704152 - Update the tracking protection icon, and remove the state transition animation. r=jaws
Updates the addressbar "lock" icon for the tracking-protection blocked/disabled state, the default "no trackers" state, and the "trackers blocked" state. Where we used to animate the transition to trackers blocked, its now a static iconwith the same blue/purple gradient fill.

Differential Revision: https://phabricator.services.mozilla.com/D111507
2021-04-13 17:35:56 +00:00
Paul Zuehlcke
d128258d65 Bug 1699669 - Added learn more link to the shim-allow warning in the protections panel. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110150
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
348e064eba Bug 1699668 - Refactor siteProtections blockers and add a warning for trackers allowed by shims. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D109717
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
88fb2c09c2 Bug 1661330 - Log STATE_ALLOWED_TRACKING_CONTENT to the ContentBlockingLog if a channel is allowed. r=geckoview-reviewers,dimi,droeh
Differential Revision: https://phabricator.services.mozilla.com/D109716
2021-04-13 16:11:20 +00:00
smolnar
9772ac8235 Backed out changeset 034a69e0a73e (bug 1701306) for causing browser-chrome failures in browser_page_action_menu. CLOSED TREE 2021-04-08 17:16:21 +03:00
Dão Gottwald
7c29048b6e Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-08 12:53:08 +00:00
Alexandru Michis
77c2ff629e Backed out changeset 8d8aa8575c1d (bug 1701306) for causing multiple bc failures.
CLOSED TREE
2021-04-06 19:45:27 +03:00
Dão Gottwald
4a29705c86 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-06 13:22:50 +00:00
Jared Wein
b7f2b3e91d Bug 1670972 - Fix default value preference type mismatches with calls to defineLazyPreferenceGetter. r=vbudhram,markh,tjr
Differential Revision: https://phabricator.services.mozilla.com/D93400
2021-03-25 20:15:39 +00:00
Paul Zuehlcke
a1d23766c7 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-02-05 13:40:35 +00:00
Narcis Beleuzu
926d2f6257 Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Paul Zuehlcke
480794a586 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-29 16:06:08 +00:00
Brindusan Cristian
b0f9bc02f2 Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00