Commit Graph

75 Commits

Author SHA1 Message Date
Neil Deakin
734124e0f9 Bug 1714337, remove separate high and non-high notification box references, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D121083
2021-07-28 18:24:42 +00:00
David Parks
8762bd9bcc Bug 1698959: Remove HangData union and SLOW_SCRIPT enum value r=dthayer,geckoview-reviewers,agi
HangData is the only member left in the union and SLOW_SCRIPT is the only member left in the enum.
This patch also migrates the one remaining (invalid) use of PLUGIN_HANG in testing to work as a SLOW_SCRIPT instead.

Differential Revision: https://phabricator.services.mozilla.com/D113885
2021-05-01 01:12:46 +00:00
David Parks
63ea606b61 Bug 1698959: Clean up dead terminatePlugin references r=dthayer
PLUGIN_HANG events are no longer sent so terminatePlugin is unused.

Differential Revision: https://phabricator.services.mozilla.com/D113884
2021-05-01 01:12:45 +00:00
David Parks
0c6bdc117c Bug 1698959: Remove NPAPI plugin telemetry references r=dthayer
PLUGIN_HANG events are no longer possible so all of these markers are already inactive.

Differential Revision: https://phabricator.services.mozilla.com/D113882
2021-05-01 01:12:45 +00:00
Francesco Lodolo (:flod)
b604626f92 Bug 1704315 - Change l10n IDs for "Stop" button in process hang infobar, r=florian
Only the label was changed in bug 1694229, causing issues with the existing access key (still used in <89 for "Stop it").
Changing both IDs to force retranslation.

Differential Revision: https://phabricator.services.mozilla.com/D111576
2021-04-12 13:51:01 +00:00
Doug Thayer
08856beab3 Bug 1702516 - Remove all terminateGlobal uses r=kmag
This never actually worked, because nothing ever listened to the notification
sent in XPCJSContext (kill-content-script-sandbox). We're also removing the
"Temporarily disable extension" button in the slow addon notification, which
was the primary caller of this - however, that's in a separate patch.

Differential Revision: https://phabricator.services.mozilla.com/D110583
2021-04-05 16:00:09 +00:00
Doug Thayer
e497769b2e Bug 1702516 - Remove Temporarily disable extension button r=florian
Fairly straightforward - this removes the button from the slow add-on script
notification, as well as the functions that only it utilizes.

Differential Revision: https://phabricator.services.mozilla.com/D110582
2021-04-05 16:00:08 +00:00
Doug Thayer
7ce69797cd Bug 1678411 - Ensure we show slow script notification for fission iframes r=smaug
See bug for more details, but effectively the decision is to show the same
notification which we would normally show for hung pages if an iframe hangs,
but only do so if the user is trying to interact with content hung by that
iframe. This should accomplish that.

Differential Revision: https://phabricator.services.mozilla.com/D107933
2021-03-11 17:41:19 +00:00
Doug Thayer
f42c2a6b01 Bug 1696482 - Update extension-specific slow script notification text r=florian
Differential Revision: https://phabricator.services.mozilla.com/D107243
2021-03-08 16:57:27 +00:00
Doug Thayer
95e063a4f9 Bug 1695734 - Remove Learn More link from content script hang infobars r=NeilDeakin
Depends on D106816

Differential Revision: https://phabricator.services.mozilla.com/D106821
2021-03-01 21:18:03 +00:00
Doug Thayer
c995a0221c Bug 1695726 - Change the slow script notification priority to info r=florian
Differential Revision: https://phabricator.services.mozilla.com/D106816
2021-03-01 19:27:01 +00:00
Doug Thayer
4f4e061bc2 Bug 1694229 - Show a different notification is selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-27 18:22:33 +00:00
Doug Thayer
431019105f Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-27 18:22:32 +00:00
Neil Deakin
960f0d6ddc Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-26 13:43:10 +00:00
Bogdan Tara
d3b237bc88 Backed out 5 changesets (bug 1694229) by flod's request, lint failures CLOSED TREE
Backed out changeset cb3d9e8d32e6 (bug 1694229)
Backed out changeset 877471a44509 (bug 1694229)
Backed out changeset 286b311d32b2 (bug 1694229)
Backed out changeset 42cb688eae03 (bug 1694229)
Backed out changeset d082f53d882e (bug 1694229)
2021-02-25 22:43:33 +02:00
Doug Thayer
29a5dae3d3 Bug 1694229 - Show a different notification if selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-25 19:59:16 +00:00
Doug Thayer
1ed0e4a9d8 Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-25 19:59:14 +00:00
Cosmin Sabou
97da8c128d Backed out changeset 36b76c196497 (bug 1691499) for bc failures on browser_decoderDoctor.js. CLOSED TREE 2021-02-25 21:47:25 +02:00
Neil Deakin
d3cfcae51d Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-25 12:00:39 +00:00
Brindusan Cristian
2d80c12f31 Backed out 5 changesets (bug 1694229) for geckoview failures. CLOSED TREE
Backed out changeset 5ce24c91b0c1 (bug 1694229)
Backed out changeset 7fef19f47442 (bug 1694229)
Backed out changeset a70e27ec7747 (bug 1694229)
Backed out changeset 6a5d472e1b05 (bug 1694229)
Backed out changeset d32085239f92 (bug 1694229)
2021-02-25 09:27:50 +02:00
Doug Thayer
0496bcc588 Bug 1694229 - Show a different notification is selected tab is hanging r=florian
As part of this, we need to detect that the currently showing notification does
not match the one what we want to display. This also fixes the case where we
show a notification for tab A, then switch to tab B which is also hanging, and
end up listing the title for tab A as hanging in the notification.

Differential Revision: https://phabricator.services.mozilla.com/D106305
2021-02-25 04:14:14 +00:00
Doug Thayer
f58f039a69 Bug 1694229 - Update slow script warning visuals r=florian
This patch removes the wait button on the slow script warning, on the suspicion
that it is confusing to the user since it's redundant with the close button. It
also changes the text of the notification to blame the hanging tab.

Differential Revision: https://phabricator.services.mozilla.com/D106015
2021-02-25 04:14:12 +00:00
Gijs Kruitbosch
bf7c7fb0c2 Bug 1686816 - ensure we have useful values for waitCount and deselectCount to avoid 'undefined' showing up in telemetry, r=jaws
Unfortunately a meaningful automated test here is difficult because we're dealing with shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D102598
2021-01-21 16:42:21 +00:00
Gijs Kruitbosch
4824b1b334 Bug 1652613 - record whether the user switched away from the tab while it was hung, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84343
2020-07-24 00:55:34 +00:00
Gijs Kruitbosch
31fd7b2b51 Bug 1652613 - record a telemetry event when we show the slow script notification warning, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D83922
2020-07-24 00:50:12 +00:00
Dorel Luca
f87f29480c Backed out 4 changesets (bug 1652613) for Browser-chrome failures in browser/browser_ProcessHangNotifications.js. CLOSED TREE
Backed out changeset 76b5a5d243d1 (bug 1652613)
Backed out changeset 6f98c9b01920 (bug 1652613)
Backed out changeset 1255237ce2e7 (bug 1652613)
Backed out changeset bdf59854c900 (bug 1652613)
2020-07-24 02:58:22 +03:00
Gijs Kruitbosch
41462c0203 Bug 1652613 - record whether the user switched away from the tab while it was hung, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D84343
2020-07-22 22:28:05 +00:00
Gijs Kruitbosch
3a046c70d1 Bug 1652613 - record a telemetry event when we show the slow script notification warning, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D83922
2020-07-22 22:28:31 +00:00
Boris Zbarsky
5c7393e484 Bug 1568278. Remove various unnecessary QIs to nsIDOMWindow. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D39065
2019-07-24 01:26:07 +00:00
Victor Porof
9a78b195ab Bug 1561435 - Format browser/modules/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36046
2019-07-05 09:55:19 +02:00
Alexander Surkov
62ec0b0d61 Bug 1527495 - migrate text-link binding to CE, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D19595
2019-02-12 19:14:40 -05:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Paolo Amadini
ecaee75fcc Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D10892
2018-11-09 14:38:49 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
503979c95a Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
MozReview-Commit-ID: GrlcOI9K2hJ
2017-05-28 19:57:46 +01:00
Mike Conley
fddd086b2c Bug 1391594 - If a window closes while hosting a <xul:browser> hung on script, clear the hang. r=billm
MozReview-Commit-ID: 88oj1bqA9To
2017-10-13 16:15:44 -04:00
Mike Conley
c2f35e935d Bug 1391594 - Unilaterally terminate script and plugin hangs during shutdown or when there are no windows. r=billm
MozReview-Commit-ID: 6DYDYTRVrYu
2017-10-02 18:38:27 -04:00
Kris Maglione
be161e68b4 Bug 1391110: Part 4 - Remove unnecessary nsIFrameLoaderOwner QIs. r=smaug
The FrameLoaderOwner interface has been implemented in WebIDL for several
years now, so these QIs are simply unnecessary overhead.

MozReview-Commit-ID: LAzvfm5Qhy0
2017-08-19 13:32:58 -07:00
Francesco Lodolo (:flod)
b25f2aec89 Bug 1391933 - Fix localization issues in Kill Add-on dialogs, r=kmag
Changes originally landed in bug 1356334:
* Removed SUMO link as a localizable string.
* Updated SUMO link: removed "en-US" from link and "cache" parameter.
* Use ordered placeholder instead of %S.
* Fix typo ("responsing").
* Use "extension" instead of "add-on" in DOM strings for consistency.
* Removed period from KillAddonScriptGlobalMessage, since it's a checkbox.

MozReview-Commit-ID: 5IFH2ruISZb
2017-08-20 10:52:32 +02:00
Kris Maglione
e8f17cb030 Bug 1356334: Part 6 - Allow completely terminating a slow content script sandbox. r=billm
MozReview-Commit-ID: 5CDLHrAeuDt
2017-04-16 14:01:16 -07:00