corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
892,613 Commits 1 Branch 0 Tags
e80180f3025d2bea54c38c41d0a2f3cbde9b6c21
Commit Graph

56 Commits

Author SHA1 Message Date
Nikki Sharpley
e80180f302 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-27 15:52:05 +00:00
Sandor Molnar
0e23de4f07 Backed out changeset 125d12cc3cdb (bug 1938249) for causing bc failures @ browser_sidebar_keys.js CLOSED TREE 2025-01-25 01:11:14 +02:00
Nikki Sharpley
463d047cea Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-24 21:34:33 +00:00
kpatenio
49e79df143 Bug 1938428 - Add new probe for RC sidebar tool being enabled or disabled in sidebar settings. r=sidebar-reviewers,shopping-reviewers,rking 
Differential Revision: https://phabricator.services.mozilla.com/D235053
 2025-01-24 18:16:41 +00:00
Sandor Molnar
991d828365 Backed out changeset 63792baa34ad (bug 1935432) for causing bc perma failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-24 20:26:33 +02:00
Jonathan Sudiaman
5fbb160ed8 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane 
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
 2025-01-24 17:14:01 +00:00
Goloman Adrian
0acf0b8472 Backed out changeset 71732d1ca82f (bug 1935432) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-01-23 16:14:02 +02:00
Jonathan Sudiaman
38276f5013 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane 
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
 2025-01-23 13:15:15 +00:00
Sarah Clements
999958fa5a Bug 1933818 - Sidebar panel keyboard shortcuts should hide the sidebar r=sidebar-reviewers,nsharpley,jsudiaman 
*Update SidebarState logic so that opening and closing panels reverts to the correct launcher visibility for the show and hide setting
*Add a test

Differential Revision: https://phabricator.services.mozilla.com/D231838
 2024-12-13 13:24:28 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
 2024-11-29 15:18:25 +00:00
Ed Lee
acaddfd634 Bug 1923900 - Record sidebar-customize for toggling chatbot and bookmarks r=jsudiaman,sidebar-reviewers 
Add events for chatbot and bookmarks. Update tests to support default unchecked bookmarks.

Differential Revision: https://phabricator.services.mozilla.com/D225304
 2024-10-11 15:37:32 +00:00
Jonathan Sudiaman
3f3415399b Bug 1922037 - Record Glean metrics upon sidebar initialization r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D224797
 2024-10-09 20:09:55 +00:00
Nikki Sharpley
b9c3ba706c Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-10-03 14:20:55 +00:00
Sandor Molnar
fbc2bb1bd2 Backed out changeset 6ad99c7c787d (bug 1914452) for causing bc sider bar related failures. CLOSED TREE 2024-10-02 21:25:44 +03:00
Nikki Sharpley
20a153c56b Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-10-02 16:52:46 +00:00
Iulian Moraru
7f4f522517 Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00
Nikki Sharpley
8536a92e8d Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-09-27 20:33:59 +00:00
Jonathan Sudiaman
03df9fb463 Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223314
 2024-09-25 23:30:38 +00:00
Sandor Molnar
7599f7c3a6 Backed out changeset ef1b42c36db7 (bug 1902056) for causing perma bc failures @ browser_toolbarKeyNav.js CLOSED TREE 2024-09-25 14:07:40 +03:00
Jonathan Sudiaman
375579d22d Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223314
 2024-09-24 20:00:26 +00:00
Fred Chasen
89e6d0b8cb Bug 1916017 - Add Review Checker as a sidebar tool. r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,sclements,kpatenio 
- Registers the a new review checker sidebar using `registerPrefSidebar` that will display if  `browser.shopping.experience2023.integratedSidebar` is enabled.
- Hides any open review checker sidebars if the pref changes.
- Adds `reviewchecker` to the sidebar revamp tools pref.

Note: this only adds the sidebar tool, it will not load anything as the actors aren't setup yet.

Differential Revision: https://phabricator.services.mozilla.com/D221362
 2024-09-19 17:07:29 +00:00
Jonathan Sudiaman
b8faa7e749 Bug 1919185 - Fix links and radio buttons that are failing Tier 2 a11y_checks for Customize Sidebar r=sidebar-reviewers,accessibility-frontend-reviewers,Gijs,Jamie 
For extension links, AccessibilityUtils was checking the `<a>` element, rather than its container. Moving `tabIndex` over to the inner "link" seemed to remedy this.
For radio inputs, we should not be checking `tabIndex` as `<moz-radio-group>` only allows focus on the active radio option (by design).

Differential Revision: https://phabricator.services.mozilla.com/D222670
 2024-09-19 14:42:45 +00:00
Jonathan Sudiaman
15ad15eecf Bug 1898250 - Add telemetry to sidebar r=sidebar-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D220720
 2024-09-16 15:42:48 +00:00
Nikki Sharpley
a441acbbaa Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane 
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
 2024-08-02 19:10:14 +00:00
Butkovits Atila
dd41b6e962 Backed out changeset 397b2df59338 (bug 1886847) for causing failures at browser-custom-colors.css. CLOSED TREE 2024-08-02 19:18:43 +03:00
Nikki Sharpley
54d0b76fd9 Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane 
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
 2024-08-02 15:26:00 +00:00
Stuart Colville
42e4b57d88 Bug 1906622 - Move preventDefault call to avoid keyboard trap r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D218343
 2024-08-02 13:04:01 +00:00
Nikki Sharpley
e4b1bd71bf Bug 1910152 - Ensure sidebar customize position settings work with RTL r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D217952
 2024-07-29 21:06:59 +00:00
Nikki Sharpley
ee42dc2123 Bug 1905869 - Add vertical tabs settings to customize panel r=sidebar-reviewers,fluent-reviewers,flod,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D215633
 2024-07-17 13:22:29 +00:00
Ed Lee
1bac981cb5 Bug 1900915 - Include chat as tool for new sidebar r=sidebar-reviewers,sclements 
Update default tool ordering. Conditionally render tool if not hidden for both main and customize.

Differential Revision: https://phabricator.services.mozilla.com/D215721
 2024-07-04 14:44:11 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D212285
 2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 18:15:25 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 14:00:00 +00:00
Mark Striemer
cabc85f076 Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-19 18:37:37 +00:00
Mark Striemer
fb377d8a08 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-19 18:37:37 +00:00
Kelly Cochrane
e2fe9bf11e Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D213278
 2024-06-18 18:24:08 +00:00
pstanciu
e91ba02454 Backed out changeset ab055e5ace5e (bug 1899576) for causing bc failures on browser_all_files_referenced.js CLOSED TREE 2024-06-18 20:49:29 +03:00
Kelly Cochrane
c8bfc52deb Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D213278
 2024-06-18 16:03:11 +00:00
Sandor Molnar
34e807bc63 Backed out 5 changesets (bug 1897529, bug 1901336, bug 1900126) for causing bc failures @ browser_a11y_sidebar.js CLOSED TREE 
Backed out changeset 334b820a4c19 (bug 1897529)
Backed out changeset 70350abadcba (bug 1900126)
Backed out changeset 3d631de2ce01 (bug 1897529)
Backed out changeset 1d654154d5ea (bug 1897529)
Backed out changeset a8f7b541a548 (bug 1901336)
 2024-06-14 22:41:48 +03:00
Mark Striemer
d06b2bcf0e Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-14 18:18:19 +00:00
Mark Striemer
caac4b33d7 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-14 18:18:19 +00:00
Tamas Szentpeteri
7b9a55f977 Backed out 4 changesets (bug 1900126, bug 1897529, bug 1901336) for causing mochitest failures on test_moz_message_bar.html. CLOSED TREE 
Backed out changeset 212bac58cc17 (bug 1900126)
Backed out changeset efaba56826e3 (bug 1897529)
Backed out changeset 9c52e2ac9df2 (bug 1897529)
Backed out changeset fc94dfe91c29 (bug 1901336)
 2024-06-14 06:09:39 +03:00
Mark Striemer
7b96f60e6a Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-13 21:52:53 +00:00
Mark Striemer
75fb7b5b6c Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-13 21:52:53 +00:00
Nikki Sharpley
79b74fdc93 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements 
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
 2024-06-10 13:42:10 +00:00
Norisz Fay
f69ee9dbb8 Backed out changeset e650be9ceb1f (bug 1894222) for causing bc failures on browser_customize_sidebar.js CLOSED TREE 2024-06-06 06:27:05 +03:00
Nikki Sharpley
5e7bc1e164 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements 
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
 2024-06-05 17:13:07 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu 
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
 2024-05-28 15:55:49 +00:00
Kelly Cochrane
8f3ea55cfc Bug 1894221 - Add Sidebar Extensions section to Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,bolsson,sclements,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210381
 2024-05-21 14:00:03 +00:00