Commit Graph

202 Commits

Author SHA1 Message Date
Shane Hughes
e7f24e223a Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D238374
2025-03-07 04:36:57 +00:00
hanna.alemu
66860e7c8b Bug 1922646 - Add a delay between the default Set to Default prompt and showing the INFOBAR_DEFAULT_AND_PIN_87 message r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D234206
2025-03-04 20:31:35 +00:00
Emily McMinn
c4129a5ba8 Bug 1945700 - Add a boolean background property to dismiss buttons that enables contrasting colours r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D237640
2025-02-28 23:12:17 +00:00
Meg Viar
35da1f9427 Bug 1940580 - On-train limited rollout of TOS preonboarding modal for Mac, Linux, and MSIX r=nalexander,hanna_a,omc-reviewers,beth,Gijs
- Support an on-train limited rollout of the TOS preonboarding modal for platforms where first run experiments are not supported (Mac, Linux, MSIX)
- This patch lands the initial feature work and an uplift in 137 release will enable it for 1% of users. Later in 137, a second uplift will increase the population to 25%.
- Two nimbus features with fallback prefs are available for testing, the fallback prefs are `browser.preonboarding.onTrainRolloutEnabled` and `browser.preonboarding.onTrainRolloutPopulation`.

Differential Revision: https://phabricator.services.mozilla.com/D238304
2025-02-27 16:23:20 +00:00
Shane Hughes
e9c7fc6d9f Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D239402
2025-02-27 08:31:42 +00:00
Emilio Cobos Álvarez
1ed7833723 Back out bug 1950189 because I pushed it accidentally.
MANUAL PUSH: Back out CLOSED TREE
2025-02-27 01:16:22 +01:00
Shane Hughes
cbe67161c2 Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=#omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239402
2025-02-27 01:00:36 +01:00
Emily McMinn
de64394a0c Bug 1949599 - Remove animated onboarding callouts for Tab Groups r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D239181
2025-02-26 17:02:18 +00:00
Gregory Pappas
2300895022 Bug 1750304 - Move isChinaRepack out of AppConstants r=settings-reviewers,home-newtab-reviewers,Gijs,pdahiya,omc-reviewers,mossop,mconley
AppConstants seems like the wrong place for this method

Differential Revision: https://phabricator.services.mozilla.com/D239276
2025-02-25 20:46:37 +00:00
Rebecca King
b3a22ac978 Bug 1938253 - Implement Callout 3 for integrated version of Review Checker - r=kpatenio,shopping-reviewers,fluent-reviewers,settings-reviewers,omc-reviewers,aminomancer,bolsson,mossop
Differential Revision: https://phabricator.services.mozilla.com/D233053
2025-02-24 18:15:36 +00:00
negin
4b16185899 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-02-24 15:21:41 +00:00
Rebecca King
622361d010 Bug 1938413 - Implement callout 4A and callout 4B for RC in the sidebar when a user disables auto-open r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D234974
2025-02-21 23:30:51 +00:00
negin
3d8c9dcaaf Bug 1919598 - Avoid creating a notification box during activeNotifications r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D238817
2025-02-21 23:05:26 +00:00
Rebecca King
ddf1ba4c90 Bug 1938417 - Implement callout 5 for Review Checker in the sidebar when a user turns off Review Checker - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D234997
2025-02-21 22:07:22 +00:00
Emily McMinn
31aeebfe5f Bug 1949261 - Tab Groups message refinements and strings r=omc-reviewers,dao,fluent-reviewers,bolsson,pdahiya,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D238837
2025-02-21 16:53:18 +00:00
Goloman Adrian
3624802d33 Backed out changeset 8b98d8d87760 (bug 1948423) for causing bc failures @browser_foxdoodle_set_default.js. CLOSED TREE 2025-02-20 06:56:38 +02:00
Shane Hughes
378d8ec5e5 Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D238374
2025-02-20 03:03:45 +00:00
Meg Viar
4066ecbd13 Bug 1948717 - Add flag that enables running actions in MULTI_ACTION SMA in sequential order r=jprickett,omc-reviewers,nalexander
To support the upcoming TOS preonboarding experiment, we want to ensure the following actions occur sequentially:
  - setting prefs, including `datareporting.healthreport.uploadEnabled` (`SET_PREF`)
  - submitting the onboarding opt-out ping, if applicable (`SUBMIT_ONBOARDING_OPT_OUT_PING`)
  - notifying that the data reporting notification has been interacted with (`DATAREPORTING_NOTIFY_DATA_POLICY_INTERACTED`).

When these actions occur out of order, it is possible for telemetry to be enabled and then disabled. This is likely what accounts for the onboarding-opt-out followed by deletion-request pings witnessed by QA in Bug 1948717.

We believe that the issue is that the `MULTI_ACTION` SMA does not guarantee any ordering of its child actions: see [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/toolkit/components/messaging-system/lib/SpecialMessageActions.sys.mjs#687-696 | here ]]. That's by design, since early actions including pinning and set-to-default, which are slow and can be run concurrently. But here, we expect sequential ordering (and also [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#578-585 | in the code ]]).

The obvious way to address this is to have the MULTI_ACTION order its child actions. However, this needs to be a flag, since we have existing consumers and we want to minimize disruption.

This patch adds support for an `orderedExecution` flag on message `action` configurations for those with type `MULTI_ACTION`. This applies to nested `MULTI_ACTIONS` using `collectSelect` as well, assuming each `MULTI_ACTION` has the `orderedExecution` flag.

Differential Revision: https://phabricator.services.mozilla.com/D238816
2025-02-20 00:28:02 +00:00
Butkovits Atila
91a59f70d0 Backed out changeset aedc669b8499 (bug 1919598) for causing failures at browser_tabnotificationbox_switch_tabs.js. CLOSED TREE 2025-02-14 19:24:24 +02:00
negin
4935d2153f Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-02-14 16:05:20 +00:00
Sarah Chung
4a5e5fad96 Bug 1947536 - expose qr code in desktop to mobile adoption message to assistive technology r=emcminn,omc-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D237898
2025-02-12 20:37:21 +00:00
Meg Viar
da90402d32 Bug 1947510 - Save default MultiSelect choices even if component defaults to a collapsed state r=omc-reviewers,hanna_a,jprickett
We want to capture the default state of multiselect checklist items when a user clicks the primary CTA on an aboutwelcome screen, even if the checklist hasn't been rendered yet (such as when the user needs to click a button to toggle it in to view).

Differential Revision: https://phabricator.services.mozilla.com/D237773
2025-02-11 22:22:30 +00:00
Sarah Chung
ccdd8c7af2 Bug 1947182 - update targeting for desktop to mobile adoption message r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237616
2025-02-10 21:51:11 +00:00
Emily McMinn
8a96646dd7 Bug 1945564 - Update Create Tab Group callout && add new callout for users who have removed the all tabs button r=omc-reviewers,dao,fluent-reviewers,bolsson,mviar
Differential Revision: https://phabricator.services.mozilla.com/D236588
2025-02-06 17:28:08 +00:00
Emily McMinn
b6fec0fc15 Bug 1944344 - Anchor vertical callout to tab strip if active tab is pinned r=omc-reviewers,dao,mviar
Differential Revision: https://phabricator.services.mozilla.com/D236956
2025-02-06 15:38:50 +00:00
Sarah Chung
00af71e19a Bug 1944079 - land desktop to mobile adoption experiment in tree r=omc-reviewers,emcminn,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D236551
2025-02-06 15:14:36 +00:00
Emily McMinn
3a3f5adda0 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D222032
2025-02-05 21:01:41 +00:00
Rebecca King
ddcdf53352 Bug 1938421 - Implement callout 6 for RC in the sidebar, when a user closes RC - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235003
2025-02-03 22:55:31 +00:00
Sandor Molnar
603aa1973c Backed out changeset d98b62477b98 (bug 1904441) for causing bc failures & assertion failures @ browser_messagepreview_receivemessage.js / nsContentSecurityUtils.cpp CLOSED TREE 2025-02-03 23:36:24 +02:00
Emily McMinn
b0ba7f9890 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D222032
2025-02-03 17:18:47 +00:00
Emily McMinn
c749a0b825 Bug 1944103 - Refine targeting for tab groups onboarding messages r=omc-reviewers,dao,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D235698
2025-01-29 22:15:28 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
2025-01-29 19:09:19 +00:00
Emily McMinn
da797a5490 Bug 1943442 - Land onboarding callouts for Tab Groups r=omc-reviewers,aminomancer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235376
2025-01-24 21:56:55 +00:00
Meg Viar
7dca8efc49 Bug 1941807 - Add ability to toggle AboutWelcome screen content by clicking a configurable header r=omc-reviewers,jprickett
Support a second variant of the preonboarding modal design by adding the ability to configure a header that toggles visiblity of content tiles.

- See design for [[ https://docs.google.com/presentation/d/1dDC9M9y-W3q90mkVRp4gq3p-x3u7F6qgy0jVeE4MwUw/edit#slide=id.g325219d6753_0_95 | modal Variant B ]]

Differential Revision: https://phabricator.services.mozilla.com/D235325
2025-01-24 13:30:07 +00:00
Punam Dahiya
0628dbd0a7 Bug 1937172 - Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage r=home-newtab-reviewers,omc-reviewers,mconley,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D234447
2025-01-23 21:32:23 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D234113
2025-01-22 05:59:40 +00:00
Punam Dahiya
59e4ab14a7 Bug 1937166 - Decouple ASRouter from NewTab TelemetryFeed r=home-newtab-reviewers,omc-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D233458
2025-01-21 18:56:18 +00:00
Meg Viar
645b9b4605 Bug 1942323 - Add carat icon to Content Tile headers and ensure proper border-radius on headers above non-toggleable tiles r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D234731
2025-01-21 18:43:09 +00:00
Emily McMinn
3748e6bed5 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer,negin
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-20 21:31:06 +00:00
Sandor Molnar
2d18e11253 Backed out changeset 232515e209c7 (bug 1940476) for causing bc failures @ browser_asrouter_trigger_docs.js 2025-01-18 07:46:06 +02:00
Emily McMinn
f4e1bff7e4 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-18 00:02:55 +00:00
Norisz Fay
149fb6e550 Backed out changeset 6d26e856d73e (bug 1940476) for causing xpcshell failures on test_backgroundtask_targeting.js 2025-01-16 23:43:14 +02:00
Emily McMinn
418d1decfb Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-16 19:28:08 +00:00
Meg Viar
9e8ae04a1b Bug 1936656 - Add ability to show multiple content tiles on a single aboutwelcome screen with option to toggle visibility r=emcminn,omc-reviewers,jprickett
**Primary Updates**
- Add ability to show multiple content tiles on a single AboutWelcome screen by supporting an array of tile objects and/or sub-arrays of tile objects to be groups together as a value for "tiles" in screen content
- Keep compatibility with messages that use a single tile object as the value of "tiles" in screen content
- Add updates to `setMultiSelectActions` to ensure we can handle actions across multiple MultiSelect tiles.
- Add optional tile headers which can be displayed in place of the tile until clicked, closing any other tile with a header that's currently open
- Send click event telemetry when a user clicks a tile header to open the tile
- Update aboutwelcome source docs related to content tiles to include this new capability

**Additional Updates to Support UX Designs**
[[ https://www.figma.com/design/F63Ac1akw2q1fN5D59rgS5/Privacy?node-id=4110-16458&t=kSzPUp4XFLq0dKg8-4 |
See Figma designs ]]
- Add ability to configure `display`, `padding`, and `width` for aboutwelcome screens (this allows us to support the proposed Spotlight modal designs, which include anchoring the modal towards the top of the screen and expanding it downward when a tile is opened, rather than centering vertically)
- Add ability to configure action buttons to show above screen content

{F11717546}

Differential Revision: https://phabricator.services.mozilla.com/D231856
2025-01-15 16:29:23 +00:00
Emily McMinn
efeb1ce68d Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-13 18:48:32 +00:00
Cosmin Sabou
efae93e17d Backed out 2 changesets (bug 1938446, bug 1919598) for causing failures on browser_tabnotificationbox_switch_tabs and conflicts. CLOSED TREE
Backed out changeset be28df34cc76 (bug 1938446)
Backed out changeset ffa630d286bb (bug 1919598)
2025-01-11 01:58:14 +02:00
Emily McMinn
b2b5a8709e Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-10 21:50:48 +00:00
negin
34caedb5e0 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-01-10 21:31:18 +00:00
Punam Dahiya
cf58fbd5e3 Bug 1618001 - Move React vendored libraries to the toolkit to prevent multiple instances r=sylvestre,omc-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,firefox-ai-ml-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232431
2025-01-08 21:08:16 +00:00
Meg Viar
81a9ec1500 Bug 1937625 - Strengthen embedded browser element flags in Messaging System r=omc-reviewers,nalexander,nika,negin
Enhancements for the embedded browser component in AboutWelcome:

- Improve the speed at which the browser starts by predicting the `remoteType` the load is going to finish in
- Set `maychangeremoteness` attribute to true to allow changing remoteness if user navigates to a different URL that requires this (such as an `about:` page, though with the current set up `about:` pages won't load for security reasons).
- Set `nodefaultsrc` attribute to true to avoid loading a default URL if `src` is blank

Differential Revision: https://phabricator.services.mozilla.com/D232425
2025-01-08 00:14:40 +00:00