Commit Graph

229 Commits

Author SHA1 Message Date
Alex Kontos
e7824895ad refactor: rename Firefox related references to their relevant counterparts 2025-11-03 16:04:55 +00:00
Beth Rennie
68961d822d Bug 1956080 - Use async experiment cleanup in browser_setDefaultBrowser.js a=RyanVM
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.

Original Revision: https://phabricator.services.mozilla.com/D251602

Differential Revision: https://phabricator.services.mozilla.com/D251907
2025-05-31 19:02:28 +00:00
Beth Rennie
6a0a362ee4 Bug 1956080 - Use async experiment cleanup in browser/components/shell r=nalexander,bhearsum
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.

Differential Revision: https://phabricator.services.mozilla.com/D250554
2025-05-22 21:45:56 +00:00
Daniel Thorn
127d08ec0b Bug 1959483 - Port tests from ExperimentFakes and ExperimentTestUtils to NimbusTestUtils in browser/components/shell r=nimbus-reviewers,beth
Differential Revision: https://phabricator.services.mozilla.com/D247016
2025-05-01 22:42:15 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
Eric Chen
192c0c6787 Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-19 20:41:18 +00:00
Beth Rennie
549fd892f5 Bug 1943119 - Remove ExperimentAPI._store r=nalexander,nimbus-reviewers,emcminn
ExperimentAPI._store used to create a new, separate ExperimentStore in
the child process until bug 1941948 (which was unnecessary) and now only
exists for vestigial reasons. Use ExperimentAPI._manager.store
everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D240414
2025-03-17 17:05:56 +00:00
Butkovits Atila
7f46417564 Backed out 2 changesets (bug 1947908, bug 1943119) for causing failures at browser_setDefaultPDFHandler.js. CLOSED TREE
Backed out changeset f605bd14b753 (bug 1947908)
Backed out changeset 6498ad43bb47 (bug 1943119)
2025-03-13 23:42:12 +02:00
Beth Rennie
eca22ee4e9 Bug 1943119 - Remove ExperimentAPI._store r=nalexander,nimbus-reviewers,emcminn
ExperimentAPI._store used to create a new, separate ExperimentStore in
the child process until bug 1941948 (which was unnecessary) and now only
exists for vestigial reasons. Use ExperimentAPI._manager.store
everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D240414
2025-03-13 15:52:44 +00:00
Cristina Horotan
bb136e0d12 Backed out changeset c7a895ce1e23 (bug 1950734) for causing bc failures at browser_processAUMID.js. CLOSED TREE 2025-03-13 07:31:36 +02:00
Eric Chen
3fa85c5c7a Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-12 23:45:49 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D221286
2024-09-06 10:08:18 +00:00
Dave Townsend
8814ffd2ef Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-13 14:13:10 +00:00
Nipun Shukla
72d8c3e995 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-12 17:05:47 +00:00
Narcis Beleuzu
bc91793ab3 Backed out changeset f0866652e65f (bug 1906260) for bc failure on /browser_startup_mainthreadio.js . CLOSED TREE 2024-08-09 12:33:45 +03:00
Dave Townsend
5d4ad37c57 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-08 19:35:41 +00:00
pstanciu
4aef4243c2 Backed out 3 changesets (bug 1794159) for causing bc failures on browser_browserGlue_telemetry.js CLOSED TREE
Backed out changeset 764e14e5df4a (bug 1794159)
Backed out changeset 76b8d6cebe8b (bug 1794159)
Backed out changeset f28a29199ba8 (bug 1794159)
2024-08-08 11:16:27 +03:00
Nipun Shukla
8ab6d14094 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-08 02:48:50 +00:00
Sandor Molnar
f5c1f4fe7c Backed out changeset 82cd657ce425 (bug 1906260) for causing mochitest failures @ test_interactive_widget.html & pup wd test failures CLOSED TREE 2024-08-06 18:06:20 +03:00
Dave Townsend
b3f84cff12 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-06 11:46:07 +00:00
Joel Maher
bd1a0e2de3 Bug 1909759 - s/preferences/settings/ for >= macosx 13.x. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D217835
2024-07-26 16:22:15 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Meg
8f07351683 Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel,negin
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
2024-07-03 14:41:46 +00:00
Tamas Szentpeteri
93f27874e0 Backed out changeset 50043205a8aa (bug 1905379) for causing mochitest failures on browser_download_preferred_action.js. CLOSED TREE 2024-07-02 19:20:10 +03:00
Meg
4c468ff89d Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
2024-07-02 12:57:53 +00:00
Meg Viar
212619a587 Bug 1903416 - Add a pref to control the display of set default guidance notification r=nrishel,negin
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Differential Revision: https://phabricator.services.mozilla.com/D214700
2024-06-24 20:50:38 +00:00
Barret Rennie
871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
2024-06-06 14:42:00 +00:00
Joel Maher
3318408dfe Bug 1898801 - Fix tests on mac which use python2 to use python3 on macosx 14.x+. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D211604
2024-05-24 19:45:19 +00:00
Nicholas Rishel
c38ebcec1e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-21 02:37:10 +00:00
Sandor Molnar
0f4b2c2a80 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel
2e90f2e33e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-20 18:49:11 +00:00
Barret Rennie
6dbf58c7e9 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-16 17:15:58 +00:00
Sandor Molnar
0881a06ac2 Backed out changeset c9a936171ae4 (bug 1790428) for causing bc failures @ browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js CLOSED TREE 2024-05-16 01:29:10 +03:00
Barret Rennie
eeaac588c8 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-15 19:19:29 +00:00
Cristian Tuns
fc78328f7f Backed out changeset 9db188aa6dac (bug 1790428) for causing bc failures in browser_remotesettingsexperimentloader_remote_defaults.js CLOSED TREE 2024-05-14 18:00:11 -04:00
Barret Rennie
58a50459f7 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-14 16:18:01 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Michael Hughes
0708cf0525 Bug 1863636 - mochi tests for filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll
Added in mochi tests to validate that the C++ filename validation for taskbar tab shortcut paths works.

Differential Revision: https://phabricator.services.mozilla.com/D199689
2024-01-29 22:26:21 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Michael Hughes
5ea9a03802 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-12-01 20:07:08 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Masatoshi Kimura
c2dc436126 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189678
2023-10-02 16:56:42 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00