Commit Graph

173 Commits

Author SHA1 Message Date
Brad Werth
e74ffd5c1b Bug 1461046 Part 4: Change PolygonShapeInfo to tolerate polygons with only 1 or 2 vertices. r=dholbert
MozReview-Commit-ID: ICcIUulgSCW
2018-05-22 15:54:21 -07:00
Brad Werth
efea470747 Bug 1461046 Part 3: Change RoundedBoxShapeInfo to tolerate empty rects. r=dholbert
MozReview-Commit-ID: FNQwXdeqfua
2018-05-18 17:38:41 -07:00
Brad Werth
c5c2747778 Bug 1461046 Part 1: Change EllipseShapeInfo to tolerate empty circles/ellipses and treat them as singular points/lines (possibly expanded by shape-margin). r=dholbert
MozReview-Commit-ID: 69VQiRjhtqA
2018-05-18 17:13:22 -07:00
Brad Werth
a925e8327a Bug 1464113 Part 1: Make ImageShapeInfo tolerate shapes that are shifted left or above their margin rects. r=dholbert
MozReview-Commit-ID: 9NuHsjQfLxP
2018-05-25 15:12:02 -07:00
Brad Werth
6bba34d1c2 Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
MozReview-Commit-ID: 5pxiK1oH7sn
2018-05-08 15:56:49 -07:00
Coroiu Cristina
617c8a343b Backed out 2 changesets (bug 1460041) for lint failure at /builds/worker/checkouts/gecko/tools/lint/wpt.yml on a CLOSED TREE
Backed out changeset 25c0ace5ecb4 (bug 1460041)
Backed out changeset 8f13ab5de9be (bug 1460041)
2018-05-11 01:25:08 +03:00
Brad Werth
064c7d4cf5 Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
MozReview-Commit-ID: 5pxiK1oH7sn
2018-05-08 15:56:49 -07:00
Coroiu Cristina
34300ac644 Backed out 2 changesets (bug 1460041) for linting failure at css/vendor-imports/mozilla/mozilla-central-reftests/shapes1 e.g. shape-outside-circle-056-ref.html on a CLOSED TREE
Backed out changeset b19f3977715c (bug 1460041)
Backed out changeset a1dbfe37baf3 (bug 1460041)
2018-05-10 20:15:58 +03:00
Brad Werth
4407595b6d Bug 1460041 Part 1: Correct PolygonShapeInfo constructor to measure its start and end block extents in margin rect space. r=jfkthame
MozReview-Commit-ID: 5pxiK1oH7sn
2018-05-08 15:56:49 -07:00
Brad Werth
bbc7810622 Bug 1459697 Part 2: Account for the possibility that EllipseShapeInfo may not generate an interval for the entire BStart() to BEnd() range, due to rounding error in the distance field calculation. r=dbaron
MozReview-Commit-ID: CYeBKhDYD1F

The distance field does not calculate a true Euclidean distance, so it is
unreasonable to require that the intervals span all of the BStart() to BEnd()
float area. The final block pixel may not generate an interval at all due to
rounding errors. This change makes accomodation for the rounding errors and
adds asserts to ensure we aren't tolerating errors outside the area of the
last block pixel.
2018-05-07 14:02:03 -07:00
Brad Werth
f7c06e2e67 Bug 1459697 Part 1: In EllipseShapeInfo distance field calculation, remove a warning that might trigger due to rounding error, and shorten the iteration of each block pixel row, when possible. r=dbaron
MozReview-Commit-ID: 6itpj3HBSRy
2018-05-08 11:11:47 -07:00
Brad Werth
a9214478bb Bug 1457602 Part 2: Correct shape-outside: image interval creation to correctly handle sideways-lr (with or without positive shape-margin.) r=jfkthame
MozReview-Commit-ID: F4fsRPajJfR
2018-05-03 15:51:06 -07:00
Brad Werth
0125bd25b7 Bug 1457602 Part 1: Correct shape-outside: image shape-margin calculation for vertical writing modes. r=jfkthame
MozReview-Commit-ID: ChUL66vUkHu
2018-04-30 17:01:24 -07:00
Chris Peterson
5d6b16ea3b Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Brad Werth
22329681a6 Bug 1451499 Part 3: Implement polygon for shape-margin > 0. r=jfkthame
MozReview-Commit-ID: BJtGaJBQMQr
2018-04-19 11:47:04 -07:00
Brad Werth
259a1af4cd Bug 1451499 Part 2: Stub in support for polygon with shape-margin == 0. r=jfkthame
MozReview-Commit-ID: 2biFnthoWin
2018-04-19 11:27:28 -07:00
Brad Werth
3ba6047dae Bug 1451499 Part 1: Uplift some interval methods from ImageShapeInfo to ShapeInfo. r=jfkthame
MozReview-Commit-ID: AMwujPuTeOm
2018-04-19 12:17:44 -07:00
Brad Werth
3103191e26 Bug 1457288 - Part 3: Change distance field sizes and indexes to be unsigned ints, avoiding undefined behavior with potential int overflows. r=mats 2018-04-30 12:25:13 -07:00
Brad Werth
c40dba0ee4 Bug 1457288 - Part 2: Clamp shape-margin distance field operands to prevent int multiplication overflow when allocating. r=mats 2018-04-27 18:10:51 -07:00
Brad Werth
1aba681806 Bug 1457288 - Part 1: Clamp EllipseShapeInfo distance field operands to the maximum shape-margin we are willing to compute. r=mats
MozReview-Commit-ID: IXAV0uaxB0R
2018-04-27 13:10:08 -07:00
Brad Werth
2807283c13 Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
MozReview-Commit-ID: 67vq9Gcr8qJ
2018-02-26 14:47:31 -08:00
Brad Werth
91c12e7873 Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
MozReview-Commit-ID: 4pjALPSIBhI
2018-04-17 11:39:50 -07:00
Brad Werth
cf7f6fcd0f Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
MozReview-Commit-ID: AEOksiuM0GJ
2018-04-13 11:29:14 -07:00
Brad Werth
92f94f4546 Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
MozReview-Commit-ID: G8qdPlnh8kY
2018-04-17 11:59:11 -07:00
Brad Werth
99177b8616 Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
MozReview-Commit-ID: CpuWWaLh1CX
2018-04-20 13:43:36 -07:00
Brad Werth
54e7c6fe32 Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
MozReview-Commit-ID: CovCfk5ryEn
2018-04-11 15:18:32 -07:00
Brad Werth
3723030669 Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
MozReview-Commit-ID: HeipoUTkqUE
2018-02-26 13:13:03 -08:00
Brad Werth
359ed0b705 Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
MozReview-Commit-ID: 1C9vB14Qhyj
2018-04-20 14:04:15 -07:00
Brad Werth
a9d6529a1b Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
MozReview-Commit-ID: 4xqfqWB78Oh
2018-02-22 11:11:03 -08:00
Brad Werth
b126f691ee Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
MozReview-Commit-ID: 2gVRyQtd7Io
2018-03-12 17:04:34 -07:00
Brad Werth
74132a44cd Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
MozReview-Commit-ID: LnzQPsSBVqY
2018-02-28 10:43:43 -08:00
Brad Werth
8711333a2d Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
MozReview-Commit-ID: BxJxIU0RVAo
2018-04-11 14:05:06 -07:00
Narcis Beleuzu
87b92a12ca Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3dafe4b (bug 1265342)
Backed out changeset 9b200122014e (bug 1265342)
Backed out changeset a90aa063b2fd (bug 1265342)
Backed out changeset 0791ff3d9194 (bug 1265342)
Backed out changeset 7109288f10b3 (bug 1265342)
Backed out changeset 048cce2fb99f (bug 1265342)
Backed out changeset c8e3dbc6c729 (bug 1265342)
Backed out changeset 09da0968333a (bug 1265342)
Backed out changeset d16f7ff85677 (bug 1265342)
Backed out changeset 53eb7f14463d (bug 1265342)
Backed out changeset 64fc631ef122 (bug 1265342)
Backed out changeset 332382c708e1 (bug 1265342)
Backed out changeset a8695981eec0 (bug 1265342)
Backed out changeset ce473fa5f1f4 (bug 1265342)
Backed out changeset 5ee470e75a53 (bug 1265342)
Backed out changeset 802aa95a52d9 (bug 1265342)
Backed out changeset 5da0c34c9600 (bug 1265342)
2018-04-24 22:31:15 +03:00
Brad Werth
f69bf8b958 Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
MozReview-Commit-ID: 67vq9Gcr8qJ
2018-02-26 14:47:31 -08:00
Brad Werth
c26c445b0a Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
MozReview-Commit-ID: 4pjALPSIBhI
2018-04-17 11:39:50 -07:00
Brad Werth
611a055050 Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
MozReview-Commit-ID: AEOksiuM0GJ
2018-04-13 11:29:14 -07:00
Brad Werth
d9819b00a3 Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
MozReview-Commit-ID: G8qdPlnh8kY
2018-04-17 11:59:11 -07:00
Brad Werth
4b4cbbf6d9 Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
MozReview-Commit-ID: CpuWWaLh1CX
2018-04-20 13:43:36 -07:00
Brad Werth
e83cbdb4d4 Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
MozReview-Commit-ID: CovCfk5ryEn
2018-04-11 15:18:32 -07:00
Brad Werth
f9764e14e4 Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
MozReview-Commit-ID: HeipoUTkqUE
2018-02-26 13:13:03 -08:00
Brad Werth
a508f00b3d Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
MozReview-Commit-ID: 1C9vB14Qhyj
2018-04-20 14:04:15 -07:00
Brad Werth
fc043ffbd8 Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
MozReview-Commit-ID: 4xqfqWB78Oh
2018-02-22 11:11:03 -08:00
Brad Werth
58233fa194 Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
MozReview-Commit-ID: 2gVRyQtd7Io
2018-03-12 17:04:34 -07:00
Brad Werth
bf970f6070 Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
MozReview-Commit-ID: LnzQPsSBVqY
2018-02-28 10:43:43 -08:00
Brad Werth
31704ece62 Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
MozReview-Commit-ID: BxJxIU0RVAo
2018-04-11 14:05:06 -07:00
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Ting-Yu Lin
3593258ca0 Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00
Ryan VanderMeulen
93ffd60378 Backed out 11 changesets (bug 1404222) for static analysis failures on a CLOSED TREE.
Backed out changeset a6a99136300c (bug 1404222)
Backed out changeset 7183b8104399 (bug 1404222)
Backed out changeset a1e4294c1c59 (bug 1404222)
Backed out changeset b79d6e8318db (bug 1404222)
Backed out changeset 0450620fdabd (bug 1404222)
Backed out changeset 026c74a92d04 (bug 1404222)
Backed out changeset 50ac4167f702 (bug 1404222)
Backed out changeset 59038f2db68a (bug 1404222)
Backed out changeset f6b9096da915 (bug 1404222)
Backed out changeset 4e0baffdd79b (bug 1404222)
Backed out changeset 57eeb849ab88 (bug 1404222)
2018-04-02 17:57:27 -04:00
Ting-Yu Lin
14acc00a84 Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00