Commit Graph

483 Commits

Author SHA1 Message Date
Norisz Fay
e7039bb6db Backed out 3 changesets (bug 1784369, bug 1784242) for causing node newtab failures CLOSED TREE
Backed out changeset f19a8a76a85b (bug 1784242)
Backed out changeset 0722fc4bb4fa (bug 1784242)
Backed out changeset 2d4131b0ca28 (bug 1784369)
2022-08-16 03:19:32 +03:00
Daisuke Akatsuka
a42205a33c Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154483
2022-08-15 23:45:32 +00:00
Daisuke Akatsuka
7e4536e9fd Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-08-01 00:27:50 +00:00
Butkovits Atila
fe05967e94 Backed out 2 changesets (bug 1776609) for causing failures at browser_topsites_annotation.js. CLOSED TREE
Backed out changeset cac795fd16d2 (bug 1776609)
Backed out changeset 88ec1cca8540 (bug 1776609)
2022-08-01 00:52:35 +03:00
Daisuke Akatsuka
63fc1e0ed5 Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-07-31 20:26:30 +00:00
Butkovits Atila
efbdfe270f Backed out 2 changesets (bug 1776609) for causing gtest failures. CLOSED TREE
Backed out changeset 7630fea97777 (bug 1776609)
Backed out changeset 426cbe0fac73 (bug 1776609)
2022-07-29 13:42:33 +03:00
Daisuke Akatsuka
e6ed592635 Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-07-29 09:24:28 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Kagami Sascha Rosylight
4fb733cb3b Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D148939
2022-06-27 20:31:34 +00:00
Dão Gottwald
f453703731 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149367
2022-06-17 07:56:26 +00:00
Butkovits Atila
246c21a815 Backed out changeset df17ec7a8095 (bug 1774377) for causing assertion failures at ErrorResult.h. CLOSED TREE 2022-06-16 01:20:24 +03:00
Dão Gottwald
ff2e859367 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149367
2022-06-15 21:34:44 +00:00
Tom Schuster
214369e07f Bug 1738694 - Pass around hasValidUserGestureActivation and fromExternal when opening links from the UI or command-line. r=Gijs,edgar
Differential Revision: https://phabricator.services.mozilla.com/D147515
2022-06-15 19:01:02 +00:00
Calixte
9eafb7c7a0 Bug 1766030 - Add an optional source URL when saving an URL. r=Gijs
In pdf.js, files are saved thanks to a blob but the original URL is lost.
Consequently, the download panel doesn't contain any information about the
origins of a saved pdf.
The saveURL, internalSave and nsITransfer.init functions has now a parameter for this originalURL.

Differential Revision: https://phabricator.services.mozilla.com/D147651
2022-05-31 17:25:29 +00:00
Dão Gottwald
365511d874 Bug 1766896 - Redirect attempts to load something else in the Firefox View tab to new tabs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D145613
2022-05-10 22:16:45 +00:00
Julien Wajsberg
2dea2aabe0 Bug 1639716 - [utilityOverlay] Provide a callback in openLinkIn to report when a content browser is created r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133375
2022-01-26 17:26:22 +00:00
Julien Wajsberg
81a07b0709 Bug 1745208 - [utilityOverlay] Add a new parameter "forceNonPrivate" to openLinkIn r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133378
2022-01-26 17:26:20 +00:00
Julien Wajsberg
a0311c9aa8 Bug 1745208 - [utilityOverlay] Make getTopWin take an option parameter r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133376
2022-01-26 17:26:19 +00:00
Gijs Kruitbosch
17c9c06a19 Bug 1742801 - do not consume the user gesture from ClickHandlerChild if ClickHandlerParent will ignore the click anyway, r=edgar
This commit does a couple of things:
- move whereToOpenLink and getRootEvent implementations into BrowserUtils,
  so they can be used from the child process.
- forward callers in utilityOverlay.js to the BrowserUtils ones
  (bug 1742889 will get rid of the forwarding and update all the callers;
   we might be able to get this and bug 1739929 into beta if risk is low
   enough, and touching a bunch of extra files really doesn't help with
   that)
- move the lazy-load of BrowserUtils from browser.js to utilityOverlay.js
  This is safe because everywhere that loads browser.js also loads
  utilityOverlay.js. It's needed because there are some places that use
  utilityOverlay.js but not browser.js, and so now they need access to
  BrowserUtils.jsm.
- use whereToOpenLink to determine if we should avoid consuming the transient
  user gesture activation in the child click handling code.
- add an automated test based on the testcase in the bug.

When working on this, I initially put the check using whereToOpenLink in
the toplevel of the function, and then when I ran places test to check that
I hadn't broken any places consumers of whereToOpenLink or getRootEvent,
realized that I had broken `browser_markPageAsFollowedLink.js`, because it
relies on "normal" (ie no modifier key, left button) link clicks making it
to ClickHandlerParent.jsm . I filed bug 1742894 about this. I've not tried
to fix that here, instead I've tried to ensure that paths through this
function are as untouched as possible while still fixing bug 1739929 and
bug 1742801.

Differential Revision: https://phabricator.services.mozilla.com/D132102
2021-11-25 22:49:00 +00:00
Drew Willcoxon
46aaa1fbb8 Bug 1731104 - Null check browser.contentDocument when highlighting a section in a lazy about:preferences tab. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D125856
2021-09-16 18:12:57 +00:00
Dão Gottwald
0bee206180 Bug 1731061 - Remove obsolete sync-pane-loaded observer from openPreferences. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D125827
2021-09-16 16:06:00 +00:00
Drew Willcoxon
191e4aff78 Bug 1730702 - When switching to an already open but lazy/unloaded about:preferences tab and highlighting a section in it, wait for it to load first. r=dao
When switching to an already open but lazy/unloaded about:preferences tab and
highlighting a section in it, wait for it to load first.

Differential Revision: https://phabricator.services.mozilla.com/D125628
2021-09-15 15:01:37 +00:00
Gijs Kruitbosch
c43492bf27 Bug 1512851 - tidy up file menu popup event handling, r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D120636
2021-07-26 12:22:37 +00:00
Gijs Kruitbosch
5fc277252a Bug 1712840 - fix new tab context menu 'no container' entry so it actually works, and add tests, r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D116142
2021-05-27 18:44:19 +00:00
Daisuke Akatsuka
5de8384d78 Bug 1710289: Avoid pasting the content of clipboard to urlbar upon clicking on new tab button and tab bar. r=masayuki,adw
Differential Revision: https://phabricator.services.mozilla.com/D114700
2021-05-11 04:58:40 +00:00
Markus Stange
2444e8909a Bug 1704948 - Remove onclick handlers from menuitems, because menuitems now dispatch command events even on middle click. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112046
2021-04-20 17:44:17 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-20 17:44:16 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
4906af56a7 Bug 1704948 - Remove onclick handlers from menuitems, because menuitems now dispatch command events even on middle click. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112046
2021-04-14 21:23:28 +00:00
Markus Stange
7f0c1757af Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-14 21:23:27 +00:00
Emilio Cobos Álvarez
3e3101a57b Bug 1703289 - Make mixed content blocker use a session-persistent permission rather than ad-hoc code. r=ckerschb,smaug
This is more fission-compatible, and a lot simpler.

Differential Revision: https://phabricator.services.mozilla.com/D111480
2021-04-12 18:04:12 +00:00
Mike Conley
09f7764241 Bug 1690573 - Migrate the report-site-issue UI access point to the Help menu. r=denschub,mixedpuppy,fluent-reviewers,webcompat-reviewers,flod
We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it _is_ the right spot, we'll
probably do something a little more self-contained, and less hacky.

I'm leaving the old .properties file just in case we change our mind here.
Yes, we'll want to port to Fluent anyways, but our ultimate choice of where
we put this thing is probably going to dictate where the string lives.

Differential Revision: https://phabricator.services.mozilla.com/D104832
2021-02-23 00:11:05 +00:00
Emma Malysz
e2150da0fa Bug 1690858: add safemode toggle to help menu r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D104747
2021-02-16 16:51:45 +00:00
Bernard Igiri
2201d256a1 Bug 1691433 - Remove check for updates option from application menus r=mconley,jaws,fluent-reviewers
Removing Check For Updates button from menu.

Differential Revision: https://phabricator.services.mozilla.com/D104548
2021-02-10 17:39:14 +00:00
Mike Conley
08ae3982d7 Bug 1689632 - Simplify the Help menu a bit. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D103489
2021-02-01 15:31:30 +00:00
Bernard Igiri
43e8d2bc1c Bug 1660848 - Add a check for updates option to application menus r=fluent-reviewers,jaws,harry,Gijs,flod,mkaply
Adding a check for updates option to the application menu, changing the about dialog styling to match the mockup, and adding a minimum delay to the checking for updates message.

Differential Revision: https://phabricator.services.mozilla.com/D95195
2021-01-15 14:26:58 +00:00
Bogdan Tara
a1eb81316f Backed out changeset 8dc3f02e20ca (bug 1660848) for multiple mochitest failures CLOSED TREE 2021-01-12 03:22:03 +02:00
Bernard Igiri
9fd6b8d74d Bug 1660848 - Add a check for updates option to application menus r=fluent-reviewers,jaws,harry,Gijs,flod,mkaply
Adding a check for updates option to the application menu, changing the about dialog styling to match the mockup, and adding a minimum delay to the checking for updates message.

Differential Revision: https://phabricator.services.mozilla.com/D95195
2021-01-11 22:37:05 +00:00
Tim Huang
b77a2550da Bug 1679325 - Part 1: Making contentAreaUtils.saveURL to accept cookieJarSettings. r=smaug
This patch makes the contentAreaUtils.saveURL to be aware of the
cookieJarSettings, and updates all callers.

This also updates the documentation of the persistArgs
'cookieJarSettings' for internalPersist().

Differential Revision: https://phabricator.services.mozilla.com/D98455
2020-12-03 20:10:36 +00:00
Daisuke Akatsuka
e31e1f90f1 Bug 1641287: Focus on browser after keyup. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D92561
2020-10-26 05:30:44 +00:00
Dão Gottwald
6611cd5483 Bug 1667882 - Allow about:crashcontent to load in a pinned tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D92034
2020-10-01 09:46:13 +00:00
Scott
29f673c538 Bug 1667645 - fixing ctrl+click newtab link clicks focus issue r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91877
2020-09-30 13:50:09 +00:00
Rob Wu
e27ed45f5c Bug 1657992 - Handle middle-click on long-press backForwardMenu only once + tests r=dao
Differential Revision: https://phabricator.services.mozilla.com/D86784
2020-08-12 14:50:42 +00:00
Kris Maglione
31bcef7913 Bug 1580764: Part 2 - Use BrowsingContext IDs rather than window IDs to compute frame IDs. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D82464
2020-07-07 21:37:53 +00:00
Jared Wein
966191117f Bug 1638683 - When opening a PDF internally, the new tab should appear adjacent to the opening tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75818
2020-05-20 14:28:04 +00:00
Jared Wein
a2d6820b31 Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.

Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 05:59:43 +00:00
Narcis Beleuzu
c37b02ed23 Backed out 9 changesets (bug 773942) for xpcshell failure on test_getMIMEInfo_pdf.js
Backed out changeset 6fb0f25b2f5d (bug 773942)
Backed out changeset 27e9fe03a549 (bug 773942)
Backed out changeset ee0ecad5e90a (bug 773942)
Backed out changeset df062e14287b (bug 773942)
Backed out changeset 7da06239ccfb (bug 773942)
Backed out changeset dfedbeeaec66 (bug 773942)
Backed out changeset 286e1be9dc46 (bug 773942)
Backed out changeset f4df0a553bc0 (bug 773942)
Backed out changeset 97f3b96b6be0 (bug 773942)
2020-05-16 08:37:53 +03:00