Commit Graph

130 Commits

Author SHA1 Message Date
mozilla.mano@sent.com
e69c734256 More UI-parity pieces for places-bookmarks. Changes include: 1) Implement New Bookmark and New Livemark commands and UI using the shared bookmark properties dialog (bug 365102). 2) Make New Folder command use the shared dialog as well. 3) Show dialog when adding a live-bookmark (bug 332965). 4) Hide most fields when adding a bookmark using 'Bookmark This Page...'. 5) defualt titles for each item type (bookmark/folder/livemark). 6) Changing the uri of a bookmark is now undoable. 7) Tidy up and document the dialog pseudo-API. patch on bug 357316, r=dietrich. 2007-03-05 22:39:21 +00:00
mozilla.mano@sent.com
df6c0b0bc8 Copy the feed-uri rather than the site-uri when copying a live bookmark, patch on bug 342381. r=sspitzer. 2007-03-05 19:47:55 +00:00
mozilla.mano@sent.com
a84b64adea Bug 371668 - Disabled properties context menu-item for bookmarked history items. r=dietrich. 2007-02-26 14:09:53 +00:00
dietrich@mozilla.com
16945b9b5a Bug 360133 Bookmarks must be internally uniquely identifiable (r=mano, sspitzer) 2007-02-26 00:54:36 +00:00
mozilla.mano@sent.com
7a14453283 Bug 370959 - places frontend code cleanup. r=sspitzer. 2007-02-20 00:51:31 +00:00
mozilla.mano@sent.com
51b12d5aac Bug 364644 - Re-enable livemark-reload functionality. r=sspitzer. 2007-02-19 20:12:25 +00:00
jminta@gmail.com
0ad7ed7d63 Bug 370329 Only do batch transactions when we really have a lot of transactions, r=mano 2007-02-14 02:08:26 +00:00
mozilla.mano@sent.com
524b4e099e Bug 366372 - 'Get Info' (Properties) command should be disabled for items under a live-bookmark folder. r=sspitzer. 2007-02-13 22:11:35 +00:00
mozilla.mano@sent.com
bc032aadca Bug 369407 - Make the history sidebar use the shared places context menu. As part of that: 1) Add context menu for multiple-items selection 2) Remove the Expand/Collapse menu-item. 3) Replace the 'Copy Link Location' menu-item with the generic 'Copy' menu-item, which also copies the node title. r=sspitzer, ui-r=mconnor. 2007-02-09 22:17:37 +00:00
mozilla.mano@sent.com
98ae5f1ec9 Copy the security checks for history items to placescontroller/utils, r=sspitzer (patch on bug 362292). 2007-02-05 20:38:52 +00:00
mozilla.mano@sent.com
1406dc11b2 Bug 369311 - Typo in buildSelectionMetadata breaks the places context menu in certain conditions. r=gavin. 2007-02-05 00:28:27 +00:00
mozilla.mano@sent.com
fe48e2b8b0 Bug 369222 - Javascript error when opening the context menu for the empty area (i.e. root node) in the places toolbar. r=sspitzer. 2007-02-04 19:23:00 +00:00
mozilla.mano@sent.com
8259e9beaf Bug 342381 - Copying a live bookmark should put the feed url on the clipboard. r=sspitzer. 2007-01-31 02:40:18 +00:00
mozilla.mano@sent.com
3fda44e9f3 Bug 367989 - metadata about node annotations is no longer set for uri nodes. r=sspitzer. 2007-01-25 18:52:15 +00:00
mozilla.mano@sent.com
839c6fb1c0 Bug 367187 - Places context menu fx2-parity. r=sspitzer. 2007-01-21 23:22:52 +00:00
mozilla.mano@sent.com
2e9f80a1fa Bug 365538 - 'Move Bookmark(s)' UI in Places Organizer. r=sspitzer. 2007-01-09 23:00:23 +00:00
mozilla.mano@sent.com
069f8865b1 Bug 366474 - rootNodeIsSelected is not reliable for the menu view. r=sspitzer. 2007-01-09 22:48:50 +00:00
mozilla.mano@sent.com
b7b2abd58d Bug 366372 - 'Get Info' (properteis) should be disabled for items under a live-bookmark folder. r=sspitzer. 2007-01-08 23:54:05 +00:00
mozilla.mano@sent.com
dba3807e3e Bug 366174 - Open in Tabs context menu item is enabled for empty folders. r=sspitzer. 2007-01-08 23:03:20 +00:00
mozilla.mano@sent.com
38fb49daf6 Bug 366027 - Redo command is broken once a remove-separator command is undone. r=sspitzer. 2007-01-07 00:46:55 +00:00
mozilla.mano@sent.com
8d8d5714db Bug 365981 - Places XUL cleanup. r=sspitzer. 2007-01-05 11:45:15 +00:00
mozilla.mano@sent.com
42b3849c26 Bug 365171 - Bug context menu delete of personal toolbar bookmark can delete history item if focused. r=sspitzer. 2006-12-28 22:56:59 +00:00
mozilla.mano@sent.com
fc466d37c2 Use the right array lenght in the fix for bug 365100. 2006-12-28 21:26:11 +00:00
mozilla.mano@sent.com
b89d15aff9 Bug 365100 - 'Open in Tabs' doesn't work in the left pane of the organizer. r=sspitzer. 2006-12-27 21:03:02 +00:00
mozilla.mano@sent.com
91c8a3694d Bug 334451 - Places Organizer: places-list tree should not list bookmark items. This also fixes the selectBookmark dialog bustage from bug 359462. r=sspitzer. 2006-12-27 00:36:35 +00:00
mozilla.mano@sent.com
5090482a0b Bug 329949 - browser.tabs.loadBookmarksInBackground is ignored in places views (histrory sidebar, bookmarks toolbar etc.). r=sspitzer. 2006-12-26 20:26:38 +00:00
mozilla.mano@sent.com
13e510775c Bug 365002 - newFolder/Separator methods should not try to focus the controller's view. r=sspitzer. 2006-12-26 01:57:23 +00:00
mozilla.mano@sent.com
a3c265afa8 Bug 336990 - Choosing delete on bookmarks toolbar deletes everything there indeed (this should only affect --enable-places-bookmarks builds). r=sspitzer. 2006-12-26 01:54:51 +00:00
mozilla.mano@sent.com
ae249d6363 Bug 359462 - Redesign PlacesController interaction with places views (this makes various edit command work in the places-based history sidebar). r=sspitzer. 2006-12-22 00:00:21 +00:00
sayrer@gmail.com
26466b1192 Bug 358946. Let the places unit tests pass. r=sspitzer,mano 2006-12-14 17:28:52 +00:00
sspitzer@mozilla.org
69152cc1c4 fix for bug #356487
make MOZ_PLACES (if enabled) only build the places based history UI, use MOZ_PLACES_BOOKMARKS to turn off the places based bookmarks UI.

also addresses bugs:

bug #330923:  "View -> Sidebar menu" is empty if you build with places
bug #355738:  implement history sidebar on top of places backend
bug #356175:  hook up the history menu to the places backend
bug #356453:  add back "Clear Private Data" menu item
bug #356630:  add back "History | Show in Sidebar" menu item
bug #356631:  remove "search in history" and "view all history" menu items
bug #357301:  add back history and bookmark sidebar toolbar button items, remove places toolbar button
bug #358831:  history sidebar, right mouse button click should not expand / collapse item

r=dietrich, r=gavin
2006-11-04 04:48:06 +00:00
sayrer@gmail.com
2a26d2a997 Bug 353434. Remove C++ feed parsing for livemarks on trunk (places). r=dietrich 2006-10-19 02:24:30 +00:00
sspitzer@mozilla.org
3ace61eb1d fix for bug #342930: "You have asked to open [lots of] tabs at once" should read "You are about to open..."
backporting the fix from the MOZILLA_1_8_BRANCH to work on the trunk (both with places enabled and without)

r=dietrich, original patch r=mconnor, ui-r=beltzner
2006-10-10 23:19:01 +00:00
pkasting@google.com
44be00e75e Bug 321973: Make "Bookmark This Link" work.
r=jhughes
sr=beng
2006-09-01 00:33:23 +00:00
gavin@gavinsharp.com
4a4c398bd4 Bug 346447: loadFolderAndReplace=false ignores "loading" tabs, patch by Pablo Greco <pablo@fliagreco.com.ar>, r=mano 2006-08-07 23:01:32 +00:00
sspitzer@mozilla.org
c2cd568443 fix for bug #344040: when warning on "opening too many tabs", only count non-deleted bookmarks (and not folders or separators)
r=ben
2006-07-22 06:52:51 +00:00
gavin@gavinsharp.com
0e7705fbc2 Bug 343958: fix strict warnings in controller.js, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie 2006-07-10 22:48:48 +00:00
sspitzer@mozilla.org
fb3d3df0d6 fix for bug #340966, regression, "node QI Failed When middle clicking a bookmark"
also address another scenario of bug #333734, "Protect against opening too many tabs at once"

r=ben
2006-06-15 22:58:34 +00:00
sspitzer@mozilla.org
d9ac39ac46 supplimental checkin for bug #333734, protect (warn) against opening too many tabs at once. ugh. 2006-06-09 08:04:10 +00:00
sspitzer@mozilla.org
adc09813b2 follow-up checkin for #333734, fix coding style per ben. 2006-06-09 07:58:20 +00:00
sspitzer@mozilla.org
75cafa7bd2 fix for bug #333734. protect (warn) against opening too many tabs at once.
r=ben, UI and strings r=beltzner
2006-06-09 07:53:12 +00:00
myk@mozilla.org
90319e8e33 Initial support for microsummaries via a service and integration into the bookmarks UI.
bug=334471
r=brettw
a=ben for the branch
2006-05-05 22:45:37 +00:00
beng@bengoodger.com
abc0a6ad91 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com 2006-04-19 03:34:26 +00:00
joe@retrovirus.com
86537d8dcf Removes the history item mode for the (Bookmark) Properties dialog, which
just showed disabled title and URI fields.  The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.

bug=330876
r/sr=ben@mozilla.org
2006-04-18 01:49:10 +00:00
beng@bengoodger.com
48e735a443 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces) 2006-04-13 22:49:02 +00:00
joe@retrovirus.com
0309b67e0d Resubmitting this patch, which adds a editing for livemark URIs as well
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org
2006-04-13 17:19:18 +00:00
brettw@gmail.com
5ecb856b5b Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks" 2006-04-13 16:40:06 +00:00
gavin@gavinsharp.com
d2aac97f1d Bug 332888: JS warning: variable folderId hides argument, r=ben 2006-04-12 18:23:32 +00:00
beng@bengoodger.com
b2ef5c0b5f 329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com 2006-04-10 19:26:01 +00:00
joe@retrovirus.com
17192e1480 Backing out patch from bug 330063 to see if it's responsible for the
branch balsa allocation increases, and if so, fix before resubmitting.
2006-04-08 17:58:16 +00:00