Commit Graph

81 Commits

Author SHA1 Message Date
Sarah Clements
39bf719fce Bug 1909843 - Vertical tab fixes r=tabbrowser-reviewers,desktop-theme-reviewers,dao
* Fix rule to show favicon when icons are missing
* Fix typo name change that affects unpinning tabs
* Fix padding issue for arrowscrollbox that affects alignment

Differential Revision: https://phabricator.services.mozilla.com/D218052
2024-08-06 14:48:27 +00:00
Jeremy Swinarton
535307654a Bug 1908873: THP appears as tooltip to accessibility tools r=dwalker,accessibility-frontend-reviewers,ayeddi,tabbrowser-reviewers,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D217631
2024-08-06 14:44:44 +00:00
Anna Yeddi
f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-08-06 13:51:06 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D164982
2024-08-05 17:49:06 +00:00
Dão Gottwald
5cc15d0779 Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218204
2024-08-05 09:25:19 +00:00
Marco Bonardo
75273bd99e Bug 1910901 - Perma timeout in browser_tab_preview.js due to prefs unsetting. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218303
2024-08-01 16:27:01 +00:00
DJ
89ad94eb74 Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 18:47:41 +00:00
DJ
a96bf7ac85 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 18:47:40 +00:00
Sandor Molnar
2e5df25263 Backed out 2 changesets (bug 1906123, bug 1902619) for causing bc failures @ @ browser_thumbnails_bg_basic.js CLOSED TREE
Backed out changeset d64bfab9a514 (bug 1902619)
Backed out changeset 5bbb9dd95c0e (bug 1906123)
2024-07-31 21:29:58 +03:00
DJ
7ae78e601d Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 17:30:23 +00:00
DJ
db52857c68 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 17:30:22 +00:00
Dão Gottwald
95d5536b2f Bug 1910576 - tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode. r=tabbrowser-reviewers,dwalker
Borrowed from https://phabricator.services.mozilla.com/D218052

Differential Revision: https://phabricator.services.mozilla.com/D218185
2024-07-31 15:18:09 +00:00
Dão Gottwald
0ca3183451 Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-31 09:12:40 +00:00
Butkovits Atila
81e0c9fdb0 Backed out changeset a99be1c64226 (bug 1910601) for causing failures at browser_multiselect_tabs_reorder.jS. 2024-07-30 23:29:04 +03:00
Dão Gottwald
ccbd151e5e Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-30 17:19:04 +00:00
Dão Gottwald
57b3a833e4 Bug 1908162 - Basic Tab Group custom element. r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217980
2024-07-30 14:57:41 +00:00
Jeremy Swinarton
416bd4c2b9 Bug 1879103: Update THP on tab change r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217829
2024-07-30 14:47:24 +00:00
Stuart Colville
a6dc7c69d9 Bug 1880138 - Filter Fx View from AllTabs hidden tabs UI. r=fxview-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D217809
2024-07-29 12:13:55 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D217700
2024-07-26 20:31:03 +00:00
Jeremy Swinarton
088315a50d Bug 1902252: Screenshot size respects devicePixelRatio r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,cmkm
Differential Revision: https://phabricator.services.mozilla.com/D217459
2024-07-25 15:03:13 +00:00
Jeremy Swinarton
0fef333b99 Bug 1908666: Prevent THP from opening when other panel is animating r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217168
2024-07-23 18:39:43 +00:00
timw-dev
139987ebda Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D216357
2024-07-23 17:07:39 +00:00
Nika Layzell
0c56f81d86 Bug 1834864 - Select BCG more consistently during COOP+COEP process switches, r=smaug,tabbrowser-reviewers,mak
Previously it was possible to bypass specific BCG selection based on
cross-origin isolated status if the site was allowed to load file URIs
using enterprise policies, which could lead to a crash.

This patch changes the behaviour such that BCG selection now happens
correctly. The site will still not be cross-origin isolated due to being
loaded into a file content process.

Differential Revision: https://phabricator.services.mozilla.com/D217007
2024-07-19 14:38:20 +00:00
Jeremy Swinarton
cd42d69cab Bug 1889880: temporarily cancel tab hover UI delay when leaving tabstrip r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209167
2024-07-18 17:01:32 +00:00
Jeremy Swinarton
60a488c0ba Bug 1907717: Fix contextmenu tests to run on 130 beta r=dwalker,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D216876
2024-07-18 16:19:42 +00:00
DJ
519ee01824 Bug 1876558 - deactivate tab preview when urlbar receives input. r=tabbrowser-reviewers,dao,urlbar-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D214870
2024-07-17 20:37:36 +00:00
Jeremy Swinarton
5215ca95dd Bug 1903042: THP popups show immediately after closing other panels r=dwalker,mconley
Differential Revision: https://phabricator.services.mozilla.com/D215809
2024-07-17 19:00:24 +00:00
Meg Viar
76dd97ec96 Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-15 13:49:33 +00:00
Jeremy Swinarton
93f2268504 Bug 1899556: Disable THP when app in background r=dwalker,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D216205
2024-07-12 21:39:42 +00:00
Stanca Serban
832439e884 Backed out changeset eec38ebb419b (bug 1876558) for causing mochitests failures in browser_tab_preview.js. CLOSED TREE 2024-07-12 21:57:33 +03:00
DJ
8325a8a7aa Bug 1876558 - deactivate tab preview when urlbar receives input. r=tabbrowser-reviewers,dao,urlbar-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D214870
2024-07-12 17:01:23 +00:00
Sandor Molnar
0aa78a67c5 Backed out changeset bccc4faa349a (bug 1904630) for causing bc perma failures @ browser/components/extensions/test/browser/browser_ext_menus.js CLOSED TREE 2024-07-12 18:55:26 +03:00
Meg Viar
ca1ff96b3d Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-12 13:53:00 +00:00
jlvivero
1cc313284f Bug 1882655 cache startup time value by calling it in the initialize function, update remove intermediate variable and fix typo, move getting startuptime to tabs.js r=tabbrowser-reviewers,sfoster,dao
Differential Revision: https://phabricator.services.mozilla.com/D215032
2024-07-10 15:55:06 +00:00
Tooru Fujisawa
773b93404f Bug 1081542 - Part 8: Add tests. r=smaug,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D201936
2024-07-10 06:16:55 +00:00
Tooru Fujisawa
5903c49a48 Bug 1081542 - Part 1: Add nsIBrowserDOMWindow.OPEN_NEWTAB_FOREGROUND. r=smaug,geckoview-reviewers,Gijs,amejiamarmol,tabbrowser-reviewers,dao
Given meta/ctrl key should use browser.tabs.loadInBackground pref instead of
browser.tabs.loadDivertedInBackground pref, the existing
nsIBrowserDOMWindow.OPEN_NEWTAB behavior doesn't match the requirement.

Add dedicate flag for "open in foreground tab" to make it controllable from
nsWindowWatcher::IsWindowOpenLocationModified.

Differential Revision: https://phabricator.services.mozilla.com/D201929
2024-07-10 06:16:52 +00:00
Tamas Szentpeteri
79cd189012 Backed out changeset ab233ce47da1 (bug 1904630) for causing mochitest failures on browser_ext_contextMenus.js. CLOSED TREE 2024-07-09 18:23:08 +03:00
Nikki Sharpley
db8bc399ee Bug 1893656 - Fix vertical tabs drag and drop r=sidebar-reviewers,tabbrowser-reviewers,dao,Gijs
- fix animation of drag and drop
- fix dragging to new window
- add tests for vertical tabs drag and drop

Differential Revision: https://phabricator.services.mozilla.com/D213237
2024-07-09 13:22:55 +00:00
Meg Viar
b81abef302 Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215429
2024-07-09 13:16:13 +00:00
David P
0606c1c950 Bug 1893119: Part 5 - Fix coordinates use in dispatchDOMEventViaPresShellForTesting r=masayuki,mconley,places-reviewers,tabbrowser-reviewers,dao
Since we now add the widget to the event in
dispatchDOMEventViaPresShellForTesting, WidgetGUIEvents that are sent in
mochitests via that method need to transform their screen coordinates by
nsIWidget::WidgetToScreenOffset, to mirror the transformation by
BrowserParent::TransformParentToChild that they don't get because they
skip the parent process.

This exposes a bunch of things that were done to work around this bug.  They
are cleaned up here.

Differential Revision: https://phabricator.services.mozilla.com/D211068
2024-07-04 07:48:04 +00:00
Jeremy Swinarton
5b1962c93d Bug 1900749: THP shows correct URL in reader mode r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215545
2024-07-03 13:52:34 +00:00
Amy Lee
0be4c4335f Bug 1902430 - Update strings for close duplicate tabs in tab overview menu. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D214455
2024-07-02 18:56:44 +00:00
DJ
8a72f7671e Bug 1900867 - dismiss tab preview when tab select occurs. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215506
2024-07-02 15:23:08 +00:00
DJ
c65aeb08e6 Bug 1899566 - only rollup tab preview on wheel if tabs overflow. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215260
2024-07-02 13:59:45 +00:00
Tom Schuster
b558a0cc09 Bug 1900381 - Remove (direct) mainPopupset onpopupshowing inline event handlers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213940
2024-07-01 08:10:00 +00:00
Cristian Tuns
49bd8e8edd Backed out changeset 6ac47dbd939c (bug 1884970) for causing bc failures in browser_tab_tooltips.js CLOSED TREE 2024-06-28 15:23:44 -04:00
Anna Yeddi
f0d91c0df0 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 18:23:45 +00:00
Cristian Tuns
29b9dc4717 Backed out changeset 87d3cf2b45b2 (bug 1884970) for causing bc failures in browser_multiselect_tabs_close.js CLOSED TREE 2024-06-28 14:15:24 -04:00
Anna Yeddi
9bcc35ccaa Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-06-28 17:19:31 +00:00