Commit Graph

198 Commits

Author SHA1 Message Date
Kelly Cochrane
f07a9b2932 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs. r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-06 14:21:04 +00:00
Noemi Erli
add41c1a33 Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE 2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7 Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures 2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15 Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 19:27:10 +00:00
Nikki Sharpley
a441acbbaa Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 19:10:14 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 18:32:38 +00:00
Butkovits Atila
dd41b6e962 Backed out changeset 397b2df59338 (bug 1886847) for causing failures at browser-custom-colors.css. CLOSED TREE 2024-08-02 19:18:43 +03:00
Nikki Sharpley
54d0b76fd9 Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 15:26:00 +00:00
Stuart Colville
42e4b57d88 Bug 1906622 - Move preventDefault call to avoid keyboard trap r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D218343
2024-08-02 13:04:01 +00:00
Jonathan Sudiaman
1a0bf393fe Bug 1910685 - Expose sidebar strings for localization r=sidebar-reviewers,fluent-reviewers,bolsson,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D218325
2024-08-01 22:35:43 +00:00
Sandor Molnar
62ae38bb63 Backed out changeset 3b4a3a45aa1a (bug 1906140) @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 04:21:31 +03:00
Kelly Cochrane
6f31e3a9a9 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-01 00:34:29 +00:00
Sandor Molnar
daa46360f2 Backed out changeset 086cdcffa062 (bug 1906140) for causing bc failures @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 00:37:35 +03:00
Kelly Cochrane
466cbf628a Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-07-31 21:02:05 +00:00
Jonathan Sudiaman
93a0b7bce5 Bug 1900979 - Fix empty strings assigned in Sidebar.ftl r=sidebar-reviewers,fluent-reviewers,kcochrane
The empty strings were used as a workaround to clear out labels when switching from expanded to collapsed state. This really should have been the component's responsibility.

Differential Revision: https://phabricator.services.mozilla.com/D218087
2024-07-31 15:18:42 +00:00
Jonathan Sudiaman
7f23df83f1 Bug 1904210 - Adjust default sidebar and sidebar panel widths r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane,dao,sclements
- Set the sidebar width in the expanded state to 280px.
- Set the sidebar panel default size to 400px with a minWidth of 200px.
- Persist sidebar panel width changes made by the user.

Differential Revision: https://phabricator.services.mozilla.com/D217736
2024-07-30 17:01:45 +00:00
Stanca Serban
320e7920b7 Backed out changeset 90b4291bf3b5 (bug 1904210) for causing mochitests failures in browser_customize_sidebar.js. 2024-07-30 17:38:38 +03:00
Jonathan Sudiaman
68c73cd2de Bug 1904210 - Adjust default sidebar and sidebar panel widths r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane,dao,sclements
- Set the sidebar width in the expanded state to 280px.
- Set the sidebar panel default size to 400px with a minWidth of 200px.
- Persist sidebar panel width changes made by the user.

Differential Revision: https://phabricator.services.mozilla.com/D217736
2024-07-30 12:30:59 +00:00
Nikki Sharpley
e4b1bd71bf Bug 1910152 - Ensure sidebar customize position settings work with RTL r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D217952
2024-07-29 21:06:59 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Jonathan Sudiaman
4976e075f8 Bug 1886408 - History in sidebar: Remove row limit, fix empty state, add hover button. r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,kcochrane,nsharpley
- max-history-rows pref set to 0 for Nightly only.
- Add the X button to close a tab on hover.
- Introduce an extension to `fxview-tab-list` which handles the differences between here and FxView.
- Reuse the empty state for when history is cleared (same as firefox view).
- Update the logic of `fxview-empty-state` to allow for opening prefs link in the parent window (instead of the sidebar browser).

Differential Revision: https://phabricator.services.mozilla.com/D217111
2024-07-25 16:03:17 +00:00
Nikki Sharpley
ee42dc2123 Bug 1905869 - Add vertical tabs settings to customize panel r=sidebar-reviewers,fluent-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D215633
2024-07-17 13:22:29 +00:00
Matthew_Cash
a8fbb156bd Bug 1900282 - Apply browser.tabs.allow_transparent_browser pref to sidebar browsers. r=dao,sidebar-reviewers,sclements,sfoster
This change allows users to remove the opaque background from the
sidebar, enabling sidebar backgrounds to be fully transparent when used
alongside a userChrome.css that provides transparency.
This is purely an aesthetic option for use with custom themes and a
continuation of Bug 28354.

Differential Revision: https://phabricator.services.mozilla.com/D212385
2024-07-15 15:06:56 +00:00
Kelly Cochrane
b40657ff11 Bug 1897976 - Update existing tests involving sidebar-button in the nav bar for when sidebar.revamp pref is flipped on r=places-reviewers,sidebar-reviewers,urlbar-reviewers,mak,sfoster,Gijs,sclements
Differential Revision: https://phabricator.services.mozilla.com/D215253
2024-07-12 15:58:29 +00:00
Luca Greco
3ae0a96b30 Bug 1905771 - switcherTarget element label set by SidebarController.registerExtension is still set when switching to a non extension sidebar. r=willdurand,sidebar-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D215945
2024-07-10 17:52:30 +00:00
Ed Lee
e7565e634f Bug 1906122 - Selecting AI Chatbot or extensions with old sidebar panel switcher when already on that panel closes the sidebar r=sidebar-reviewers,nsharpley
Detect menu usage as checkbox or not to toggle or show.

Differential Revision: https://phabricator.services.mozilla.com/D215797
2024-07-04 21:06:53 +00:00
Ed Lee
1bac981cb5 Bug 1900915 - Include chat as tool for new sidebar r=sidebar-reviewers,sclements
Update default tool ordering. Conditionally render tool if not hidden for both main and customize.

Differential Revision: https://phabricator.services.mozilla.com/D215721
2024-07-04 14:44:11 +00:00
Gijs Kruitbosch
772edac095 Bug 1900663 - reuse existing windows as openers when opening a window from the macOS dock menu, r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D212625
2024-07-02 14:15:21 +00:00
Gijs Kruitbosch
40e851d728 Bug 1905692 - use JS to handle activation/click of sidebar close button in non-revamped sidebar, r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D215379
2024-07-01 19:40:55 +00:00
Jonathan Sudiaman
3fe0267737 Bug 1904868 - Fix leaks from PlacesQuery when closing during a fetch in progress r=sidebar-reviewers,fxview-reviewers,places-reviewers,Standard8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05328f734d54c873b30256da3cdf783a73abab50

Differential Revision: https://phabricator.services.mozilla.com/D215023
2024-07-01 16:53:41 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D212285
2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D213591
2024-06-21 18:15:25 +00:00
Nikki Sharpley
cb083a0f14 Bug 1896987 - Fix browser_sidebar_context_menu.js intermittent r=sidebar-reviewers,jsudiaman
`BrowserTestUtils.isVisible` is failing on some platforms despite being visible. Other tests
in the same suite simply check the existence of `sidebar` so reverting to that.

Differential Revision: https://phabricator.services.mozilla.com/D214563
2024-06-21 17:49:54 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D213591
2024-06-21 14:00:00 +00:00
Nikki Sharpley
77be78d994 Bug 1896987 - Fix browser_sidebar_context_menu.js intermittent r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D213807
2024-06-20 14:39:00 +00:00
Mark Striemer
cabc85f076 Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213330
2024-06-19 18:37:37 +00:00
Mark Striemer
fb377d8a08 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213328
2024-06-19 18:37:37 +00:00
Kelly Cochrane
e2fe9bf11e Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 18:24:08 +00:00
pstanciu
e91ba02454 Backed out changeset ab055e5ace5e (bug 1899576) for causing bc failures on browser_all_files_referenced.js CLOSED TREE 2024-06-18 20:49:29 +03:00
Kelly Cochrane
c8bfc52deb Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 16:03:11 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
2024-06-15 10:43:19 +00:00
Ed Lee
3cefd95d0b Bug 1899827 - Stub initial conditional sidebar depending on chat pref r=tarek,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,flod,sclements
Add placeholder chat page that is shown in old sidebar when pref is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D212756
2024-06-15 01:48:55 +00:00
Sandor Molnar
34e807bc63 Backed out 5 changesets (bug 1897529, bug 1901336, bug 1900126) for causing bc failures @ browser_a11y_sidebar.js CLOSED TREE
Backed out changeset 334b820a4c19 (bug 1897529)
Backed out changeset 70350abadcba (bug 1900126)
Backed out changeset 3d631de2ce01 (bug 1897529)
Backed out changeset 1d654154d5ea (bug 1897529)
Backed out changeset a8f7b541a548 (bug 1901336)
2024-06-14 22:41:48 +03:00
Mark Striemer
d06b2bcf0e Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213330
2024-06-14 18:18:19 +00:00