Commit Graph

1910 Commits

Author SHA1 Message Date
Stephanie Cunnane
0ecad04d44 Bug 1911117 - Only run browser_search_telemetry_categorization_experiment_info.js for non-artifact builds. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D218363
2024-08-01 23:04:35 +00:00
Narcis Beleuzu
d6e4988bcf Backed out changeset 18511e925790 (bug 1911117) as req by scunnane 2024-08-02 00:59:26 +03:00
Stephanie Cunnane
0fcad493db Bug 1911117 - Only run browser_search_telemetry_categorization_experiment_info.js for non-artifact builds. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D218363
2024-08-01 21:38:15 +00:00
Moritz Beier
732359d637 Bug 1881739 - Create a SearchTestUtils function to simplify creating configurations for tests. r=Standard8,mcheang,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216807
2024-08-01 01:29:19 +00:00
Masayuki Nakano
528d09c312 Bug 1904279 - Get rid of dom.w3c_pointer_events.dispatch_click_as_pointer_event pref r=smaug,pip-reviewers,search-reviewers,devtools-reviewers,urlbar-reviewers,nchevobbe,dao,jteow,mconley
Keep supporting the pref makes a lot of `click`, `auxclick` and `contextmenu`
event creators complicated (and look messy).  So, let's delete it as soon as
possible.

Differential Revision: https://phabricator.services.mozilla.com/D217225
2024-07-30 06:49:42 +00:00
Stephanie Cunnane
267a9c02e8 Bug 1900094 - Add telemetry for impressions missing due to domain-to-categories map issues. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D214868
2024-07-25 04:49:43 +00:00
Moritz Beier
650113020b Bug 1863530 - Remove browser.search.widget.inNavBar pref. r=dao,settings-reviewers,search-reviewers,omc-reviewers,urlbar-reviewers,Gijs,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D215607
2024-07-23 17:29:00 +00:00
Stephanie Cunnane
cbe0471b10 Bug 1879667 - Record client's experiment information in the SERP categorization ping. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D209269
2024-07-17 16:51:12 +00:00
James Teow
419db13c99 Bug 1907097 - Add telemetry for when ads_blocked are counted - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D216208
2024-07-16 07:16:42 +00:00
Moritz Beier
12220c0dde Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D216047
2024-07-15 11:15:22 +00:00
Moritz Beier
b0c1584ee2 Bug 1906665 - Intermittent TV browser/components/search/test/browser/browser_searchPanelHeader.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D216206
2024-07-11 07:33:02 +00:00
James Teow
0482ed1f22 Bug 1906945 - Switch to using checkVisibility in child process - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D216082
2024-07-10 19:51:16 +00:00
Mark Banner
585f1f907b Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D214956
2024-07-10 13:10:53 +00:00
Noemi Erli
35d7ea8a75 Backed out changeset d05089c1e269 (bug 1822297) for causing Documentation related failures CLOSED TREE 2024-07-10 13:36:53 +03:00
Mark Banner
7bda04576d Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D214956
2024-07-10 09:34:20 +00:00
Cristian Tuns
4a568b94bb Backed out changeset 4d2f43c22de3 (bug 1822297) for causing frequent bc failures in browser_searchbar_default.js CLOSED TREE 2024-07-09 13:10:27 -04:00
Mark Banner
de7dcec0bf Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. r=mak,search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D214956
2024-07-09 15:04:46 +00:00
James Teow
59fcaf5a0a Bug 1905095 - Loosen the heuristic for ads_visible - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D215283
2024-07-08 14:57:13 +00:00
Moritz Beier
3ac77d2134 Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D214834
2024-07-08 12:12:01 +00:00
pstanciu
cd0b5dbe48 Backed out changeset 80bffab6cb97 (bug 1904014) for causing bc failures on browser_oneOffContextMenu.js CLOSED TREE 2024-07-03 17:21:47 +03:00
Moritz Beier
fcb61b2ae0 Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D214834
2024-07-03 13:30:46 +00:00
James Teow
fa3b3d1fea Bug 1905100 - Remove Persisted Search Tip - r=adw,urlbar-reviewers
The onboarding will be handled by OMC who will help with the
messaging for all the scotch bonnet features.

Differential Revision: https://phabricator.services.mozilla.com/D215234
2024-07-01 23:45:47 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D214240
2024-06-26 16:03:23 +00:00
Moritz Beier
be3e1bf453 Bug 1895873 - Remove icons and search_form from the application provided search WebExtensions. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D214820
2024-06-26 16:03:21 +00:00
Norisz Fay
709322cd79 Backed out changeset e12f0e69c0ae (bug 1895873) for causing build bustages CLOSED TREE 2024-06-25 21:51:33 +03:00
Moritz Beier
a11658f0a0 Bug 1895873 - Remove icons and search_form from the application provided search WebExtensions. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D214820
2024-06-25 17:39:47 +00:00
Dão Gottwald
f0cf92a1c5 Bug 1903996 - Make customizing and mousedown proper boolean attributes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D214525
2024-06-21 15:38:54 +00:00
Moritz Beier
e1ae506f34 Bug 1903608 - Pressing enter on search bar settings icon does not open settings. r=dao,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D214287
2024-06-20 20:47:18 +00:00
Yazan Al Macki
d5b1a493c3 Bug 1902323 - Ensure mimetype info is passed when creating new blobs in order to correctly render application provided search engine icons if they are svg based. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D213671
2024-06-20 15:55:42 +00:00
Mark Banner
a3a8ab8731 Bug 1897142 - Update Search Config tests. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D211926
2024-06-20 15:45:09 +00:00
Stanca Serban
030d3afa61 Backed out 2 changesets (bug 1897142) for causing xpcshell failures in test_UrlbarSearchUtils.js. CLOSED TREE
Backed out changeset e986137d0387
Backed out changeset ffeb79eca5db (bug 1897142)
2024-06-20 17:05:48 +03:00
Mark Banner
a56fd5df74 Bug 1897142 - Update Search Config tests. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D211926
2024-06-20 12:15:40 +00:00
James Teow
f10b831079 Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D213350
2024-06-18 06:02:58 +00:00
Masayuki Nakano
e1fd41420f Bug 1675847 - part 3: Make ePointerClick event dispatchers and handlers use WidgetPointerEvent r=smaug,search-reviewers,devtools-reviewers,nchevobbe,jteow
This patch makes the all `ePointerClick` event dispatcher in C++ code use
`WidgetPointerEvent` instead of `WidgetMouseEvent`.

Then, this patch also makes the all `click` event dispatcher in chrome code use
`PointerEvent` instead of `MouseEvent`.  For detecting wrong trusted event
dispatching of `click` event, this patch adds assertion into `MouseEvent`.
Therefore, all chrome test dispatchers also changed to use `PointerEvent`.

Finally, this patch includes a change of a WPT.  That checks the `pointerId`
caused by executing an access key.  In this case, the value should be `-1`
rather than the default value `0` because Pointer Event spec defines so for
synthetic pointer events caused by non-pointing devices [1].  Chrome also
sets it to `-1` and fails [2].  Therefore, the new assertion will pass on both
Firefox and Chrome.

1. https://w3c.github.io/pointerevents/#dom-pointerevent-pointerid
2. https://wpt.fyi/results/uievents/interface/keyboard-accesskey-click-event.html?run_id=5087897523060736&run_id=5136270464647168&run_id=5163620816388096&run_id=5201281304231936

Differential Revision: https://phabricator.services.mozilla.com/D213001
2024-06-14 00:18:47 +00:00
Mark Banner
6efe8618e0 Bug 1901208 - Add an integration test to ensure that searchWith pings are correctly recorded. r=search-reviewers,mcheang
Differential Revision: https://phabricator.services.mozilla.com/D212921
2024-06-09 10:22:53 +00:00
Barret Rennie
871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
2024-06-06 14:42:00 +00:00
Dale Harvey
bea695c636 Bug 1900900 - Enable trending suggestions and recent searches for release. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D212750
2024-06-06 11:27:28 +00:00
Stephanie Cunnane
c0d3659ae2 Bug 1891799 - Update search-telemetry-v2 schema as part of Google account signed-in status work. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D207627
2024-06-05 16:13:05 +00:00
Chris H-C
85b4052c71 Bug 1900085 - Disable builtin Glean pings during tests r=TravisLong,perftest-reviewers,sparky,search-reviewers,jteow
This patch specifically disables "baseline" and "events" pings through not
telling Glean about user (in)activity, which triggers their submission.
"baseline" should matter less, but if an "events" ping is submitted during a
test it could contain a test's recorded events that it will later want to
assert are present.

"metrics" pings are already suppressed in automation via the `MOZ_AUTOMATION`
envvar. So update the docs to note that.

"deletion-request" pings are permitted at all times for all reasons and are not
included in the builtin pings we're disabling.

Differential Revision: https://phabricator.services.mozilla.com/D212315
2024-06-04 18:15:26 +00:00
Moritz Beier
8193d431ac Bug 1894910 - Remove function to open search page from search bar with an empty search. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D211832
2024-06-03 11:09:24 +00:00
Stephanie Cunnane
260f31ac91 Bug 1892332 - Distinguish between private and regular browsing modes wrt Google signed-in telemetry. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D212040
2024-06-01 02:52:17 +00:00
James Teow
1e7012698d Bug 1899663 - Change _checkURLForSerpMatch and updateTrackingStatus to have less impression logic - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D212100
2024-05-30 19:04:14 +00:00
James Teow
6c465da1a8 Bug 1899625 - Update search telemetry impression definition for historical context - r=scunnane DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D212143
2024-05-30 18:12:21 +00:00
ujas.thakkar
7acd32b983 Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D211309
2024-05-23 16:17:00 +00:00
Mark Banner
bb7cb93cc2 Bug 1836804 - Remove support for {moz:locale} parameter replacements in search URLs. r=search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D209972
2024-05-13 22:10:30 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Yazan Al Macki
deeab6e381 Bug 1887966 - Remove unnecessary async from schema test and make the UI ordering consistent with the schema. r=jteow,search-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209803
2024-05-08 14:04:59 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
James Teow
cfe7e470ff Bug 1851907 - Remove SERP Telemetry v1 feature gating pref - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D207947
2024-05-01 17:41:04 +00:00