Commit Graph

893 Commits

Author SHA1 Message Date
Harry Twyford
58cf2e7f96 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-22 15:46:30 +00:00
Cosmin Sabou
b7f0575fc4 Backed out changeset 5a673b05aea0 (bug 1713827) for bc failures on browser_contentSearchUI_default.js. CLOSED TREE 2021-07-21 01:06:27 +03:00
Harry Twyford
107a1e3766 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-20 21:25:10 +00:00
Matthew Noorenberghe
04bb39bed9 Bug 970675 - Allow changing popup blocker settings for the session in private windows. r=johannh
The permission manager automatically only saves permissions for the session with private browsing principals:
https://searchfox.org/mozilla-central/rev/da25888c4495585c532640f0e5efad07b1037621/extensions/permissions/PermissionManager.cpp#1586-1588

Differential Revision: https://phabricator.services.mozilla.com/D118887
2021-07-12 15:04:23 +00:00
Andreas Farre
bd9faf87ad Bug 1701303 - Move counting of private browsing contexts to parent process. r=smaug,johannh
Move the counting of private browsing contexts to the parent
process. Also change to only consider non-chrome browsing contexts
when counting private contexts. The latter is possible due to bug
1528115, because we no longer need to support hidden private windows.

With counting in the parent process we can make sure that when we're
changing remoteness on a private browsing context the private browsing
context count never drops to zero. This fixes an issue with Fission,
where we remoteness changes could transiently have a zero private
browsing context count, that would be mistaken for the last private
browsing context going away.

Changing to only count non-chrome browsing contexts makes us only fire
'last-pb-context-exited' once, and since we count them in the parent
there is no missing information about contexts that makes us wait for
a content process about telling us about insertion or removal of
browsing contexts.

Differential Revision: https://phabricator.services.mozilla.com/D118182
2021-07-05 15:17:55 +00:00
Marian-Vasile Laza
7cf836b79b Backed out changeset 55f827545de2 (bug 1701303) for causing bustages on ContentParent.cpp. CLOSED TREE 2021-07-05 17:12:13 +03:00
Andreas Farre
042d294d58 Bug 1701303 - Move counting of private browsing contexts to parent process. r=smaug,johannh
Move the counting of private browsing contexts to the parent
process. Also change to only consider non-chrome browsing contexts
when counting private contexts. The latter is possible due to bug
1528115, because we no longer need to support hidden private windows.

With counting in the parent process we can make sure that when we're
changing remoteness on a private browsing context the private browsing
context count never drops to zero. This fixes an issue with Fission,
where we remoteness changes could transiently have a zero private
browsing context count, that would be mistaken for the last private
browsing context going away.

Changing to only count non-chrome browsing contexts makes us only fire
'last-pb-context-exited' once, and since we count them in the parent
there is no missing information about contexts that makes us wait for
a content process about telling us about insertion or removal of
browsing contexts.

Differential Revision: https://phabricator.services.mozilla.com/D118182
2021-07-05 13:16:49 +00:00
Marian-Vasile Laza
83fb5bc219 Backed out changeset 4854ff4fff72 (bug 1701303) for causing bustages on nsDocShell.cpp. CLOSED TREE 2021-07-05 14:21:48 +03:00
Andreas Farre
e7338fb5d4 Bug 1701303 - Move counting of private browsing contexts to parent process. r=smaug,johannh
Move the counting of private browsing contexts to the parent
process. Also change to only consider non-chrome browsing contexts
when counting private contexts. The latter is possible due to bug
1528115, because we no longer need to support hidden private windows.

With counting in the parent process we can make sure that when we're
changing remoteness on a private browsing context the private browsing
context count never drops to zero. This fixes an issue with Fission,
where we remoteness changes could transiently have a zero private
browsing context count, that would be mistaken for the last private
browsing context going away.

Changing to only count non-chrome browsing contexts makes us only fire
'last-pb-context-exited' once, and since we count them in the parent
there is no missing information about contexts that makes us wait for
a content process about telling us about insertion or removal of
browsing contexts.

Differential Revision: https://phabricator.services.mozilla.com/D118182
2021-07-05 09:30:53 +00:00
Andrei Oprea
3fbca1cf31 Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 11:06:58 +00:00
Sandor Molnar
5b2a952c7e Backed out changeset f4ab27bcac2e (bug 1715504) for causing browser-chrome failures in browser_all_files_referenced. CLOSED TREE 2021-06-18 13:38:10 +03:00
Andrei Oprea
4f4f660965 Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 09:50:19 +00:00
Andrei Oprea
499e2e6b05 Bug 1711473 - Intermittent browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus.js r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D116485
2021-06-08 15:10:44 +00:00
Christoph Kerschbaumer
e241d18c0c Bug 1714947: Update missed PBM tests to work with https-first-mode enabled r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D116979
2021-06-08 12:48:32 +00:00
Emilio Cobos Álvarez
bd41ea3fde Bug 1713787 - Fix whitespace handling inside CSS variables. r=xidorn
As per w3c/csswg-drafts#881 and w3c/csswg-drafts#774.

Differential Revision: https://phabricator.services.mozilla.com/D116459
2021-06-07 10:16:39 +00:00
Andrei Oprea
3def4a0356 Bug 1711720 - Nimbus test helpers should flush on update to child processes r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D115481
2021-05-31 12:54:16 +00:00
Butkovits Atila
98574e1840 Bug 1700527 - disable browser_privatebrowsing_about.js on Win for frequent failures. r=intermittent-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D115324
2021-05-20 06:34:59 +00:00
Christoph Kerschbaumer
692041d76f Bug 1710850: Update PBM tests within browser/components/privatebrowsing to work with https-first-mode enabled r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D114969
2021-05-18 08:04:31 +00:00
Kate Hudson
2e7f27a4e9 Bug 1709344 - Add Nimbus to about:privatebrowsing r=desktop-theme-reviewers,andreio,harry
Differential Revision: https://phabricator.services.mozilla.com/D114268
2021-05-13 01:18:18 +00:00
Butkovits Atila
c13a4d73bf Bug 1700527 - disable browser_privatebrowsing_about.js on Linux_opt for frequent failures. r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D114711
2021-05-10 16:21:25 +00:00
Valentin Gosu
b48d0f6ea6 Bug 1694662 - Remove Appcachestorage & oldwrappers r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D106455
2021-04-30 07:20:24 +00:00
Mark Striemer
a517a96c36 Bug 1702327 - Fix browser_privatebrowsing_popupblocker.js r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D110615
2021-04-06 04:26:29 +00:00
Butkovits Atila
c35c211cab Bug 1700527 - disable browser_privatebrowsing_about.js on Linux_64_opt for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D110045
2021-03-31 12:25:57 +00:00
Harry Twyford
180c0118e8 Bug 1616700 - Part 3 - Update the placeholder string on the handoff input to read "Search with {engine} or enter address" r=fluent-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108266
2021-03-23 22:56:54 +00:00
Harry Twyford
dc0789cef0 Bug 1616700 - Part 2 - Apply a disabled appearance to the handed-off input rather than hiding it. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108826
2021-03-23 22:56:54 +00:00
Harry Twyford
3d581840b3 Bug 1616700 - Part 1 - Use default address bar search mode for new tab search handoff r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108825
2021-03-23 22:56:54 +00:00
Alexandru Michis
7472bfb633 Backed out 3 changesets (bug 1616700) for causing failures in browser_privatebrowsing_about.js
Backed out changeset 5e1b8f75fef5 (bug 1616700)
Backed out changeset fdf97a561019 (bug 1616700)
Backed out changeset de3717cc63ef (bug 1616700)
2021-03-20 01:23:39 +02:00
Harry Twyford
7b440baa90 Bug 1616700 - Part 3 - Update the placeholder string on the handoff input to read "Search with {engine} or enter address" r=fluent-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108266
2021-03-19 21:31:13 +00:00
Harry Twyford
656e81ecc6 Bug 1616700 - Part 2 - Apply a disabled appearance to the handed-off input rather than hiding it. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108826
2021-03-19 21:31:13 +00:00
Harry Twyford
3108d69a6b Bug 1616700 - Part 1 - Use default address bar search mode for new tab search handoff r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108825
2021-03-19 21:31:12 +00:00
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Kris Maglione
2be6e84b6f Bug 1685801: Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101483
2021-01-28 20:58:24 +00:00
Mihai Alexandru Michis
e10f79168a Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
d341ae508d Bug 1685801: Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101483
2021-01-28 05:25:10 +00:00
Butkovits Atila
91af0d3269 Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione
a8770fe0cd Bug 1685801: Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101483
2021-01-28 03:32:33 +00:00
Daisuke Akatsuka
3e263466ee Bug 1678611: Apply page-title-changed event instead of onTitleChanged. r=mak,mixedpuppy
Depends on D98278

Differential Revision: https://phabricator.services.mozilla.com/D98280
2020-12-16 08:28:54 +00:00
Marco Bonardo
4830941a5f Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 10:01:24 +00:00
smolnar
7b08899f40 Backed out 4 changesets (bug 1665049) for causing bustages in browser.ini CLOSED TREE
Backed out changeset fd06f6552ad0 (bug 1665049)
Backed out changeset 156a323cd31a (bug 1665049)
Backed out changeset 011f54945acb (bug 1665049)
Backed out changeset 028644c366d5 (bug 1665049)
2020-12-18 11:45:30 +02:00
Marco Bonardo
59fc3065cf Bug 1665049 - Remove browser.urlbar.update2. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D99487
2020-12-18 09:26:35 +00:00
Marco Bonardo
c1aa2fcc37 Bug 1677408 - Part 2 - Update consumers of onPageChanged. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D97275
2020-11-23 16:26:17 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
2020-11-23 16:49:31 +02:00
Marco Bonardo
4ef53e7609 Bug 1677408 - Part 2 - Update consumers of onPageChanged. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D97275
2020-11-23 12:54:26 +00:00
Nika Layzell
ed9e85fc9a Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
f6849f1603 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00