Commit Graph

65 Commits

Author SHA1 Message Date
Christoph Kerschbaumer
d8034a3e61 Bug 1654260: Package all formautofill css files and load them using the internal chrome: protocol. r=MattN,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D85023
2020-08-31 13:18:56 +00:00
Sam Foster
7328d3a035 Bug 1481481 - Create separate forms for shipping, payer and billing address r=MattN
* New AddressForm instances for each address type
* Move selected-state-key out of state for the address forms, and into an attribute
* Remove passing form title via state, just use data-title-edit and data-title-add on the element
* Remove shippingOption form title logic from address picker, just set the right attribute values from PaymentDialog
* Move setting the extraRequiredFields data attribute the payer form needs out to the payment-dialog's render.
* Amend onboarding logic to direct to billing address form when necessary
* Fix-up tests

Differential Revision: https://phabricator.services.mozilla.com/D11545
2018-11-21 19:23:27 +00:00
Sam Foster
d756aa22ef Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-06 00:28:46 +00:00
Brindusan Cristian
074281f389 Backed out changeset ea5d6df24de0 (bug 1482689) as requested by sfoster. 2018-11-06 02:20:51 +02:00
Sam Foster
3e6f95011e Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-06 00:04:42 +00:00
Cosmin Sabou
a752eeafc6 Backed out 2 changesets (bug 1482689) for browser chrome failures on browser_address_edit.js
Backed out changeset 61b49da4b9cb (bug 1482689)
Backed out changeset c810cab5dbdb (bug 1482689)
2018-11-05 18:28:15 +02:00
Sam Foster
f2be145084 Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that isn't applicable to billing addresses.
* A couple new mochitests for the new/different behavior

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-05 15:16:02 +00:00
Jared Wein
fc09272194 Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7473
2018-10-13 00:39:02 +00:00
Sam Foster
140c17314a Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7209
2018-09-28 20:00:03 +00:00
Matthew Noorenberghe
cc38c1b150 Bug 1490805 - Add a required CSC/CVV field to the add card page. r=jaws
Depends on D6882

Differential Revision: https://phabricator.services.mozilla.com/D6883
2018-09-27 17:26:24 +00:00
Jared Wein
1b3517ace7 Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN
I had to move the tooltip to appear above the help icon to make sure that it cause scrollbars to appear on the address form.

Differential Revision: https://phabricator.services.mozilla.com/D6912
2018-09-27 14:11:39 +00:00
Matthew Noorenberghe
3b00cb1745 Bug 1432939 - Link to Firefox Options/Preferences from the PaymentRequest dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6724
2018-09-25 17:26:38 +00:00
Matthew Noorenberghe
538c456013 Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5186
2018-09-20 21:07:20 +00:00
Sam Foster
6ddf9e9404 Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6318
2018-09-19 22:10:50 +00:00
Sam Foster
97e02f994e Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6322
2018-09-19 20:57:26 +00:00
Sam Foster
4b5fb70b7e Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-19 18:15:11 +00:00
Bogdan Tara
c104128b3d Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
579931d05b Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-14 20:28:41 +00:00
Jared Wein
dc4a70252a Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5320
2018-09-10 18:16:55 +00:00
Jared Wein
5ce5be7ff8 Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5068
2018-09-06 19:43:19 +00:00
Jared Wein
96dfeffbdd Bug 1477100 - Show the labels as placeholders inside of the fields. r=MattN
Show the labels as placeholders inside of the fields.

Differential Revision: https://phabricator.services.mozilla.com/D2955
2018-08-17 16:25:46 -07:00
Jared Wein
46b7ce906e Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp
2018-08-03 18:51:31 -04:00
Jared Wein
97ca8b6dd2 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd
2018-07-31 15:09:58 -04:00
Jared Wein
f7aa111f10 Bug 1472278 - Localize the required form asterisk on the address-form, basic-card-form, and CVV entry field. r=MattN
MozReview-Commit-ID: 7VN1VY7QziT
2018-07-30 21:13:36 -04:00
Jared Wein
133cd95906 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Brindusan Cristian
46820164b1 Backed out changeset d402c7b803c6 (bug 1477114) as requested by jaws. 2018-08-02 23:18:53 +03:00
Jared Wein
704b82dea4 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Jared Wein
5b13f28790 Bug 1478175 - Implement the branding in the lower left corner of the payment-summary page. r=sfoster
MozReview-Commit-ID: Dp8SdEzlrG3
2018-07-30 17:24:16 -04:00
Jared Wein
f91a633c7e Bug 1468153 - Update the edit strings (Add/Update) and the failure strings to use the hostname. r=sfoster
MozReview-Commit-ID: HcOMsP5zWBg
2018-07-30 14:22:52 -04:00
Matthew Noorenberghe
8ef03fea38 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
730a3a6580 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Cosmin Sabou
4d1b71eee6 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
8e85abc48e Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
5ef6fd17d6 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
b5efc53363 Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc
2018-07-23 20:01:19 -07:00
Gurzau Raul
7bbe193f73 Backed out 4 changesets (bug 1463538) for failing on /payments/test/browser/browser_payments_onboarding_wizard.js
Backed out changeset 1c945ede0071 (bug 1463538)
Backed out changeset 8ccd9f4b230d (bug 1463538)
Backed out changeset e078fb39875e (bug 1463538)
Backed out changeset 798bf0d7928c (bug 1463538)
2018-07-24 11:16:21 +03:00
Matthew Noorenberghe
d8912866dc Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc
2018-07-23 20:01:19 -07:00
Sam Foster
b0eaf62f75 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5
2018-07-20 15:51:52 -07:00
prathiksha
109c049ded Bug 1475080 - Clean up the pickers on the payment summary page to match the spec. r=MattN
MozReview-Commit-ID: FOyD7DkwjHk
2018-07-20 11:13:43 -07:00
Matthew Noorenberghe
dabfaffc23 Bug 1469464 - PaymentRequest footer styling. r=sfoster
MozReview-Commit-ID: BbuIitPlUpQ
2018-07-11 22:59:46 -07:00
Matthew Noorenberghe
ad055f054f Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e
2018-07-12 09:52:30 -07:00
Matthew Noorenberghe
3ea8717627 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
0e35e78e3c Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T
2018-07-11 23:16:12 -07:00
Coroiu Cristina
03b5354741 Backed out 6 changesets (bug 1469464) for browser-chrome failures at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Backed out changeset f9d4885e8956 (bug 1469464)
Backed out changeset 59c418929764 (bug 1469464)
Backed out changeset 58c1a79fb661 (bug 1469464)
Backed out changeset 90654d5df81a (bug 1469464)
Backed out changeset 9453814beada (bug 1469464)
Backed out changeset 4b86bde79c91 (bug 1469464)
2018-07-12 10:52:02 +03:00
Matthew Noorenberghe
52509f0e6f Bug 1469464 - PaymentRequest footer styling. r=sfoster
MozReview-Commit-ID: BbuIitPlUpQ
2018-07-11 22:59:46 -07:00
Matthew Noorenberghe
b91a35cee8 Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e
2018-07-11 23:43:27 -07:00
Matthew Noorenberghe
c6d6c5d254 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
70982a8d17 Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T
2018-07-11 23:16:12 -07:00
Matthew Noorenberghe
0af67e543d Bug 1466720 - Default PaymentRequest dialog styles for background, <a>, and debugging.html. r=jaws
MozReview-Commit-ID: 5WFzbFFBvYj
2018-06-13 11:40:11 -07:00
prathiksha
d0213418ea Bug 1462779 - Show the billing address page during on-boarding if requestShipping is false and there are no saved addresses. r=MattN
MozReview-Commit-ID: E7KM4cIielG
2018-05-18 16:44:25 -07:00