Commit Graph

964 Commits

Author SHA1 Message Date
Mike Conley
0b34589f5b Bug 1412471 - Fix intermittent failure in browser_panelUINotifications_fullscreen_noAutoHideToolbar.js by ensuring we wait for update popup. r=Gijs
MozReview-Commit-ID: Yypy0ls4Ap
2017-11-24 10:55:41 -05:00
Dorel Luca
a124b68f6f Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
f5fa7dc767 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Dorel Luca
7f5a8af5d3 Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 00:33:41 +02:00
Edouard Oger
0bfd63cd24 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Gijs Kruitbosch
033316a6a6 Bug 1420583 - fix new tab adjacency logic when using "restore defaults", r=jaws
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.

MozReview-Commit-ID: FjNJ1n8foGi
2017-11-27 15:23:42 +00:00
Tawny Hoover
35be16f8ab Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws
MozReview-Commit-ID: 3Rio9EjwilT
2017-11-24 21:54:54 -05:00
Gijs Kruitbosch
fb8b8fa353 Bug 1418757 - new tab button isn't adjacent to the last tab when customizing in customize mode, r=jaws
MozReview-Commit-ID: bQoNfDD2sX
2017-11-22 13:49:07 +00:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt
2017-11-21 14:21:32 +00:00
Alphan Chen
f742ba195a Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs 2017-11-23 15:03:41 +08:00
Tooru Fujisawa
9c833f1705 Bug 1418739 - Part 2: Remove unused delayedStartup parameter from BrowserTestUtils.waitForNewWindow. r=smaug 2017-11-21 03:41:56 +09:00
Mark Banner
af3baeea57 Bug 1371293 - Fix instances of space-before-function-paren failures after ESLint 4 upgrade. r=mossop
MozReview-Commit-ID: 5XfdCSDjLEG
2017-11-06 13:46:21 +00:00
Gijs Kruitbosch
4240d1040c Bug 1388029 - remove dead CSS relating to the old panel, r=jaws
MozReview-Commit-ID: FoXjvWPc9in
2017-11-07 12:52:56 +00:00
Gijs Kruitbosch
f4281f60f4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
625192689c Bug 1408166 - prevent search bar popup from ever showing when browser_940307_panel_click_closure_handling is running to avoid it interfering with context menu clicks, r=florian
MozReview-Commit-ID: jyRcdAKpxR
2017-11-07 10:54:10 +00:00
Jared Wein
f9d4685ed9 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH
2017-10-31 14:38:15 -04:00
Coroiu Cristina
a1006bed59 Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
36471c65ad Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH
2017-10-31 14:38:15 -04:00
Mark Banner
cfa9659d1d Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
MozReview-Commit-ID: 8pidN7x6MYh
2017-10-30 09:55:39 +00:00
Edouard Oger
f7eb3c6d4f Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw
2017-10-24 14:05:52 -04:00
Sebastian Hengst
e2a7e61d30 Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
2017-10-26 23:33:04 +02:00
Edouard Oger
e0dacee365 Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw
2017-10-24 14:05:52 -04:00
Felipe Gomes
0f344c77d4 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
99112e9931 Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
3f29526da6 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb
2017-10-16 14:00:30 -02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Julian Descottes
e33357b027 Bug 1361080 - filter out hidden devtools menu items in customizableui test;r=jaws
DevTools are adding a hidden menuitem "Enable DevTools..." that will be used to
propose an onboarding screen to users. This hidden button makes a customizable ui
test fail. It needs to be filtered out.

MozReview-Commit-ID: IX4SlpDHdsT
2017-10-11 17:04:22 +02:00
Erica Wright
9c350e6d69 Bug 1406191 - Cleanup browser_widget_animation.js, remove event listener and close panel correctly. r=johannh
MozReview-Commit-ID: 6IjrdxnWPqa
2017-10-10 15:59:14 -04:00
Dão Gottwald
d09618162c Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq
2017-10-07 20:10:24 +02:00
Erica Wright
495e08000d Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
a70af3db06 Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR
2017-10-05 15:17:12 +01:00
Edouard Oger
8d9ed38c2f Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6
2017-09-20 13:16:19 -04:00
Sebastian Hengst
3ea44cf653 Backed out changeset 9ab9bde4021f (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:49:30 +02:00
Edouard Oger
f50c2aabd4 Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6
2017-09-20 13:16:19 -04:00
Sebastian Hengst
f9eadf482f Backed out changeset 97fdb9d392e5 (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:12:32 +02:00
Edouard Oger
5e1c52df77 Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6
2017-09-20 13:16:19 -04:00
Gijs Kruitbosch
21beddb96d Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
MozReview-Commit-ID: AqBwn9ovTjT
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
bec818f3cb Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
MozReview-Commit-ID: 4GxPEm119Yc
2017-09-27 22:37:19 +01:00
Mike de Boer
3f2ca69f96 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j
2017-09-29 13:51:51 +02:00
Sebastian Hengst
f146d54210 Backed out changeset 8855ba3f65ba (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-09-28 20:27:50 +02:00
Edouard Oger
84e93c925e Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
MozReview-Commit-ID: AIBjAZZlYX6
2017-09-20 13:16:19 -04:00
Mike de Boer
3f03abccde Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
MozReview-Commit-ID: 44Q9NbKEJeC
2017-09-20 14:25:58 +02:00
Andrew Halberstadt
454052d2b2 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
MozReview-Commit-ID: IQL7hWxQX9F
2017-08-22 16:56:02 -04:00
Gijs Kruitbosch
4d8b290d17 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ
2017-09-18 16:36:46 +01:00
Gijs Kruitbosch
9f4f621edb Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy
MozReview-Commit-ID: HBfdW5vEZaD
2017-08-23 14:06:26 +01:00
Johann Hofmann
7d223531dc Bug 1349552 - Part 3 - Add a test for drag space in customize mode. r=nhnt11
MozReview-Commit-ID: AiqY1J5WwYo
2017-09-10 20:39:21 +02:00
Gijs Kruitbosch
89bf690512 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Sebastian Hengst
5c208f4475 merge mozilla-central to autoland. r=merge 2017-09-07 12:40:32 +02:00
Sebastian Hengst
1197f950f9 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00