Embarrassingly, I forgot I added this in bug 1388990 when we had similar issues
with the back/forward buttons. It's a more straightforward solution for this
problem.
Differential Revision: https://phabricator.services.mozilla.com/D94751
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
This is using collapsed as a carryover from XBL days, where setting the element to hidden would destroy bindings.
But it's causing a side effect of shrinking the browser element to 0x0 which causes the content to resize, leading to
some flickering and poor performance when switching back to content from a Customize Mode tab.
By setting hidden we instead are just toggling the display property.
Differential Revision: https://phabricator.services.mozilla.com/D94057
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
When we move items in customize mode, we unwrap them, then move them, then wrap
them again. The unwrapping sets the `command` attribute back on the button, and
that also sets the `disabled` attribute on the button. The wrapping removes the
`command` attribute but leaves the `disabled` attribute.
When the `disabled` attribute is removed from the command, this does not
propagate to the button because the command attribute has not been put back.
To fix this, the patch avoids adding and immediately removing the command
attribute when moving items while in customize mode.
Differential Revision: https://phabricator.services.mozilla.com/D93338
We want this to be turned on for nightly users by default. The page range is still a WIP,
so we should hide that section for now.
This also adds the pref to the "Nightly Experiment" panel, turned on by default.
Differential Revision: https://phabricator.services.mozilla.com/D85907
Add support for a hidden preference named app.update.notifyDuringDownload
that, when set to true, causes a "Downloading update" message to appear
in the app menu during a MAR download. Clicking the message opens the
about box so the user can see detailed progress information.
Differential Revision: https://phabricator.services.mozilla.com/D77688
This is what I see when running the test:
console.log: Changing zoom for browser from 1 to 0.5
set fullZoom@chrome://global/content/elements/browser-custom-element.js:812:19
set fullZoom@chrome://browser/content/tabbrowser.js:526:7
ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
set zoom@chrome://global/content/viewZoomOverlay.js:49:10
@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:26:5
Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1039:34
Tester_execTest@chrome://mochikit/content/browser-test.js:1074:11
nextTest/<@chrome://mochikit/content/browser-test.js:904:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
"FullZoomChange for browser"
PASS Zoom reset button exists in Panel Menu -
console.log: Changing zoom for browser from 0.5 to 1
console.log: set fullZoom@chrome://global/content/elements/browser-custom-element.js:817:19
ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
FullZoom__applyPrefToZoom@chrome://browser/content/browser-fullZoom.js:479:19
FullZoom_onLocationChange@chrome://browser/content/browser-fullZoom.js:247:14
XWB_onUpdateCurrentBrowser@chrome://browser/content/browser.js:5419:16
callListeners@chrome://browser/content/tabbrowser.js:820:31
_callProgressListeners@chrome://browser/content/tabbrowser.js:834:22
_callProgressListeners@chrome://browser/content/tabbrowser.js:5776:46
onStateChange@chrome://browser/content/tabbrowser.js:6039:14
_callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:75:31
onStateChange@resource://gre/modules/RemoteWebProgress.jsm:88:10
Which is pretty broken (the zoom is reset way earlier than clicking the reset
button, by FullZoom.onLocationChange).
This seems to me was mostly passing by chance, but with my Fission changes
which made FullZoomChange events more async (and actually, not notify twice) it
started failing.
Wait to load a page before changing the zoom level so that the browser doesn't
reset it when navigating.
Differential Revision: https://phabricator.services.mozilla.com/D72208
This removes the annotation from the following tests:
browser/base/content/test/general:
- browser_bug735471.js by removing the test
- browser_clipboard.js which seems like it's not using CPOWs anyway
- browser_blockHPKP.js which is disabled and isn't using CPOWs anyway
browser/components/customizableui/test:
- browser_934951_zoom_in_toolbar.js as CPOW usage was removed in bug 962248
toolkit/components/reader/test:
- browser_readerMode_with_anchor.js as CPOW usage was already removed in bug 1492482
toolkit/content/tests/browser:
- browser_datetime_datepicker.js as CPOW usage was removed in bug 1492482
- browser_saveImageURL.js which used deprecated CPOW-only APIs that I removed in an earlier cset
It also removes all the test framework code relying on this annotation.
Depends on D70685
Differential Revision: https://phabricator.services.mozilla.com/D70686
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66397
