Commit Graph

271 Commits

Author SHA1 Message Date
Gijs Kruitbosch
d2f652ce40 Bug 1711519 - remove trivial gProton and gProtonDoorhangers checks, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D116630
2021-06-03 11:41:54 +00:00
Ed Lee
a664a5abaa Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 05:13:31 +00:00
Dorel Luca
82ab95e902 Backed out changeset 69811ad1a854 (bug 1706366) for Browser-chrome failures in browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js. CLOSED TREE 2021-04-30 06:10:41 +03:00
Sam Foster
c5c4a2fb76 Bug 1705049 - Update chevron/overflow menu animation. r=mconley
* New filmstrip animation svg. It animates between the currentColor and attention color. We *could* do this via a CSS animation changing the fill value over time, but my understanding is to ensure animation happens on the compositor/GPU, the filmstrip is the better way to go.

Differential Revision: https://phabricator.services.mozilla.com/D113856
2021-04-30 00:43:40 +00:00
Ed Lee
30d568996f Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 00:42:33 +00:00
Dorel Luca
f46a7f2574 Backed out changeset 8fd40805444e (bug 1705049) for Browser-chrome failures in browser/components/customizableui/test/browser_widget_animation.js. CLOSED TREE 2021-04-30 02:47:50 +03:00
Sam Foster
fe11b075d1 Bug 1705049 - Update chevron/overflow menu animation. r=mconley
* New filmstrip animation svg. It animates between the currentColor and attention color. We *could* do this via a CSS animation changing the fill value over time, but my understanding is to ensure animation happens on the compositor/GPU, the filmstrip is the better way to go.

Differential Revision: https://phabricator.services.mozilla.com/D113856
2021-04-29 21:41:52 +00:00
Barret Rennie
9ad4361e00 Bug 1702116 - Fix races in AddonManager & XPIDatabase r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D110363
2021-04-22 01:15:54 +00:00
Michael Kohler
1be16968ee Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D111011
2021-04-11 11:42:57 +00:00
Butkovits Atila
6fcf242672 Backed out changeset 2ee25a7f42f2 (bug 1701990) for causing failures at browser_970511_undo_restore_default.js. CLOSED TREE 2021-04-10 10:50:31 +03:00
Michael Kohler
6ef0e4de5c Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D111011
2021-04-10 06:10:15 +00:00
Blake Winton
02e2d45742 Bug 1703254 - Hide compact mode for people who don't use it, and Density menu when there's only one option. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D107913
2021-04-06 16:00:05 +00:00
Kris Maglione
caf1d0e771 Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 20:58:43 +00:00
Mihai Alexandru Michis
e10f79168a Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
2d5f151948 Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 05:25:03 +00:00
Butkovits Atila
91af0d3269 Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione
cebae4d59b Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 03:32:43 +00:00
Dão Gottwald
f1cf8c85f6 Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D98028
2020-11-26 21:54:32 +00:00
Jared Wein
7d0327cac7 Bug 1673403 - Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95777
2020-11-04 17:11:26 +00:00
Razvan Maries
038da7739d Backed out changeset e52abe08f115 (bug 1673403) for multiple bc perma failures. CLOSED TREE 2020-11-04 01:36:06 +02:00
Jared Wein
0efb8a4c3d Bug 1673403 - Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95777
2020-11-03 22:26:41 +00:00
Gijs Kruitbosch
32732be7ca Bug 1673409 - show icon and label for import button in customize mode, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D94783
2020-10-28 17:02:29 +00:00
Csoregi Natalia
ac65ad4313 Backed out changeset e9f3001bd7bd (bug 1673409) for failures on browser_palette_labels.js. CLOSED TREE 2020-10-28 02:52:37 +02:00
Gijs Kruitbosch
f9bc544f40 Bug 1673409 - show icon and label for import button in customize mode, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D94783
2020-10-28 00:09:49 +00:00
Gijs Kruitbosch
b3b0b65d9e Bug 1673388 - use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r=mconley
Embarrassingly, I forgot I added this in bug 1388990 when we had similar issues
with the back/forward buttons. It's a more straightforward solution for this
problem.

Differential Revision: https://phabricator.services.mozilla.com/D94751
2020-10-26 20:51:04 +00:00
smolnar
b581b26df4 Backed out changeset 38627c09131d (bug 1671619) for causing crashes (bug 1672560). DONTBUILD a=backout 2020-10-23 12:42:38 +03:00
Brian Grinstead
1d325e3bdf Bug 1671619 - Use [hidden] instead of [collapsed] for the browser container when entering and exiting Customize Mode r=Gijs
This is using collapsed as a carryover from XBL days, where setting the element to hidden would destroy bindings.
But it's causing a side effect of shrinking the browser element to 0x0 which causes the content to resize, leading to
some flickering and poor performance when switching back to content from a Customize Mode tab.
By setting hidden we instead are just toggling the display property.

Differential Revision: https://phabricator.services.mozilla.com/D94057
2020-10-20 15:23:46 +00:00
Gijs Kruitbosch
a040958b42 Bug 1670907 - moving buttons in customize mode should not disable them, r=mconley
When we move items in customize mode, we unwrap them, then move them, then wrap
them again. The unwrapping sets the `command` attribute back on the button, and
that also sets the `disabled` attribute on the button. The wrapping removes the
`command` attribute but leaves the `disabled` attribute.
When the `disabled` attribute is removed from the command, this does not
propagate to the button because the command attribute has not been put back.

To fix this, the patch avoids adding and immediately removing the command
attribute when moving items while in customize mode.

Differential Revision: https://phabricator.services.mozilla.com/D93338
2020-10-14 14:04:02 +00:00
Gijs Kruitbosch
d10e66f2d7 Bug 1663173 - disable commands that don't need to be enabled in customize mode, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D89289
2020-09-11 20:40:28 +00:00
Dan Mosedale
c12df05128 Bug 1659871 - Clean up tests + manifest parsing, add an Alpenglow test, r=pdahiya,florian
Differential Revision: https://phabricator.services.mozilla.com/D89005
2020-09-02 16:46:37 +00:00
Dan Mosedale
f14a9fad10 Bug 1643776 - Add Alpenglow theme, r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-21 17:20:07 +00:00
Razvan Maries
3748d2b321 Backed out changeset 2f4bf8bab6cf (bug 1643776) for causing bug 1660323. CLOSED TREE 2020-08-21 04:34:24 +03:00
Dan Mosedale
fc5fca3570 Bug 1643776 - Add Alpenglow theme, r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-21 00:43:03 +00:00
Razvan Maries
c6be7eea6f Backed out changeset 2a1fa73b1a63 (bug 1643776) for perma failures on browser_all_files_referenced.js. CLOSED TREE 2020-08-21 01:02:18 +03:00
Dan Mosedale
2c6910f146 Bug 1643776 - Add Alpenglow theme r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-20 21:04:57 +00:00
Razvan Maries
1ba54818c3 Backed out changeset 6ffb6196daf7 (bug 1643776) for perma failures on browser_all_files_referenced.js. CLOSED TREE 2020-08-20 22:26:31 +03:00
Dan Mosedale
8d18c184da Bug 1643776 - Add Alpenglow theme r=dmose,rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D86058
2020-08-20 17:52:09 +00:00
Dave Townsend
4b134e74e8 Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00
Artem
5ad832b023 Bug 1609556 - Migrate toolbar-context-menu to Fluent r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D76016
2020-05-27 18:09:40 +00:00
Gijs Kruitbosch
8b24ac52cf Bug 1558635 - use an html:template for the customize mode palette to avoid instantiating items in the palette, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D74097
2020-05-13 23:31:05 +00:00
Emma Malysz
d62624260d Bug 1634033: lazify menus and panels used within customize mode by placing in template. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D74576
2020-05-11 18:13:57 +00:00
Dão Gottwald
0083b1be54 Bug 1635095 - Obey prefers-reduced-motion in CustomizeMode.jsm. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73648
2020-05-04 21:19:26 +00:00
Gijs Kruitbosch
3c4fa421c4 Bug 1518500 - ensure we don't end up without a flexible space if moving items directly to toolbars, r=dao
Before this patch, we change aDraggedItemId somewhat late in the _applyDrop method -
significantly, we do this after the aTargetNode == areaCustomizationTarget check. So
we end up bailing out before adjusting aDraggedItemId, and we add the specific dummy
item from the palette into the toolbar, rather than adding a new spring to the
toolbar, and leaving the existing palette item alone.

Simply moving this adjustment to aDraggedItemId earlier into the method is sufficient
to fix the issue at hand.

Differential Revision: https://phabricator.services.mozilla.com/D62948
2020-02-17 15:43:32 +00:00
Dão Gottwald
693625795d Bug 1609938 - Enable tab animation when closing the customize tab via ESC key or Done button. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60248
2020-01-17 23:22:49 +00:00
Dão Gottwald
82d6a116c2 Bug 1609932 - Make depopulatePalette synchronous and remove the customize tab immediately in CustomizeMode::exit. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60243
2020-01-17 23:31:43 +00:00
Dão Gottwald
f195d48c77 Bug 883397 - Remove redundant about:blank check from CustomizeMode.exit. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D60146
2020-01-16 17:20:11 +00:00
Dão Gottwald
6845ef2fdd Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D58763
2020-01-16 11:41:36 +00:00
Coroiu Cristina
d285db3ceb Backed out changeset e2a0b2626fe8 (bug 1560348) for frequently failing browser-chrome at browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js 2020-01-08 10:13:51 +02:00
Dão Gottwald
fbdeec7f3d Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D58763
2020-01-07 11:28:13 +00:00
Brindusan Cristian
1b7034b487 Backed out changeset c716cc9f2a70 (bug 1560348) for bc failures at browser_lwt_telemetry.js. CLOSED TREE 2020-01-07 13:08:00 +02:00