corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
448,076 Commits 1 Branch 0 Tags
e529af5cb02f6e5acf87dd5378368b51a51d28f5
Commit Graph

43 Commits

Author SHA1 Message Date
Gijs Kruitbosch
1b441533b6 Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws 
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB
 2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
1329c154ed Bug 1319788 - fix typo in getting a telemetry histogram, r=mak 
MozReview-Commit-ID: 22CFX0Ueo1q
 2016-11-23 14:47:55 +00:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws 
MozReview-Commit-ID: 2ZvTiZDHchz
 2016-11-11 08:10:51 -08:00
Gijs Kruitbosch
1eb867efaf Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak 
MozReview-Commit-ID: EiZfkj6AsVL
 2016-10-22 14:40:48 +01:00
Wes Kocher
5d8f248c21 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
cf59a894b6 Bug 1314237 - detect nightly/devedition as 'firefox' in migration code, r=mikedeboer 
MozReview-Commit-ID: 6vQa59i81Gb
 2016-11-01 11:57:30 +00:00
Gijs Kruitbosch
f0e91ab90a Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak 
MozReview-Commit-ID: EiZfkj6AsVL
 2016-10-22 14:40:48 +01:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8 
MozReview-Commit-ID: 7Gx90a5y8t6
 2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
bbf79f28ea Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer 
MozReview-Commit-ID: RXO68w3Kv3
 2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
ac3e073240 Bug 1309614 - finish initializing places before we import stuff, r=mak 
MozReview-Commit-ID: JucE0HjQdwC
 2016-10-13 17:02:29 +01:00
Gijs Kruitbosch
529d9db2c4 Bug 1305770 - make cookies and passwords import from Chrome without locking, r=mak 
MozReview-Commit-ID: CbozmZHwAgz
 2016-10-03 16:17:06 +01:00
Gijs Kruitbosch
8e887a3fe8 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws 
MozReview-Commit-ID: 7kDMRrt5JNK
 2016-09-23 16:27:20 +01:00
Wes Kocher
297b6a4a72 Backed out 3 changesets (bug 1279240) for leaks on Windows VM mochitests a=backout 
Backed out changeset 4b69e32e3a83 (bug 1279240)
Backed out changeset d0d5180dc062 (bug 1279240)
Backed out changeset dc1b725b47d4 (bug 1279240)
 2016-09-29 17:44:41 -07:00
Gijs Kruitbosch
27c451ade9 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws 
MozReview-Commit-ID: 7kDMRrt5JNK
 2016-09-23 16:27:20 +01:00
Jinank Jain
7e5a9f8bcc Bug 1276701 - Remove Windows code from Safari migrator. r=Gijs 
MozReview-Commit-ID: CuV2xSmXnq
 2016-08-23 14:49:39 -07:00
Gijs Kruitbosch
e2e91c7669 Bug 1289436 - add telemetry for the length of time we take to import data, r=jaws,bsmedberg 
MozReview-Commit-ID: CkbHJVRucr5
 2016-07-26 18:05:08 +01:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
be83ddb0f6 Bug 1289229 - disable automigration undo if people create/change bookmarks/logins, r=mak 
MozReview-Commit-ID: DAoNV9H71Yv
 2016-07-26 12:48:37 +01:00
Gijs Kruitbosch
bcb431e2ad Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection, r=Dolske 
MozReview-Commit-ID: Bmuyv59fRAv
 2016-06-29 19:37:48 +01:00
Gijs Kruitbosch
63852c5b10 Bug 1276694 - store recency of browser data in telemetry when importing to see how good a predictor default browser is, r=dolske,bsmedberg 
MozReview-Commit-ID: 16uPNGGDE68
 2016-05-30 17:10:54 +01:00
Gijs Kruitbosch
47f3a1a1e3 Bug 1271775 - shut up eslint warning about return value, rs=bustage 
MozReview-Commit-ID: ESoog14WDSw
 2016-06-10 10:11:51 +01:00
Gijs Kruitbosch
e79046a3c6 Bug 1271775 - allow bypassing the initial migration dialog, r=jaws 
MozReview-Commit-ID: LkhHl7ipGEb
 2016-06-01 19:00:53 +01:00
Gijs Kruitbosch
667a1f5782 Bug 1275114 - add telemetry to determine how to make browser choices when automatically migrating on first profile startup, r=bsmedberg,Dolske 
MozReview-Commit-ID: zVmKTBzAS9
 2016-05-24 11:44:49 +01:00
Marco Bonardo
dbef55764d Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs 
MozReview-Commit-ID: 3w5TIPi2S8d
 2016-05-24 17:29:30 +02:00
Wes Kocher
4c1ab391da Backed out changeset 684824592e64 (bug 1272652) for marionette failures 2016-05-23 15:13:08 -07:00
Marco Bonardo
964325f635 Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs 
MozReview-Commit-ID: 3w5TIPi2S8d
 2016-05-20 17:00:43 +02:00
Gijs Kruitbosch
8171833389 Bug 1265368 - enable resetting non-default profiles, r=MattN 
MozReview-Commit-ID: KpW9JgghFkn
 2016-05-05 21:38:49 +01:00
Gijs Kruitbosch
b761ddf66c Bug 1246591 - remove preprocessing and fix any other issues, r=MattN 2016-02-08 12:54:38 +00:00
Mike Hommey
fd332b9f07 Bug 1235107 - Move bookmarks.html to a chrome localized location. r=dolske 2016-01-05 20:03:43 +09:00
Gijs Kruitbosch
eada4126d8 Bug 1219707 - fix argument passing to migration.js, r=jaws 2015-10-29 12:16:15 +00:00
Tooru Fujisawa
14a6e39246 Bug 1216775 - Remove for-each from browser/. r=Gijs 2015-10-19 01:27:39 +09:00
Gijs Kruitbosch
55079ed3a7 Bug 731025 - Add telemetry for migrator usage and errors, r=MattN,p=bsmedberg 2015-10-07 13:34:46 +01:00
Tooru Fujisawa
aa4cdf03d4 Bug 1207491 - Part 7: Remove use of expression closure from browser/components/migration/. r=Gijs 2015-09-23 18:36:21 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Gijs Kruitbosch
5dd713b1f1 Bug 1196311 - actually ship edge migrator, r=jaws 2015-08-19 17:41:30 +01:00
Gijs Kruitbosch
b8a3720667 Bug 1192032 - add edge bookmarks/favorites migrator, r=MattN 2015-08-11 16:53:10 +01:00
Bernardo P. Rittmeyer
31ae466fd3 Bug 706005 - Chrome migrator notifies user to close browser. r=MattN 2015-08-07 23:36:32 -07:00
Matthew Noorenberghe
26e57c126f Bug 706973 - Support migration from Chromium/Canary. r=Mano 2015-08-06 00:02:22 -07:00
Hector Zhao
f3cb670681 Bug 1164752 - Include 360 secure browser in migration. r=mak 2015-05-13 18:00:55 +08:00
Marco Bonardo
d90008e8ab Bug 1094876 - Migrators should use new Bookmarks.jsm API. r=ttaubert 2015-04-20 16:32:49 +02:00
Abhishek Bhattacharya
817d790315 Bug 1123309 - Remove Dict.jsm. r=mak,gfritzsche,felipe 2015-04-08 15:49:47 -03:00
Neil Rashbrook
ae3687114e Bug 1100118 Allow migration from Firefox to Firefox Developer Edition r=MattN 2015-02-14 21:29:49 +00:00
Birunthan Mohanathas
32a88e8a97 Bug 1038458 - Part 4: Flatten browser/components/migration/{public,src}/ directories. r=mak 2014-07-26 09:31:57 -07:00