Commit Graph

408 Commits

Author SHA1 Message Date
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
bcfb85b065 Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak
MozReview-Commit-ID: JRo5ZVu0uFD
2017-02-10 11:11:57 -05:00
Jared Wein
65cc3fc0d6 Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak
MozReview-Commit-ID: 2jor6H2cQck
2017-01-30 10:34:53 -05:00
Thom Chiovoloni
43289b1e98 Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh
MozReview-Commit-ID: 3ybnskOID1O
2017-01-17 13:15:49 -05:00
Ehsan Akhgari
ec238285dd Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku
This patch makes nsMenuItemIconX also participate in the setup
introduced in bug 1277803.
2017-01-20 10:55:23 -05:00
Masayuki Nakano
4da8f2b45c Bug 1331798 Bookmark panel for new bookmark shouldn't be closed automatically during composition and after text input without keyboard events nor composition events r=jaws
Bookmark panel for a new bookmark shouldn't be closed automatically during composition even if mouse cursor is moved outside the panel because user may click in IME's UI.

Additionally, editor might be modified without keyboard events nor composition events.  In such case, the bookmark panel shouldn't be closed automatically too.

MozReview-Commit-ID: 1FAUmkXjid
2017-01-19 15:04:56 +09:00
Jared Wein
be861fe6d3 Bug 1327938 - Clear the existing timeout before creating a new one, as we should only have one autoclose timer running at a time. r=mak
MozReview-Commit-ID: 9HdSMGWRvb1
2017-01-18 11:17:10 -05:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
1cde0c1e45 Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q
2017-01-03 17:02:09 -05:00
Phil Ringnalda
d436071a6a Backed out changeset 83d895c1c1ea (bug 1326712) for failures in browser_bookmark_popup.js 2017-01-03 19:36:42 -08:00
Jared Wein
af375db7c6 Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q
2017-01-03 17:02:09 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Marco Bonardo
e00ec4e5e7 Bug 1321556 - Remove unused bindings from urlbarbindings.xml. r=dao
MozReview-Commit-ID: FfIsoh76ajn
2016-12-09 14:17:12 -10:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Mark Banner
6b3a6a4cda Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11
2016-10-31 10:33:38 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Mark Banner
9b40970863 Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop
MozReview-Commit-ID: HGiOmpyN5zV
2016-10-28 11:40:32 +01:00
Dão Gottwald
541f5a3c25 Bug 1304617 - Avoid using the ordinal attribute for positioning the Hide / Show Recently Bookmarked menu items. r=mak 2016-10-13 18:47:52 +02:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin
MozReview-Commit-ID: Dh1npORCQ6J
2016-08-16 15:33:05 -07:00
Katie Broida[:ktbee]
0bcb756d06 Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws 2016-08-19 07:27:00 -04:00
Wes Kocher
60df6d1b56 Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
d45a62dd73 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB
2016-08-11 16:51:45 -04:00
Dão Gottwald
9fe86c0970 Bug 1289659 - Account for placesContext not existing in non-browser windows on Mac. r=mdeboer 2016-08-10 13:49:20 +02:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Jared Wein
64ec468589 Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark. r=mak
MozReview-Commit-ID: DNqcu5vxrBG
* * *


MozReview-Commit-ID: 3KoNVklCK8d
2016-07-06 07:27:00 +02:00
Scott Wu
cdf8013d9a Bug 754623 - Get page title from tab label; r=mak
MozReview-Commit-ID: BOXUKUcA0fZ
2016-05-19 12:45:21 +08:00
Dão Gottwald
53646327b9 Bug 1257087 - Middle mouse click on history item should open it. r=mak 2016-05-25 18:15:15 +02:00
Dão Gottwald
afd98e3cc6 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
e2b9fd07a5 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
f294e5ef5b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-20 14:41:49 +02:00
Mike de Boer
bb1fb58dcc Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
356268be93 Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open. r=mak 2016-05-04 16:52:40 +02:00
Carsten "Tomcat" Book
7eb9095b50 merge mozilla-inbound to mozilla-central a=merge 2016-05-02 11:25:32 +02:00
Matt Brubeck
d9d992c252 Bug 943888 - Always keep the bookmark star button enabled [r=mak]
MozReview-Commit-ID: 27ee1dbLSM1
2016-04-25 13:59:00 -07:00
Scott Wu
e88688a3cb Bug 446171 - Part 1: Get page titles from tab and not depend on history; r=mak
MozReview-Commit-ID: EUQv2p9LxtY
2016-03-21 14:57:18 +08:00
Dão Gottwald
7412b86381 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Wes Kocher
366e3a081a Backed out changeset fec92924befb (bug 1250203) for bc leaks
MozReview-Commit-ID: BMq0vBarOQZ
2016-04-15 12:19:44 -07:00
Dão Gottwald
07e467fc94 Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-15 16:50:20 +02:00
Sebastian Hengst
19ef2b5693 Backed out changeset 81df156cb345 (bug 1250203) for test failures in mochitest-5 test_ext_bookmarks.html, browser-chrome browser_views_liveupdate.js, OS X xpcshell test_browserGlue_migrate.js and maybe more. r=backout on a CLOSED TREE 2016-04-08 18:42:07 +02:00
Dão Gottwald
a9266fbadc Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-08 16:33:21 +02:00
malayaleecoder
638ea233f5 Bug 1254496 - Remove gURLBar null-checks. r=dao 2016-03-10 23:15:49 +05:30
Marco Bonardo
49938bf053 Bug 1253930 - Recently bookmarked items have the default favicon instead of the correct one. r=dao
MozReview-Commit-ID: LMTVQetQL9Q
2016-03-07 12:06:40 +01:00