Olli Pettay
606e57d58a
Bug 466856 - Crash [@ nsTypedSelection::CopyRangeToAnchorFocus], r+sr=roc
2009-02-26 18:36:34 +02:00
Peter Van der Beken
30d54eb9a7
Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz.
2009-01-14 13:24:10 +01:00
Peter Van der Beken
4c7b70dbc9
Back out changeset 9fd8740decb8 (Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles).) to try to fix orange.
2009-01-14 15:12:37 +01:00
Peter Van der Beken
a638221f4a
Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz.
2009-01-14 13:24:10 +01:00
Benjamin Smedberg
0f95227641
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a084ac404
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Uri Bernstein
f07bc84d72
Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc
2009-01-08 22:17:49 +01:00
Mats Palmgren
0eb7b02ef8
Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc
2008-12-08 00:11:37 +01:00
Vladimir Vukicevic
42e5c567b6
b=461813, crash in nsFrameSelection::HandleDrag; r+sr=roc
2008-11-04 11:29:13 -08:00
Markus Stange
615b3a4ee1
Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc
2008-11-04 15:38:16 +01:00
Benjamin Smedberg
91a3d948e0
Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc
2008-10-30 10:15:22 -07:00
Benjamin Smedberg
f4133116e4
Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410.
2008-10-28 02:47:40 -04:00
Benjamin Smedberg
e6bf9e93fd
Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc
2008-10-28 00:47:19 -04:00
Uri Bernstein
ab84639432
Bug 459921 - Double-click-and-drag selects previous word when dragging to left half of first letter of a word. r+sr=roc.
2008-10-21 11:52:52 +02:00
Uri Bernstein
c72ab700ee
Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc.
2008-10-17 21:46:33 +02:00
Theppitak Karoonboonyanan
1703d4c904
Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc
2008-10-16 20:44:32 +13:00
Olli Pettay
e4345417cd
bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking
2008-10-15 12:40:28 +03:00
Uri Bernstein
bd1f6dba4a
Bug 459660: Remove two unused members of nsTypedSelection and their accessors. r+sr=roc.
2008-10-13 23:25:21 +02:00
Uri Bernstein
760fdefd8c
Bug 459588: Kill OLD_SELECTION code. r+sr=roc.
2008-10-13 00:11:51 +02:00
Uri Bernstein
fc382ab3d0
Bug 426766: Cursor keys behave weirdly in "view source" window. r+sr=roc.
2008-10-09 12:07:16 +02:00
Uri Bernstein
45724fce6e
Bug 458089: Kill VISUALSELECTION code. r=smontagu, sr=roc.
2008-10-09 12:05:30 +02:00
Alexander Surkov
b50bd7e887
Bug 456944 - Crash when spell checking selection changes, r=smaug, sr=roc
2008-10-08 20:53:14 +08:00
Graeme McCutcheon
93b55448a4
Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc
2008-09-07 16:12:50 +02:00
Uri Bernstein
8c618073ad
Merge commit for bug 210197
2008-08-09 19:34:08 +03:00
Uri Bernstein
b5db30ef38
Unconditionally reset mDragSelectingCells to false on mouse-up, so that the system doesn't remain in table selection mode when dragging outside a table. bug=210197. r+sr=mats.palmgren
2008-08-09 18:09:37 +03:00
Asaf Romano
95767c850b
Bug 263683 - Findbar's Highlight feature should not manipulate the DOM. Patch by Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>, r=me,roc. sr=roc.
2008-07-30 23:48:56 +03:00
b78179b566
bug 345759 - Spell as you type not accessible, r=aaronlev, r=Olli.Pettay, sr=neil
2008-07-17 14:06:24 +02:00
John Daniels
2aef16c1bf
Bug 419532 – deCOMtaminate nsICaret. r+sr=roc
2008-07-16 12:52:01 +02:00
Benjamin Smedberg
8886216dff
Bug 442729 - Annotate stack-only classes in layout, r+sr=roc
2008-07-01 15:16:45 -04:00
6971cc0752
Bug 423523: Caret can leave div w/ contenteditable = true with repeated arrow keys, patch by Chris Pearce <chris@pearce.org.nz>, r+sr=peterv, a=beltzner
2008-04-23 15:33:14 -07:00
c28a527a14
Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons
2008-04-14 18:04:18 -07:00
08c190bb1e
When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest (v3) by Martijn Wargers.
2008-03-31 10:47:42 -07:00
a292b44ee8
reverting fix for 392746 due to unexplained failure of /tests/toolkit/content/tests/widgets/test_colorpicker_popup.xul
2008-03-30 14:55:37 -07:00
7dbf778dbb
When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest by Martijn Wargers.
2008-03-30 11:13:29 -07:00
0ccdef5621
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner
2008-02-28 07:28:37 -08:00
4aa69fa997
backing out the previous patch, becaused qm-centos5-01 dep unit test is orange
2008-02-28 05:59:25 -08:00
3538ede317
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner
2008-02-28 03:01:56 -08:00
836d6685cd
Make nsTypedSelection ctors initialize all members (fixes an UMR) and reorder members to save space. b=417895 r+sr=roc a=blocking1.9
2008-02-26 07:04:14 -08:00
d53278e296
Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep
2008-02-21 18:24:04 -08:00
439d9b7115
Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures.
2008-02-20 03:10:16 -08:00
46fdf03ed0
Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep]
2008-02-20 02:19:31 -08:00
351de4d3bf
Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745).
2008-02-15 12:20:55 -08:00
ba51f7f475
Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner]
2008-02-14 21:30:34 -08:00
750ad2685e
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 12:47:33 -08:00
2927dedce8
Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron
2007-10-09 17:00:05 -07:00
9f351ff772
remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc
2007-10-01 16:20:37 -07:00
2696c68ab6
Bug 371680 - expose nsIAccessibleText::scrollSubstringTo, r=aaronlev, roc, sr=roc, a=roc
2007-08-23 21:54:45 -07:00
060596c3e9
Make sure layout is up to date before moving the caret. Bug 375436 followup to fix orange, pending reviews from roc.
2007-08-21 22:13:24 -07:00
d0829b5bfc
Make sure to process style updates before reflow, and both before painting. Bug 375436, r+sr=roc, a=dbaron
2007-08-21 19:57:06 -07:00