Commit Graph

1725 Commits

Author SHA1 Message Date
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
f6849f1603 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Bryce Seager van Dyk
10b0486085 Bug 1673917 - Rename vprintf style nsTSubstring::AppendPrintf -> AppendVprintf. r=sg
This patch also expands tests to check that the results of creating string via
both methods are consistent.

Differential Revision: https://phabricator.services.mozilla.com/D95053
2020-10-29 14:51:45 +00:00
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Dimi Lee
ae6f5da965 Bug 1669731 - P4. Add a testcase r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D93272
2020-10-14 09:17:07 +00:00
Kris Maglione
9b9f8495d2 Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-25 02:01:15 +00:00
Razvan Maries
96e347488a Backed out changeset 737f0e3e2f94 (bug 1660057) for xpcshell perma failures. CLOSED TREE 2020-09-24 23:25:54 +03:00
Kris Maglione
ab4a388891 Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-24 18:35:58 +00:00
Simon Giesecke
ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Emilio Cobos Álvarez
fe8e2251a1 Bug 1664432 - Remove -moz-user-disabled. r=edgar
We treat it exactly the same as -moz-broken. The pseudo-class is not
exposed to content, so I don't think we have a reason to keep it around.

Differential Revision: https://phabricator.services.mozilla.com/D89904
2020-09-11 19:26:40 +00:00
Chris Peterson
7fa2183e8c Bug 1663058 - Replace MOZ_MUST_USE with [[nodiscard]] in toolkit/components/url-classifier. r=dimi
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Depends on D89258

Differential Revision: https://phabricator.services.mozilla.com/D89259
2020-09-03 21:07:29 +00:00
Simon Giesecke
a8062966f9 Bug 1659923 - Avoid unnecessary copies around Base64Encode. r=xpcom-reviewers,necko-reviewers,froydnj,valentin
This also adds some more variants of Base64Encode and Base64EncodeAppend.

Differential Revision: https://phabricator.services.mozilla.com/D87559
2020-08-19 17:45:16 +00:00
Butkovits Atila
7d07d0a0cb Backed out changeset d48e99735b2c (bug 1653568) for failure at test_classify_by_default.html. CLOSED TREE 2020-08-18 15:32:17 +03:00
Dimi Lee
0c0eca4701 Bug 1653568 - Add testcase to make sure WebSocket is classified by URL Classifier r=baku
Differential Revision: https://phabricator.services.mozilla.com/D83942
2020-08-18 09:24:05 +00:00
tkhan
7fd75b1690 Bug 1657123 - Removing xorigin and fission annotations for Toolkit/Safe Browsing mochitests, r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D85883
2020-08-04 15:09:06 +00:00
Dimi Lee
41a56eb2d8 Bug 1647681 - Add a testcase to ensure channels with top-level sandboxing are classified r=baku
Differential Revision: https://phabricator.services.mozilla.com/D84680
2020-08-03 19:23:56 +00:00
Sebastian Hengst
a40afb7960 Bug 1655421 - Set test_fingerprinting.html and test_socialtracking.html as passing with xorig. r=jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D85255
2020-07-29 15:05:44 +00:00
tkhan
b96f217e72 Bug 1655017 - Update xorigin and fission mochitest annotations, r=intermittent-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D84860
2020-07-27 01:16:21 +00:00
Coroiu Cristina
1f44d2bb9b Backed out changeset b71322e45143 (bug 1647681) for mochitest failures at toolkit/components/url-classifier/tests/mochitest/test_classify_top_sandboxed.html on a CLOSED TREE 2020-07-24 16:37:43 +03:00
Dimi Lee
8808e09918 Bug 1647681 - Add a testcase to ensure channels with top-level sandboxing are classified r=baku
Differential Revision: https://phabricator.services.mozilla.com/D84680
2020-07-23 15:34:56 +00:00
tkhan
5cc1917c10 Bug 1653400 - Add xorigin and fission annotations, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D84006
2020-07-23 18:05:05 +00:00
Dimi Lee
74d729c1a5 Bug 1654438 - Add mochi.xorigin-test to whitelistHosts pref r=gcp
In fission cross-origin mochitests, "mochi.xorigin-test" is the
top-level url instead of "mochi.test".
Our pairwise whitelist has to use the right top-level host accordingly
to make testcase work.

Differential Revision: https://phabricator.services.mozilla.com/D84585
2020-07-23 12:22:45 +00:00
Razvan Maries
fe3e123a43 Backed out 2 changesets (bug 1653568) for perma failures on test_classify_by_default.html. CLOSED TREE
Backed out changeset a7579719654a (bug 1653568)
Backed out changeset 5c2193152723 (bug 1653568)
2020-07-21 11:07:18 +03:00
Coroiu Cristina
0e95f34b3d Bug 1653568 - fix lint failure a=fix on a CLOSED TREE 2020-07-21 10:33:40 +03:00
Dimi Lee
edf5486bad Bug 1653568 - Add a testcase to make sure WebSocket is classified by URL Classifier r=baku
Differential Revision: https://phabricator.services.mozilla.com/D83942
2020-07-17 13:55:54 +00:00
Frederik Braun
617d3006d9 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
tkhan
ee01624549 Bug 1650919 - Adding manifest annotations for xorigin test harness. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D82763
2020-07-13 20:34:46 +00:00
Bogdan Tara
3c06465cef Backed out changeset 1a0f002865d3 (bug 1650919) for test_deprecated.html failures CLOSED TREE 2020-07-13 19:22:21 +03:00
tkhan
ff22d64560 Bug 1650919 - Adding manifest annotations for xorigin test harness. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D82763
2020-07-13 13:01:43 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Dimi Lee
aa143866ce Bug 1437626 - P4. Test requests sent in a service worker is classified r=baku
This patches does the following:
1. Test fetch in service worker should be classified.
2. Test requests should not be classified when it is whitelisted.
3. Test requests should not be classified when it is a first-party.

Depends on D80184

Differential Revision: https://phabricator.services.mozilla.com/D80185
2020-07-08 12:27:14 +00:00
Andrea Marchesini
50a6d0f5ed Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D82497
2020-07-07 16:17:11 +00:00
Sylvestre Ledru
2f24605d75 Bug 1519636 - Reformat recent changes to the Google coding style r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D82178
2020-07-04 09:38:43 +00:00
Noemi Erli
3abcd21207 Backed out 4 changesets (bug 1437626) for causing ES lint failure CLOSED TREE
Backed out changeset c9a432ac1964 (bug 1437626)
Backed out changeset 905916b5ee1a (bug 1437626)
Backed out changeset c692ce0d363a (bug 1437626)
Backed out changeset fcd023c403bc (bug 1437626)
2020-07-02 11:05:40 +03:00
Dimi Lee
3a61ac5abd Bug 1437626 - P4. Test requests sent in a service worker is classified r=baku
This patches does the following:
1. Test fetch in service worker should be classified.
2. Test requests should not be classified when it is whitelisted.
3. Test requests should not be classified when it is a first-party.

Depends on D80184

Differential Revision: https://phabricator.services.mozilla.com/D80185
2020-07-02 07:20:54 +00:00
Simon Giesecke
a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Dimi Lee
344115a954 Bug 1513674 - Remove nsIMemoryReporter from fixed-length prefix. r=gcp
Right now, now matter which SafeBrowsing protocol we use (V2 or V4), we
always use variable-length prefix set to store prefixes. Since
nsUrlClassifierPrefixSet is a member of VariableLengthPrefixSet and it
is never used alone, we can remove nsIMemoryReporter from it to prevent
calculating the same memory report twice.

Differential Revision: https://phabricator.services.mozilla.com/D81171
2020-06-30 05:40:02 +00:00
Mathieu Leplatre
4a882eabb4 Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-24 10:00:53 +00:00
Jean-Yves Avenard
4d64459120 Bug 1647133 - P2. Make nsIURIClassifier take a nsISerialEventTarget. r=gcp
The argument aEventTarget is actually never used by any caller; nullptr is always passed for it.

But the code is there in case it isn't null which would call into IProtocol::SetEventTargetFor

Depends on D80419

Differential Revision: https://phabricator.services.mozilla.com/D80421
2020-06-22 14:46:01 +00:00
tkhan
00168e2bff Bug 1602668 - M(1) manifest and test changes. r=kmag,karlt,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D70362
2020-06-22 19:09:49 +00:00
Csoregi Natalia
8b9a10c396 Backed out changeset a0af6d53c082 (bug 1639284) for multiple failures e.g. browser_asrouter_whatsnewpanel.js CLOSED TREE 2020-06-22 12:20:39 +03:00
Mathieu Leplatre
27dc624708 Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-22 08:21:40 +00:00
Cosmin Sabou
6fd9645044 Backed out changeset 7e39d1eed06b (bug 1639284) for xpcshell failures on test_blocklist_severities.js. CLOSED TREE 2020-06-18 17:29:29 +03:00
Mathieu Leplatre
4c3bab8f1e Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-18 09:47:43 +00:00
Mihai Alexandru Michis
9e01eae954 Backed out changeset da7cbff78183 (bug 1639284) for causing failures in test_engine_selector_remote_settings.js
CLOSED TREE
2020-06-17 20:51:02 +03:00
Kris Maglione
0720b18caa Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00