Commit Graph

54 Commits

Author SHA1 Message Date
Dão Gottwald
b54eac8074 Bug 1626179 - Use the search-textbox custom element in the Synced Tabs sidebar. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D68959
2020-03-31 10:06:16 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
2018-08-08 15:22:53 -07:00
Amy Chan
c6aea6fb8d Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz
2018-04-12 19:22:38 -04:00
Gurzau Raul
9091cce264 Backed out 2 changesets (bug 1446975) for failing xpcshell on sync/tests/unit/test_syncedtabs.js and browser-chrome failures e.g. test/urlbar/browser_page_action_menu.js on a CLOSED TREE
Backed out changeset 69653800c483 (bug 1446975)
Backed out changeset 44e3e7446b02 (bug 1446975)
2018-04-13 01:28:22 +03:00
Amy Chan
b887099e67 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz
2018-04-12 16:18:22 -04:00
Edouard Oger
8578b6545b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh
2018-03-20 17:08:16 -04:00
Michael Kaply
97e2f5fdd4 Bug 1432355 - Add a policy to disable private browsing. r=Gijs
MozReview-Commit-ID: AprbL6usEv5
2018-03-01 10:20:38 -06:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dale Harvey
f1f7c753fd Bug 1411230 - Move synctab sidebar search icon to left. r=dao
MozReview-Commit-ID: 39ctqQlNNOG
2017-11-14 14:05:40 +00:00
Edouard Oger
bf97626bd8 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv
2017-04-18 14:15:43 -04:00
Sebastian Hengst
6471972ae8 Backed out changeset 0a0138825fb5 (bug 1353571) 2017-05-03 21:56:44 +02:00
Edouard Oger
c9a99ae676 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv
2017-04-18 14:15:43 -04:00
Edouard Oger
6bb3388c4a Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF
2017-03-10 20:14:51 -05:00
Wes Kocher
2a580c40a3 Backed out changeset cfe8ab5f1c08 (bug 1269277) for failures in browser_aboutAccounts.js a=backout
MozReview-Commit-ID: FgcSoHPCnoH
2017-03-10 16:55:36 -08:00
Edouard Oger
433b309613 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF
2017-03-09 15:53:08 -05:00
Wes Kocher
a692eeae0b Backed out changeset 805da5d5567f (bug 1269277) for failures in browser_device_connected.js and browser_aboutAccounts.js a=backout
MozReview-Commit-ID: 1xafqaoxNWG
2017-03-10 12:31:13 -08:00
Edouard Oger
a7bd01f4fe Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF
2017-03-09 15:53:08 -05:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Edouard Oger
5439c385e7 Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs. r=markh
MozReview-Commit-ID: IFWtIfl0QZI
2017-01-05 15:40:36 -05:00
Kit Cambridge
390ec1bcc4 Bug 1322408 - Use gBrowser.loadTabs to open all tabs when middle-clicking a client in Synced Tabs. r=markh
MozReview-Commit-ID: 6phgHjAAXUs
2016-12-07 11:46:36 -10:00
Edouard Oger
d2392f97e8 Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3
2016-08-19 17:10:45 -07:00
Sebastian Hengst
e4b461b181 Backed out changeset bbe3a00528ed (bug 1288247) for failing test_TabListComponent.js. r=backout 2016-08-24 18:22:40 +02:00
Edouard Oger
a48f5cedf3 Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3
2016-08-19 17:10:45 -07:00
Edouard Oger
f67773f756 Bug 1297473 - Check for first tab in synced tabs sidebar before assigning tabindex. r=markh
MozReview-Commit-ID: 9FkT0HpoB8r
2016-08-23 11:11:29 -07:00
Edouard Oger
b7a080c31e Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: LkGNdSF8Znm
2016-05-18 15:45:29 -07:00
Phil Ringnalda
bcab7288cc Back out e7c3a1d7ce27 (bug 1269348) on suspicion of causing failures in test_tab_store.js
CLOSED TREE
2016-05-17 23:20:47 -04:00
Edouard Oger
54cc5d67aa Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: GG34hPxDKcy
2016-05-17 14:15:32 -07:00
Edouard Oger
9fd9e94361 Bug 1260482 - Use SVGs instead of bitmaps for devices in Synced Tabs menu. r=markh 2016-05-10 10:59:00 -04:00
Edouard Oger
b57b279c5a Bug 1269352 - Synced Tabs sidebar does not register duplicate listeners. r=markh 2016-05-04 11:52:00 -04:00
Edouard Oger
13f7aff504 Bug 1247110 - Synced Tabs Sidebar - Fixed keyboard navigation. r=markh 2016-04-14 09:33:00 -04:00
Edouard Oger
6f927aac5c Bug 1261223 - Synced Tabs now uses HiDPI default favicons. r=markh 2016-04-05 09:36:00 -04:00
Kit Cambridge
e9b39583ec Bug 1257008 - Don't collapse the tab list when right-clicking on a device in the Synced Tabs sidebar. r=markh
MozReview-Commit-ID: JsaWLfMOYyC
2016-03-15 16:56:52 -07:00
Kit Cambridge
7229c73ac8 Bug 1262310 - Fix opening synced tabs from the sidebar. r=markh
MozReview-Commit-ID: 8VHbEqsyuF2
2016-04-05 17:06:00 -07:00
Carsten "Tomcat" Book
bed6b58c78 Backed out changeset 902ee4a0983d (bug 1261223) for XPC failures 2016-04-05 09:18:57 +02:00
Edouard Oger
c1854c9701 Bug 1261223 - Synced Tabs now uses HiDPI default favicons. r=markh 2016-04-04 11:33:00 +02:00
Kit Cambridge
8b7ad60498 Bug 1246156 - Show additional link options in the synced tabs sidebar context menu. r=markh
MozReview-Commit-ID: 44KlEasJiLc
2016-03-10 15:56:25 -08:00
Mark Hammond
40abeb4a37 Bug 1247345 - arrange for the searchbox to not scroll in the SyncedTabs sidebar. r=Gijs 2016-03-29 22:08:13 +11:00
Carsten "Tomcat" Book
4d9e7cebd8 Backed out changeset c325569a1f4d (bug 1247345) for test failures in browser_sidebar_syncedtabslist.js 2016-03-29 11:55:33 +02:00
Mark Hammond
8cfe6a44c0 Bug 1247345 - arrange for the searchbox to not scroll in the SyncedTabs sidebar. r=Gijs 2016-03-24 08:52:12 +11:00