Commit Graph

681 Commits

Author SHA1 Message Date
Mihai Alexandru Michis
e10f79168a Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
2d5f151948 Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 05:25:03 +00:00
Butkovits Atila
91af0d3269 Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione
cebae4d59b Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101486
2021-01-28 03:32:43 +00:00
Gijs Kruitbosch
b36f54e0e6 Bug 1680216 - measure paint delay induced by initializing bookmarks toolbar later, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D101731
2021-01-22 02:59:29 +00:00
Gijs Kruitbosch
92360a48e9 Bug 1681138 - avoid delaying loading the bookmarks toolbar in new windows post-startup, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D101689
2021-01-22 12:42:25 +00:00
Bogdan Tara
70e7d8daea Backed out 2 changesets (bug 1680216, bug 1681138) for browser_984455_bookmarks_items_reparenting.js failures
Backed out changeset 09beb66ab605 (bug 1680216)
Backed out changeset 5e8e8cc89f61 (bug 1681138)
2021-01-22 04:55:12 +02:00
Gijs Kruitbosch
b5cc25b297 Bug 1680216 - measure paint delay induced by initializing bookmarks toolbar later, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D101731
2021-01-22 01:10:50 +00:00
Gijs Kruitbosch
886631d364 Bug 1681138 - avoid delaying loading the bookmarks toolbar in new windows post-startup, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D101689
2021-01-22 01:13:39 +00:00
Jared Wein
2f28ab9ee0 Bug 1682553 - Move bookmarks listeners to PlacesUIUtils so there will only be one listener instead of one per window. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99923
2020-12-18 21:35:09 +00:00
Mike Conley
7d395050a0 Bug 1682022 - Fork some strings from the menubar set in preparation to move them to sentence case. r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D100042
2020-12-18 21:06:03 +00:00
Mike Conley
0729eef6ca Bug 1682022 - Convert some bookmarking strings to Fluent. r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D100041
2020-12-18 21:09:22 +00:00
Razvan Maries
eff801a858 Backed out changeset b5a13cf5b066 (bug 1682553) for perma failures on browser_bookmarks_toolbar_telemetry.js. CLOSED TREE 2020-12-18 22:02:13 +02:00
Jared Wein
eb675cbafd Bug 1682553 - Move bookmarks listeners to PlacesUIUtils so there will only be one listener instead of one per window. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99923
2020-12-18 18:29:42 +00:00
Micah Tigley
a5ff856247 Bug 1674840 - Add Other Bookmarks folder to toolbar dynamically. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99701
2020-12-17 16:52:35 +00:00
Micah Tigley
04928862eb Bug 1680732 - Call updateNodesVisibility() from 'Show Other Bookmarks' pref observer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D98777
2020-12-10 20:42:40 +00:00
Gijs Kruitbosch
144ce9b683 Bug 1678921 - make empty toolbar disclaimer take up no horizontal space, so the entire toolbar functions as a drag target for bookmarks, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D98546
2020-12-02 23:38:04 +00:00
Micah Tigley
4709190877 Bug 1678662 - Add a listener to respond to changes when the 'Show Other Bookmarks' pref is changed. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D98397
2020-12-02 20:00:47 +00:00
Micah Tigley
41687e7f07 Bug 1678659 - Update Fluent strings for bookmarks toolbar submenu. r=jaws,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D98373
2020-12-01 21:28:58 +00:00
Dão Gottwald
f1cf8c85f6 Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D98028
2020-11-26 21:54:32 +00:00
Marco Bonardo
5fee7240ed Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 16:28:04 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
2020-11-23 16:49:31 +02:00
Marco Bonardo
ae29233b62 Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 12:56:40 +00:00
Gijs Kruitbosch
a69698a340 Bug 1667237 - bookmarks toolbar flickers on startup / new windows in some cases, r=florian,jaws
Differential Revision: https://phabricator.services.mozilla.com/D97712
2020-11-20 13:22:38 +00:00
Micah Tigley
2218b31ae9 Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97211
2020-11-19 21:49:26 +00:00
Narcis Beleuzu
016b07dbf6 Backed out 2 changesets (bug 1674539) for bc failures on browser_toolbar_other_bookmarks.js . CLOSED TREE
Backed out changeset 63032f8390ea (bug 1674539)
Backed out changeset 36ab7b9324d9 (bug 1674539)
2020-11-19 23:46:02 +02:00
Micah Tigley
afe05f330b Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97211
2020-11-19 20:40:04 +00:00
Jared Wein
1cacf7d2fc Bug 1665391 - Add telemetry to measure effectiveness of 2h2020 bookmarks changes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D97251
2020-11-19 16:01:25 +00:00
Jared Wein
1aeee18f35 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96763
2020-11-14 01:07:35 +00:00
Jared Wein
c763bedef6 Bug 1674091 - Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96764
2020-11-14 01:07:28 +00:00
Jared Wein
35a2f81166 Bug 1674091 - Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96762
2020-11-14 01:07:28 +00:00
Cosmin Sabou
c02cd339df Backed out 3 changesets (bug 1674091) for bookmarks.jsm bc related failures.
Backed out changeset b37a366b6bca (bug 1674091)
Backed out changeset 4d49ba20a908 (bug 1674091)
Backed out changeset c2ed373e6fc3 (bug 1674091)
2020-11-13 02:37:56 +02:00
Jared Wein
63643ae16e Bug 1674091 - Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96764
2020-11-12 21:23:54 +00:00
Jared Wein
09cc1da1b4 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96763
2020-11-12 21:23:52 +00:00
Jared Wein
890c772341 Bug 1674091 - Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96762
2020-11-12 21:23:50 +00:00
Gijs Kruitbosch
8159be9844 Bug 1675551 - ensure we can use the browser.toolbars.bookmarks.2h2020 pref for experiments and enable it on early beta, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96709
2020-11-11 15:36:00 +00:00
Jared Wein
721fa81844 Bug 1674199 - Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95196
2020-11-10 04:18:47 +00:00
Gijs Kruitbosch
dffaa65a4a Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 23:16:56 +00:00
Csoregi Natalia
6a0cdbf039 Backed out changeset ca520bfdc084 (bug 1674515) for failures on browser_autoshow_bookmarks_toolbar.js. CLOSED TREE 2020-11-09 19:32:08 +02:00
Gijs Kruitbosch
f6a60b989e Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D96329
2020-11-09 16:00:29 +00:00
Gijs Kruitbosch
0a0c86d14c Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-05 21:08:10 +00:00
Gijs Kruitbosch
452154d8d1 Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94879
2020-11-05 21:08:09 +00:00
Gijs Kruitbosch
13baffef64 Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
2020-11-05 21:08:40 +00:00
Jared Wein
328aa2d63d Bug 1674160 - Don't show the bookmarks toolbar if there are no visible toolbarbuttons or toolbaritems. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95539
2020-11-05 23:00:55 +00:00
Jared Wein
84ba59a4bb Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 23:00:47 +00:00
Narcis Beleuzu
f5b44dd87b Backed out 4 changesets (bug 1425290, bug 1432604, bug 1665389) for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js . CLOSED TREE
Backed out changeset 455ff5647429 (bug 1432604)
Backed out changeset cf70da964b70 (bug 1425290)
Backed out changeset e6b38d403cc3 (bug 1425290)
Backed out changeset 09f049232773 (bug 1665389)
2020-11-05 23:01:31 +02:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Gijs Kruitbosch
393befad12 Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94880
2020-11-04 23:43:05 +00:00
Gijs Kruitbosch
e0585a1ea6 Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Differential Revision: https://phabricator.services.mozilla.com/D94879
2020-11-04 23:24:35 +00:00
Gijs Kruitbosch
9bcce69d4a Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
2020-11-04 23:24:27 +00:00