corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
866,896 Commits 1 Branch 0 Tags
defd76eb83814f97a46d5af2bd9efa3690377db1
Commit Graph

167 Commits

Author SHA1 Message Date
Gijs Kruitbosch
772edac095 Bug 1900663 - reuse existing windows as openers when opening a window from the macOS dock menu, r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D212625
 2024-07-02 14:15:21 +00:00
Gijs Kruitbosch
40e851d728 Bug 1905692 - use JS to handle activation/click of sidebar close button in non-revamped sidebar, r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D215379
 2024-07-01 19:40:55 +00:00
Jonathan Sudiaman
3fe0267737 Bug 1904868 - Fix leaks from PlacesQuery when closing during a fetch in progress r=sidebar-reviewers,fxview-reviewers,places-reviewers,Standard8 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05328f734d54c873b30256da3cdf783a73abab50

Differential Revision: https://phabricator.services.mozilla.com/D215023
 2024-07-01 16:53:41 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements 
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
 2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D212285
 2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 18:15:25 +00:00
Nikki Sharpley
cb083a0f14 Bug 1896987 - Fix browser_sidebar_context_menu.js intermittent r=sidebar-reviewers,jsudiaman 
`BrowserTestUtils.isVisible` is failing on some platforms despite being visible. Other tests
in the same suite simply check the existence of `sidebar` so reverting to that.

Differential Revision: https://phabricator.services.mozilla.com/D214563
 2024-06-21 17:49:54 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 14:00:00 +00:00
Nikki Sharpley
77be78d994 Bug 1896987 - Fix browser_sidebar_context_menu.js intermittent r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D213807
 2024-06-20 14:39:00 +00:00
Mark Striemer
cabc85f076 Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-19 18:37:37 +00:00
Mark Striemer
fb377d8a08 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-19 18:37:37 +00:00
Kelly Cochrane
e2fe9bf11e Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D213278
 2024-06-18 18:24:08 +00:00
pstanciu
e91ba02454 Backed out changeset ab055e5ace5e (bug 1899576) for causing bc failures on browser_all_files_referenced.js CLOSED TREE 2024-06-18 20:49:29 +03:00
Kelly Cochrane
c8bfc52deb Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D213278
 2024-06-18 16:03:11 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-15 10:43:19 +00:00
Ed Lee
3cefd95d0b Bug 1899827 - Stub initial conditional sidebar depending on chat pref r=tarek,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,flod,sclements 
Add placeholder chat page that is shown in old sidebar when pref is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D212756
 2024-06-15 01:48:55 +00:00
Sandor Molnar
34e807bc63 Backed out 5 changesets (bug 1897529, bug 1901336, bug 1900126) for causing bc failures @ browser_a11y_sidebar.js CLOSED TREE 
Backed out changeset 334b820a4c19 (bug 1897529)
Backed out changeset 70350abadcba (bug 1900126)
Backed out changeset 3d631de2ce01 (bug 1897529)
Backed out changeset 1d654154d5ea (bug 1897529)
Backed out changeset a8f7b541a548 (bug 1901336)
 2024-06-14 22:41:48 +03:00
Mark Striemer
d06b2bcf0e Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-14 18:18:19 +00:00
Mark Striemer
caac4b33d7 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-14 18:18:19 +00:00
Iulian Moraru
7af9a3a07c Backed out changeset 7c5bb1ba9d20 (bug 1893655) for causing bc failures on browser_vertical_tabs.js. 2024-06-14 18:43:35 +03:00
Nikki Sharpley
47dbba19cd Bug 1902051 - Fix browser_sidebar_prefs.js intermittent r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D213445
 2024-06-14 13:27:36 +00:00
Sarah Clements
4758236bb0 Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-14 13:01:40 +00:00
Tamas Szentpeteri
7b9a55f977 Backed out 4 changesets (bug 1900126, bug 1897529, bug 1901336) for causing mochitest failures on test_moz_message_bar.html. CLOSED TREE 
Backed out changeset 212bac58cc17 (bug 1900126)
Backed out changeset efaba56826e3 (bug 1897529)
Backed out changeset 9c52e2ac9df2 (bug 1897529)
Backed out changeset fc94dfe91c29 (bug 1901336)
 2024-06-14 06:09:39 +03:00
Mark Striemer
7b96f60e6a Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213330
 2024-06-13 21:52:53 +00:00
Mark Striemer
75fb7b5b6c Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D213328
 2024-06-13 21:52:53 +00:00
Nikki Sharpley
cc7dd2025a Bug 1896987 - Fix browser_sidebar_context_menu.js intermittent r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D213467
 2024-06-13 17:57:27 +00:00
Sam Foster
c1d6738d4c Bug 1896914 - Hide the new sidebar when in DOM fullscreen. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D212975
 2024-06-12 19:04:12 +00:00
Kelly Cochrane
e8c800fec8 Bug 1902008 - Fix for intermittent failure in browser/components/sidebar/tests/browser/browser_sidebar_max_width.js r=nsharpley,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D213433
 2024-06-12 15:50:51 +00:00
Nikki Sharpley
250538c1ef Bug 1901885 - Fix browser_adopt_sidebar_from_opener.js intermittent r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D213431
 2024-06-12 15:25:30 +00:00
Nikki Sharpley
dfc9c84b23 Bug 1891777 - Add a tools pref to the sidebar revamp r=sidebar-reviewers,kcochrane 
Rather than persisting via SessionStore, as the original bug suggests, use a pref to globally
store the disabled/enabled state of the sidebar tools.

Not entirely unrelated, I added a test for adopting the sidebar from an opener window as well.

Differential Revision: https://phabricator.services.mozilla.com/D212853
 2024-06-12 15:06:01 +00:00
Tamas Szentpeteri
795db7bf00 Backed out changeset 8c48512a48de (bug 1891777) for causing mochitest failures on browser_sidebar_prefs.js 2024-06-12 17:36:22 +03:00
Nikki Sharpley
c5c36beb8e Bug 1891777 - Add a tools pref to the sidebar revamp r=sidebar-reviewers,kcochrane 
Rather than persisting via SessionStore, as the original bug suggests, use a pref to globally
store the disabled/enabled state of the sidebar tools.

Not entirely unrelated, I added a test for adopting the sidebar from an opener window as well.

Differential Revision: https://phabricator.services.mozilla.com/D212853
 2024-06-12 13:22:13 +00:00
Nikki Sharpley
45ae83c603 Bug 1901673 - Fix browser_hide_sidebar_on_popup intermittent r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D213223
 2024-06-12 13:17:42 +00:00
Kelly Cochrane
2858cd5222 Bug 406629 - Setting sidebar max-width to 75 percent of viewport width r=sidebar-reviewers,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D211440
 2024-06-12 12:06:32 +00:00
Kelly Cochrane
7a1e691737 Bug 1896988 - Fix for intermittent failure in browser_customize_sidebar.js r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D213243
 2024-06-12 12:03:52 +00:00
Nikki Sharpley
0f28ad6176 Bug 1901262 - Add test for adopting the sidebar from the opener window r=sidebar-reviewers,sfoster 
It was recommended in https://phabricator.services.mozilla.com/D210218 that we have a
test for checking the sidebar is correctly adopted from the opener window when opening
an additional window.

Differential Revision: https://phabricator.services.mozilla.com/D212951
 2024-06-11 13:48:46 +00:00
Nikki Sharpley
f60a47f6c5 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane 
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
 2024-06-10 22:44:53 +00:00
Tamas Szentpeteri
1b4d233427 Backed out changeset 4ab23ba75a11 (bug 1895868) for causing mochitest failures on browser_history_sidebar.js 2024-06-10 21:55:16 +03:00
Nikki Sharpley
878b2fc533 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane 
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
 2024-06-10 17:37:11 +00:00
Nikki Sharpley
79b74fdc93 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements 
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
 2024-06-10 13:42:10 +00:00
Norisz Fay
f69ee9dbb8 Backed out changeset e650be9ceb1f (bug 1894222) for causing bc failures on browser_customize_sidebar.js CLOSED TREE 2024-06-06 06:27:05 +03:00
Ed Lee
93d51ae3f5 Bug 1894990 - Re-work logic for adding Megalist to sidebar to align with revamped sidebar r=mtigley,sidebar-reviewers,kcochrane 
Consolidate custom megalist sidebar logic to a helper for pref-controlled sidebars.

Differential Revision: https://phabricator.services.mozilla.com/D212240
 2024-06-05 18:59:31 +00:00
Nikki Sharpley
5e7bc1e164 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements 
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
 2024-06-05 17:13:07 +00:00
Kelly Cochrane
0f32bd57a5 Bug 1896623 - Ensure 'customize sidebar' option isn't added to menu bar View > Sidebars menu r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D210853
 2024-05-30 14:08:34 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu 
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
 2024-05-28 15:55:49 +00:00
Nikki Sharpley
f2f0a26b06 Bug 1892033 - Move sidebar style persistence from XULstore to SessionStore r=sidebar-reviewers,sessionstore-reviewers,backup-reviewers,dao,Gijs,sclements,kpatenio 
Move style persistence from XULstore to SessionStore.

Follow up bug to fix persistence of sidebar when only a new tab is open and window is closed, and its
accompanying test `browser_sidebar_persist.js`: Bug 1898613

Depends on D207048

Differential Revision: https://phabricator.services.mozilla.com/D207787
 2024-05-24 20:16:31 +00:00
Kelly Cochrane
8f3ea55cfc Bug 1894221 - Add Sidebar Extensions section to Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,bolsson,sclements,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210381
 2024-05-21 14:00:03 +00:00
Kelly Cochrane
67d49fd057 Bug 1892012 - Add toolbar entry point for the sidebar as a default setting r=sidebar-reviewers,Gijs,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D209978
 2024-05-17 16:37:16 +00:00
Kelly Cochrane
0b3b1956ca Bug 1896658 - Add bookmarks to sidebar customization panel r=sidebar-reviewers,fluent-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210378
 2024-05-15 19:48:00 +00:00