Commit Graph

607 Commits

Author SHA1 Message Date
Julian Descottes
1820ae6d22 Bug 1767769 - [devtools] Properly wait for errors in browser_resources_error_messages.js r=devtools-reviewers,nchevobbe
Replace hardcoded timeout with waiting for resource

Differential Revision: https://phabricator.services.mozilla.com/D245888
2025-04-17 12:20:12 +00:00
Julian Descottes
4e2af88d45 Bug 1889407 - [devtools] Fix browser_target_configuration_command_custom_user_agent.js r=devtools-reviewers,nchevobbe
Make sure to await watchResources before using fetch

Differential Revision: https://phabricator.services.mozilla.com/D245473
2025-04-15 08:19:05 +00:00
Julian Descottes
94f8527c94 Bug 1959345 - [devtools] Disable frequently failing devtools tests r=jmaher,devtools-reviewers,ochameau
Mostly restoring skip-ifs which still seem useful given recent failures.

Differential Revision: https://phabricator.services.mozilla.com/D245247
2025-04-14 15:52:50 +00:00
Julian Descottes
d534438b4d Bug 1767778 - [devtools] Ignore unrelated workers from browser_target_command_browser_workers r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D245265
2025-04-14 08:04:53 +00:00
Julian Descottes
b0222e2216 Bug 1767768 - [devtools] Skip will-navigate assert in browser_resources_document_events.js on slow platforms r=ochameau,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245240
2025-04-14 07:59:24 +00:00
Joel Maher
76447d27c5 Bug 1957258 - cleanup devtools-chrome .toml manifest, enable many tests! r=aryx,devtools-reviewers,profiler-reviewers,julienw,ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D243603
2025-04-04 15:06:02 +00:00
Julian Descottes
a87855c091 Bug 1957857 - [devtools] Remove backward compatibility code for cycle 139 r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D244129
2025-04-02 15:37:26 +00:00
Julian Descottes
5979591396 Bug 1957867 - Fix eslint ignore for paths containing target r=frontend-codestyle-reviewers,devtools-reviewers,Standard8,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D244130
2025-04-02 15:36:48 +00:00
Emilio Cobos Álvarez
1fd21d1126 Bug 1956486 - Fix some devtools tests with inline stylesheet caching. r=devtools-reviewers,jdescottes
Network override needs this already for <link>, the test was using
@import to bypass the usual caching.

browser_resources_css_messages.js needs to clear the cache as well now
that reloading might not reparse the stylesheet.

Differential Revision: https://phabricator.services.mozilla.com/D243770
2025-04-01 11:55:57 +00:00
Edgar Chen
82d780e44e Bug 1954685 - Unship onafterscriptexecute and onbeforescriptexecute events on Nightly; r=dom-core,webidl,saschanaz,devtools-reviewers,ochameau,hsivonen,jandem
Differential Revision: https://phabricator.services.mozilla.com/D241940
2025-03-31 19:10:02 +00:00
Julian Descottes
e3081f7b6b Bug 1767781 - [devtools] Restore linux skip-if on browser_target_command_service_workers_navigation.js r=devtools-reviewers,bomsy
After splitting the test in c12995f9bf8e all skip-ifs were removed from the main test.
Within one week, the main test has still failed relatively often on linux, restoring this skip-if.

Differential Revision: https://phabricator.services.mozilla.com/D241298
2025-03-13 07:58:26 +00:00
Julian Descottes
a43ae7c28b Bug 1952901 - [devtools] Filter out addon targets in browser_target_command_frames.js r=devtools-reviewers,ochameau
This is not the main intermittent failure, but the addon targets are sometimes
destroyed in the middle of the test, making it quite flaky.

Differential Revision: https://phabricator.services.mozilla.com/D240874
2025-03-11 16:23:49 +00:00
Julian Descottes
31df1015da Bug 1952482 - Enable prettier for devtools/shared/commands/target r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe
The "target/" rule matches all folders named target regardless of the depth.
Removing redundant entries and adding an exclusion for the devtools folder.

Differential Revision: https://phabricator.services.mozilla.com/D240728
2025-03-10 10:20:40 +00:00
Julian Descottes
68e24566e6 Bug 1767781 - [devtools] Split browser_target_command_service_workers_navigation.js in 2 tests r=devtools-reviewers,ochameau
Only the last test function in the test seems to fail.
Split and enable the initial test.

Differential Revision: https://phabricator.services.mozilla.com/D240495
2025-03-05 19:20:13 +00:00
Julian Descottes
001f7732ce Bug 1808555 - [devtools] Skip browser_resources_last_private_context_exit.js on linux debug r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D240480
2025-03-05 15:06:08 +00:00
Alexandre Poirot
c684086c38 Bug 1944109 - [devtools] Allow debugging scripts via their WindowGlobal target when reusing the browser toolbox codepath. r=devtools-reviewers,devtools-backward-compat-reviewers,hbenl,bomsy
The Browser Toolbox currently debug all scripts in a given content process
via the related Content Process Target actor.
Because of this, we have to ignore the WindowGlobal Target actors
for anything related to Sources, breakpoints,...

But VS.Code would benefit from reusing the Browser Toolbox codepath,
while never using the Content Process targets (which have no real meaning for the user in VS.code),
and instead debug the sources via the WindowGlobal Target actors.

Introduce a new configuration to be able to distinguish the two codepaths.

Differential Revision: https://phabricator.services.mozilla.com/D235681
2025-02-27 09:56:47 +00:00
Alexandre Poirot
e22fbe740c Bug 1944107 - [devtools] Instantiate Content Script targets when debugging all contexts. r=devtools-reviewers,hbenl,bomsy
The TargetCommand will avoid listening for CONTENT_SCRIPT targets for the browser toolbox,
so we can safely enable them in the server.
This will allow VsCode to listen for CONTENT_SCRIPT, while not spawning the CONTENT_PROCESS ones.

Differential Revision: https://phabricator.services.mozilla.com/D235680
2025-02-27 09:56:47 +00:00
Nicolas Chevobbe
b441747d21 Bug 1946442 - [devtools] Fix RuleRewriter when dealing with rules containing nested rules. r=devtools-reviewers,jdescottes.
Create a dummy rule with the content of the rule being modified so we can
check if it has a nested rule. In such case, we can then get the location
of the nested rule so we can insert the added text in the correct position.

A few unit test cases are added to make sure the RuleRewriter does handle
nested rules properly.

Differential Revision: https://phabricator.services.mozilla.com/D237734
2025-02-19 14:08:29 +00:00
Tooru Fujisawa
38bcd773fa Bug 1947063 - Part 1: Add bypassCache option to BrowserTestUtils.reloadTab. r=mossop,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D237560
2025-02-14 15:10:35 +00:00
Alexandre Poirot
40e54fc01c Bug 1944981 - [devtools] Expose a targetType attribute on all target actor forms. r=devtools-reviewers,bomsy
This will help distinguish targets by types in the frontend, as well as in Vs Code.

Differential Revision: https://phabricator.services.mozilla.com/D236268
2025-02-11 13:41:36 +00:00
Alexandre Poirot
83d08122aa Bug 1944104 - [devtools] Flag Content Script and WindowGlobal targets with related addon-id. r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D235679
2025-02-11 13:41:36 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Nicolas Chevobbe
ff34f67aa7 Bug 1941380 - Cap console log string substitution precision for floating point numbers. r=baku,devtools-reviewers,jdescottes.
Test cases are added to check we're handling things correctly.

Differential Revision: https://phabricator.services.mozilla.com/D236109
2025-02-05 13:00:40 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Emilio Cobos Álvarez
4eaad99f2b Bug 581863 - Fix nsWindow coordinates to make sense. r=stransky,win-reviewers,rkraesig,devtools-reviewers,ochameau
I stumbled upon this bug while realizing that some of the math I'm doing
for PiP windows doesn't work at all on Linux (bug 1934760), because
screenX != mozInnerScreenX, even though outerWidth == innerWidth.

I've tested this on X11 and Wayland (plasma and Gnome) with CSD and SSD,
and in general, this is the same thing Windows does, so should be fine.

The basic idea is:

 * Keep mBounds being frame manager bounds (so, outer* and screen*),
   relative to mShell.

 * Keep mClientMargin to translate from mBounds to client bounds.

This is both simpler and makes the math consistent.

Differential Revision: https://phabricator.services.mozilla.com/D230981
2025-02-03 17:08:44 +00:00
Sandor Molnar
fd25f04e12 Bug 1767771 - Disable test 'browser_resources_reflows.js' on linux & win for frequent failures r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D236459
2025-02-01 17:28:36 +00:00
Julian Descottes
071c728519 Bug 1891110 - [devtools] Ignore requests for non-test related network events in browser_resources_network_events_parent_process.js r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D236340
2025-01-31 17:13:34 +00:00
Stanca Serban
5ffef93a6b Backed out changeset 94171e91d5e5 (bug 1941380) for causing build bustages. CLOSED TREE 2025-01-31 10:09:18 +02:00
Nicolas Chevobbe
17d16c361c Bug 1941380 - Cap console log string substitution precision for floating point numbers. r=baku,devtools-reviewers,jdescottes.
Test cases are added to check we're handling things correctly.

Differential Revision: https://phabricator.services.mozilla.com/D236109
2025-01-31 06:02:06 +00:00
Julian Descottes
10b6f848bb Bug 1928535 - [devtools] Fix browser_target_command_reload.js to run with --repeat r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D235971
2025-01-29 17:03:48 +00:00
Alexandru Marc
54f9869da0 Backed out changeset e4fee8872931 (bug 1928535) for causing dt failures @ browser_target_command_reload.js 2025-01-29 18:07:21 +02:00
Julian Descottes
9c143df30a Bug 1928535 - [devtools] Fix browser_target_command_reload.js to run with --repeat r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D235971
2025-01-29 15:06:48 +00:00
Alexandre Poirot
6545daceb2 Bug 1943128 - [devtools] Avoid spawning legacy target listener for shared worker. r=devtools-reviewers,bomsy
The Shared Workers are still only displayed in the Browser Toolbox.

Differential Revision: https://phabricator.services.mozilla.com/D235207
2025-01-29 14:42:57 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Alexandru Marc
7be65d9046 Bug 1767778 - Disable browser_target_command_browser_workers.js on linux1804 x64 for frequent failures r=devtools-reviewers,ochameau DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D234015
2025-01-13 13:57:35 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D233026
2025-01-07 19:51:49 +00:00
Joel Maher
4e9342fda0 Bug 1937925 - Additional devtools greenup on macosx 14.70. r=aryx,devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D232424
2024-12-18 22:59:26 +00:00
Alexandre Poirot
f6cdc992fc Bug 1934478 - Fix sending request from Web Extension and Browser toolboxes. r=extension-reviewers,devtools-reviewers,nchevobbe,rpl
The source of trouble here is the Web Extension Fallback Document,
which is loaded via the system principal and used by DevTools
as the top level target.

Because of it being system principal, we use the special "devtools loader" for ESM.
This is what cause the exception about the "global" option.
Using global attribute set to contextual fixes this exception.

Because of it being the top level target, we are trying to send the request
from its document. But as it is a system principal, it is ignored by the Network Observer.
So that the resent request is sent, but isn't shown.

Using the currently selected target in Network Command helps circumvent that
by sending the request with a real extension document and the request
is then shown in the network monitor.
But this change also impact web page and browser debugging.

Differential Revision: https://phabricator.services.mozilla.com/D231602
2024-12-17 19:02:42 +00:00
Alexandre Poirot
6bf81f433c Bug 1589908 - [devtools] Display worker custom name instead of URL in DevTools. r=devtools-reviewers,nchevobbe
This patch affects both the console context selector and debugger source tree / thread panels.
The URL should still be displayed in tooltips.

Differential Revision: https://phabricator.services.mozilla.com/D231026
2024-12-12 17:31:59 +00:00
Joel Maher
bd0980024e Bug 1936405 - Green up mochitest* on windows 11 24H2. r=aryx,necko-reviewers,jgilbert,devtools-reviewers,omc-reviewers,ochameau,kershaw,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D231746
2024-12-12 02:43:50 +00:00
Alexandre Poirot
43b934b373 Bug 1934666 - [devtools] Avoid selecting a destroying target. r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D231166
2024-12-11 17:22:57 +00:00
Alexandre Poirot
8417905eb2 Bug 1413872 - [devtools] Spawn dedicated target actors for Web Extension Content Scripts. r=devtools-backward-compat-reviewers,devtools-reviewers,rpl,nchevobbe
This should ultimately allow to pick up content script as an evaluation context in the console.

Differential Revision: https://phabricator.services.mozilla.com/D221035
2024-12-10 18:30:57 +00:00
Alexandre Poirot
979b077956 Bug 1918267 - [devtools] Avoid waiting for replies of hanging processes in DevTools communications made to content processes. r=devtools-reviewers,jdescottes
DevTools currently broadcast its data to all processes (in order to reach all service workers, which may run in arbitrary processes).
We expect for the queries to be processed in the content process before replying back to the client/frontend in the related RDP request.

But, in some case, some content process may be stuck on a CC or slow page script.
When this happens, DevTools would be blank on opening or very slow to operate.

Let's try to avoid waiting for any query send to process which timed out on any past query.

Differential Revision: https://phabricator.services.mozilla.com/D229960
2024-12-03 17:54:17 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Sebastian Hengst
4d78eba78c Bug 1922355 - adjust mochitest expectations for macOS 14.70 x86-64. r=jmaher,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229944
2024-11-25 16:28:39 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Alexandre Poirot
2b093042bb Bug 1929004 - [devtools] Record DOM Mutation when tracing from DevTools. r=dthayer
For now, use a custom DOM Marker. But it would be nice to show them from the stack chart.

Differential Revision: https://phabricator.services.mozilla.com/D227832
2024-11-07 15:52:03 +00:00
Alexandre Poirot
8de5c5849e Bug 1921020 - [devtools] Allow evaluating console results reusing the Tracer actor Object Actor Pool. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
This helps ensure that the object actors returned by the console actor evaluation RDP request
are the same for the same JS values being processed and notified via the tracer ressources.
This allows identifying same objects when doing a search per value.

Differential Revision: https://phabricator.services.mozilla.com/D225237
2024-11-04 14:42:51 +00:00
Sandor Molnar
979747c5d4 Backed out 2 changesets (bug 1921020) for causing dt failures @ browser_dbg-javascript-tracer-sidebar-values-search.js CLOSED TREE
Backed out changeset b0ee34e44bb0 (bug 1921020)
Backed out changeset 0f807adadf05 (bug 1921020)
2024-11-01 02:57:08 +02:00