Commit Graph

148 Commits

Author SHA1 Message Date
Goloman Adrian
251308a40f Backed out changeset 9fc3318eca2c (bug 1927258) for causing bc failures @browser_multiselect_tabs_copy_through_drag_and_drop.js. CLOSED TREE 2025-02-27 18:00:00 +02:00
Nikki Sharpley
59098cf49c Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-27 14:25:03 +00:00
Butkovits Atila
c12223cfbb Backed out changeset 7cebb9e8b38c (bug 1927258) for causing failures at browser_tabReorder_vertical.js. CLOSED TREE 2025-02-27 04:26:39 +02:00
Nikki Sharpley
89eef374ea Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-26 19:56:35 +00:00
Dão Gottwald
84d373b75c Bug 1950622 - Correctly decide whether or not multiple selected tabs need to be moved together. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239738
2025-02-26 14:06:55 +00:00
Cristina Horotan
4dd2dad95f Backed out changeset 85d499c8e0bf (bug 1927258) for causing multiple failures tabbrowser related. CLOSED TREE 2025-02-26 06:42:56 +02:00
Nikki Sharpley
525619dde7 Bug 1927258 - Add a fade effect when vertical pinned tabs overflow r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,reusable-components-reviewers,dao,tgiles,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D237645
2025-02-25 22:01:56 +00:00
Dão Gottwald
ebf19a0299 Bug 1950113 - Remove null checks before isTabGroupLabel calls. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239346
2025-02-24 22:10:49 +00:00
Dão Gottwald
5bb0ca5467 Bug 1950104 - Make #moveTabNextTo handle the vertical pinned tabs container. r=nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D239354
2025-02-24 17:19:59 +00:00
Dão Gottwald
e8d536a337 Bug 1946339 - Fix stability of group creation indicator. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239331
2025-02-24 16:21:40 +00:00
Dão Gottwald
bbf8ed375a Bug 1949840 - Rename dropTab and dropTabs methods now that we use them not just for dropping. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239189
2025-02-21 21:23:27 +00:00
Dão Gottwald
d968cb60db Bug 1948943 - Fix moving together multiselected tabs across tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239119
2025-02-21 15:27:42 +00:00
Dão Gottwald
e0bb662eef Bug 1933280 - Fix dragging into and out of tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239000
2025-02-20 22:44:21 +00:00
Dão Gottwald
b2246100d5 Bug 1948883 - Unlock tab sizing when collapsing a group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238798
2025-02-20 05:21:52 +00:00
Dão Gottwald
a5d59a8e99 Bug 1945788 - Fix dragging multiple tabs in RTL. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238486
2025-02-18 23:07:08 +00:00
Kelly Cochrane
dcab8d8bd8 Bug 1945993 - Make sure browser.tabs.tabMinWidth pref is applied as expected to horizontal tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D236934
2025-02-14 14:58:03 +00:00
Dão Gottwald
5c9f9cced1 Bug 1945463 - [tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237287
2025-02-10 14:45:16 +00:00
Emilio Cobos Álvarez
81c4d6a66f Bug 1946016 - Remove macOS special case too. r=dao,tabbrowser-reviewers
Just tested, doesn't change behavior.

Differential Revision: https://phabricator.services.mozilla.com/D236871
2025-02-05 20:42:47 +00:00
Emilio Cobos Álvarez
f592072c68 Bug 1946016 - Don't be explicit about window size when detaching tabs on Linux. r=dao,tabbrowser-reviewers
Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.

The reason for the behavior change here is because `outerWidth` before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.

It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.

Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.

Differential Revision: https://phabricator.services.mozilla.com/D236867
2025-02-05 17:02:24 +00:00
Dão Gottwald
ae8e1343e4 Bug 1945440 - Fix tab drag and drop in RTL mode. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236512
2025-02-03 14:21:52 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236318
2025-02-03 10:15:25 +00:00
Dão Gottwald
0093579918 Bug 1945118 - Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236343
2025-01-31 14:22:14 +00:00
Dão Gottwald
89a390256e Bug 1944844 - Set dropElement before returning early. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D236159
2025-01-30 14:44:07 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234804
2025-01-29 18:37:29 +00:00
Emilio Cobos Álvarez
77261b9adc Bug 1943301 - Simplify tab throbber animation syncing. r=dao,tabbrowser-reviewers
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.

Differential Revision: https://phabricator.services.mozilla.com/D235300
2025-01-23 15:02:01 +00:00
Dão Gottwald
c4a94bbaa7 Bug 1942176 - Handle context menu key for tab group labels, r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234668
2025-01-20 15:25:23 +00:00
Dão Gottwald
602f317a6a Bug 1941645 - Stop scrolling to the selected tab when collapsing/expanding a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234326
2025-01-17 11:48:38 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-15 23:07:45 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-13 17:55:32 +00:00
Dão Gottwald
a5e0177580 Bug 1940444 - Uncaught TypeError: can't access property "pinned", middleTab is undefined when attemtping to drag multiple discontinuous tabs while there's a collapsed tab group. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233495
2025-01-08 16:22:11 +00:00
Dão Gottwald
048a7a56f8 Bug 1940041 - Fix typo. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D233271
2025-01-06 19:27:45 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Mauro B
35bae9ed07 Bug 1921951 - Fixed linter errors. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233208
2025-01-04 12:48:45 +00:00
Mauro B
dea2dbc861 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-04 12:48:45 +00:00
Narcis Beleuzu
884122ae28 Backed out changeset 5ddfa4c882b5 (bug 1921951) for lint failures on tabs.js . CLOSED TREE 2025-01-04 02:05:03 +02:00
Mauro B
1cae811100 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-03 23:24:54 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
2024-12-31 20:03:05 +00:00
Dão Gottwald
8b91d8e6b9 Bug 1935956 - Include group labels in scrollable elements. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232517
2024-12-19 15:32:48 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-12 12:57:41 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-11 14:37:38 +00:00
Dão Gottwald
5536b67d3f Bug 1933775 - When you collapse all tab groups on tab strip, open a New tab. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231295
2024-12-05 20:28:19 +00:00
Nikki Sharpley
6d6ad18210 Bug 1934957 - Remove unnecessary additional shift for expanded vertical pinned tabs drag over r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D230987
2024-12-04 14:33:35 +00:00
Stephen Thompson
2623aa98bb Bug 1933210 - maintain tab ordering on drop group creation r=dao,tabbrowser-reviewers
- when creating a group from the front edge of a target tab, the target tab should be the last tab in the group
- when creating a group from the back end of a target tab, the target tab should be the first tab in the group
- the tab group should be created at the position of the target tab

Differential Revision: https://phabricator.services.mozilla.com/D230283
2024-12-04 02:35:49 +00:00
Nikki Sharpley
9afc398378 Bug 1935026 - Ensure we are using the right scroll position for vertical pinned tabs r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D231017
2024-12-03 21:27:51 +00:00
Dão Gottwald
db518f5774 Bug 1934296 - Adding a tab to a collapsed group should expand the group. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D230982
2024-12-03 18:15:28 +00:00