Boris Zbarsky
ffcfe5490a
Bug 1209035. Fix incorrect "is this control focused?" checks in form code. r=smaug
...
For number controls, nsContentUtils::IsFocusedContent doesn't really do the
right thing, because the thing it thinks is focused is the anonymous text
element inside the number control. As a result, we weren't properly updating
the state of the currently-focused number control when hitting enter in it to
submit the form.
The HTMLFormElement change is enough on its own to fix the bug. The constraint
validation change is a just-in-case.
I haven't figured out a sane way to write a reftest for this, unfortunately:
the enter key press needs to look like a real user event to trigger the
submission behavior.
2018-06-27 12:04:26 -04:00
Jeff Gilbert
70a22b2878
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
0348c342b8
Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
...
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Chris Peterson
f7ceeaf5cf
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
2018-06-17 22:43:11 -07:00
Emilio Cobos Álvarez
e13a620d19
Bug 1449806: Merge {Servo,Generic}SpecifiedValues into MappedDeclarations. r=xidorn
...
The idea would be that this header is only included in cpp files, thus it's ok
to include ServoBindings, etc.
MozReview-Commit-ID: EgQEsR0cZd4
2018-06-25 11:14:39 +02:00
Boris Zbarsky
a0e4948ccd
Bug 1465875 part 5. Eliminate nsIDOMNSEditableElement. r=qdot
2018-06-01 22:35:23 -04:00
Emilio Cobos Álvarez
4b8b5e1717
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Olli Pettay
0090dd7e52
Bug 1459693, ensure the right anonymous element is focused when calling input.focus(), r=mccr8
2018-05-30 17:04:18 +03:00
Boris Zbarsky
86d99155db
Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot
2018-05-29 22:58:49 -04:00
Olli Pettay
3627dc8f11
Bug 1461321 - input.list should work in shadow DOM, r=peterv
2018-05-24 22:46:11 +03:00
Kris Maglione
7e3b82a9eb
Bug 1462964: Remove obsolete nsIDOMBlob interface. r=bz
...
MozReview-Commit-ID: 2HIlaSrvfBe
2018-05-21 17:32:44 -07:00
Chris Peterson
5d6b16ea3b
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Adrian Wielgosik
104ccff3c8
Bug 1418078 - Remove nsIDOMHTMLInputElement. r=bz
...
MozReview-Commit-ID: Gun4oxg1NJZ
2018-04-18 22:35:32 +02:00
Boris Zbarsky
268d2c0bc3
Bug 1455674 part 9. Remove nsIDOMElement use from nsIFocusManager. r=qdot
2018-04-26 23:35:19 -04:00
Boris Zbarsky
45892dfa49
Bug 1456588 part 1. Change nsIFocusManager::SetFocus to take Element. r=enndeakin
2018-04-26 10:37:46 -04:00
Adrian Wielgosik
38f9a663ce
Bug 1447389 - Remove nsIDOMNodeList. r=bz
...
MozReview-Commit-ID: 11szZP6dS6V
2018-04-25 23:01:30 +02:00
Boris Zbarsky
821cd16e9f
Bug 1456169 part 3. Remove the now-unnecessary nsITextControlElement::GetPreviewNode. r=emilio
...
MozReview-Commit-ID: 3goF5VXvQap
2018-04-24 02:17:18 -04:00
Boris Zbarsky
ae88fa2749
Bug 1456169 part 2. Remove the now-unnecessary nsITextControlElement::GetPlaceholderNode. r=emilio
...
MozReview-Commit-ID: FcVbeHEwkMz
2018-04-24 02:17:17 -04:00
Boris Zbarsky
d0e4853121
Bug 1456169 part 1. Remove the now-unnecessary nsITextControlElement::GetRootEditorNode. r=emilio
...
MozReview-Commit-ID: 6DYEtQMTCRF
2018-04-24 02:17:17 -04:00
Boris Zbarsky
57e4b18aed
Bug 1455052 part 8. Stop using nsIDOMEvent in docshell and dom. r=masayuki
...
MozReview-Commit-ID: ASkuyN3xSwB
2018-04-20 12:55:30 -04:00
Kyle Machulis
9763b54e77
Bug 1453517 - Remove nsPopupWindowManager and related XPCOM bits; r=bz
...
MozReview-Commit-ID: JIDdZfnNN8E
2018-04-11 16:16:13 -07:00
Kyle Machulis
3ff8407067
Bug 1453517 - Consolidate popup permission checks to nsContentUtils; r=bz
...
Permissions checks for popups were happening in nsIPopupWindowManager,
but that really only required a pref and perm check. The XPCOM
machinery around this isn't really needed, and the check was only
called from two places in content, so this fits in nsContentUtils.
MozReview-Commit-ID: 9x60x1BKWcr
2018-04-11 16:18:20 -07:00
Jeff Walden
738579bba3
Bug 1453456 - Replace nsCRT::IsAscii{Alpha,Digit} with mfbt/TextUtils.h versions. r=froydnj
2018-04-12 20:19:30 -07:00
Ciure Andrei
40a9e70f9f
Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE
2018-04-11 12:00:35 +03:00
Ciure Andrei
e88f87924d
Merge autoland to mozilla-central. a=merge
2018-04-11 11:56:26 +03:00
Ciure Andrei
ea89df62df
Backed out 8 changesets (bug 1451169) on request from njn a=backout
...
Backed out changeset b92f856e15a8 (bug 1451169)
Backed out changeset 348e825756fa (bug 1451169)
Backed out changeset 624d82428726 (bug 1451169)
Backed out changeset 4d51610ca08e (bug 1451169)
Backed out changeset bb76a9589717 (bug 1451169)
Backed out changeset c145fbd03947 (bug 1451169)
Backed out changeset 6d36289e0f54 (bug 1451169)
Backed out changeset 914fb7cd9fc3 (bug 1451169)
2018-04-11 11:22:05 +03:00
Cameron McCormack
9a6c8a3e60
Bug 1317539 - Remove dom.forms.number pref. r=bz
...
MozReview-Commit-ID: EgeUfWMcE8D
2018-04-10 11:02:28 +10:00
Nika Layzell
32fa76c4fe
Bug 1443954 - Part 3: Add support for RefCounted types to IPDL, r=bz,froydnj,baku
...
This patch was reviewed in parts, however the intermediate states would not build:
Bug 1443954 - Part 3A: Strip pointers from the argument to WriteParam and WriteIPDLParam before selecting the ParamTraits impl, r=froydnj
Bug 1443954 - Part 3B: Move nsIAlertNotification serialization to the refcounted system, r=bz
Bug 1443954 - Part 3C: Move geolocation serialization to the refcounted system, r=bz
Bug 1443954 - Part 3D: Move nsIInputStream serialization to the refcounted system, r=baku
Bug 1443954 - Part 3E: Move BlobImpl serialization to the refcounted system, r=baku
Bug 1443954 - Part 3F: Correctly implement ParamTraits for actors after the ParamTraits changes, r=froydnj
2018-04-10 17:49:48 -04:00
Nika Layzell
cccd4523db
Bug 1438026 - Part 3: Replace nsPresState with the new PresState type, r=baku
2018-04-10 17:49:44 -04:00
Boris Zbarsky
5b75c1416d
Bug 1449631 part 8. Remove nsIDOMEventTarget::GetEventTargetParent. r=smaug
...
MozReview-Commit-ID: 5wQ2LYrjUxf
2018-04-05 13:42:41 -04:00
Nicholas Nethercote
7ccd4b9401
Bug 1451169 - Use nsStaticAtom* instead of nsStaticAtom** in Element.h. r=baku
...
And then fix up everything else that needs to change as well.
MozReview-Commit-ID: GDMfERqdQAc
2018-04-03 13:21:06 +10:00
Boris Zbarsky
152cd3ba6e
Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor
...
MozReview-Commit-ID: 202nkbmkwfR
2018-03-21 17:39:04 -04:00
Boris Zbarsky
29226b0510
Bug 1446851. Get rid of nsIDOMWheelEvent. r=qdot
...
We can't include WheelEventBinding.h in MouseEvents.h because that produces
this include loop:
WheelEventBinding.h -> MouseEventBinding.h -> UIEventBinding.h ->
nsGlobalWindow.h -> nsGlobalWindowInner.h -> nsRefreshDriver.h ->
AnimationEventDispatcher.h -> AnimationComparator.h -> Animation.h ->
EffectCompositor.h -> PseudoElementHashEntry.h -> Element.h ->
PointerEventHandler.h -> MouseEvents.h -> WheelEventBinding.h
MozReview-Commit-ID: 5KNwH69aJYW
2018-03-20 00:16:05 -04:00
Bogdan Tara
1096f0f569
Merge mozilla-central to autoland. a=merge CLOSED TREE
2018-03-17 12:34:09 +02:00
Adrian Wielgosik
03284e63fb
Bug 1446515 - Remove nsIDOMFileList. r=bz
...
MozReview-Commit-ID: 4ab1e6NTcOB
2018-03-16 20:55:32 +01:00
Emilio Cobos Álvarez
a76d4ae5b0
Bug 1409183: Don't consider anonymous checkboxes as part of the document radio group. r=smaug
...
Summary: In this case the radiobox is in a SVG <use> subtree.
Reviewers: smaug
Bug #: 1409183
Differential Revision: https://phabricator.services.mozilla.com/D741
MozReview-Commit-ID: Abkg7ahST5t
2018-03-17 00:19:43 +01:00
Nicholas Nethercote
21a918ec7d
Bug 1445117 - Remove duplicates from nsGkAtoms. r=froydnj
...
In each case, the atom had an obvious name and a weird name. Where possible, I
kept the obvious name and commented out the weird name, viz:
- `mixed` over `_mixed` for "mixed"
- `el` over `el_` for "el"
- `other` over `other_` for "other"
- `remote` over `Remote` for "remote"
But for several of them I didn't do that, because the weird name is used
within the HTML5 parser -- which is a huge pain to modify because it involves
code generated by code from another repo -- so I kept the weird name and
commented out the obvious name, viz:
- `list_` over `list` for "list"
- `svgSwitch` over `_switch` for "switch"
- `set_` over `set` for "set"
MozReview-Commit-ID: Jp3CpdWXNDm
2018-03-14 10:27:25 +11:00
Adrian Wielgosik
b3471f9af4
Bug 1440741 - Remove all members from nsIDOMHTMLFormElement. r=qdot
...
MozReview-Commit-ID: 2UcUy4MkVsM
2018-02-23 19:28:08 +01:00
Emilio Cobos Álvarez
24dd511927
Bug 1439155: Be consistent about what does readonly apply to. r=smaug
...
MozReview-Commit-ID: 4NiDe7pUzGa
2018-02-22 08:07:55 +01:00
Adrian Wielgosik
ddc8320336
Bug 1439751 - Cleanup HTMLInputElement some more. r=qdot
...
MozReview-Commit-ID: APunYKaGM8I
2018-02-20 23:11:27 +01:00
Adrian Wielgosik
9ed001b20f
Bug 1439751 - Remove all members from nsIDOMHTMLInputElement. r=qdot
...
MozReview-Commit-ID: JVagEzvSONN
2018-02-20 23:10:44 +01:00
Boris Zbarsky
831a04431e
Bug 1436508 part 14. Remove nsIDOMMutationEvent. r=masayuki
...
MozReview-Commit-ID: Gf59kFSIuaK
2018-02-09 11:17:10 -05:00
Boris Zbarsky
3ab7ce89fa
Bug 1434686 part 4. Use IgnoreErrors() in dom/. r=mystor
...
MozReview-Commit-ID: GwVDrTLPTOb
2018-02-01 14:21:14 -05:00
Boris Zbarsky
62c5e0df60
Bug 1418085 part 5. Remove nsIDOMHTMLInputElement::GetList. r=mystor
...
MozReview-Commit-ID: JbWMti82q3R
2018-01-30 00:25:36 -05:00
Emilio Cobos Álvarez
f68231c053
Bug 1431041: Fix placeholder-shown when the value of the input is invalid. r=smaug
...
Wow, the setup for <input type="number"> is really weird :(.
Looking at the callers, this should be sane.
MozReview-Commit-ID: C0ZNNSdg0Hb
2018-01-18 17:20:39 +01:00
Emilio Cobos Álvarez
4ddc45d084
Bug 1431041: Make placeholder apply to <input type="number">. r=smaug
...
MozReview-Commit-ID: GLbdLxHLiH4
2018-01-18 17:20:37 +01:00
Csoregi Natalia
288cbd4f18
Backed out 2 changesets (bug 1431041) for failing dom/html/test/forms/test_input_number_placeholder_shown.html. on a CLOSED TREE
...
Backed out changeset 57641ee7058f (bug 1431041)
Backed out changeset 7a4c3ab0ade8 (bug 1431041)
2018-01-18 07:29:14 +02:00
Emilio Cobos Álvarez
fe79e47619
Bug 1431041: Fix placeholder-shown when the value of the input is invalid. r=smaug
...
Wow, the setup for <input type="number"> is really weird :(.
Looking at the callers, this should be sane.
MozReview-Commit-ID: C0ZNNSdg0Hb
2018-01-17 18:30:59 +01:00
Emilio Cobos Álvarez
0f41607b68
Bug 1431041: Make placeholder apply to <input type="number">. r=smaug
...
MozReview-Commit-ID: GLbdLxHLiH4
2018-01-17 14:52:01 +01:00
Andrea Marchesini
03bde7c37a
Bug 1419771 - Introduce DOMPrefs, a thread-safe access to preferences for DOM - part 16 - Webkit/Blink directory picker enabled, r=asuth
2018-01-08 14:05:05 +01:00