Commit Graph

37 Commits

Author SHA1 Message Date
Asaf Romano
1fb486c62a Bug 982115 - PlacesTransactions: (1) Decouple |transact| and |batch|, and make batch work like Task.spawn, rather than the custom solution we had so far (yielding transactions rather than calling |transact| for the batched transactions). so that |transact| may be called during a batch from any function, not limiting the batch 'context' to the function passed to |batch|; (2) Rename the uri input property to URL, and allow passing DOM URL objects for it (in addition to plain specs and nsIURI objects) - this matches recent Bookmark.jsm and History.jsm work; (3) Improve the module documentation. r=mak. 2014-11-10 10:36:56 +02:00
Asaf Romano
88912b1ad3 Bug 1069235 - make guid and parentGuid naming consistent. r=mak 2014-09-20 10:57:34 +03:00
Asaf Romano
0598101f72 Bug 1058566 - Transaction for duplicating any places item. r=mak. 2014-09-17 14:59:23 +03:00
Ryan VanderMeulen
17842860d8 Backed out changeset ae6de471bcd7 (bug 1058566) for causing bug 1067978. 2014-09-16 15:41:27 -04:00
Asaf Romano
0b04b6c3d1 Bug 1058566 - Transaction for duplicating any places item. r=mak 2014-09-16 12:25:18 +03:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Asaf Romano
199cfe7699 Bug 993391 - Places async transactions: Implement "move bookmarks" command. r=mak. 2014-04-22 08:42:23 +03:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
OHZEKI Tetsuharu
ffe4ad1ad4 Bug 575955 - Replace internal usage of old transactions shim, add a new toolkit test. r=mak 2012-02-28 18:40:38 -05:00
Metal Sonic
259a398dae Bug 507387 - fix copyright holder; Mozilla Corporation -> Mozilla Foundation. r=gerv. 2009-12-21 21:50:30 +00:00
93b09ca5b2 Bug 384370 - use JSON as the on disk, lossless format for our bookmark backup (r=mano) 2008-03-13 12:25:49 -07:00
b1849d036b Backing out test of bug 384370 2008-03-10 10:49:31 -07:00
2571ebe699 Bug 384370 - test perf run (r=mano) 2008-03-10 09:41:52 -07:00
0781141317 backing out test checkin of bug 384370 2008-03-04 14:12:27 -08:00
6da087308d TESTING - temp checkin of bug 384370 (r=mconnor) 2008-03-04 13:23:04 -08:00
5d455b7439 backing out test patch for bug 384370 2008-03-04 12:04:14 -08:00
bb3c05808d Bug 384370 ? use JSON as the on disk, lossless format for our bookmark backup - TESTING (r=mconnor) 2008-03-04 11:50:18 -08:00
6bb7b53329 backing out, broke when unrotting 2008-03-04 11:43:35 -08:00
5ee69ae743 Bug 384370 ? use JSON as the on disk, lossless format for our bookmark backup - TESTING PERF (r=mconnor) 2008-03-04 11:41:52 -08:00
9b9e2aedff backing out bug 384370 for hosation of Ts 2008-02-29 09:29:58 -08:00
4ea67490b4 Bug 384370 - use JSON as the on disk, lossless format for our bookmark backup (take two, r=mano, a=beltzner) 2008-02-29 08:39:13 -08:00
083ba1ff68 backing out bug 384370, caused 25ms Ts regression on linux, and leaks on linux and mac 2008-02-27 11:05:52 -08:00
d088f39bf8 Bug 384370 - use JSON as the on disk, lossless format for our bookmark backup (r=mano) 2008-02-27 10:14:13 -08:00
9535227f15 Bug 416381 - Organize > Move bookmark to Toolbar Folder results in misplaced bookmark. r=dietrich. 2008-02-20 09:14:58 -08:00
e994aef1be Bug 390739 - Redo menu item is greyed out in Bookmarks Organizer (was: doesn't work when deleting items and undoing in Bookmarks Manager). r=dietrich. 2007-12-02 12:08:23 -08:00
a2a01c1f1d Bug 387746 - New Left Pane for Places Organizer, along with other places back-end and front-end changes; also fixes bugs 393547, 395994, 401075, 403141. r=dietrich. 2007-11-19 18:01:53 -08:00
5021cce06b Bug 373944 - revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833. patch by seth and me, r=dietrich. a=blocking-m9. 2007-10-24 19:37:05 -07:00
931d07c105 fix for bug #389912: Cannot move folder with "move" button in Bookmark Manager
r=mano, a=mconnor for M7
2007-07-27 22:12:22 -07:00
f8da84dfd7 Bug 376004 - Places Transactions must not live in the window global scope. patch by Steve Won and me. 2007-07-15 02:44:50 -07:00
8ee4c1ea1e backing out fix for bug #373944 as it causes a performance regression, see bug #385208 2007-06-20 15:46:54 -07:00
e5c49c3c0a fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833.
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano
2007-06-20 00:43:51 -07:00
eb61e9e519 Bug 382101 - Cannot move bookmark folder to the 'root'. r=sspitzer. 2007-05-30 17:34:13 -07:00
2707806f19 Bug 371823 - Optimize item moves. r=sspitzer. 2007-05-22 15:03:53 -07:00
7b90b99bc0 Bug 372508 part 2 - remove folderId getter. r=sspitzer. 2007-05-14 14:56:38 -07:00
1cc2f071ac Bug 379211 - Use item IDs for annotating bookmark/folder items rather than place: URIs. r=dietrich. 2007-05-10 01:05:19 -07:00
dietrich@mozilla.com
16945b9b5a Bug 360133 Bookmarks must be internally uniquely identifiable (r=mano, sspitzer) 2007-02-26 00:54:36 +00:00
mozilla.mano@sent.com
2e9f80a1fa Bug 365538 - 'Move Bookmark(s)' UI in Places Organizer. r=sspitzer. 2007-01-09 23:00:23 +00:00