Commit Graph

1874 Commits

Author SHA1 Message Date
Evgenia Kotovich
8d5d1cda5f Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-15 12:58:11 +00:00
Jens Stutte
e7d28b3e05 Bug 1731564: Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
Depends on D127233

Differential Revision: https://phabricator.services.mozilla.com/D127234
2021-10-07 08:06:15 +00:00
Marian-Vasile Laza
7de6967c5a Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte
25eeb7d613 Bug 1731564: Use motivated SpinEventLoopUntil inside toolkit/*. r=Gijs
Depends on D127233

Differential Revision: https://phabricator.services.mozilla.com/D127234
2021-10-06 19:45:17 +00:00
Andi-Bogdan Postelnicu
f221c438ca Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345
2021-08-25 10:46:17 +00:00
Tim Huang
34f103bb6c Bug 1698195 - Part 2: Enable test_classifier.html for fission. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D122518
2021-08-13 09:32:36 +00:00
Tim Huang
7283251594 Bug 1698195 - Part 1: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D122517
2021-08-13 09:32:36 +00:00
Christoph Kerschbaumer
3c12a4bedc Bug 1723115: Update tests within toolkit/components to work with https-first enabled r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D121365
2021-07-30 13:50:59 +00:00
Christoph Kerschbaumer
84559c5091 Bug 1711918: Update PBM tests within toolkit/components/url-classifier/ to work with https-first-mode enabled r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D115499
2021-05-20 09:12:19 +00:00
Paul Zuehlcke
e7228cfa51 Bug 1699668 - Tests for shim warning. r=webcompat-reviewers,johannh,denschub
Differential Revision: https://phabricator.services.mozilla.com/D109718
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
88fb2c09c2 Bug 1661330 - Log STATE_ALLOWED_TRACKING_CONTENT to the ContentBlockingLog if a channel is allowed. r=geckoview-reviewers,dimi,droeh
Differential Revision: https://phabricator.services.mozilla.com/D109716
2021-04-13 16:11:20 +00:00
Ed Lee
fc092b8968 Bug 1702330 - Fix test_reporturl.html proton infobars r=mstriemer
Depends on D110963

Differential Revision: https://phabricator.services.mozilla.com/D111539
2021-04-10 19:56:14 +00:00
Simon Giesecke
87c754b1bd Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D108588
2021-03-24 17:56:50 +00:00
Simon Giesecke
9e995a79e8 Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
Simon Giesecke
cf0f01f8dc Bug 708901 - Migrate to nsTHashSet in toolkit/components/url-classifier. r=gcp
Depends on D109328

Differential Revision: https://phabricator.services.mozilla.com/D108604
2021-03-23 10:36:40 +00:00
Simon Giesecke
c2fbe35339 Bug 1698098 - Make use of nsBaseHashtable::Clone. r=xpcom-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D107617
2021-03-19 09:01:46 +00:00
Simon Giesecke
86e29e162f Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D108585
2021-03-17 15:49:46 +00:00
Andrew Halberstadt
4cc9bc35b1 Bug 1694833 - Skip some mochitest-plain tests with fission so we can add new tasks, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D108251
2021-03-12 20:43:26 +00:00
Simon Giesecke
c7a36b5d58 Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.

Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
Simon Giesecke
769d57149a Bug 1634281 - Remove unused nsDataHashtable.h includes. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D106007
2021-03-03 08:58:52 +00:00
Simon Giesecke
95c38cc6b8 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Simon Giesecke
74da3a3ce3 Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/url-classifier. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D106110
2021-02-24 12:49:56 +00:00
Simon Giesecke
2634de766d Bug 1691913 - Rename nsClassHashtable::LookupOrAdd to GetOrInsertNew. r=xpcom-reviewers,nika
It should be called "Get" rather than "Lookup" because it returns
UserDataType. "Add" is called "Insert" in the other methods.

Differential Revision: https://phabricator.services.mozilla.com/D105470
2021-02-22 12:07:47 +00:00
Alexis Beingessner
8318b261c4 Bug 1686616 - make PermissionManager use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105528
2021-02-18 13:26:31 +00:00
Simon Giesecke
3c36abd9aa Bug 1692880 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-16 15:53:33 +00:00
smolnar
03bc7728ba Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
Simon Giesecke
f04f372040 Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-15 10:04:46 +00:00
Mark Banner
c991d8611e Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Christoph Kerschbaumer
06a526b024 Bug 1686679: Use different origin in test test_classifier_match.html to comply with Principal based vetting in ContentParent r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D101729
2021-01-14 10:38:54 +00:00
Kartik Gautam
619cd73acb Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
Cosmin Sabou
5980f4a6e1 Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD 2020-12-28 00:43:51 +02:00
Kartik Gautam
25fc1e9e28 Bug 1684173 - Add newline character at end of files when missing r=sylvestre
Depends on D100443

Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
Simon Giesecke
fdd0be071c Bug 1583109 - Use StringJoin(Append) where easily possible. r=nika
Bug 1583109 introduced new function templates StringJoin and StringJoinAppend.
These are now used to replace several custom loops across the codebase that
implement string-joining algorithms to simplify the code.

Differential Revision: https://phabricator.services.mozilla.com/D98750
2020-12-17 14:58:18 +00:00
Csoregi Natalia
51401405eb Backed out changeset 16d174e7c342 (bug 1583109) for bustage on nsReadableUtils.h. CLOSED TREE 2020-12-16 22:51:26 +02:00
Simon Giesecke
8db61da8b6 Bug 1583109 - Use StringJoin(Append) where easily possible. r=nika
Bug 1583109 introduced new function templates StringJoin and StringJoinAppend.
These are now used to replace several custom loops across the codebase that
implement string-joining algorithms to simplify the code.

Differential Revision: https://phabricator.services.mozilla.com/D98750
2020-12-16 19:38:23 +00:00
Dana Keeler
23fe8d2bdc Bug 1681646 - unconditionally dispatch event to disable async updates in URL classifier at shutdown r=ckerschb
Before this patch, nsUrlClassifierDBService::Shutdown() would check if its
classifier had been set before dispatching an event to have it disable async
updates. However, this was racy, as the pointer being checked is set on a
background thread, and this ::Shutdown() runs on the main thread.
This race was introduced in bug 1363038 to avoid a deadlock. It seems the real
cause of the deadlock was addressed shortly after in bug 1394031, but this change
was never reverted until now.

Differential Revision: https://phabricator.services.mozilla.com/D99715
2020-12-15 17:08:31 +00:00
Kartik Gautam
cb9c278e67 Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-15 10:34:54 +00:00
Dorel Luca
7f1605c133 Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE 2020-12-13 16:38:21 +02:00
Kartik Gautam
2908b96137 Bug 1679758 - Remove trailing empty lines r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-13 13:28:30 +00:00
Dimi Lee
fb9f30baf6 Bug 1676804 - P3. Add testcase r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D98900
2020-12-09 09:20:51 +00:00
Dimi Lee
88e9c5f3fe Bug 1676804 - P2. Safe Browsing canonicalization should escape # r=gcp
We didn't escape '#' as defined in the Safe Browsing spec
"In the URL, percent-escape all characters that are <= ASCII 32, >= 127, "#", or "%".
The escapes should use uppercase hex characters."

See https://developers.google.com/safe-browsing/v4/urls-hashing

Differential Revision: https://phabricator.services.mozilla.com/D98899
2020-12-09 09:17:15 +00:00
Dimi Lee
5546503ad7 Bug 1676804 - P1. Safe Browsing canonicalization should not include query string r=gcp
In the Safe Browsing spec, it says "Do not apply these path canonicalizations to the query parameters.",
we should follow it.

Differential Revision: https://phabricator.services.mozilla.com/D98898
2020-12-09 07:43:30 +00:00
Simon Giesecke
fbb9c742c8 Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
Simon Giesecke
c83a083a0c Bug 1676365 - Move SpinEventLoopUntil to separate header. r=#xpcom-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96556

Depends on D96554
2020-11-23 16:10:41 +00:00
Simon Giesecke
46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
David Parks
62133ac0a0 Bug 1675349: Update tests under toolkit/components for the removal of plugins. r=jmathies
REMOVED
-------
toolkit/components/url-classifier/tests/browser/browser_flashblock_{on,off}_with_{always,ask to,never}_activate.js
bug 1350381
Test Flash user pref and Flash Block combination wrt sites blocklisted in different ways

toolkit/components/forgetaboutsite/test/browser/browser_clearplugindata.js
Test plugindata part of ForgetAboutSite's use of nsIClearDataService, which uses nsPluginHost to call's the plugin's (here, testplugin's) exported NPP_ClearSiteData function.

Differential Revision: https://phabricator.services.mozilla.com/D95917
2020-11-18 16:00:06 +00:00
Bogdan Tara
d1cceb4cfb Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE
Backed out changeset 244e0f2b410c (bug 1675349)
Backed out changeset ba5724069dd4 (bug 1675349)
Backed out changeset 37fca259c7e9 (bug 1675349)
Backed out changeset f2b16caca1fc (bug 1675349)
Backed out changeset 28835d4935be (bug 1675349)
Backed out changeset eb913f58953a (bug 1675349)
Backed out changeset 19e3cb80f469 (bug 1675349)
Backed out changeset d9723f3a3a7e (bug 1675349)
Backed out changeset c888dfcdf70e (bug 1675349)
Backed out changeset 48f153341af6 (bug 1675349)
Backed out changeset 7fc67a9b2932 (bug 1675349)
Backed out changeset 1cee4d97f801 (bug 1675349)
Backed out changeset 59a0cb79c7c1 (bug 1675349)
Backed out changeset 43d349fa37b1 (bug 1675349)
Backed out changeset c84bfb6eae59 (bug 1675349)
Backed out changeset 38e9af69ae57 (bug 1675349)
Backed out changeset 3255c1ab3059 (bug 1675349)
Backed out changeset 2f3eaf9c342c (bug 1675349)
Backed out changeset 769e5c0db4c2 (bug 1675349)
2020-11-18 06:06:36 +02:00
David Parks
438cfea71a Bug 1675349: Update tests under toolkit/components for the removal of plugins. r=jmathies
REMOVED
-------
toolkit/components/url-classifier/tests/browser/browser_flashblock_{on,off}_with_{always,ask to,never}_activate.js
bug 1350381
Test Flash user pref and Flash Block combination wrt sites blocklisted in different ways

toolkit/components/forgetaboutsite/test/browser/browser_clearplugindata.js
Test plugindata part of ForgetAboutSite's use of nsIClearDataService, which uses nsPluginHost to call's the plugin's (here, testplugin's) exported NPP_ClearSiteData function.

Differential Revision: https://phabricator.services.mozilla.com/D95917
2020-11-18 02:47:27 +00:00
Nika Layzell
ed9e85fc9a Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00