Commit Graph

1076 Commits

Author SHA1 Message Date
Jonathan Kew
d9ef4db9df Bug 1157569 - Followup to address review nits (renamings, comment updates) from parts 13 and 14. 2015-06-27 11:16:18 -07:00
Jonathan Kew
70fa25bc45 Bug 1157569 - part 14 - Finish conversion of border-collapse code in nsTableFrame to logical coordinates. r=dholbert 2015-06-27 11:16:10 -07:00
Jonathan Kew
0bb2d05104 Bug 1157569 - part 13 - More conversion of physical to logical terminology in border-collapse calculations. r=dholbert 2015-06-27 11:16:03 -07:00
Jonathan Kew
2868c1271c Bug 1177606 - Correct the row positioning within rowGroups in vertical-rl tables when distributing extra width. r=dholbert 2015-06-26 16:50:38 -07:00
Jonathan Kew
195dff09b2 Bug 1177600 - Properly adjust table row and cell positions when their containing block-size changes in vertical-rl writing mode. r=dholbert 2015-06-26 16:50:21 -07:00
Jonathan Kew
4bd2a8515b Bug 1174711 patch 5 - Copy inline-size rather than width from prev-in-flow when initializing nsTableFrame. r=dholbert 2015-06-24 16:23:59 -07:00
Jonathan Kew
7fd4a15b24 Bug 1176523 - Convert Get/SetContinuousBCBorderWidth in nsTableColFrame and nsTableColGroupFrame to logical coordinates. r=dholbert 2015-06-24 09:56:54 -07:00
Jonathan Kew
cd6c65dc69 Bug 1176354 - Rename nsTableRowFrame::GetBSize to differentiate better from nsIFrame::BSize. r=dholbert 2015-06-23 13:41:31 -07:00
Jonathan Kew
797a0a8648 Bug 1176555 - Replace explicit bit-twiddling of frame state flags by human-readable nsIFrame state-manipulation methods in table layout code. r=dholbert 2015-06-23 13:41:29 -07:00
Jonathan Kew
8ad732797c Bug 1176105 - Remove the (largely gutted) nsTableIterator class, and replace with simple frame-list iteration. r=dholbert 2015-06-23 11:47:45 -07:00
Jonathan Kew
b1c3c0cbd7 Bug 1176414 - Clean up/rename various column index variables in nsTableRowFrame and nsTableFrame. r=dholbert 2015-06-23 11:45:17 -07:00
Jonathan Kew
b5b77139b5 Bug 1176070 - Optimize nsTableFrame's FirstInFlow() lookups from calls to GetColumnISize(). r=dholbert 2015-06-23 11:44:36 -07:00
Jonathan Kew
2e820e821b Bug 1174711 - patch 4 - Rename mSpecialHeightReflow to mSpecialBSizeReflow, and update comments to match. r=dholbert 2015-06-22 10:33:34 +01:00
Jonathan Kew
b41d8c794d Bug 1174711 - patch 2 - Convert nsTableFrame to work with logical coordinates. r=dholbert 2015-06-22 10:33:34 +01:00
Jonathan Kew
ac7784827a Bug 1174711 - patch 1 - Rename nsIPercentHeightObserver to nsIPercentBSizeObserver, and update related frame methods to match. r=dholbert 2015-06-22 10:33:34 +01:00
Jonathan Kew
07b2930c0a Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert 2015-06-20 21:00:33 +01:00
Jonathan Kew
18d7a3a9d7 Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert 2015-06-20 21:00:26 +01:00
L. David Baron
7c5f15af6a Back out changesets ed293fc9596c and f18cb4c41578 (bug 1174700) for fatal assertions in all Windows debug reftest runs.
CLOSED TREE

Assertion failure: origKidNormalPosition.B(wm) == 0, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/layout/tables/nsTableRowFrame.cpp:861
TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/ua-style-sheet-size-1.html | application terminated with exit code 1
2015-06-20 22:41:07 -07:00
Jonathan Kew
10ed31cdc4 Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert 2015-06-20 21:00:33 +01:00
Jonathan Kew
7dca7a6c5c Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert 2015-06-20 21:00:26 +01:00
Jonathan Kew
a45bc02094 Bug 1174507 - Replace the frame flag CONTAINS_RELATIVE_HEIGHT with CONTAINS_RELATIVE_BSIZE, and adjust callsites appropriately. r=dholbert 2015-06-18 07:33:50 +01:00
Jonathan Kew
bb98c1ac7e Bug 1157569 - part 12 - Convert physical values from BCPropertyData to logical when returning from Get[Included]OuterBCBorder. r=roc 2015-06-17 11:03:25 +01:00
Mats Palmgren
fcb056fcd4 Bug 1174450 part 9 - Remove the nsRenderingContext* param from Intrinsic*SizeOffsets methods since it's unused. r=jfkthame 2015-06-16 11:21:04 +00:00
Xidorn Quan
568d90647a Bug 1171328 - Convert nsTableFrame::GetChildAreaOffset() and its friends to use LogicalMargin. r=dholbert 2015-06-10 13:13:49 +12:00
Daniel Holbert
54f6107ac4 Bug 1169432 part 5: Use range-based 'for' loops when walking frame lists, in nsTableFrame. r=mats 2015-06-05 15:39:35 -07:00
Daniel Holbert
792104a41a Bug 1169432 part 4: Convert NS_ASSERTION(false, ...) to NS_ERROR(...) in nsTableFrame. r=mats 2015-06-05 15:39:27 -07:00
Daniel Holbert
6039aca337 Bug 1169432 part 3: Use nsTArray::Contains instead of nsTArray::IndexOf(), for brevity, in nsTableFrame. r=mats 2015-06-05 15:39:13 -07:00
Daniel Holbert
8e95f07f19 Bug 1169432 part 2: Refactor nsTableFrame::Init. r=mats 2015-06-05 15:39:06 -07:00
Simon Montagu
e6de936024 Bug 1147834: Use abstract coordinates in nsHTMLReflowState, r=jfkthame 2015-06-04 03:43:02 -07:00
Daniel Holbert
a98977f9e3 Bug 1167696 part 2: Remove nsTableReflowState's frame constructor-arg; get it from passed-in reflow state instead. r=mats 2015-05-25 19:43:50 -07:00
Daniel Holbert
df337b594f Bug 1167696 part 1: Remove nsTableReflowState's unused constructor & nsPresContext arg. r=mats 2015-05-25 19:43:10 -07:00
Daniel Holbert
19946c390c Bug 1167765: Misc whitespace cleanup in nsTableFrame.cpp. whitespace/rewrapping-only, no review, DONTBUILD 2015-05-22 14:23:44 -07:00
Xidorn Quan
0a2bdb61ae Bug 1159127 - Always redirect inserting col group frame to first-in-flow table frame. r=mats 2015-05-20 13:29:43 +12:00
Xidorn Quan
a95c207636 Bug 1157569 part 12 - Remove useless m{Start,End}Side from BCMapCellInfo. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
77350f9bef Bug 1157569 part 11 - Rename methods and fields in nsTableCellFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
059b18f863 Bug 1157569 part 9 - Rename methods and fields in nsTableRowFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
610e73078d Bug 1157569 part 8 - Move some code in BCPaintBorderIterator::SetDamageArea for less computation. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
f1fda36c8e Bug 1157569 part 7 - Rename methods and fields in nsTableColFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
795fbd02c8 Bug 1157569 part 6 - Rename methods and fields in BCMapCellInfo from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
d42c72a22b Bug 1157569 part 5 - Convert GetColorAndStyle, GetPaintStyleInfo, and CompareBorders in nsTableFrame to accept writing mode and logical side. r=roc
This changes behavior of border collapse on RTL tables, but it seems
that there is no test coverage on those cases, and those cases should
have been broken before, due to the mix of m{Start,End}side and
physical sides in the methods. Hence this change should be fine, as
long as we are going to fix it in later patches.
2015-05-04 19:09:25 +12:00
Xidorn Quan
94e77d04ad Bug 1157569 part 4 - Replace mTableIsLTR with mTableWM in BCMapCellInfo & BCPaintBorderIterator. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
948a00255c Bug 1157569 part 3 - Merge two GetColorAndStyle functions in nsTableFrame. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
63ba89f0cb Bug 1157569 part 2 - Convert output parameters of GetColorAndStyle/GetPaintStyleInfo in nsTableFrame to use pointers. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
42729f13dc bug 1157569 part 1 - Rename BC_BORDER_{TOP,RIGHT,BOTTOM,LEFT}_HALF* to BC_BORDER_{START,END}_HALF*. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
e645ff916c Bug 1159990 - Add TableArea struct and replace nsIntRect with it for table damage area. r=roc 2015-05-01 09:46:59 +12:00
Daniel Holbert
ebd37b4c23 Bug 1155880 part 3: Rename nsTableFrame::GetColumnWidth to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:27 -07:00
Daniel Holbert
678cdc970f Bug 1155880 part 2: Rename nsTableColFrame Get/Set/ResetFinalWidth methods to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:26 -07:00
Daniel Holbert
bf5b274e01 Bug 1155880 part 1: Rename nsITableLayoutStrategy::ComputeColumnWidths and associated comments to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:24 -07:00
Daniel Holbert
709b4256c5 Bug 1155798: Drop end-of-line whitespace from C++ files in layout/tables. (whitespace-only, no review, DONTBUILD) 2015-04-17 11:42:05 -07:00
Mats Palmgren
0280e62037 Bug 1143299 - Make frame insertion methods deal with aPrevFrame being on an overflow list. r=roc a=abillings 2015-04-11 00:21:06 +00:00