Commit Graph

41 Commits

Author SHA1 Message Date
Csoregi Natalia
d86e48d443 Backed out changeset 54ca07441fde (bug 1590935) for browser-chrome failures on browser_aboutNetError.js. CLOSED TREE 2019-10-25 05:27:32 +03:00
Martin Thomson
9511fdc6ad Bug 1590935 - Offer to re-enable TLS 1.0 on SSL_ERROR_PROTOCOL_VERSION_ALERT, r=johannh
As it turns out, there are some sites that generate this error.  It's a small
number, but enough to justify the change.

No new tests because we can't generate this condition in our test setup.

Differential Revision: https://phabricator.services.mozilla.com/D50396
2019-10-25 00:25:34 +00:00
Johann Hofmann
2c9c5a6278 Bug 1584685 - Don't use try..catch to check for non-existent error strings in aboutNetError.js. r=nhnt11
document.l10n.formatValues seems to have changed and now not throw an error but instead
return `undefined` when no string was found. This broke the implementation which relied
on try..catch to detect non-existent error strings.

Differential Revision: https://phabricator.services.mozilla.com/D49873
2019-10-22 11:48:36 +00:00
longsonr
2860cd862e Bug 1584685 - correct parameter to ssl-connection-error. r=johannh?
Differential Revision: https://phabricator.services.mozilla.com/D47524
2019-10-14 19:25:12 +00:00
Brindusan Cristian
86c996c000 Bug 1579285 - Fix prettier Eslint. r=me CLOSED TREE 2019-09-27 07:30:19 +03:00
Martin Thomson
ff059987d6 Bug 1579285 - Offer to enable TLS 1.0 on neterror page r=johannh
As we roll out the TLS 1.0 and 1.1 deprecation, sites that don't support TLS 1.2
will show the neterror page.  This adds a box to that page that shows in this
specific case.  That box explains what is going on and gives an option to
re-enable TLS 1.0.

As mentioned, this will show alongside an option to reset TLS-related
preferences if any overrides are active.

Hitting the button will set the new pref to 'true' and reload the page.

Once the override is engaged, the option won't show, but that option to reset
preferences will show (as this is a TLS-related preference).

The intent is to remove this affordance in March 2020 as we formally move to
having TLS 1.2 the minimum version.  All going to plan, this will only affect
prerelease channels, though anyone who has tweaked security.tls.version.* could
also see this.

Differential Revision: https://phabricator.services.mozilla.com/D45799
2019-09-27 01:26:06 +00:00
Coroiu Cristina
ceeec89ab1 Backed out 4 changesets (bug 1579285, bug 1579270) for browser-chrome failures at browser/base/content/test/siteIdentity/browser_deprecatedTLSVersions.js on a CLOSED TREE
Backed out changeset 36d7cc55bd16 (bug 1579285)
Backed out changeset 26e3ed3c1592 (bug 1579285)
Backed out changeset 913652258fe6 (bug 1579285)
Backed out changeset 0781e60dd54c (bug 1579270)
2019-09-27 04:19:59 +03:00
Brindusan Cristian
fea59f1c51 Bug 1579285 - Fix ESlint. a=me CLOSED TREE 2019-09-27 03:50:33 +03:00
Martin Thomson
f34a2ef4fb Bug 1579285 - Offer to enable TLS 1.0 on neterror page r=johannh
As we roll out the TLS 1.0 and 1.1 deprecation, sites that don't support TLS 1.2
will show the neterror page.  This adds a box to that page that shows in this
specific case.  That box explains what is going on and gives an option to
re-enable TLS 1.0.

As mentioned, this will show alongside an option to reset TLS-related
preferences if any overrides are active.

Hitting the button will set the new pref to 'true' and reload the page.

Once the override is engaged, the option won't show, but that option to reset
preferences will show (as this is a TLS-related preference).

The intent is to remove this affordance in March 2020 as we formally move to
having TLS 1.2 the minimum version.  All going to plan, this will only affect
prerelease channels, though anyone who has tweaked security.tls.version.* could
also see this.

Differential Revision: https://phabricator.services.mozilla.com/D45799
2019-09-27 00:18:11 +00:00
prathiksha
5200f9c04c Bug 1578239 - Remove security.ui.certerror telemetry. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46115
2019-09-18 10:53:46 +00:00
prathiksha
cc93a1dfac Bug 1561443 - Move _getErrorMessageFromCode from NetErrorChild.jsm to aboutNetError.js. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D36542
2019-09-17 09:49:59 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
prathiksha
8809c8360e Bug 1553342 - Have Browser:CertExceptionError message exchanges happen over RPM. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D34581
2019-09-05 20:04:03 +00:00
Johann Hofmann
7348622a88 Bug 1568492 - Add default parameter to RPMGetIntPref. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D39173
2019-07-24 22:07:12 +00:00
Sylvestre Ledru
f4d7743944 Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217
2019-07-10 12:03:37 +00:00
Andreea Pavel
1ec8be7299 Backed out changeset 3d59cb02b6ff (bug 1562642) for eslint failure on a CLOSED TREE 2019-07-10 14:44:29 +03:00
Sylvestre Ledru
48a94b058e Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217
2019-07-10 11:15:25 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
prathiksha
30b35262ab Bug 1555438 - Remove getDetailedCertErrorInfo from NetErrorChild.jsm. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D33065
2019-06-26 20:24:05 +00:00
prathiksha
fd0dc69f38 Bug 1552333 - Move onCertErrorDetails from NetErrorChild.jsm to aboutNetError.js. r=johannh,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D31901
2019-06-18 03:54:21 +00:00
prathiksha
18844e7cd2 Bug 1549561 - Move _setTechDetails from NetErrorChild.jsm to aboutNetError.js. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D30852
2019-05-30 06:43:14 +00:00
Johann Hofmann
eb9e199b6b Bug 1547695 - De-dupe #errorTryAgain on about:neterror/certerror. r=prathiksha
We were using the same ID on two elements, which kind of messed up things everywhere
our code reasonably expected only one element of the kind to exist. We just use a
class name now.

This also cleans up #advancedPanelErrorTryAgain which worked around this issue
by using a different ID.

Differential Revision: https://phabricator.services.mozilla.com/D30298
2019-05-13 19:38:03 +00:00
prathiksha
b84df6bb6f Bug 1544610 - Part 1 - Have certerror captive portal message exchanges happen over RPM. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D28539
2019-05-03 23:30:35 +00:00
Johann Hofmann
68e7b1e3db Bug 1530348 - Unfork aboutNetError.{xhtml,css}. r=nhnt11
The larger changesets in this patch are simply moving code from one file into the other with hg mv.

A short summary of the changes:

- I removed the forked redirection from AboutRedirector.cpp
- I deleted the original aboutNetError.xhtml and aboutNetError.css files
  and moved aboutNetError-new.xhtml and aboutNetError-new.css in their place instead.
- I removed the browser.security.newcerterrorpage.enabled pref and all its usages.
- I removed some localization strings and resources that went unused because of the above changes.

Differential Revision: https://phabricator.services.mozilla.com/D25232
2019-03-29 09:33:58 +00:00
Syeda Asra Arshia Qadri
09c839a6ae Bug 1535278: Cert error pages in iframes should not say 'Warning: Potential Security Risk Ahead' r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23792
2019-03-22 21:09:10 +00:00
Mellina Yonashiro
e33017de4b Bug 1534629 Non-bypassable cert error pages should use Advanced instead of More information r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23316
2019-03-18 17:11:50 +00:00
Syeda Asra Arshia Qadri
5aee5576c7 Bug 1284835: Replaced Hardcoded URLs with Services.urlFormatter.formatURLPref r=johannh
Bug 1284835: Replaced Hardcoded URLs with Services.urlFormatter.formatURLPref r=reviewers

Differential Revision: https://phabricator.services.mozilla.com/D21834
2019-03-13 08:23:00 +00:00
Johann Hofmann
d341a062ca Bug 1485670 - Improve error page styles in iframes. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D21907
2019-03-06 15:58:18 +00:00
ui.manish
7d6dfaef58 Bug 1499326 - Remove custom styling for cert error pages with browser.xul.error_pages.expert_bad_cert r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D13982
2018-12-11 14:18:51 +00:00
Johann Hofmann
64592659c5 Bug 1450784 - Add a new error page for MOZILLA_PKIX_ERROR_MITM_DETECTED. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D12874
2018-11-26 10:17:58 +01:00
Andreea Pavel
f6eeeabba9 Backed out changeset 05e25df4db43 (bug 1450784) for failing bc at browser/base/content/test/static/browser_misused_characters_in_strings.js on a CLOSED TREE 2018-12-04 22:28:23 +02:00
Johann Hofmann
dc5e8fada4 Bug 1450784 - Add a new error page for MOZILLA_PKIX_ERROR_MITM_DETECTED. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D12874
2018-11-26 10:17:58 +01:00
Johann Hofmann
c174911ba8 Bug 1499685 - Fix browser_aboutCertError.js test cases for the old cert error pages. r=nhnt11
Two of these tests simply require the new pref to be set, while there was some actual
breakage that required me to put some more code behind another gate.

Differential Revision: https://phabricator.services.mozilla.com/D8978
2018-10-17 22:13:34 +00:00
Johann Hofmann
e64182b00c Bug 1492943 - Part 2 - Update copy for HSTS certificate errors. r=nhnt11
Copy changes as outlined in https://docs.google.com/document/d/18mKAiSSLRTVcjJ1C9rIMQRnQ7eMwqqXPPN0xIyW6DDI/edit?ts=5bbfbfbb#

- New heading
- Slightly updated description
- Replace "More..." with "More Information"
- Remove the "Recommended" label on the return button

Differential Revision: https://phabricator.services.mozilla.com/D8831
2018-10-16 18:50:37 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
trisha
276f6f397f Bug 1476509 - Implement a new clock skew error page r=flod,johannh
MozReview-Commit-ID: 5WmgrxUcSZ6
2018-08-02 22:59:04 +05:30
Andreea Pavel
b414d7b427 Backed out changeset ef30529d43dd (bug 1476509) for breaking localization a=backout 2018-08-11 13:45:07 +03:00
trisha
b637a1908a Bug 1476509 - Implement a new clock skew error page r=johannh
MozReview-Commit-ID: BUR0hCnh5gb
2018-08-02 22:59:04 +05:30
Trisha Gupta
f17eac346d Bug 1475025 - Vertically center the various error pages r=johannh 2018-07-17 21:36:53 +05:30
trisha
96667c1b91 Bug 1463755 - Update the design of certificate error pages r=johannh
MozReview-Commit-ID: JAUprQQlDmi
2018-06-18 23:04:56 +05:30
vinoth
f0f5253fbf Bug 1453560 - Apply Meta CSP to Content Privileged about:certerror and about:neterror. r=ckerschb, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D918
2018-04-26 04:07:07 -04:00