corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
899,915 Commits 1 Branch 0 Tags
d8275ce7d6cf791a0e8ca1ee33e035260a1f44ec
Commit Graph

248 Commits

Author SHA1 Message Date
Kelly Cochrane
d8275ce7d6 Bug 1951427 - Rework expand on hover to only overlay the sidebar launcher r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D240171
 2025-03-14 13:09:18 +00:00
Goloman Adrian
8cbc210af4 Backed out changeset e93b9b73aebd (bug 1951427) for causing bc failures @browser_sidebar_move.js. 2025-03-14 08:20:43 +02:00
Kelly Cochrane
8959c0fe82 Bug 1951427 - Rework expand on hover to only overlay the sidebar launcher r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D240171
 2025-03-13 23:39:02 +00:00
Sam Foster
5e0d65a91e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-12 16:41:47 +00:00
Goloman Adrian
6847fa7ceb Backed out changeset 4754bc9e58f3 (bug 1921536) for causing bc failures @browser_toolbarKeyNav.js 2025-03-08 09:15:01 +02:00
Sam Foster
ace31bb084 Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-08 05:17:08 +00:00
Sandor Molnar
b51ff49434 Backed out changeset f56181344f2a (bug 1921536) for causing bc failures @ browser_bookmark_context_menu_contents.js & browser_reviewchecker_sidebar.js CLOSED TREE 2025-03-06 06:15:10 +02:00
Sam Foster
dc4f09430e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-06 01:52:28 +00:00
kpatenio
de5da3721b Bug 1951175 - add icon_click Glean event for Review Checker sidebar icon. r=sidebar-reviewers,shopping-reviewers,rking,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D240087
 2025-03-03 23:02:40 +00:00
Kelly Cochrane
98adf13686 Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-28 09:24:26 +00:00
Stanca Serban
48f17a87bb Backed out changeset 75ec289e02ef (bug 1947818) for causing mochitests failures in browser_customize_sidebar.js. CLOSED TREE 2025-02-27 23:11:38 +02:00
Kelly Cochrane
6c12de724c Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-27 19:59:46 +00:00
Stanca Serban
de66cbe460 Backed out changeset 793f8bede918 (bug 1947818) for causing mochitests failures in browser_sidebar_move.js. CLOSED TREE 2025-02-27 21:36:43 +02:00
Kelly Cochrane
f1fe3cf1b3 Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-27 17:01:13 +00:00
Goloman Adrian
a048ca4c8b Backed out changeset b0a8901d8246 (bug 1921536) for casuing failures @test_sidebar_state.js. 2025-02-27 10:46:12 +02:00
Sam Foster
d318c71f26 Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-02-27 07:22:17 +00:00
Jonathan Sudiaman
05aa3cf512 Bug 1947952 - Skip windowPrivacyMatches checks for revamped sidebar. r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D239435
 2025-02-25 16:19:29 +00:00
Jonathan Sudiaman
15bccd9659 Bug 1947607 - Replace calls to flushTaskQueue() with more precise waits r=sidebar-reviewers,nsharpley,sfoster 
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.

Differential Revision: https://phabricator.services.mozilla.com/D238042
 2025-02-24 13:20:45 +00:00
Rebecca King
622361d010 Bug 1938413 - Implement callout 4A and callout 4B for RC in the sidebar when a user disables auto-open r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D234974
 2025-02-21 23:30:51 +00:00
Sam Foster
ad43d98af3 Bug 1946869 - Call updateToolbarButton when the state initializes and changes. r=sidebar-reviewers,jsudiaman 
- Allow both prefs to update before handling sidebar.visibility changes as we need an up-to-date
  verticalTabs value
- Call updateToolbarButton at the completion of initializeUIState rather than as
  a sideeffect of one of the state property changes
- And same idea with handleToolbarButtonClick

Differential Revision: https://phabricator.services.mozilla.com/D237680
 2025-02-21 07:05:34 +00:00
Sandor Molnar
e2d60a3172 Backed out 2 changesets (bug 1947607, bug 1948925) for causing sidebar related bc failures CLOSED TREE 
Backed out changeset ea661e75b85b (bug 1948925)
Backed out changeset c2881b804a7c (bug 1947607)
 2025-02-19 04:32:59 +02:00
Jonathan Sudiaman
a87903a846 Bug 1947607 - Replace calls to flushTaskQueue() with more precise waits r=sidebar-reviewers,nsharpley,sfoster 
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.

Differential Revision: https://phabricator.services.mozilla.com/D238042
 2025-02-19 01:36:13 +00:00
Micah Tigley
a99127f0ca Bug 1941077 - Render CPM in the sidebar. r=rsafaeian,fluent-reviewers,sidebar-reviewers,credential-management-reviewers,bolsson,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D233948
 2025-02-14 13:11:04 +00:00
Sam Foster
8559325d30 Bug 1947526 - Preserve user's visibility pref value and fix default expanded state when switching to vertical tabs. r=sidebar-reviewers,nsharpley,kcochrane 
* Make sure we don't overwrite a user's choice to hide-sidebars in vertical tabs at startup
* Roll in a fix to bug 1947257 and ensure the launcher is initially expanded when enabling vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D237849
 2025-02-13 23:45:43 +00:00
Ryan Safaeian
3b015b140d Bug 1946830 - [contextual-password-manager] Add new probe for when CPM is toggled in sidebar. r=mtigley,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237931
 2025-02-13 21:03:21 +00:00
Nikki Sharpley
94a85bdc4f Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-11 16:29:47 +00:00
Jonathan Sudiaman
5e9cd630a5 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-11 00:05:12 +00:00
Norisz Fay
322845f56e Backed out changeset 022da00de2e7 (bug 1944910) for causing failures on browser_vertical_tabs.js CLOSED TREE 2025-02-11 05:34:20 +02:00
Nikki Sharpley
3b00c42254 Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-10 14:32:23 +00:00
Alexandru Marc
88bcc4fdba Backed out 2 changesets (bug 1946188, bug 1945927) for causing bc failures @ browser_sidebar_max_width.js 
Backed out changeset 12f92dcdff8d (bug 1946188)
Backed out changeset b71374a4ec8d (bug 1945927)
 2025-02-10 16:59:42 +02:00
Jonathan Sudiaman
fa275b3b28 Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-10 13:31:32 +00:00
Alexandru Marc
f43ff8bcd9 Backed out changeset 24d23a09f65c (bug 1944910) for causing bc failures @ browser_newtabButton.js CLOSED TREE 2025-02-08 15:17:08 +02:00
Nikki Sharpley
88603ffd0e Bug 1944910 - Hide sidebar main element when "hide-sidebar" is selected in vertical tabs mode.r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236605
 2025-02-07 22:03:50 +00:00
Kelly Cochrane
6fd7168076 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 19:36:03 +00:00
Butkovits Atila
d45f0bd128 Backed out changeset e38f4befbd26 (bug 1946675) for causing failures at browser_parsable_css.js. CLOSED TREE 2025-02-07 21:14:51 +02:00
Kelly Cochrane
b5ee7175f0 Bug 1946675 - Fix for sidebar animations after recent changes for expand on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D237233
 2025-02-07 17:57:42 +00:00
Kelly Cochrane
9430fe2dd3 Bug 1946532 - Temporarily remove expand on hover styles/listeners if toolbar button is used to expand the sidebar in expand on hover mode r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D237101
 2025-02-07 15:14:54 +00:00
Sam Foster
3212d879b7 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-07 00:33:29 +00:00
Stanca Serban
35dcb51890 Backed out changeset e1b44a36cc7b (bug 1944931) for causing mochitests failures in browser_toolbarKeyNav.js. CLOSED TREE 2025-02-06 23:07:09 +02:00
Sam Foster
9e30d4a3f1 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-06 19:24:32 +00:00
Goloman Adrian
d2c88036c2 Backed out changeset ff0ae341ed38 (bug 1945927) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-02-06 18:52:47 +02:00
Jonathan Sudiaman
094417d2bf Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-06 15:27:35 +00:00
Alexandru Marc
b68ad3585c Backed out changeset cef2da85ff94 (bug 1945927) for causing bc failures @ browser_glean_sidebar.js CLOSED TREE 2025-02-06 03:34:55 +02:00
Jonathan Sudiaman
56a6d4edfc Bug 1945927 - Ensure that resize observer is restored when reinitializing revamped sidebar. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236933
 2025-02-05 23:28:14 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 14:05:08 +00:00
Goloman Adrian
29382f98d1 Backed out changeset 0923d9bb2550 (bug 1944931) for causing bc failures @browser_reviewchecker_sidebar.js. CLOSED TREE 2025-02-05 02:17:40 +02:00
Sam Foster
ba5b624404 Bug 1944931 - Ensure sidebar.visibility gets set when vertical tabs are enabled. r=sidebar-reviewers,sclements,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236447
 2025-02-04 19:08:22 +00:00
Sam Foster
c32900b41c Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window

Differential Revision: https://phabricator.services.mozilla.com/D236292
 2025-02-04 07:43:21 +00:00