Commit Graph

148 Commits

Author SHA1 Message Date
Butkovits Atila
d7afe8c2aa Backed out changeset 0edde29b2e70 (bug 1939503) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-08 05:43:29 +02:00
Stephen Thompson
607c9a5cec Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-08 02:47:03 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232430
2024-12-19 08:54:25 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-12 12:57:41 +00:00
Dão Gottwald
8a2e7099f7 Bug 1934007 - Prevent empty group when attempting to group pinned tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231788
2024-12-11 16:21:34 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-11 14:37:38 +00:00
Emilio Cobos Álvarez
910845c8c5 Bug 1933769 - Remove no-op focus() calls. r=tabbrowser-reviewers,dao
Since bug 1823984, this focus() call has been a no-op on remote frames.

The previous patch also fixes the non-remote frame focus switch.

Differential Revision: https://phabricator.services.mozilla.com/D230098
2024-12-09 21:42:42 +00:00
Stephen Thompson
b437b0d758 Bug 1927994 - do not allow pinned tabs to move inside tab groups r=dao,tabbrowser-reviewers
There are a number of oddities that cropped up from pinned tabs moving into tab groups, e.g. when the first item in the tab strip is a tab group or when pinning a tab that's already in a tab group. This patch repairs those cases to ensure that pinned tabs stick to the beginning of the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D230344
2024-12-06 05:26:16 +00:00
Dão Gottwald
1a974c5351 Bug 1935029 - Add Nimbus recipe for tab groups. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231030
2024-12-05 15:13:07 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-05 01:20:07 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-04 04:17:36 +00:00
Dão Gottwald
db518f5774 Bug 1934296 - Adding a tab to a collapsed group should expand the group. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D230982
2024-12-03 18:15:28 +00:00
Cosmin Sabou
82fbc8fbe4 Backed out changeset a8d030efc4ea (bug 1924861) for causing bc failures on browser_stop_pending. 2024-12-02 01:21:14 +02:00
Adam Vandolder
f6e7455adc Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-01 04:13:01 +00:00
Sandor Molnar
7e190c9386 Backed out changeset b94afd94ed9c (bug 1924861) for causing multiple bc failures. CLOSED TREE 2024-11-30 20:40:15 +02:00
Adam Vandolder
5f7b028386 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-29 23:38:09 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 12:12:51 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 03:26:50 +00:00
Nikki Sharpley
83c7885079 Bug 1908471 - Round content area top corner closest to sidebar r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D229676
2024-11-27 19:50:02 +00:00
Simon Friedberger
997eea8abc Bug 1932640. Remove History:UndoCloseTab event handler. r=mossop,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229920
2024-11-27 11:07:19 +00:00
Dão Gottwald
d7bdd7e169 Bug 1933279 - Remove tabs from multiselection once added to tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230222
2024-11-27 02:08:55 +00:00
Goloman Adrian
5475feeda5 Backed out changeset 38acfee0b08a (bug 1933279) for causing bc failures @browser_vertical_tab.js. 2024-11-27 05:35:42 +02:00
Dão Gottwald
6a25e2974a Bug 1933279 - Remove tabs from multiselection once added to tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230222
2024-11-27 02:08:55 +00:00
Dão Gottwald
3245dd9a52 Bug 1928189 - Let Firefox View show tabs from collapsed groups. r=sthompson,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D229896
2024-11-26 16:45:56 +00:00
Alexandru Marc
89b15045ed Backed out changeset 90929265e20e (bug 1933119) for causing bc failures @ browser_keyword.js 2024-11-26 21:56:46 +02:00
Butkovits Atila
cce1ec2c4f Backed out changeset 4b65f5631ed1 (bug 1932640) for causing failures complaining about tabCount. 2024-11-26 18:17:47 +02:00
Emilio Cobos Álvarez
444f65b693 Bug 1933119 - Remove no-op focus() calls. r=tabbrowser-reviewers,dao
Since bug 1823984, this focus() call has been a no-op on remote frames.

The previous patch also fixes the non-remote frame focus switch.

Differential Revision: https://phabricator.services.mozilla.com/D230098
2024-11-26 14:10:55 +00:00
Simon Friedberger
5b85f70e4a Bug 1932640. Remove History:UndoCloseTab event handler. r=mossop,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229920
2024-11-26 13:32:49 +00:00
Stephen Thompson
bb28e6575a Bug 1932943 - Add border to tab group icon r=dao,sessionstore-reviewers
Add a 1 pixel stroke to the tab group icon SVG so that it can be styled as a border using CSS. Using border style properties for CSS does not work in all contexts; specifically, macOS native menus do not seem to allow border rules but do allow SVG rendering.

Differential Revision: https://phabricator.services.mozilla.com/D230070
2024-11-25 21:10:22 +00:00
jabram
ad7b1e649c Bug 1451132 - Provide option to close current tab on quit r=fluent-reviewers,reusable-components-reviewers,mconley,settings-reviewers,mossop,accessibility-frontend-reviewers,mstriemer,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D223374
2024-11-25 21:03:45 +00:00
Jeremy Swinarton
fc4e710b51 Bug 1927774: Add closed tab groups to history menus r=dao,fluent-reviewers,sessionstore-reviewers,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228843
2024-11-25 20:04:15 +00:00
Stephen Thompson
35bab3b13c Bug 1927540 - drop tab into/out of end of tab groups r=dao,tabbrowser-reviewers
When all tabs are inside of tab groups, this patch allows the user to drag a tab to become a standalone tab at the end of the tab stirp. The user also has the ability to drop the tab into the end of the tab group at the end of the tab strip if the tab is dropped closer to the tab group.

Differential Revision: https://phabricator.services.mozilla.com/D229440
2024-11-19 20:26:31 +00:00
Stephen Thompson
841ffe9813 Bug 1921830 - move active tab left/right into/out of tab groups r=dao
Adds tab group contexts to the functionality behind keyboard shortcuts for moving the active tab left/right in the tab strip

Differential Revision: https://phabricator.services.mozilla.com/D227253
2024-11-19 19:40:21 +00:00
Greg Stoll
5bad86a2d5 Bug 1926390 part 2 - add telemetry and tests for explicit tab unloading r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D229141
2024-11-18 15:02:41 +00:00
codesuki
95975f82f7 Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
2024-11-15 11:51:17 +00:00
Dão Gottwald
ddc5737e8c Bug 1928166 - Maintain tab order when ungrouping. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228990
2024-11-14 19:52:58 +00:00
Florian Quèze
634ebeeac3 Bug 1930163 - Remove support for setting a legacy telemetry scalar when a notification bar is shown, r=mstriemer,tabbrowser-reviewers,reusable-components-reviewers,dao.
Differential Revision: https://phabricator.services.mozilla.com/D228453
2024-11-14 17:25:13 +00:00
Dão Gottwald
f8d89fd012 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 16:33:19 +00:00
Alexandru Marc
898e7469f6 Backed out changeset 365a4dc7fe2d (bug 1930654) for causing bc failures @ browser_standalone_application_chooser_window_fallback.js . CLOSED TREE 2024-11-14 17:37:47 +02:00
Dão Gottwald
af03c5baa7 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 14:02:57 +00:00
Simon Friedberger
4fcd691190 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00